Commit Graph

6200 Commits

Author SHA1 Message Date
Michael Barrett
9ce4c85905
Added custom theme setting descriptions (#17024)
refs https://github.com/TryGhost/Team/issues/3448

Added the ability to specify a description for a custom theme setting

---------

Co-authored-by: Sodbileg Gansukh <sodbileg.gansukh@gmail.com>
2023-06-15 15:10:56 +01:00
Simon Backx
885e5b7b9c 🐛 Fixed visible scrollbars in signup form preview
fixes https://github.com/TryGhost/Team/issues/3485
2023-06-15 15:04:09 +02:00
Kevin Ansfield
3e8a0c5028
🎨 Added word count to beta editor
closes https://github.com/TryGhost/Team/issues/3242

- the beta editor now provides `<WordCountPlugin>` for tracking word count so we can add the UI for it back
2023-06-14 17:56:03 +01:00
Ronald Langeveld
998708c81a
🐛 Fixed empty icon crashing signup embed preview (#17022)
closes https://github.com/TryGhost/Team/issues/3471

- after adding and removing an icon, icon settings passed an undefined
icon to the signup form's all-in-one style. The AIO conditions didn't
take that into account and caused the entire component to crash.

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 9e1aea3</samp>

Fix signup form embed code generation when icon is not set. Add a check
for `this.settings.icon` in `signup-form-embed.js` before replacing
image path.
2023-06-14 15:13:49 +02:00
Simon Backx
14e05a6f0f 🐛 Disabled signup form embed menu when members are disabled
fixes https://github.com/TryGhost/Team/issues/3470

- When members are disabled or invite only, the signup form embed should be disabled
- The comments access setting is now also disabled if members are disabled
- The tiers menus are now also disabled if members are disabled
2023-06-14 14:57:08 +02:00
Simon Backx
04d04e1864
Revert "Fixed post editor items getting cut off on iOS" (#17017)
Reverts TryGhost/Ghost#16765

This commit broke the browser tests because the save button is hidden
underneath the settings menu:


![image](https://github.com/TryGhost/Ghost/assets/5277847/ec384fbb-6a39-4799-965d-768f66df3ad5)
2023-06-14 11:31:58 +02:00
Simon Backx
e680ddf14a Fixed retrying failed email without error message
refs https://ghost.slack.com/archives/CTH5NDJMS/p1686730494254149?thread_ts=1686593227.689069&cid=CTH5NDJMS
2023-06-14 10:18:50 +02:00
Jonathan Browne
d34b9b021a
Fixed post editor items getting cut off on iOS (#16765) 2023-06-14 09:45:17 +02:00
Elena Baidakova
9f1279b58e
🐛 Fixed snippet insertion in the new editor (#17003)
refs TryGhost/Team#3445
- The snippet model always expects an object as it gets serialized when
saving - if we give it a string, it gets doubly serialized. It breaks
snippet replacement and insertion in the new editor.
2023-06-13 15:51:23 +04:00
Fabien 'egg' O'Carroll
7e1efd97e8
🐛 Fixed Post History for posts sent as an email (#16999)
refs https://github.com/TryGhost/Team/issues/3458

From the discussion in slack, for all published/sent posts:
  Published only --> view history & restore
  Published & sent --> view history & restore
  Email only --> history hidden

And for all unpublished/unsent posts:
  All states --> view history & restore.
2023-06-13 12:38:39 +02:00
Ronald Langeveld
c0e638fecd Added membersEnabled config to lexical editor
refs https://github.com/TryGhost/Team/issues/3456

- adds a boolean config whether members signup is enabled so that we can
  hide the signup card option from the editor if it's not enabled.
2023-06-13 08:47:16 +02:00
Simon Backx
5e7edb9da5 Added embeddable signup form
refs https://github.com/TryGhost/Team/issues/3274

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
Co-authored-by: Ronald Langeveld <hi@ronaldlangeveld.com>
Co-authored-by: Jono Mingard <reason.koan@gmail.com>
Co-authored-by: Sag <guptazy@gmail.com>
2023-06-09 11:30:03 +02:00
Simon Backx
ffa6c9c5f8 Added width:100% to minimal signup form CSS
no issue

Otherwise the auto margin would cause issues in a grid or flex container.
2023-06-09 11:08:14 +02:00
Simon Backx
12f7fd0153 Updated minimal signup form to be centered by default
no issue

Added `margin: 0 auto;` css by default.
2023-06-09 10:47:51 +02:00
Simon Backx
66ca072055 Moved maximum width and centering outside minimal signup form
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1686299301740999

- Easier to customize: easy to choose between centering and left alignment
- Fixes issue with centering error message
2023-06-09 10:42:24 +02:00
Sanne de Vries
e74b38ac93
Updated color picker in signup form modal (#16971)
Refs https://github.com/TryGhost/Team/issues/3407

---------

Co-authored-by: Simon Backx <simon@ghost.org>
2023-06-09 08:55:35 +02:00
Sanne de Vries
1e7b332b7f Updated signup form embed settings copy
No ref
2023-06-09 08:26:21 +02:00
Simon Backx
c5fbd8bae6 Added Plausible events when copying the signup form embed code
fixes https://github.com/TryGhost/Team/issues/3389
2023-06-08 15:51:32 +02:00
Sanne de Vries
9d93d21a2d Fixed signup form modal height
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
- Previous commit broke the height as the negative margin should've only been applied horizontally
2023-06-08 14:18:16 +02:00
Sanne de Vries
7a74563e21 Fixed scrollbar position in signup form modal
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
2023-06-08 14:06:31 +02:00
Simon Backx
5949d6a8d4 🐛 Fixed closing modals in admin UI when releasing mouse outside modal
no issue

When selecting text, and releasing your mouse outside the modal, the modal would close.
2023-06-08 13:50:44 +02:00
Simon Backx
5658f4b627 Fixed admin failing tests
no issue

renderInPlace broke tests because expected dropdown changed place in the DOM
2023-06-08 13:38:13 +02:00
Simon Backx
a68ac4b688 Renamed data-logo to data-icon in signup embed attributes
fixes https://github.com/TryGhost/Team/issues/3401
2023-06-08 13:23:38 +02:00
Simon Backx
887f7385e1 Fixed label picker overflow hidde in modal in signup form modal
no issue
2023-06-08 13:17:54 +02:00
Elena Baidakova
4f1a92fb17
Fixed the ability to return to the main post page after scheduling a post in lexical (#16970)
refs TryGhost/Team#3405
- BackgroundSave option sets post status as Draft. Don't need such
behaviour as a post already can have a different status when a user
leaves the page.
2023-06-08 12:20:07 +04:00
Steve Larson
85896287e3 Added koenig lexical package version to sentry report
closes TryGhost/Team#3381
2023-06-07 11:05:35 -05:00
Peter Zimon
5960fdeb53 Fixed editor feature image overlay bug
refs. https://github.com/TryGhost/Team/issues/3399

The feature image overlay that helps with the contrast for the feature image buttons were covering the alt text input field and button.
2023-06-07 17:30:07 +02:00
Nick Moreton
c4629e0118
Added transparency grid and event tracking to Image Editor (#16959) 2023-06-07 16:05:38 +01:00
Kevin Ansfield
abc169329c
Added error logging to lexical snippet fix try/catch
no issue

- we had a `catch` with no error logging, it shouldn't be hit but it will be useful to know if it does fail
2023-06-07 09:56:18 +01:00
Rishabh
71e5d708d4 Reverted "Disabled image editor setting check"
This reverts commit 9d9e296148.

This commit was a temporary fix to load the image editor if the setting was disabled.
2023-06-07 02:10:02 +05:30
Ghost CI
80ed948bb9 Merged v5.50.2 into main 2023-06-06 19:05:20 +00:00
Rishabh
9d9e296148 Disabled image editor setting check
refs https://github.com/TryGhost/Team/issues/3034

Temporarily disables image editor setting check to allow it load by default
2023-06-06 23:59:43 +05:30
Rishabh
6806b88139 Fixed pintura link in image editor integration
refs https://github.com/TryGhost/Team/issues/3034
2023-06-06 23:35:56 +05:30
Steve Larson
75458cd7be Added koenig lexical version to feedback submission
refs TryGhost/Team#3381
2023-06-06 12:55:51 -05:00
Kevin Ansfield
d5a547b6ad
Added double-encoded fix to mobiledoc->lexical snippets sync
no issue

Early in the editor beta snippets were being saved with double-encoded JSON meaning we were dealing with strings rather than objects after Ember's deserialization. That's since been fixed so we're dealing with objects everywhere but old data can still cause issues.

- added a step to the `syncMobiledocSnippets()` method that checks if `snippet.lexical` is a string and performs the necessary fixes to the double-encoded values
- updated the snippet filter in the old editor to exclude double-encoded snippets as that could still load before the new editor has been accessed and the sync+fix has run
2023-06-06 15:20:22 +01:00
Kevin Ansfield
ed24899fa5
🐛 Fixed existing snippets not being available in beta editor
closes https://github.com/TryGhost/Team/issues/3387

- adds syncing of mobiledoc->lexical formats for snippets when opening the beta editor
- this is a one-way sync
  - new snippets or changes made to snippets inside the beta will not be available in the old editor
  - creating or changing snippets in the old editor will sync to (and potentially overwrite snippets) in the beta editor
- fixed incorrect saving of doubly-escaped JSON when creating snippets in the beta editor
2023-06-06 15:20:14 +01:00
Sanne de Vries
d9a20b0e00 Fixed form embed settings overflowing in x direction
Closes https://github.com/TryGhost/Team/issues/3384
2023-06-06 15:24:08 +02:00
Kevin Ansfield
c11c842b1e
Added double-encoded fix to mobiledoc->lexical snippets sync
no issue

Early in the editor beta snippets were being saved with double-encoded JSON meaning we were dealing with strings rather than objects after Ember's deserialization. That's since been fixed so we're dealing with objects everywhere but old data can still cause issues.

- added a step to the `syncMobiledocSnippets()` method that checks if `snippet.lexical` is a string and performs the necessary fixes to the double-encoded values
- updated the snippet filter in the old editor to exclude double-encoded snippets as that could still load before the new editor has been accessed and the sync+fix has run
2023-06-06 13:35:07 +01:00
Kevin Ansfield
48defc4000
🐛 Fixed existing snippets not being available in beta editor
closes https://github.com/TryGhost/Team/issues/3387

- adds syncing of mobiledoc->lexical formats for snippets when opening the beta editor
- this is a one-way sync
  - new snippets or changes made to snippets inside the beta will not be available in the old editor
  - creating or changing snippets in the old editor will sync to (and potentially overwrite snippets) in the beta editor
- fixed incorrect saving of doubly-escaped JSON when creating snippets in the beta editor
2023-06-06 12:56:33 +01:00
Sanne de Vries
9c9eae1c11 Updated signup embed modal responsiveness
Refs https://github.com/TryGhost/Team/issues/3340
2023-06-06 12:21:11 +02:00
Simon Backx
31549933a1 Removed 200% width in signup form minimal preview
no issue

This change wasn't needed after all
2023-06-06 10:43:32 +02:00
Simon Backx
0ae1dad2d2 Removed signup form preview flickering in Safari and improved responsiveness
no issue

- In Safari, we'll poll longer before animating to the new iframe
- Update the iframe immediately if the last change was a while ago, to improve responsiveness
2023-06-06 10:43:06 +02:00
Sodbileg Gansukh
feac482859 Fixed loading screen flash issue in dark mode
closes https://github.com/TryGhost/Team/issues/3344
2023-06-06 16:21:15 +08:00
Simon Backx
f0518bc76a Increased signup form embed icon resolution to 192px
no issue

Optimal resolution for @3x devices
2023-06-06 09:42:42 +02:00
Simon Backx
fc89ad22fc Prevented setting signup form embed locale when feature flag is disabled
fixes https://github.com/TryGhost/Team/issues/3385
2023-06-06 09:40:47 +02:00
Simon Backx
ab0c33346d Fixed signup form minimal width in preview
no issue
2023-06-05 18:10:19 +02:00
Simon Backx
1e7b658148 Updated sign up form to use resized version of icon
fixes https://github.com/TryGhost/Team/issues/3345

The icon is now served as a 128x128px version
2023-06-05 17:59:18 +02:00
Simon Backx
9aef897936 Increased virtual iframe width of minimal signup form preview
no issue

Because the signup form is responsive, it is displayed too small in the preview. To counteract this, the width of the iframe is increased to 200%, and clipped to make it larger.
2023-06-05 17:37:43 +02:00
Simon Backx
22f4d55f75 Added throttling and animation when updating signup form preview
fixes https://github.com/TryGhost/Team/issues/3378
2023-06-05 15:24:59 +02:00
Sodbileg Gansukh
f4c109cfb2 Added small improvements to the image editor UI
refs https://github.com/TryGhost/Team/issues/3208

- added maximum width limit to the editor stage, so the image doesn't get under the editor controls
- made the crop indicator a bit bigger
- fixed image alignment for the vertical layout
2023-06-05 18:27:31 +08:00