Commit Graph

6200 Commits

Author SHA1 Message Date
Ronald Langeveld
52150d5ffb
Fixed Signup Embed iFrame not loading in Safari (#16935)
refs https://github.com/TryGhost/Team/issues/3375

- Fixed a safari bug that caused the signup embed iframe to be in the
`onLoad` state perpetually, causing it not to render.
2023-06-05 12:01:55 +02:00
Kevin Ansfield
bbd511b752
Added beta of the new Ghost editor (#16923)
no issue

Keep an eye on Ghost's changelog (https://ghost.org/changelog/) for the full feature announcement.
2023-06-05 09:46:31 +01:00
Simon Backx
d4f82f8b88 Added copy on click to textarea in signup form embed modal
no issue
2023-06-02 16:31:30 +02:00
Simon Backx
fc5af7e7f8 Removed notification when copying signup form embed code 2023-06-02 16:21:20 +02:00
Simon Backx
ff28e1c94f Added fixed order in data attributes for signup form embed script
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1685711310532969
2023-06-02 16:13:42 +02:00
Sanne de Vries
8833ec03de
Updated signup form modal (#16925)
Refs https://github.com/TryGhost/Team/issues/3340

---------

Co-authored-by: Simon Backx <simon@ghost.org>
2023-06-02 16:07:30 +02:00
Simon Backx
258dc2f8f2 Added locale data option to signup form script
refs https://github.com/TryGhost/Team/issues/3307
2023-06-02 14:36:17 +02:00
Daniel Lockyer
8098f8c53e Updated Admin extensions script functionality
fixes https://github.com/TryGhost/Toolbox/issues/587

- this commit changes two things surrounding the extensions script:
  - moves the script tag from the nav menu to the application template
    so we always load the script irregardless of if the current page has
    a nav menu
  - opens up showing the script to all logged-in users and not just
    Owners as previous
2023-06-02 14:05:40 +02:00
Simon Backx
c27b488f3d Added async attribute to signup form script tag 2023-06-02 13:59:49 +02:00
Kevin Ansfield
ba6ae472c3
Renamed editor beta route
closes https://github.com/TryGhost/Team/issues/3369

- removes `lexical` from user-visible URL
- only renames path rather than renaming all associated files to keep changeset minimal prior to beta launch
2023-06-02 12:52:57 +01:00
Michael Barrett
108c7c38f6
Removed imageEditor flag (#16921)
refs https://github.com/TryGhost/Team/issues/3337

Removed `imageEditor` flag and moved gated logic to be behind the
`lexicalEditor` flag as part of the labs clean up
2023-06-02 12:07:31 +01:00
Simon Backx
806abf28e4 Added placeholder to member label input for signup form embed modal
refs https://github.com/TryGhost/Team/issues/3340
2023-06-02 12:28:58 +02:00
Djordje Vlaisavljevic
307380a29e Removed L label next to Lexical posts in post list
refs https://github.com/TryGhost/Team/issues/3370
2023-06-02 09:42:52 +01:00
Djordje Vlaisavljevic
559c1e0764 Updated feedback form copy
refs https://github.com/TryGhost/Team/issues/3370
2023-06-02 09:42:52 +01:00
Simon Backx
f00b788e6a Moved signup form embed to the membership settings
refs https://github.com/TryGhost/Team/issues/3340
2023-06-02 10:15:08 +02:00
Simon Backx
9ff9906670 Added transparent background pattern to minimal signup form preview
refs https://github.com/TryGhost/Team/issues/3340
2023-06-02 09:48:25 +02:00
Simon Backx
5152e0e042 Moved signup form embed to a modal
refs https://github.com/TryGhost/Team/issues/3340
2023-06-02 09:31:38 +02:00
Jono Mingard
eaa16c2f75 Added simple colour picker to change signup embed background
refs https://github.com/TryGhost/Team/issues/3338
2023-06-02 11:33:08 +12:00
Jono Mingard
024045b9e3 Update signup form text colours to be passed via attributes 2023-06-02 10:59:00 +12:00
Djordje Vlaisavljevic
1cce47482f Added link to Editor beta changelog post in Labs
refs https://github.com/TryGhost/Team/issues/3364
2023-06-01 17:20:04 +01:00
Sanne de Vries
3923b5cc88 Updated embeddable signup form to be responsive
Refs https://github.com/TryGhost/Team/issues/3334
2023-06-01 17:43:28 +02:00
Simon Backx
bcaf95f506 Updated signup form with minimal style to use automatic height and minimum height
refs https://github.com/TryGhost/Team/issues/3295
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1685620939701309?thread_ts=1685614059.121599&cid=C04TMVA1D7A

- The error message of the minimal style form is not visible
- Use minimum height instead of fixed height
- Automatically update height
- Fixed issues with iframe inline style causing spacing and layout jumps
2023-06-01 14:36:00 +02:00
Michael Barrett
ef92028b22
Removed post diffing from post history feature (#16904)
refs https://github.com/TryGhost/Team/issues/3337

Removed post diffing from post history feature as this functionality is
likely to be reworked in a future cycle
2023-06-01 13:22:51 +01:00
Michael Barrett
83847bf22c
Added emailCustomization flag and removed makeItRain flag (#16903)
refs https://github.com/TryGhost/Team/issues/3337

Moved current email customization functionality that is behind the
`makeItRain` to its own flag (`emailCustomization`) and removed the now
redundant `makeItRain` flag
2023-06-01 12:32:37 +01:00
Michael Barrett
09ded37d91
Removed emailErrors flag (#16900)
refs https://github.com/TryGhost/Team/issues/3337

Removed emailErrors flag as it is no longer needed
2023-06-01 12:11:01 +01:00
Simon Backx
17e9b803e4 Added POC for resizing iframe to fit outer container
refs https://github.com/TryGhost/Team/issues/3295
2023-06-01 12:06:48 +02:00
Rishabh
4883d73a0f Updated API service for admin-x
refs https://github.com/TryGhost/Team/issues/3151

The api service in admin-x was using hardcoded `x-ghost-version` as we did not have access to version value in the app so far. This change passes the ghost version from ember Admin app to Settings-X app via props, and refactors the api util to use the app version as a common header.

- Adds new services provider to pass common services for the app
- passes API as a service via context for the App
- refactors existing API usage to use api from context
2023-06-01 14:32:38 +05:30
Sodbileg Gansukh
116e09af95 Show the mobile nav only when logged in
closes https://github.com/TryGhost/Team/issues/3134

- the mobile nav was showing for 404 pages when not logged in
- this adds an additional check, so that the nav is only shown when user is logged in, not only when the user is not contributor
2023-06-01 15:23:47 +08:00
Chris Raible
c0b3aab4f2
Removed postHistory flag and updated post history logic (#16908)
no issue

- Removed the postHistory flag from labs
- Post History will be saved and displayed for all lexical posts,
regardless of whether the lexicalEditor flag is currently set
- Post History will still not be displayed for any mobiledoc posts
- With this change, the logic is simplified as we don't have to worry
about flags, but only the content in the given post (mobiledoc vs
lexical)
- If someone toggles the lexicalEditor flag on, creates a new post, then
toggles the lexicalEditor off, we still want Post History to work for
the existing lexical post
2023-05-31 23:45:29 -07:00
Sodbileg Gansukh
3ab851e3aa Optimized Inter in the Admin
closes https://github.com/TryGhost/Team/issues/3257

- replaces the TTF with WOFF2 which is more compressed version
- adds a font file for italic style specifically so that the italic text is rendered consistently across different browsers
2023-06-01 11:56:27 +08:00
Djordje Vlaisavljevic
bbdb90f1d6 Updated feedback form copy
refs https://github.com/TryGhost/Team/issues/3264
2023-05-31 21:56:37 +01:00
Simon Backx
644051e3e9 Fixed labels for signup form
fixes https://github.com/TryGhost/Team/issues/3316
fixes https://github.com/TryGhost/Team/issues/3313

Instead of using a comma separated list of labels, we now use multiple data properties: data-label-1, data-label-2, etc.
2023-05-30 14:06:25 +02:00
Sodbileg Gansukh
7eaee22a75
Added a custom duration to the comp expirations (#16808)
refs https://github.com/TryGhost/Team/issues/1856

- adds a custom duration option with date picker to the complimentary plan when "Custom" is selected
- this allows customers to choose any date as expiration date

---------

Co-authored-by: Michael Barrett <mike@ghost.org>
2023-05-30 13:35:40 +08:00
Elena Baidakova
254de144e4
Fixed dark mode for lexical (#16888)
refs TryGhost/Team#3327
2023-05-29 17:20:25 +04:00
Sanne de Vries
08fc96a077 Refined signup card frontend styles
Refs https://github.com/TryGhost/Team/issues/3246
2023-05-29 12:28:27 +02:00
Simon Backx
488aa983d0 Added signup form code generation to admin
fixes https://github.com/TryGhost/Team/issues/3296

Adds a new `signupForm` feature flag, that will enable/disable the new embeddable signup form code generation.

Since the new flag shares its name with a new config value (that contains the script location), this also fixes the feature helper to only use a config with the same name if it is a boolean.
2023-05-25 15:18:40 +02:00
Sag
92e7c069f3 Added site title and description in the config for the Lexical editor
refs https://github.com/TryGhost/Team/issues/3282
2023-05-24 11:23:00 +02:00
Djordje Vlaisavljevic
af907b70cb Fixed condition for displaying feedback form on Post published
refs #3252
2023-05-23 22:41:01 +01:00
Steve Larson
49687f73a6 Added handling for new paragraphs when clicking under cards
closes TryGhost/Team#3064
2023-05-23 14:16:18 -05:00
Michael Barrett
81e160c8d3
🐛 Fixed member activity event filter (#16849)
closes https://github.com/TryGhost/Ghost/issues/16817

The member activity event filter was broken due to a recursion issue.
This commit changes the usage of a getter fn to a normal class method to
make the logic more performant and remove the recursion issue
2023-05-23 14:44:49 +01:00
Naz
cc4ff8c6d4 Added collections CRUD UI
refs https://github.com/TryGhost/Team/issues/3168

- This is basic scaffolding for collection resources UI in Admin. For the most part it's a copy-paste of tags code with slight modifications to fit the collections usecase
2023-05-23 17:26:47 +07:00
Sag
2526bd627e
Simplified fetchLabels to return an array of label names (#16842)
refs https://github.com/TryGhost/Team/issues/3182
2023-05-23 08:48:14 +02:00
Sodbileg Gansukh
282d385484 Added dark mode support to staff invitation modal popover
closes https://github.com/TryGhost/Team/issues/2951
2023-05-23 13:52:35 +08:00
Sodbileg Gansukh
03cded7e9e Added more context to the site description setting label
no issues
2023-05-23 12:37:06 +08:00
Djordje Vlaisavljevic
4af604a04f Updated feedback form copy
refs #3252
2023-05-22 21:37:05 +01:00
Djordje Vlaisavljevic
ae91be348b Updated feedback form copy
refs #3264
2023-05-22 12:21:19 +01:00
Sodbileg Gansukh
f4bb135f9c Fixed typography inconsistency in the publish flow
refs https://github.com/TryGhost/Team/issues/2812
2023-05-22 17:31:18 +08:00
Sodbileg Gansukh
50c68dc5ad Fixed background color of the update banner in dark mode
refs https://github.com/TryGhost/Ghost/issues/16819
2023-05-22 14:13:59 +08:00
Djordje Vlaisavljevic
b489986edc Updated feedback widget design on Post published
refs #3244
2023-05-19 15:06:29 +01:00
Djordje Vlaisavljevic
b99a9299cc Removed wordcount and Lexical badge, added help icon
refs #3254, #3253, #3242
2023-05-19 15:06:29 +01:00
Aileen Nowak
462073b452 🎉 Moved Substack migrator app to GA under beta features 2023-05-19 09:58:41 -04:00
Aileen Nowak
307a25f765 Moved migrate app labs flag to Beta features 2023-05-19 09:58:41 -04:00
Djordje Vlaisavljevic
26086d7140 Added dark mode design for feedback forms
refs https://github.com/TryGhost/Team/issues/3250
2023-05-19 12:19:26 +01:00
Elena Baidakova
ca46308abe
Added logic for showing feedback form in Labs (#16831)
refs TryGhost/Team#3247
- The feedback form UI is hidden by default
- Enabling “Lexical editor” doesn’t show the feedback form
- Disabling “Lexical editor” shows the feedback form below this lab item
and user can send the feedback
- Refreshing the page or navigating to some other page and then back to
Labs → the form is hidden again
2023-05-19 13:15:25 +04:00
Sodbileg Gansukh
c7b6a72a49 Separated tiers group to active and archived
refs https://github.com/TryGhost/Team/issues/1403

- currently, all tiers are grouped together in dropdowns with list of tiers
- this separates them into active and archived groups, so that the status of the tiers is clear when making choices
2023-05-19 11:59:44 +07:00
Djordje Vlaisavljevic
06331a89c4 Updated feedback widget design in Labs
refs https://github.com/TryGhost/Team/issues/3245
2023-05-18 16:17:24 +01:00
Djordje Vlaisavljevic
f8f1a66d77 Updated feedback widget design on Post published
refs https://github.com/TryGhost/Team/issues/3244
2023-05-18 16:17:24 +01:00
Nick Moreton
14ce57fa2b
Added trackEvent util for sending events to Plausible (#16824) 2023-05-18 14:32:50 +01:00
Djordje Vlaisavljevic
933b4bb4cb Removed autofocus from inline feedback forms
refs https://github.com/TryGhost/Team/issues/3231
2023-05-17 13:58:28 +01:00
Elena Baidakova
6512edcbd2 Disabled feedback button if textarea is empty
no issue
2023-05-17 16:11:35 +04:00
Elena Baidakova
29c440743c Disabled feedback dropdown closing on outside click
no issue
2023-05-17 15:06:37 +04:00
Michael Barrett
93599315ab
Move duplicate post functionality out of labs (#16812)
no issue

Removed the labs check for the duplicate post functionality making it
available for everybody
2023-05-17 11:44:07 +01:00
Michael Barrett
94c863f189
Implemented post slug update on duplicated post title update (mobiledoc) (#16811)
no issue

Updated the slug generation logic so that when a mobiledoc post is
duplicated and the title is edited, the slug gets updated to reflect the
new title of the post. See lexical implementation here:
https://github.com/TryGhost/Ghost/pull/16802
2023-05-17 10:11:01 +01:00
Sodbileg Gansukh
d61249a335 Fixed double scrollbar issue in members list
closes https://github.com/TryGhost/Team/issues/2765
2023-05-17 14:27:39 +08:00
Elena Baidakova
9abd9fac71 Cleaned up the feedback form after sending the message
no issue
2023-05-17 09:21:48 +04:00
Steve Larson
64662c986b Changed successful feedback send text
no refs
2023-05-16 13:03:40 -05:00
Rishabh
2c1cab6c42 Updated css handling for admin-x-settings package
refs https://github.com/TryGhost/Team/issues/3151

- adds root classname for admin-x settings app so class names can be scoped inside
- adds new preflight.css for resetting admin styles for admin-x app
- moved font to assets/font so it can be picked for both demo app and Admin
2023-05-16 21:08:49 +05:30
Elena Baidakova
57d5f544d8
Updated inlined feedback form (#16794)
refs TryGhost/Team#3214

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 92b2412</samp>

This pull request refactors and simplifies the feedback system for the
lexical editor feature. It replaces the nested modal with a new
`FeedbackLexical` component that can be used in different contexts. It
also removes unused code and files related to the old feedback modal.
2023-05-16 16:16:57 +04:00
Michael Barrett
ef0b863c2b
🐛 Fixed validation error when creating 0% offer (#16803)
closes https://github.com/TryGhost/Team/issues/3073

Fixed validation error when creating 0% offer. Issue was occurring due
to a falsy check on the offer value. Have resolved by having a more
strict check on the offer value based on the possible empty value it can
be - If creating a new offer without providing an offer value, the value
will be `undefined`. If supplying an offer value, then removing the
offer value, the value will be an empty string. This check prevents `0`
being classed as an invalid value.
2023-05-16 12:03:37 +01:00
Michael Barrett
965e9700a0
🐛 Fixed link to translation information in general settings (#16804)
closes https://github.com/TryGhost/Team/issues/3212

The link in the description for the publication language setting in
general settings was pointing to an outdated page
(https://ghost.org/docs/i18n/). This fix updates the link to point at
https://ghost.org/docs/faq/translation/
2023-05-16 12:03:21 +01:00
Djordje Vlaisavljevic
75aa3d1186 Updated feedback widget design inside Editor
no refs
2023-05-16 11:49:01 +01:00
Michael Barrett
43f55521c0
Implemented post slug update on duplicated post title update (#16802)
no issue

Updated the slug generation logic so that when a post is duplicated and
the title is edited, the slug gets updated to reflect the new title of
the post
2023-05-16 10:47:40 +01:00
Rishabh
f9ac201891 Handled missing config for new admin-x settings routing
refs https://github.com/TryGhost/Team/issues/3151

- handles redirection to old settings if the config for admin-x is missing and new settings route is opened
2023-05-16 12:27:18 +05:30
Rishabh
31779c95b5 Added feature flag for new admin-x settings
refs https://github.com/TryGhost/Team/issues/3151

- allows toggling route to new settings screen in react

Co-authored-by: Peter Zimon <zimo@ghost.org>
2023-05-16 12:23:24 +05:30
Rishabh
bf2a2eeb63 Added route for new admin-x settings
refs https://github.com/TryGhost/Team/issues/3151

- adds route in Admin for opening new settings screen in react
- adds new config for passing `adminX` to Admin
- loads adminX settings from package in Admin UI when new route is opened

Co-authored-by: Peter Zimon <zimo@ghost.org>
2023-05-16 12:23:24 +05:30
Sodbileg Gansukh
0e97cc3a11 Fixed double scrollbar issue on Pages
closes https://github.com/TryGhost/Team/issues/3219

- the pages template had a leftover .gh-list-sticky and it was causing an additional scrollbar inside the list
- removing the unncessary element fixes the issue
2023-05-16 12:27:37 +08:00
Elena Baidakova
86e84e35cb
Replaced modal feedback on dropdown in editor (#16793)
refs TryGhost/Team#3213

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 2a96438</samp>

This pull request enhances the feedback modal feature in the lexical
editor. It improves the layout and appearance of the modal and its
trigger button, and uses a dropdown component to show and hide the
modal.
2023-05-15 17:15:34 +04:00
Djordje Vlaisavljevic
6812e026b0 Commented out inlined beta feedback form on Published post page
no refs
2023-05-15 10:35:16 +01:00
Djordje Vlaisavljevic
5ae2425fb6 Hid inlined Labs beta feedback form
no refs
2023-05-15 10:35:16 +01:00
Djordje Vlaisavljevic
8640acf94e Moved feedback button to the left side of editor
no refs
2023-05-15 10:35:16 +01:00
Djordje Vlaisavljevic
1e3d78a937 Added inlined feedback form design to post published page
no refs
2023-05-15 10:35:16 +01:00
Djordje Vlaisavljevic
d82ad53bab Fixed bug where closing modal takes you to dashboard
no refs
2023-05-15 10:35:16 +01:00
Sodbileg Gansukh
c1b6d70b3d Added enter key support to tier benefits
closes https://github.com/TryGhost/Team/issues/2950

- when adding/editing tiers, benefits used to be added only when the plus button was pressed
- this adds enter key support for adding new benefits, same as how the navigation items are added
2023-05-15 16:47:20 +08:00
Michael Barrett
59fe794b0c
Implemented duplicate post functionality (#16767)
refs: https://github.com/TryGhost/Team/issues/3139 https://github.com/TryGhost/Team/issues/3140

- Added duplicate post functionality to post list context menu
  - Currently only a single post can be duplicated at a time
  - Currently only enabled via the `Making it rain` flag
- Added admin API endpoint to copy a post - `POST ghost/api/admin/posts/<post_id>/copy/`
- Added admin API endpoint to copy a page - `POST ghost/api/admin/pages/<page_id>/copy/`
2023-05-15 09:30:32 +01:00
Sodbileg Gansukh
77dda7beba Fixed long URL scrolling in members activity
refs https://github.com/TryGhost/Team/issues/2616

- long urls were causing scrolls in the members activity
- now the urls are broke into multiple lines, so that it's easier to understand/copy them
2023-05-15 16:00:11 +08:00
Sodbileg Gansukh
828c1df6ac Capitalize the homepage event in the members activity
refs https://github.com/TryGhost/Team/issues/2616
2023-05-15 16:00:11 +08:00
Fabien "egg" O'Carroll
ecb90c88ca 🐛 Fixed visibility of the post history feature
We had side stepped the existing checks of lexical and the feature flag when
checking if a published post was sent as an email. This takes into account the
existing checks to make sure the feature isn't leaked without the flag
2023-05-12 17:34:52 -04:00
Sag
d86ac17e31
Added fetchLabels to the Lexical config (#16774)
closes https://github.com/TryGhost/Team/issues/3183
- fetches all existing labels
- returns "id" and "name" fields
2023-05-11 16:36:56 +02:00
Steve Larson
080a1c92d8 fixed linter errors
no refs
2023-05-11 08:14:11 -05:00
Steve Larson
26389507ed Revert "Reverted "Add lexical feedback (#16772)""
This reverts commit 0a9f280a75.
2023-05-11 08:12:25 -05:00
Naz
3eebeb608c
Added collections feature flag
closes https://github.com/TryGhost/Team/issues/3165

- This feature flag is here to gate the development of Collections 2.0 feature
2023-05-11 16:31:45 +07:00
Elena Baidakova
bfa9ea88a2 Removed p wrapper for announcement bar
refs TryGhost/Team#3147
2023-05-11 13:22:05 +04:00
Daniel Lockyer
0a9f280a75
Reverted "Add lexical feedback (#16772)"
This reverts commit 72ed8f56f6.
2023-05-11 11:08:18 +02:00
Steve Larson
72ed8f56f6
Add lexical feedback (#16772)
no refs
- add lexical feedback modal in the editor, labs, and publish workflows
- modal is a basic textarea form

---------

Co-authored-by: Djordje Vlaisavljevic <dzvlais@gmail.com>
2023-05-10 17:40:55 -05:00
Jono M
62f7600aa4
Update search text highlighting to escape HTML (#16760)
refs: https://github.com/TryGhost/Team/issues/2390

Escapes each matched and non-matched segment of the post title in the
admin search field, to make sure they're displayed in plain text but
still have matches highlighted.
2023-05-11 09:53:05 +12:00
Sodbileg Gansukh
13e9c65860 Removed unnecessary tabindex property 2023-05-10 15:43:30 +08:00
Sodbileg Gansukh
b668ca3943 Fixed newsletter clicks not updating in Safari
refs https://github.com/TryGhost/Team/issues/2619

- blur event occurs before mouseup event is called, so when the update button was clicked, the update function has never been called in Safari
- this replaces the mouseup with mousedown which is called before the blur event, so the links are updated properly
2023-05-10 15:40:57 +08:00
Ronald Langeveld
8a08cf3628
Added signupCard feature flags (#16763)
no issue

This pull request adds a new experimental feature flag `signupCard` to
the Ghost admin app, which enables a signup card component in the
lexical editor that's currently being worked on. 
The feature flag can be toggled from the settings/labs
UI and is read from the server-side configuration.
2023-05-09 16:27:36 +02:00
Rishabh Garg
c6a75cf015
Integrated image editor for staff and tag admin pages (#16755)
refs https://github.com/TryGhost/Team/issues/3145

- includes image editing for generic upload image components to extend
image editing capabilities to other areas in Admin
- allows image editing for tag images and staff user images
2023-05-08 15:22:25 +05:30
Elena Baidakova
9df8e89806 Revert "Removed p wrapper for koenig-lexical-input (#16754)"
This reverts commit 9051ea62aa.
2023-05-08 12:15:37 +04:00