Commit Graph

35418 Commits

Author SHA1 Message Date
Michael Barrett
998f862e87
🐛 Fixed newsletter post duplication (#17103)
closes https://github.com/TryGhost/Team/issues/3521

When duplicating a newsletter (email only post) some of the fields
relating to the newsletter (i.e `newsletter_id`) were being erroneously
copied over. Upon publishing this made the post appear as if it was an
email only post that had been sent to subscribers when it actually had
not
2023-06-23 11:18:35 +01:00
Simon Backx
018f97e679
Added Access-Control-Allow-Origin: * to image assets (#17115)
refs https://ghost.slack.com/archives/C025584CA/p1687506966658799
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1687426009256949

This change is required because we otherwise hit CORS issues when admin
tries to load an image and calculate the average color (to determine the
text color).
2023-06-23 11:10:48 +02:00
Daniel Lockyer
55b7bef9ad Fixed disabling search via config
fixes https://github.com/TryGhost/Ghost/issues/16120

- if you set `sodoSearch.url` to `false` in config, it'll currently
  crash because we're not correctly handling the types correctly
- the first part of the fix is ensuring the value is a string so we can
  call `.includes` on it
- second, the `false` value is passed into the output as a string, so we
  should detect if we passed a false value and early return with an
  empty string if so
- credits to https://github.com/ltoinel for the fix inspiration
2023-06-23 10:51:43 +02:00
Simon Backx
b8d071e223 Added --https option to test Lexical in Safari in https
no issue

Safari doesn't allow to load non-https scripts in a https environment, so we need to load Lexical from https using a Caddy proxy. This adds the `--https` option to `yarn dev --lexical`.

Might consider to somehow include a caddyfile somehow in the repo to make this work everywhere without changes.
2023-06-23 10:49:20 +02:00
Sanne de Vries
710d2143c2
Updated signup card background image positioning (#17113)
No ref
2023-06-23 10:27:20 +02:00
Jono M
2d6e988017
Added tests for AdminX navigation settings (#17109)
- Updated test request records to be distinct per API call
- Updated design tests to check preview data
- Added tests for navigation settings

refs https://github.com/TryGhost/Team/issues/3349
2023-06-23 20:16:01 +12:00
Princi Vershwal
5a1dcbc9a5
Removed Bluebird Promise.map from user.js file (#17112)
refs https://github.com/TryGhost/Ghost/issues/14882

Co-authored-by: Princi Vershwal <princi.vershwal@Princis-MacBook-Pro.local>
2023-06-23 10:13:02 +02:00
Daniel Lockyer
08e2fbeacb Removed Bluebird from tests
refs https://github.com/TryGhost/Ghost/issues/14882

- we're moving away from using Bluebird in favor of native Promises, so
  this commit removes nearly all instances from tests
2023-06-23 10:03:03 +02:00
Princi Vershwal
2798d43663
Removed Bluebird Promise.each from db.utils (#17032)
refs https://github.com/TryGhost/Ghost/issues/14882

Co-authored-by: Princi Vershwal <princi.vershwal@Princis-MacBook-Pro.local>
Co-authored-by: Daniel Lockyer <hi@daniellockyer.com>
2023-06-23 09:46:41 +02:00
Princi Vershwal
cc95c39dbb
Removed Bluebird Promise.map from settings.js file (#17086)
refs https://github.com/TryGhost/Ghost/issues/14882

Co-authored-by: Princi Vershwal <princi.vershwal@Princis-MacBook-Pro.local>
2023-06-23 09:16:16 +02:00
Princi Vershwal
d9c739efb7
Removed Bluebird Promise.map from apps index.js file (#17073)
refs https://github.com/TryGhost/Ghost/issues/14882

Co-authored-by: Princi Vershwal <princi.vershwal@Princis-MacBook-Pro.local>
2023-06-23 09:13:29 +02:00
renovate[bot]
9dad8f5291 Update dependency @ember/render-modifiers to v2.1.0 2023-06-23 09:10:51 +02:00
Zavrod
dbacbf6e50
Updated Czech translations (#16751)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-23 09:09:36 +02:00
Kasun Jayarathna
6ad20ec32c
Updated Sinhalese translations (#17096)
refs https://github.com/TryGhost/Team/issues/2795
2023-06-23 09:07:26 +02:00
Princi Vershwal
308a3b286a
Replaced Bluebird Promise.mapSeries with sequence util (#17008)
refs https://github.com/TryGhost/Ghost/issues/14882

Co-authored-by: Princi Vershwal <princi.vershwal@Princis-MacBook-Pro.local>
2023-06-23 09:04:37 +02:00
renovate[bot]
f87dc8f5eb Update dependency liquid-wormhole to v3.0.1 2023-06-23 09:00:34 +02:00
Daniel Lockyer
e47626913d Updated Dutch translations
refs https://github.com/TryGhost/Team/issues/2795
2023-06-23 08:42:15 +02:00
Princi Vershwal
21085d0732
🐛 Handled BOM character for Unicode encoded file uploads (#17104)
fixes https://github.com/TryGhost/Ghost/issues/16917
refs https://github.com/TryGhost/Ghost/issues/16917#issuecomment-1602984601

Co-authored-by: Princi Vershwal <princi.vershwal@Princis-MacBook-Pro.local>
2023-06-23 08:31:16 +02:00
renovate[bot]
9e6c800e38 Update dependency webpack-cli to v5 2023-06-23 08:29:15 +02:00
renovate[bot]
c0d32080b7 Update dependency semver to v7.5.3 2023-06-23 07:08:38 +02:00
Simon Backx
9135ca92e0 Added Playwright test for comment reply pagination
refs https://github.com/TryGhost/Team/issues/3504
2023-06-22 19:09:21 +02:00
Simon Backx
9035a87e50 Updated @tryghost/kg-default-nodes and @tryghost/kg-lexical-html-renderer
no issue
2023-06-22 17:07:44 +02:00
Simon Backx
5e3e04c409 Updated lockfile (Sentry removed from comments-ui)
no issue

Missed a lockfile update somewhere in a previous commit.
2023-06-22 17:06:04 +02:00
Sanne de Vries
f2d35c6a9a
Updated admin darkmode background color to be consistent with global … (#17101)
…colors

No ref
2023-06-22 16:35:03 +02:00
Daniel Lockyer
2c067aa1bb Fixed hack to kill Ghost after boot in tests
- in the migration tests we need to boot Ghost and then kill it
  afterwards
- because there was no easy way to do this, the workflow waits for 20s
  and then kills the last process ID
- aside from being a terrible idea, it means we're also just arbitrarily
  waiting for 20s, which burns time when it takes shorter to boot Ghost
- this commit implements an environment variable that will kill the
  server once it has run the whole boot process, and then fixes the
  workflow to use that
2023-06-22 15:32:48 +02:00
Simon Backx
8d6fb51908 Added Playwright tests to comments-ui
refs https://github.com/TryGhost/Team/issues/3504

Not complete yet, but contains the basic structure and a few tests that work and should run in CI.
2023-06-22 15:06:13 +02:00
Simon Backx
ab86e0d901 Removed Sentry and unused data options from comments-ui
refs https://github.com/TryGhost/Team/issues/3504

- Sentry was never setup and we don't use it
- Styles have been moved to inline JS styles (no separate css file generated)
- App version was never used
- Improved current script tag detection
2023-06-22 15:06:13 +02:00
Michael Barrett
a79035c2f6
🐛 Fixed portal free trial message incorrectly showing (#17095)
no issue

Fixed portal free trial message incorrectly showing when signing up for
free. Message was showing due to `pageQuery` erroneously not being
passed down the call stack to `getSiteProducts`
2023-06-22 13:38:33 +01:00
Sanne de Vries
64518d2ad4
Updated signup card frontend styles for contained split layout (#17078)
Refs https://github.com/TryGhost/Team/issues/3459
2023-06-22 12:41:45 +02:00
renovate[bot]
e723365cd5 Update storybook monorepo to v7.0.23 2023-06-22 12:31:42 +02:00
Jono M
9a569b1d1f
Updated AdminX form inputs to be controlled instead of uncontrolled (#17090)
refs https://github.com/TryGhost/Team/issues/3349
2023-06-22 20:44:29 +12:00
Simon Backx
098d2ad3d9 Updated comments-ui eslint rules
refs https://github.com/TryGhost/Team/issues/3504

- Use same rules as signup-forms
- Updates files for the new rules
2023-06-22 10:39:39 +02:00
Daniel Lockyer
dfd5c50b80
Configured yarn dev to allow starting Comments-UI
refs https://github.com/TryGhost/Toolbox/issues/400

- this allows for easier development with Comments-UI
2023-06-22 10:23:05 +02:00
Daniel Lockyer
76a6a14731
Added workflow for running Comments-UI tests
refs https://github.com/TryGhost/Toolbox/issues/400

- this will run whenever the comments-ui files have changed
2023-06-22 10:06:28 +02:00
Daniel Lockyer
76f01cca23
Added Comments-UI build folder to gitignore
refs https://github.com/TryGhost/Toolbox/issues/400

- we don't want to track this in git
2023-06-22 10:05:58 +02:00
Daniel Lockyer
130c9c3c6f
Updated test:unit script for Comments-UI
refs https://github.com/TryGhost/Toolbox/issues/400

- this package won't pass tests on Node 16 because of the use of
  `fetch`, but that's ok because we publish using Node 18 anyway
- this switches the test command to just ensuring the package can build
2023-06-22 10:01:07 +02:00
Daniel Lockyer
8fc09b9433
Removed unneeded files
refs https://github.com/TryGhost/Toolbox/issues/400

- these files are no longer needed now the package is in the monorepo
2023-06-22 09:57:43 +02:00
Daniel Lockyer
5da9264ea7
Updated lockfile
- removed the imported one from comments-ui repo
2023-06-22 09:51:25 +02:00
Daniel Lockyer
36af781a67
Migrated code + history from Comments-UI
refs https://github.com/TryGhost/Toolbox/issues/400

- this moves comments-ui into the monorepo to aid with the development
  workflow
2023-06-22 09:48:32 +02:00
Simon Backx
60f969c9c2 Locked resolutions of tiptap and prosemirror 2023-06-22 08:35:17 +02:00
Daniel Lockyer
498e166e8b
Updated lockfile 2023-06-21 18:08:23 +02:00
Ghost CI
caadf7235c Merged v5.52.3 into main 2023-06-21 15:37:59 +00:00
Ghost CI
b7cad4e8fb v5.52.3 2023-06-21 15:37:57 +00:00
Simon Backx
fbd268272a Fixed linting issues 2023-06-21 17:25:47 +02:00
Daniel Lockyer
346b9ff9e2 Added missing dependencies
- both eslint and jsdom are needed to correctly run linting + tests
2023-06-21 17:22:07 +02:00
Daniel Lockyer
fcce6d8519 Removed react-scripts dependency
refs 13d3d0cde6

- this is no longer needed because we've migrated to Vite
2023-06-21 17:19:14 +02:00
Daniel Lockyer
2df3caa159 Removed use of Cypress eslint plugin
refs 13d3d0cde6

- we removed cypress in the referenced commit so this is no longer
  needed
2023-06-21 17:18:00 +02:00
Michael Barrett
db0081ccaf
🐛 Fixed revision save reverting newly published post to draft (#17083)
fixes https://github.com/TryGhost/Ghost/issues/17076

When a post is saved `_revisionSaveTask` gets queued to execute 10
minutes from the save. When a post is published via the publish modal
`_revisionSaveTask` does not get dequeued. When `_revisionSaveTask` gets
executed at the 10 minute mark it is assumed that it is ok to save a
revision, which will cause the post to be reverted back to a draft. This
change enforces another check during the task exection to ensure that it
is in fact still ok to save a revision (in case anything has changed in
the 10 minutes since the task queued, i.e the post being published)
2023-06-21 17:08:39 +02:00
Simon Backx
e94bdd57ae Updated posts exporter comment tests
fixes https://github.com/TryGhost/Team/issues/3505

I've investigated this, but luckily this is expected behaviour, and was just an error previously in the test:
- The `feedback_more_like_this` and `feedback_less_like_this` columns are only hidden if there is no newsletter with feedback enabled, or if member features are disabled.
- Having a post which is a draft, should not change the visible columns, only global settings should change the comments (so the format is consistent).
- Instead of that, the columns should be null, which means it will be visible but empty.
2023-06-21 16:57:54 +02:00
Simon Backx
181185156a Added --comments option to yarn dev
refs https://github.com/TryGhost/Team/issues/3504
2023-06-21 16:41:00 +02:00