Commit Graph

35747 Commits

Author SHA1 Message Date
Daniel Lockyer
a1cc60638a Added yarn build:clean command
- this reset the Nx build cache and removes the build files from each
  package:
2023-07-17 17:41:57 +02:00
Daniel Lockyer
60e478ff90 Enabled sourcemaps in tsconfig
refs https://ghost.slack.com/archives/C05DUT549JR/p1689604345421799

- this enables sourcemap creation in our tsconfig setup so breakpoints
  work correctly in a debugger
- this should eventually be switched out for a CLI flag as we don't want
  to produce sourcemaps all the time (for example during release)
2023-07-17 17:41:57 +02:00
Aileen Booker
c281935a35 Added ref query param to Explore link 2023-07-17 16:31:57 +01:00
Daniel Lockyer
61b4a6828d Removed pre-push hook
- we no longer allow pushing to the `main` branch, so this hook is never
  used
- if you tried to push locally, it'd fail because I've since removed
  Lerna
- this commit cleans up the hook
2023-07-17 17:10:58 +02:00
Ghost CI
367ff21ed6 Merged v5.54.3 into main 2023-07-17 14:18:35 +00:00
Ghost CI
b74e29aa70 v5.54.3 2023-07-17 14:18:33 +00:00
Daniel Lockyer
999425ccf6
Fixed loading CDN assets via lazy loading
refs https://github.com/TryGhost/DevOps/issues/47

- in the event we supply a CDN URL, don't prefix the URL with anything
  as this will get auto-prefixed
- if not, add the Ghost Admin root because the assets sit under there
2023-07-17 15:40:46 +02:00
Daniel Lockyer
dc2c8330af
Configured Admin to use CDN URLs for lazy-loaded assets
refs https://github.com/TryGhost/DevOps/issues/47

- this allows Ghost to use a different URL for lazy-loaded assets, so it
  can be loaded from a CDN
2023-07-17 15:40:42 +02:00
Daniel Lockyer
46422d7bae Reverted "Enabled Sentry Replay within Admin"
refs https://ghost.slack.com/archives/C02G9E68C/p1689599266267649

- this reverts commit bb6deda10e
- we're seeing some weird errors when Admin boots otherwise
2023-07-17 15:31:25 +02:00
Daniel Lockyer
27d8441098
Reverted "Enabled Sentry Replay within Admin"
refs https://ghost.slack.com/archives/C02G9E68C/p1689599266267649

- this reverts commit bb6deda10e
- we're seeing some weird errors when Admin boots otherwise
2023-07-17 15:23:59 +02:00
Kevin Ansfield
53096e214c
🐛 Fixed poor performance when rendering beta editor posts (#17388)
no issue

- bumps `@tryghost/kg-lexical-html-renderer` which includes a change to drastically reduce the number of `jsdom` instantiations made when rendering text content
2023-07-17 14:21:37 +01:00
Kevin Ansfield
636b1e67b2
Fixed pages API test snapshot having a flaky cache string (#17391)
no issue

- `x-cache-invalidate` will vary across different runs as the post's preview uuid will be different each time the post is created
2023-07-17 13:21:00 +00:00
Kevin Ansfield
135f5fa287
🐛 Fixed poor performance when rendering beta editor posts (#17388)
no issue

- bumps `@tryghost/kg-lexical-html-renderer` which includes a change to drastically reduce the number of `jsdom` instantiations made when rendering text content
2023-07-17 13:42:55 +01:00
Daniel Lockyer
67a8244811 Fixed loading CDN assets via lazy loading
refs https://github.com/TryGhost/DevOps/issues/47

- in the event we supply a CDN URL, don't prefix the URL with anything
  as this will get auto-prefixed
- if not, add the Ghost Admin root because the assets sit under there
2023-07-17 14:03:20 +02:00
Naz
97f24338bf Commented out flaky collections tests
refs https://github.com/TryGhost/Arch/issues/16

- There's a race condition happening when processing multiple collection updates at the same time. It causes the state to be inconsistent between the runs.
- Once the event handling is improved these tests should be put back into action
2023-07-17 20:02:54 +08:00
Ronald Langeveld
0c719f33f7 🐛 Fixed memberlinks returning undefined in autocomplete. (#17385)
refs https://github.com/TryGhost/Ghost/pull/17327

- Added an additional condition to avoid the new memberLinks function
from returning undefined, which may lead to nothing being returned at
all in the autocomplete.

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->

Improved `memberLinks` function in `koenig-lexical-editor.js` to support
optional links and fix a bug.
2023-07-17 13:38:31 +02:00
renovate[bot]
a0e537c3eb Update dependency vite-plugin-commonjs to v0.8.2 2023-07-17 13:07:33 +02:00
Ronald Langeveld
baa84f4765
Added base styles for Header Card v2 (#17387)
refs https://github.com/TryGhost/Product/issues/3508

- copied over styles from the signup card, which is what the new header
card is loosely based on.
- this is meant to be hacked till we have the new header card look
pretty.

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 150aa92</samp>

This change introduces a new header card v2 component that allows users
to create custom headers for their Ghost site. It adds a new CSS file
`header_v2.css` that defines the styles and responsive behavior for the
component. The file uses modern CSS features to achieve a flexible and
consistent design. The file is part of the frontend module of the Ghost
core repository.
2023-07-17 10:49:48 +00:00
Ronald Langeveld
d1e1dc3e79
Fixed memberlinks returning undefined in autocomplete. (#17385)
refs https://github.com/TryGhost/Ghost/pull/17327

- Added an additional condition to avoid the new memberLinks function
from returning undefined, which may lead to nothing being returned at
all in the autocomplete.

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 59d45a1</samp>

Improved `memberLinks` function in `koenig-lexical-editor.js` to support
optional links and fix a bug.
2023-07-17 10:45:16 +00:00
Naz
ea2defb76c Updated collection descriptions
refs https://github.com/TryGhost/Arch/issues/25

- Updated collection descriptions to be less wordy and avoid a redundant "Collection" in them.
2023-07-17 18:43:21 +08:00
Naz
c733424cc5 Fixed collections ordering
refs https://github.com/TryGhost/Arch/issues/25

- When run against different DB Engines the returned order of collections belonging to a post is not consistent (SQLite vs MySQL). Having a primitive ordering by slug allows to keep the order compatible
2023-07-17 18:43:21 +08:00
Naz
9bfb197a85 Added fixtures for collection posts
refs https://github.com/TryGhost/Arch/issues/25

- Adds collection_posts fixtures
2023-07-17 18:43:21 +08:00
Naz
b5d1245be1 Added posts_collections table population
refs https://github.com/TryGhost/Ghost/pull/17247

- When the instance is started the posts_collections records should be pre-filled for built-in collections. This is to avoid expensive processing during every instance startup.
2023-07-17 18:43:21 +08:00
Naz
ed91412cd5 Changed "index" collection name to "latest"
https://github.com/TryGhost/Arch/issues/25

- This naming matches how the collection will be visible in the cards and how it's marketed. Naming it "index" even for internal purposes will get confusing.
2023-07-17 18:43:21 +08:00
Naz
acbe3a250e Added built in collection fixtures
refs https://github.com/TryGhost/Arch/issues/25

- The instance should have two built-in collections "latest" (prviously known as "index") and "featured". These have been filled through in-memory tricks before, now they should come pre-populated through fixtures mechanism.
2023-07-17 18:43:21 +08:00
Fabien "egg" O'Carroll
32f602d899 Fixed VSCode launch.json config
The dev script was moved and the launch config was not updated.
2023-07-17 11:40:40 +01:00
Fabien "egg" O'Carroll
605aa18d6a Added collections helper
This is an initial implementation which uses the Posts Content API rather than
the Collections Content API, this is because we haven't added the Collections
Content API yet, but we can added it later when necessary.
2023-07-17 11:35:30 +01:00
Fabien "egg" O'Carroll
be0dbe3e91 Used posts-service for Posts Content API
We want to keep the differences between the Content & Admin API's in the API
layer, rather than at the service layer. The caching functionality hasn't been
moved yet though, and can be handled separately.
2023-07-17 11:35:30 +01:00
Daniel Lockyer
e87c994bba Configured Admin to use CDN URLs for lazy-loaded assets
refs https://github.com/TryGhost/DevOps/issues/47

- this allows Ghost to use a different URL for lazy-loaded assets, so it
  can be loaded from a CDN
2023-07-17 10:57:42 +02:00
Djordje Vlaisavljevic
375d723878
Added static Newsletter settings to Admin X settings (#17374)
refs https://github.com/TryGhost/Product/issues/3601

- Added static design for Newsletter settings group to Admin X settings,
that shows a simple list of newsletters and opens a preview modal with a
sidebar with static form design
- Fixed issue with spacing in `Forms` when there is no title
2023-07-17 09:12:05 +01:00
renovate[bot]
d753ad4f02 Update dependency @storybook/addon-styling to v1.3.4 2023-07-17 09:51:13 +02:00
renovate[bot]
8e4393d16f Update dependency @playwright/test to v1.36.1 2023-07-17 09:48:14 +02:00
Chris Raible
b625fe76b1
Updated snapshots to include show_title_and_feature_image in event payload (#17378)
no issue

- Tests were failing for me locally because the snapshot for testing
page event payloads didn't include the new
`show_title_and_feature_image` property
- Updated snapshot to include this property, which also changed a few content lengths and `x-cache-invalidate` headers as a side effect
2023-07-14 16:03:40 -07:00
Sag
f746704ba1
Fixed detection of the stripe_customer_id field in Members Import (#17375)
no issue
2023-07-14 15:43:38 +00:00
Ghost CI
fad31e0bca v5.54.2 2023-07-14 15:34:52 +00:00
Ghost CI
a7292cbf1f v5.54.1 2023-07-14 15:03:30 +00:00
Daniel Lockyer
95682f6f94 Configured auto-imported assets to load from supplied URL
refs https://github.com/TryGhost/DevOps/issues/47

- this allows us to optionally configure a URL to set as the CDN URL in
  Admin
2023-07-14 16:29:59 +02:00
Jono M
0137f498d7
Added tests for tier edit modal (#17369)
refs https://github.com/TryGhost/Product/issues/3580
2023-07-14 13:04:34 +00:00
Daniel Lockyer
704fc18856 Removed duplicate build step during tarballing
- we don't need to define this in `prepack` because Nx can be configured
  to do this for us
2023-07-14 14:29:14 +02:00
Daniel Lockyer
0616222d2e Added support for prepending CDN URLs to Admin assets
refs https://github.com/TryGhost/DevOps/issues/47

- this allows us to produce builds that use URLs from a CDN if the env
  var is provided
2023-07-14 12:27:37 +02:00
Peter Zimon
a463db4845
Admin X Tiers refinements (#17366)
refs. https://github.com/TryGhost/Product/issues/3580

- It was possible to archive free tier
- The form group heading wasn't discoverable enough
- The left action in modals were not working
2023-07-14 11:43:28 +02:00
Daniel Lockyer
90adbc4865 Removed canary workflows
refs https://github.com/TryGhost/DevOps/issues/47

- we need to start building from git refs so this workflow which builds
  a tarball is no longer needed and just adds to the execution time
2023-07-14 11:24:18 +02:00
renovate[bot]
2f76f07dff Update dependency vite to v4.4.4 2023-07-14 11:04:59 +02:00
Daniel Lockyer
06a9e03f20 Added woff2 and mp4 file fingerprinting to Admin
refs https://ghost.slack.com/archives/C027S85FS/p1688984189646059?thread_ts=1688979558.123869&cid=C027S85FS

- this enables those file extensions to get fingerprinted so the
  filenames contain hashes
2023-07-14 10:50:18 +02:00
Daniel Lockyer
9a68187b8e Reformatted list of fingerprint-enabled file extensions
- this makes it easier to read the diff when you're adding extensions
2023-07-14 10:50:18 +02:00
renovate[bot]
b8870dec99 Update dependency tailwindcss to v3.3.3 2023-07-14 08:58:58 +02:00
Daniel Lockyer
9f40c90e07 Switched to Nx runner for more tasks
- this switches us to using Nx for `ghost:dev`, which means we can
  configure its dependencies and ensure that the TS projects are built
  beforehand
- also switches to Nx for `ghost:archive` so we don't need to run
  `build:ts` for all `yarn` commands
2023-07-14 08:52:01 +02:00
Daniel Lockyer
e990cbba01 Configured storing Nx cache in GHA to speed up builds
refs https://github.com/TryGhost/DevOps/issues/47

- this allows us to store and restore the cache for TS builds, which
  should speed up the whole process
2023-07-14 08:52:01 +02:00
Naz
0be06f0237 Added extra logging to collections event processing
no issue

- These logs are useful when tracking event processing by the collections repo.
2023-07-14 14:20:37 +08:00
Naz
382d7fa25f Removed unused collections repositories
no issue

- These repositories were leftover from first phases of collections development. Not needed any longer as we have more specialized bookshelf repositories in the core code
2023-07-14 14:20:37 +08:00