refs https://github.com/TryGhost/Toolbox/issues/583
- this commit adds config for codecov because this repo needs some
changes that aren't suitable for the global config
- this probably needs some adjusting over time but should get us started
for now
closes https://github.com/TryGhost/Ghost/issues/16817
The member activity event filter was broken due to a recursion issue.
This commit changes the usage of a getter fn to a normal class method to
make the logic more performant and remove the recursion issue
refs https://github.com/TryGhost/Team/issues/3168
- This is basic scaffolding for collection resources UI in Admin. For the most part it's a copy-paste of tags code with slight modifications to fit the collections usecase
refs. https://github.com/TryGhost/Team/issues/3150
The sidebar was `sticy` which meant that users had to scroll all the way down to see the bottom of the sidebar. This defeats the purpose of being able to quickly jump to a section.
refs. https://github.com/TryGhost/Team/issues/3150
The style of having only an underline for input textfields and dropdowns sounds good in theory (and we might be able to use it in other context), but in Settings these components were hard to scan.
refs https://github.com/TryGhost/Team/issues/3151
- updates textfield to have password type
- updates wiring for mailgun settings
- updates wiring for analytics settings
- fixes local value read or useSettingGroup
refs 97584cf0c4
- We now track launch.json file in source control and it's often useful to be able to debug tests either for separate packages or e2e types of tests inside of Ghost core
- These configurations should be useful "templates" for custom launchers one might need when working on specific part of the code
refs https://github.com/TryGhost/Team/issues/3151
- adds new hook for managing state/changes in a Settings Group
- updates existing settings to work with the new hook to clean the code
- wires membership access settings for read/write
- lint cleanup
- this will allow us to see which set of tests are consuming the most
amount of time in CI
- in order to split apart the commands, I've had to override the
coverage thresholds for integration+regression tests in order to keep
c8 happy
- also sprinkled some more labels into the workflows to make things
clearer to read
fixes https://github.com/TryGhost/Toolbox/issues/583
- we currently upload the codecov for unit tests and e2e/admin tests
separately
- unfortunately this means that when one submits before the other, the
codecov % will be incorrect
- this leaves a big red cross on the commit until the other coverage is
uploaded
- this should fix that by upload the coverage in one step once CI is
happy