Commit Graph

4568 Commits

Author SHA1 Message Date
Renovate Bot
af3a20515a Update dependency ember-exam to v3 2019-05-13 15:55:11 +01:00
Kevin Ansfield
d193317bbd Refactored deprecated usage of this.$() in rendering tests
no issue

- https://emberjs.com/deprecations/v3.x#toc_jquery-apis
2019-05-13 15:31:32 +01:00
Kevin Ansfield
a96e942c4b Refactored deprecated usage of [files] option param for triggerEvent 2019-05-13 15:31:32 +01:00
Kevin Ansfield
1520122483 Refactored deprecated usage of setupTest* methods
no issue

- https://github.com/emberjs/ember-mocha/blob/master/docs/migration.md#upgrading-to-the-new-testing-apis
- deleted tests files which had no specific tests
- migrated unskipped component unit tests to integration tests
2019-05-13 15:31:32 +01:00
Kevin Ansfield
67360b5f71 Updated test-helper.js to use explicit start() call
no issue

- this was a breaking change introduced in ember-mocha@0.15.0 https://github.com/emberjs/ember-mocha/blob/master/CHANGELOG.md#v0150-2019-05-11
2019-05-13 15:31:32 +01:00
Renovate Bot
0eaf9e0247 Update ember testing 2019-05-13 15:31:32 +01:00
Kevin Ansfield
cf4246dd5e Bumped waitFor timeouts in gh-uploader tests
no issue

- Travis was randomly failing here
2019-05-13 09:59:05 +01:00
Renovate Bot
320d228efd Update dependency ember-infinity to v1.4.5 2019-05-13 02:30:27 +00:00
Renovate Bot
82f5eec067 Update dependency ember-data to v3.9.3 2019-05-13 01:29:00 +00:00
Kevin Ansfield
e6d03e9904 Fixed deprecated computed().volatile() usage
no issue

- https://deprecations.emberjs.com/v3.x/#toc_computed-property-volatile
2019-05-07 14:54:41 +01:00
Peter Zimon
ccbc26d6bc Sidebar refinements and view site in new tab button (#1192)
no refs.

- added view site in new tab button to sidebar
- show secondary actions on sidebar only on mouseover
- replaced labs icon
- refined spacing for view site
- unified colors of secondary icons
2019-05-07 15:29:59 +02:00
Kevin Ansfield
d0c2caec9e Fixed transition-state deprecation on Integration screen
no issue

- https://deprecations.emberjs.com/v3.x/#toc_transition-state
2019-05-07 14:04:16 +01:00
Kevin Ansfield
b7b51bbb0f Fixed deprecated usage of new EmberObject in <GhUploader>
no issue

- https://deprecations.emberjs.com/v3.x/#toc_object-new-constructor
- `UploadTracker` is extended from `EmberObject` so we should use the `.create` method
2019-05-07 13:26:32 +01:00
Kevin Ansfield
320908d64d Removed unused code in posts route 2019-05-07 12:55:19 +01:00
Kevin Ansfield
a7f4610381 Removed usage of ember-light-table in subscribers screen (#1191)
no issue

`ember-light-table` is falling behind Ember.js and other addon development and is increasingly causing issues with Ember deprecations and addon incompatibility.

- swaps `ember-light-table` usage for a straightforward table using `vertical-collection` for occlusion
- uses the same loading mechanism as the members screen with a slight optimisation where the initial load will fetch subscribers in batches of 200 until they are all loaded
- removes now-unused pagination mixin
- fixes duplicate subscriber validation handling
2019-05-07 12:39:56 +01:00
Nazar Gargol
3afcbf0c39 Version bump to 2.22.0 2019-05-07 12:37:29 +02:00
Kevin Ansfield
344999a69b Fixed "remove all listeners" deprecation
no issue

- https://deprecations.emberjs.com/v3.x/#toc_events-remove-all-listeners
2019-05-06 15:00:06 +01:00
Kevin Ansfield
f8ccb81dfc Fixed deprecated access of controller.{currentPath,currentRouteName}
no issue

- replaced access of `controller.{currentPath,currentRouteName}` with `router.currentRouteName`
- https://deprecations.emberjs.com/v3.x/#toc_application-controller-router-properties
2019-05-06 14:51:23 +01:00
renovate[bot]
0fb1bb5353 Update dependency @tryghost/kg-parser-plugins to v0.5.0 (#1188) 2019-05-06 12:31:39 +01:00
renovate[bot]
eecf78d9fd Lock file maintenance (#1189) 2019-05-06 12:31:26 +01:00
renovate[bot]
d938800d2e Update dependency ember-power-select to v2.3.2 (#1187) 2019-05-06 12:04:39 +01:00
Kevin Ansfield
5d03aa2f06 Removed coveralls code-coverage reporting (#1190)
no issue
- coverage reports were not really being used and were frequently ignored when merging PRs because we knew there were reductions in test coverage
- coveralls also causes some problems with Renovate because there can be random micro changes in reported coverage that meant a PR "failed" when really it was fine
2019-05-06 12:02:23 +01:00
Renovate Bot
dc045cc710 Update dependency @tryghost/kg-clean-basic-html to v0.1.1 2019-05-06 10:29:32 +00:00
Renovate Bot
787b07b5b5 Update dependency @tryghost/mobiledoc-kit to v0.11.2 2019-05-06 05:23:36 +00:00
Renovate Bot
125c817061 Update dependency @tryghost/timezone-data to v0.2.2 2019-05-06 03:24:47 +00:00
Renovate Bot
6d1a2c7bf9 Update dependency @tryghost/kg-parser-plugins to v0.4.2 2019-05-06 02:25:09 +00:00
Renovate Bot
76cdb9e677 Update dependency @tryghost/helpers to v1.1.3 2019-05-06 01:24:29 +00:00
Kevin Ansfield
70bec996fe Use extracted @tryghost/kg-parser-plugins package
no issue

- `@tryghost/kg-parser-plugins` contains the parser plugins used by the editor and was extracted so that they can be used in server-side html-to-mobiledoc conversion
2019-05-03 10:45:08 +01:00
Kevin Ansfield
d412e624d5 Use extracted @tryghost/kg-clean-basic-html package
no issue
- `cleanBasicHtml` has been extracted to an external package so that it can be used inside the extracted `@tryghost/kg-parser-plugins` package server-side
2019-05-02 17:14:00 +01:00
Kevin Ansfield
5883784268 Fixed random failure of gh-uploader test 2019-05-01 16:09:28 +01:00
Kevin Ansfield
02005c0171 Added caption support to code cards (#1181)
*  Added caption support to code cards

no issue

* fix caption placeholder text

* add figure-to-code-card parser plugin, add language detection to code card parsers

* extract {{kg-action-bar}} component

* do not show card toolbar if caption has focus
2019-05-01 16:36:02 +02:00
Kevin Ansfield
7bd1b20492 Fixed Travis not running for non-renovate PRs 2019-05-01 15:34:37 +01:00
Kevin Ansfield
1768b864be do not show card toolbar if caption has focus 2019-05-01 15:13:49 +01:00
Kevin Ansfield
ab85412625 extract {{kg-action-bar}} component 2019-05-01 13:57:00 +01:00
Kevin Ansfield
74fa03a72a add figure-to-code-card parser plugin, add language detection to code card parsers 2019-05-01 10:41:42 +01:00
Kevin Ansfield
f64ae7a326 fix caption placeholder text 2019-05-01 09:54:04 +01:00
Kevin Ansfield
0b9aedf060 Added caption support to code cards
no issue
2019-04-30 18:14:49 +02:00
Kevin Ansfield
88e319f89f Fixed invisible caret in captions for cards with no style specified 2019-04-30 17:53:19 +02:00
Kevin Ansfield
dabb52cbf6 Increased timeout for gh-task-button disabled assertion 2019-04-30 17:29:28 +02:00
Zimo
de50206727 Refined code card language input font size
no issue.
2019-04-30 17:03:06 +02:00
Kevin Ansfield
1dad18a06c Added language selection to code cards (#1180)
no issue

- Added a language indicator when in rendered mode and a language input when in edit mode
- Allow code card language to be set with <code>```lang</code>+<kbd>Space/Enter</kbd> expansion 
    - previously <code>\`\`\`</code> would immediately create a code card, the <kbd>Space/Enter</kbd> is now necessary for the insertion to occur
    - lang is optional <code>\`\`\`</code>+<kbd>Space/Enter</kbd> will insert a code card with no language selected
    - requires <kbd>Enter</kbd> to be pressed to finalise the expansion and insert the card
    - added hook for text expansions to skip newline creation for when they are triggered with <kbd>Enter</kbd>
- Set the code card editor's language mode based on selected language
    - set the CodeMirror mode based on the code card payload language
        - add a basic map of language short codes to their respective CodeMirror modes
    - observe `mode` property in `{{gh-cm-editor}}` so that the mode is properly set when it's changed after initial render
2019-04-30 16:46:29 +02:00
Kevin Ansfield
a7ec41f4e5 Version bump to 2.21.1 2019-04-30 11:10:02 +02:00
Kevin Ansfield
ef69eb8610 🐛 Fixed syntax highlighting inside Code Injection inputs
no issue
- the CodeMirror and theme styles were not being correctly loaded
2019-04-29 17:57:41 +02:00
Kevin Ansfield
cdb29b3284 Fixed slash-menu appearing empty immediately after setting title on new post
closes https://github.com/TryGhost/Ghost/issues/9847
- the text expansion is triggered twice in this situation, the first time with `""` and the second with `"/"`. The second trigger was trying to match cards to `"/"` which returned an empty card set
- added a quick workaround that ensures we never include a leading `/` in the card selection query
2019-04-29 17:08:40 +02:00
Kevin Ansfield
d7771059d0 Increase timeout for gh-uploader progress bar assertion
no issue
- hopeful fix for randomly failing Travis
2019-04-29 16:56:19 +02:00
Kevin Ansfield
484b8cf0d4 Update dependency @tryghost/mobiledoc-kit to v0.11.2-ghost.1
closes https://github.com/TryGhost/Ghost/issues/10717
- includes fix for `range#expandByMarker`
2019-04-29 16:47:08 +02:00
Kevin Ansfield
a89cc44199 Fixed backspace not combining sections if first section is a special markup
refs https://github.com/TryGhost/Ghost/issues/10717#issuecomment-487557026
- avoid triggering special markup delete behaviour when cursor is at the beginning of a section
2019-04-29 14:25:59 +02:00
Kevin Ansfield
0162df47b3 Fixed linting 2019-04-29 13:56:00 +02:00
Kevin Ansfield
2b1fadf757 🐛 Fixed current styling being lost when applying markdown expansions
closes https://github.com/TryGhost/Ghost/issues/10677
- adjusted the basic markdown text expansion behaviour to delete the MD chars and add a markup to the resulting range rather than deleting the whole range and re-adding it
- extracted basic markdown format behaviour into a helper function
- fixed the link markup expansion so that `[](https://example.com)` is recognised and creates a link with the URL as the text
2019-04-29 13:05:04 +02:00
renovate[bot]
1d9cd18e14 Lock file maintenance (#1178) 2019-04-29 09:00:37 +02:00