TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-11-24 06:35:49 +03:00
Code Issues Projects Releases Wiki Activity
389 Commits 227 Branches 1,677 Tags 368 MiB
bcb23bc9dc
Commit Graph

389 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Simon Backx
bcb23bc9dc Cleaned up Frame components 
refs https://github.com/TryGhost/Team/issues/1858
 2022-08-31 14:52:49 +02:00
Simon Backx
02a514f17c Removed style option from Frame component 2022-08-31 14:36:26 +02:00
Simon Backx
c3c00d0215 Fixed linting issues 2022-08-31 14:20:23 +02:00
Simon Backx
c803f7454e Fixed secundaryFormCount debug counter visible 
no issue
 2022-08-31 13:29:23 +02:00
Simon Backx
90e0ced175 Added separate BlankAvatar component 
refs https://github.com/TryGhost/Team/issues/1858
 2022-08-31 13:29:01 +02:00
Simon Backx
b701ba9c0d Cleaned up Comment component (#8) 
refs https://github.com/TryGhost/Team/issues/1858
fixes https://github.com/TryGhost/Team/issues/1789

- Split up the Comment component in many small Components to make it easier to read and maintain
- Added support for synchronous actions, which are required for actions that affect the context state based on the current value (e.g., increasing a value by one) because of the asynchronous nature of setState:

Before this change
```
// Context state: {hello: 0};
dispatchAction('increaseHelloByOne')
dispatchAction('increaseHelloByOne')
```

Could end up having a state `{hello: 1}` instead of the expected `{hello: 2}`, because underlying this would resolve into:

```
// Context state: {hello: 0};
const hello = {hello: 0};
setState({hello: hello + 1});
setState({hello: hello + 1});
```

Instead of

```
// Context state: {hello: 0};
setState(({hello}) => {hello: hello + 1});
setState(({hello}) => {hello: hello + 1});
```

Synchronous actions now support this.

- Removed deprecated `onAction` context state function
- Replaced the boolean based form checking by the more reliable counter based checking that uses synchronous actions (reason we needed synchronous actions) (fixes https://github.com/TryGhost/Team/issues/1789)
- Prevent creating a new `dispatchAction` function every time the context state changes, by using bind. This prevents infinte updates in `useEffect` hooks that depend on `dispatchAction` and also update the context via actions.
 2022-08-30 16:25:40 +02:00
James Morris
3a29a55228 Added eslinting to better manage Tailwind classes 2022-08-30 14:53:35 +01:00
James Morris
455cba4da2 Fixed the transparent background on text input for light mode 2022-08-30 10:38:17 +01:00
Simon Backx
31c2174d47 v0.9.2 2022-08-15 12:45:46 +02:00
Peter Zimon
e95e93618f Refined spacings for paragraphs and blockquotes 
- paragraphs had a bit too much bottom margin
- blockquotes missed bottom margin
 2022-08-15 12:42:40 +02:00
Simon Backx
6274e90e27 v0.9.1 2022-08-15 12:34:45 +02:00
Simon Backx
c8d4b89ac7 🐛 Added line break on Shift + Enter 
refs https://github.com/TryGhost/Team/issues/1793

Included in the @tiptap/extension-hard-break extension.
 2022-08-15 12:32:59 +02:00
Simon Backx
41623a6512 v0.9.0 2022-08-15 11:30:18 +02:00
Simon Backx
2b83af85d1 🐛 Fixed popups not closing correctly 
refs https://ghost.slack.com/archives/C02G9E68C/p1660323308235919

- When opening and closing a popup very fast, it will stay in DOM, blocking all pointer events.
- The Headless UI component <Transition show={show}> is not removed from DOM when show is set to true, and false very fast
- Fixed this by forcing a popup to get removed from DOM after 250ms after is has been closed.
- Updated HeadlessUI version
- Moved testing packges to dev dependencies
 2022-08-15 10:22:26 +02:00
Simon Backx
bf698c9a75 v0.8.0 2022-08-12 15:56:07 +02:00
Simon Backx
e44415eb6f Cleaned up margin syntax 2022-08-12 15:51:35 +02:00
Simon Backx
99ae23cf23 Excluded the last paragraph from bottom margin 2022-08-12 15:50:32 +02:00
James Morris
398a410ba2 Fixed up the paragraph spacing in the editor 
no issue
 2022-08-12 14:23:18 +01:00
James Morris
ee210d80b6 v0.7.0 2022-08-12 14:03:38 +01:00
Simon Backx
991e0856b8 Removed unused jsom import 2022-08-12 14:47:31 +02:00
Simon Backx
11c3dcc77a Fixed comment content missing after unhiding them 
fixes https://github.com/TryGhost/Team/issues/1786
 2022-08-12 14:22:48 +02:00
Simon Backx
de30741fce Added unlike spy 2022-08-12 14:17:35 +02:00
Simon Backx
75510aac5e Added like and unlike tests 
refs https://github.com/TryGhost/Team/issues/1780
 2022-08-12 14:15:48 +02:00
James Morris
39629145d0 Added in more spacing for the CTAs to catch more ophans 
no issue
 2022-08-12 13:08:32 +01:00
James Morris
001229801d Fixed up some small dark mode problems 
- The loading spinner in dark mode wasn't black
- The action buttons didn't hover correctly in dark mode

no issue
 2022-08-12 11:19:01 +01:00
Simon Backx
42d69562d9 Added test for replies and deleted members 
refs https://github.com/TryGhost/Team/issues/1780
 2022-08-12 11:19:48 +02:00
James Morris
2d79ef7cf9 Fixed local warnings in the terminal when building for comments 
no issue
 2022-08-12 09:29:29 +01:00
James Morris
fa056be39b Fixed pagination buttons to show singular values properly 
refs https://github.com/TryGhost/Team/issues/1782
 2022-08-12 08:56:19 +01:00
James Morris
34004cd135 Added in precise fixed width buttons for form 
- Reduces large widths of the buttons and so now variable
- Added fixed width to keep button same width when sending

refs https://github.com/TryGhost/Team/issues/1779
 2022-08-11 17:14:00 +01:00
James Morris
63476f6eca Updated the shadow to bring a little more contrast 
refs https://github.com/TryGhost/Team/issues/1779
 2022-08-11 16:56:26 +01:00
James Morris
52cfac284f Added in some spacing to the CTA when there are comments 
refs https://github.com/TryGhost/Team/issues/1779
 2022-08-11 16:41:57 +01:00
Simon Backx
163367dd93 Removed transformApiSiteData import 2022-08-11 17:29:37 +02:00
Simon Backx
58d32b3c82 Implemented dark mode tests 
refs https://github.com/TryGhost/Team/issues/1780
 2022-08-11 17:28:41 +02:00
Simon Backx
ef4cfc9b9a Readded auth frame test and improved test structure 
refs https://github.com/TryGhost/Team/issues/1780
 2022-08-11 17:11:26 +02:00
James Morris
6abd6f6d03 Updated the report dialog to a nicer style 
refs https://github.com/TryGhost/Team/issues/1778
 2022-08-11 16:07:37 +01:00
Simon Backx
fd21a88d52 Added first basic comments test 2022-08-11 16:40:10 +02:00
James Morris
3b7d26154e Added in the comment border line when replying with no replies 
refs https://github.com/TryGhost/Team/issues/1779
 2022-08-11 15:35:04 +01:00
James Morris
91134ecb62 Pushed some changes to the profile modal for comments 
- Includes a fix to the close button when on mobile
- Has some tweaks suggested by Zimo to bring in line with Portal

refs https://github.com/TryGhost/Team/issues/1779
 2022-08-11 15:30:34 +01:00
Simon Backx
24f384b0a2 Fixed calculating if reply form is in viewport 2022-08-11 15:16:36 +02:00
James Morris
e130c2edcd Tweaked non-published comments in dark mode 
refs https://github.com/TryGhost/Team/issues/1775
 2022-08-11 13:57:35 +01:00
James Morris
1e72a267a3 Pushed a little fix to the dark mode for the comment border 
refs https://github.com/TryGhost/Team/issues/1777
 2022-08-11 13:53:42 +01:00
Simon Backx
ceaecf43e6 Updated form to only close when another form opens and scroll better 
fixes https://github.com/TryGhost/Team/issues/1753
refs https://github.com/TryGhost/Team/issues/1758

- Scroll only if form is not in viewport + scroll to center
- Fixes: You can’t tap reply if another reply box is open (or at least you have to tap a bunch of times)
 2022-08-11 14:46:14 +02:00
James Morris
4a0ad8c6bc Little style tweaks to comment replies border and pagination border 
refs https://github.com/TryGhost/Team/issues/1777
 2022-08-11 12:41:27 +01:00
James Morris
6db7d9bd2d Fixes for super long expertise in form and comments 
refs https://github.com/TryGhost/Team/issues/1758
 2022-08-11 12:35:38 +01:00
James Morris
5e8ebe44b8 Adding in a subtle border for the comments when it has replies 
refs https://github.com/TryGhost/Team/issues/1777
 2022-08-11 11:54:28 +01:00
James Morris
9a306a2db2 Posted a few little tweaks to the deleted/hidden comment 
refs https://github.com/TryGhost/Team/issues/1775
 2022-08-11 11:26:05 +01:00
James Morris
ba8df169ad Changed the markup layout of the comments to fix a positoning problem when expertise is too long on mobile 
- When the Expertise is too long, it can cause a broken look to comments on mobile
- Changed how the markup works to better handle the details
 2022-08-11 10:09:14 +01:00
James Morris
0cf0c5833a This seems to fix the modal zooming on iOS 
refs https://github.com/TryGhost/Team/issues/1758
 2022-08-11 09:16:55 +01:00
Simon Backx
12b224e17a v0.6.0 2022-08-11 10:03:22 +02:00
James Morris
a64f13ae2d Some attempts to fix some issues with comments on mobile 
refs https://github.com/TryGhost/Team/issues/1758
 2022-08-10 17:36:00 +01:00