1
0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-21 09:52:06 +03:00
Commit Graph

18018 Commits

Author SHA1 Message Date
renovate[bot]
c0d32080b7 Update dependency semver to v7.5.3 2023-06-23 07:08:38 +02:00
Simon Backx
9035a87e50 Updated @tryghost/kg-default-nodes and @tryghost/kg-lexical-html-renderer
no issue
2023-06-22 17:07:44 +02:00
Sanne de Vries
f2d35c6a9a
Updated admin darkmode background color to be consistent with global … ()
…colors

No ref
2023-06-22 16:35:03 +02:00
Daniel Lockyer
2c067aa1bb Fixed hack to kill Ghost after boot in tests
- in the migration tests we need to boot Ghost and then kill it
  afterwards
- because there was no easy way to do this, the workflow waits for 20s
  and then kills the last process ID
- aside from being a terrible idea, it means we're also just arbitrarily
  waiting for 20s, which burns time when it takes shorter to boot Ghost
- this commit implements an environment variable that will kill the
  server once it has run the whole boot process, and then fixes the
  workflow to use that
2023-06-22 15:32:48 +02:00
Simon Backx
8d6fb51908 Added Playwright tests to comments-ui
refs https://github.com/TryGhost/Team/issues/3504

Not complete yet, but contains the basic structure and a few tests that work and should run in CI.
2023-06-22 15:06:13 +02:00
Simon Backx
ab86e0d901 Removed Sentry and unused data options from comments-ui
refs https://github.com/TryGhost/Team/issues/3504

- Sentry was never setup and we don't use it
- Styles have been moved to inline JS styles (no separate css file generated)
- App version was never used
- Improved current script tag detection
2023-06-22 15:06:13 +02:00
Sanne de Vries
64518d2ad4
Updated signup card frontend styles for contained split layout ()
Refs https://github.com/TryGhost/Team/issues/3459
2023-06-22 12:41:45 +02:00
renovate[bot]
e723365cd5 Update storybook monorepo to v7.0.23 2023-06-22 12:31:42 +02:00
Jono M
9a569b1d1f
Updated AdminX form inputs to be controlled instead of uncontrolled ()
refs https://github.com/TryGhost/Team/issues/3349
2023-06-22 20:44:29 +12:00
Ghost CI
caadf7235c Merged v5.52.3 into main 2023-06-21 15:37:59 +00:00
Ghost CI
b7cad4e8fb v5.52.3 2023-06-21 15:37:57 +00:00
Michael Barrett
db0081ccaf
🐛 Fixed revision save reverting newly published post to draft ()
fixes https://github.com/TryGhost/Ghost/issues/17076

When a post is saved `_revisionSaveTask` gets queued to execute 10
minutes from the save. When a post is published via the publish modal
`_revisionSaveTask` does not get dequeued. When `_revisionSaveTask` gets
executed at the 10 minute mark it is assumed that it is ok to save a
revision, which will cause the post to be reverted back to a draft. This
change enforces another check during the task exection to ensure that it
is in fact still ok to save a revision (in case anything has changed in
the 10 minutes since the task queued, i.e the post being published)
2023-06-21 17:08:39 +02:00
Simon Backx
e94bdd57ae Updated posts exporter comment tests
fixes https://github.com/TryGhost/Team/issues/3505

I've investigated this, but luckily this is expected behaviour, and was just an error previously in the test:
- The `feedback_more_like_this` and `feedback_less_like_this` columns are only hidden if there is no newsletter with feedback enabled, or if member features are disabled.
- Having a post which is a draft, should not change the visible columns, only global settings should change the comments (so the format is consistent).
- Instead of that, the columns should be null, which means it will be visible but empty.
2023-06-21 16:57:54 +02:00
Michael Barrett
934ec415fc
🐛 Fixed revision save reverting newly published post to draft ()
fixes https://github.com/TryGhost/Ghost/issues/17076

When a post is saved `_revisionSaveTask` gets queued to execute 10
minutes from the save. When a post is published via the publish modal
`_revisionSaveTask` does not get dequeued. When `_revisionSaveTask` gets
executed at the 10 minute mark it is assumed that it is ok to save a
revision, which will cause the post to be reverted back to a draft. This
change enforces another check during the task exection to ensure that it
is in fact still ok to save a revision (in case anything has changed in
the 10 minutes since the task queued, i.e the post being published)
2023-06-21 15:12:19 +01:00
Jono Mingard
dd1d2f8d4d Added simple search bar to AdminX settings
refs https://github.com/TryGhost/Team/issues/3349
2023-06-21 22:11:55 +10:00
Ronald Langeveld
543f3750a7
🐛 Fixed draft pages not saving on forced revisions ()
closes https://github.com/TryGhost/Team/issues/3493

- Fixed pages not saving on force revision. As a side effect, it broke
admin navigation as it doesn't manage to create a new revision upon going back to the pages list.
- This was simply caused by a missing option in the API endpoint config.

---

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at b646916</samp>

This change enables the `pages` endpoint to handle page revisions by
adding the `save_revision` permission. This is part of a pull request
that adds page versioning and restoring functionality to Ghost.
2023-06-21 13:32:18 +02:00
Hannah Wolfe
3a58b6402a Update dependency eslint-plugin-ghost to v3.2.0
refs: https://github.com/TryGhost/Toolbox/issues/595

- Adds custom rules for node assert
- Enforces assert/strict as an error
2023-06-21 10:34:37 +01:00
Hannah Wolfe
6161f94910
Updated to use assert/strict everywhere ()
refs: https://github.com/TryGhost/Toolbox/issues/595

We're rolling out new rules around the node assert library, the first of which is enforcing the use of assert/strict. This means we don't need to use the strict version of methods, as the standard version will work that way by default.

This caught some gotchas in our existing usage of assert where the lack of strict mode had unexpected results:
- Url matching needs to be done on `url.href` see aa58b354a4
- Null and undefined are not the same thing,  there were a few cases of this being confused
- Particularly questionable changes in [PostExporter tests](c1a468744b) tracked [here](https://github.com/TryGhost/Team/issues/3505).
- A typo see eaac9c293a

Moving forward, using assert strict should help us to catch unexpected behaviour, particularly around nulls and undefineds during implementation.
2023-06-21 09:56:59 +01:00
Simon Backx
0c28cebfd4 Updated rate limiting snapshot for updated copy
refs https://ghost.slack.com/archives/C02G9E68C/p1687303342271029
2023-06-21 10:36:53 +02:00
sudachi12
366050a87d
Added Japanese translations ()
refs https://github.com/TryGhost/Team/issues/2795
2023-06-21 09:09:02 +02:00
brienjohn
4f5f58078d
Updated Traditional Chinese translations ()
refs https://github.com/TryGhost/Team/issues/2795
2023-06-21 08:30:43 +02:00
renovate[bot]
e3c9af380c Update dependency @storybook/testing-library to v0.2.0 2023-06-21 08:12:26 +02:00
Ghost CI
5dadaea515 Merged v5.52.2 into main 2023-06-21 03:32:58 +00:00
Ghost CI
18a0e173fb v5.52.2 2023-06-21 03:32:56 +00:00
Chris Raible
2568c5898a
🐛 Fixed post scheduling for sites with transferred ownership ()
refs 

- By default, the post scheduler runs as user_id = 1, which is the
original owner of the site
- If ownership has been transferred to a different user, it's possible
that there is no user with id = 1
- In this case, the scheduler would fail to publish a post, because
updating the post using user_id = 1 failed a foreign key constraint in
the post_revisions table
- This commit fixes the issue by checking if the contextUser exists, and
if not, replacing it with the current owner of the site
2023-06-20 19:51:13 -07:00
renovate[bot]
385ad2688b Update dependency @sinonjs/fake-timers to v11 2023-06-20 15:48:01 +02:00
renovate[bot]
476d7900d0 Update dependency @types/jsonwebtoken to v9 2023-06-20 15:46:04 +02:00
renovate[bot]
b1bcc2cb2d Update dependency luxon to v3 2023-06-20 15:22:54 +02:00
renovate[bot]
9d81dd5a80 Update metascraper to v5.34.7 2023-06-20 15:22:40 +02:00
Daniel Lockyer
5c4ef092b6 Updated vitest to v0.32
refs https://github.com/TryGhost/Ghost/pull/16949
refs https://github.com/vitest-dev/vitest/releases/tag/v0.32.0

- contains a switch from `@vitest/coverage-c8` to `@vitest/coverage-v8`
  as this is now required in 0.32
2023-06-20 14:54:04 +02:00
Daniel Lockyer
c1d2f250ce Updated translation files
- contains some changes produced by i18next-parser
2023-06-20 14:54:04 +02:00
Ronald Langeveld
bd348dc297
🎨 Improved copy on page & post revisions ()
no issue

Updates the labels of the post history components to reflect the type of
content (post or page).
It modifies the `restore-revision`, `gh-post-settings-menu`, and
`modal-post-history` components.
2023-06-20 14:52:51 +02:00
renovate[bot]
7f3cd9c674 Update dependency tough-cookie to v4.1.3 2023-06-20 12:45:13 +00:00
renovate[bot]
6623572c5b Update dependency socket.io to v4.6.2 2023-06-20 14:40:10 +02:00
Simon Backx
fd2ef61b3c 🎨 Improved copy on too many login attempts
fixes https://github.com/TryGhost/Team/issues/2391
2023-06-20 14:32:04 +02:00
Yovko Lambrev
49931d05e7
Updated Bulgarian translations ()
refs https://github.com/TryGhost/Team/issues/2795
2023-06-20 14:22:38 +02:00
renovate[bot]
d919a9024f Update dependency @extractus/oembed-extractor to v3.1.10 2023-06-20 12:18:09 +00:00
renovate[bot]
e81070762d Update dependency gscan to v4.37.0 2023-06-20 14:04:43 +02:00
Kasun Jayarathna
0241e28d1c
Updated Sinhalese translations ()
refs https://github.com/TryGhost/Team/issues/2795
2023-06-20 14:04:25 +02:00
Kasun Jayarathna
9be5d6a4b2
Updated Sinhalese translations ()
refs https://github.com/TryGhost/Team/issues/2795
2023-06-20 14:04:00 +02:00
Jono Mingard
384b468cbb Improved naming in AdminX dirty state handling
refs https://github.com/TryGhost/Team/issues/3349
2023-06-20 19:59:47 +10:00
Jono Mingard
5a6421c8bb Updated add navigation button to validate the new item
refs https://github.com/TryGhost/Team/issues/3433
2023-06-20 19:58:27 +10:00
Kasun Jayarathna
0b0c36a7fb
Updated Sinhalese translations ()
refs https://github.com/TryGhost/Team/issues/2795
2023-06-20 11:01:55 +02:00
Kasun Jayarathna
93f9e1dfce
Updated Sinhalese translations ()
refs https://github.com/TryGhost/Team/issues/2795
2023-06-20 10:57:09 +02:00
Duy
13fb5c2e31
Updated Vietnamese translations ()
refs https://github.com/TryGhost/Team/issues/2795
2023-06-20 09:31:01 +02:00
Daniel Lockyer
d4c5fe2f46
Merged v5.52.1 into main 2023-06-20 08:58:53 +02:00
Ghost CI
69fddf8abe v5.52.1 2023-06-20 06:54:10 +00:00
renovate[bot]
ea3ab6beb6 Update dependency @vitejs/plugin-react to v4.0.1 2023-06-20 08:09:23 +02:00
Jono Mingard
f084fbd025 Added dirty state navigation blocking to AdminX settings
refs https://github.com/TryGhost/Team/issues/3349
2023-06-20 12:58:44 +10:00
Jono Mingard
4fd0473f1b Updated URL editing to not automatically force everything to URLs
refs https://github.com/TryGhost/Team/issues/3433
2023-06-20 12:01:34 +10:00