TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-25 03:44:29 +03:00
Code Issues Projects Releases Wiki Activity
34,717 Commits 253 Branches 1,686 Tags 397 MiB
c3f6d77fd9
Commit Graph

34717 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jono Mingard
c3f6d77fd9 Added simple tests for design modal 
refs https://github.com/TryGhost/Team/issues/3354
 2023-06-12 11:04:19 +12:00
Jono Mingard
90c269275e Factored out useForm from useSettingGroup to be useful in more places 
refs https://github.com/TryGhost/Team/issues/3151
 2023-06-12 10:01:13 +12:00
Steve Larson
d1b5bf0a80 Updated koenig lexical dependencies 
no refs
 2023-06-09 12:22:01 -05:00
Steve Larson
88c3412cd4 Updated koenig lexical dependencies 
no refs
 2023-06-09 12:11:37 -05:00
renovate[bot]
ae3e38a14d Update dependency concurrently to v8.2.0 2023-06-09 17:39:51 +02:00
Ghost CI
2744d9a58b v5.51.0 2023-06-09 15:03:06 +00:00
Rishabh
eaf5aaade2 Updated site preview to handle theme settings 
refs https://github.com/TryGhost/Team/issues/3354

- wires theme settings to site preview frame, dynamically updating the preview when theme settings change
 2023-06-09 20:06:06 +05:30
Naz
f7e2f82089 Enabled collections permissions in controller 
refs https://github.com/TryGhost/Team/issues/3220

- With permissions in place in the database, they can be enabled on controller level.
 2023-06-09 21:13:06 +07:00
Naz
05bb82cf1a Added collections CRUD permissions 
refs https://github.com/TryGhost/Team/issues/3220

- Added permissions for collection resources
 2023-06-09 21:13:06 +07:00
Daniel Lockyer
abf45dcd14
Added note about requiring Node 18 to use yarn dev 
refs https://ghost.slack.com/archives/CSF1ATVTJ/p1686134251084789

- whilst Ghost supports Node 16, only Node 18 and above comes with
  `--watch`, which we use in the `yarn dev` script
 2023-06-09 15:11:59 +02:00
Simon Backx
2a263c1024 Updated Signup Form to v0.1 
no issue
 2023-06-09 14:32:17 +02:00
Simon Backx
c3abd3a021 Released Signup Form v0.1.0 2023-06-09 14:31:32 +02:00
Peter Zimon
2d3ab08724 Experimenting with sticky footers in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-09 14:29:39 +02:00
Peter Zimon
4e5523674c Updated twitter and FB settings tests in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-09 14:16:56 +02:00
Peter Zimon
33ea5486df Updated user detail modal buttons in AdminX 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-09 14:16:56 +02:00
Simon Backx
6d6da2492c Fixed showing errors when non 2XX response in signup form 
no issue
 2023-06-09 14:12:09 +02:00
Rishabh
c26f77586a Added dynamic site preview iframe 
refs https://github.com/TryGhost/Team/issues/3354

- adds dynamically loading iframe with site preview based on preview data in Admin
 2023-06-09 17:39:53 +05:30
Simon Backx
a4b24b1c7a Filled in signup form translation contexts 2023-06-09 13:54:23 +02:00
Simon Backx
08b37395cf Added translated placeholder in signup form embed 
no issue
 2023-06-09 13:48:43 +02:00
Simon Backx
381149e45b Added signup form button animation (minimal) 
no issue
 2023-06-09 12:07:57 +02:00
Sanne de Vries
afe18d54de Added email icon to signup form success page 
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#de29f9cc1a364a12a4a0eeebef68f3a4
 2023-06-09 11:35:36 +02:00
Simon Backx
5e7edb9da5 ✨ Added embeddable signup form 
refs https://github.com/TryGhost/Team/issues/3274

Co-authored-by: Sanne de Vries <sannedv@protonmail.com>
Co-authored-by: Ronald Langeveld <hi@ronaldlangeveld.com>
Co-authored-by: Jono Mingard <reason.koan@gmail.com>
Co-authored-by: Sag <guptazy@gmail.com>
 2023-06-09 11:30:03 +02:00
Peter Zimon
90b9959afc Set up showing images in brand settings (AdminX) 
refs. https://github.com/TryGhost/Team/issues/3354
 2023-06-09 11:26:56 +02:00
Simon Backx
ffa6c9c5f8 Added width:100% to minimal signup form CSS 
no issue

Otherwise the auto margin would cause issues in a grid or flex container.
 2023-06-09 11:08:14 +02:00
Simon Backx
66840cda0a Fixed minimal form padding 
no issue

Previous change made the viewport always maximum 440px, so it always triggered the `sm` breakpoint
 2023-06-09 11:06:50 +02:00
Sanne de Vries
6cdaf04fcd Updated NL translations for Portal and Signup Form 
No ref
 2023-06-09 10:53:22 +02:00
Simon Backx
12f7fd0153 Updated minimal signup form to be centered by default 
no issue

Added `margin: 0 auto;` css by default.
 2023-06-09 10:47:51 +02:00
Simon Backx
66ca072055 Moved maximum width and centering outside minimal signup form 
refs https://ghost.slack.com/archives/C04TMVA1D7A/p1686299301740999

- Easier to customize: easy to choose between centering and left alignment
- Fixes issue with centering error message
 2023-06-09 10:42:24 +02:00
Simon Backx
f4a822e7e0 Removed success page for minimal signup form 
no issue

Shows the success state in the button now.
 2023-06-09 10:26:05 +02:00
Naz
c507ea9600 Improved oversized batch correction logic 
refs 551532f874
refs https://github.com/TryGhost/Team/issues/3324

- After analyzing data dumps, the data revealed that we have extra data from a stray batch. The filtering logic manually filters out the data to the recipients that belong to a "current batch".
- Hunting down the root cause of the data mixup proved to be too expensive of an investigation, so this is a "good enough patch" to deal with the problem.
- Most likely cause is the concurrent batch sending, but reducing the concurrency would be too expensive of a performance price to pay instead of filtering the data rarely.
 2023-06-09 14:40:12 +07:00
Fabien "egg" O'Carroll
643fbbbb1f Removed collections from stable list in Admin API 
We had to add these so that they could be played with programatically
but now we have a god_mode flag, we can remove them.
 2023-06-09 09:31:44 +02:00
Fabien "egg" O'Carroll
29a403cc68 Supported a god_mode param in the Admin API 
This currently skips the not-implemented middleware and can be used to
access experimental endpoints whilst in development.
 2023-06-09 09:31:44 +02:00
Sanne de Vries
e74b38ac93
Updated color picker in signup form modal (#16971) 
Refs https://github.com/TryGhost/Team/issues/3407

---------

Co-authored-by: Simon Backx <simon@ghost.org>
 2023-06-09 08:55:35 +02:00
Sanne de Vries
1e7b332b7f Updated signup form embed settings copy 
No ref
 2023-06-09 08:26:21 +02:00
renovate[bot]
58f48d2e0a Update dependency @playwright/test to v1.35.0 2023-06-09 08:25:51 +02:00
Naz
efac36c36c
Removed data dump during email batching 
refs 551532f874
refs https://github.com/TryGhost/Team/issues/3324

- Having a data dumped in production was a one-off trick to allow us debug the error. Now that we have data it's no longer needed.
 2023-06-09 10:44:13 +07:00
Simon Backx
7e47bff92f Released Signup Form v0.0.3 2023-06-08 16:35:54 +02:00
Simon Backx
c5fbd8bae6 Added Plausible events when copying the signup form embed code 
fixes https://github.com/TryGhost/Team/issues/3389
 2023-06-08 15:51:32 +02:00
Sanne de Vries
9d93d21a2d Fixed signup form modal height 
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
- Previous commit broke the height as the negative margin should've only been applied horizontally
 2023-06-08 14:18:16 +02:00
Sanne de Vries
7a74563e21 Fixed scrollbar position in signup form modal 
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#325a9bc8979a4be9bf436c3f619d8e53
 2023-06-08 14:06:31 +02:00
Simon Backx
5949d6a8d4 🐛 Fixed closing modals in admin UI when releasing mouse outside modal 
no issue

When selecting text, and releasing your mouse outside the modal, the modal would close.
 2023-06-08 13:50:44 +02:00
Simon Backx
5658f4b627 Fixed admin failing tests 
no issue

renderInPlace broke tests because expected dropdown changed place in the DOM
 2023-06-08 13:38:13 +02:00
Zabriskije
f3b60e6c6f
Updated Italian translations (#16966) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-08 13:33:18 +02:00
Markus Härnvi
bd679e0a81
Updated Swedish translations (#16964) 
refs https://github.com/TryGhost/Team/issues/2795
 2023-06-08 13:32:11 +02:00
Simon Backx
a68ac4b688 Renamed data-logo to data-icon in signup embed attributes 
fixes https://github.com/TryGhost/Team/issues/3401
 2023-06-08 13:23:38 +02:00
Simon Backx
a1e632abe0 Removed page color in signup form Storybook preview component 
no issue

The Storybook did set the color, but that shouldn't be set because normally the components are always rendered in an iframe, with a default black, unchangeable color.
 2023-06-08 13:17:54 +02:00
Simon Backx
887f7385e1 Fixed label picker overflow hidde in modal in signup form modal 
no issue
 2023-06-08 13:17:54 +02:00
Sanne de Vries
a8b9be38f8 Added max width to success message in signup form 
Refs https://www.notion.so/ghost/Embed-testing-0193905e46d449b5ad865f7364176814?pvs=4#419cf40167784a5c85bd38ea3a2006ed
 2023-06-08 13:13:32 +02:00
Sanne de Vries
5346fb430c Updated loading state for embeddable signup form 
Closes https://github.com/TryGhost/Team/issues/3390
 2023-06-08 12:28:45 +02:00
Simon Backx
0b6cae09e9 Fixed Storybook missing context 
no issue

Storybook didn't have access to the `t` method needed for translations. This change adds a Storybook decorator to all stories.
 2023-06-08 11:20:16 +02:00