1
0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-27 04:43:12 +03:00
Commit Graph

29905 Commits

Author SHA1 Message Date
Kevin Ansfield
c77c150745 Refactored facebook/twitter URL inputs
refs https://github.com/TryGhost/Ghost/issues/14101

Twitter/facebook URL validation doesn't follow our typical validation and was duplicated across multiple screens making the controllers unnecessarily complex.

- extracted url input fields and their validation into separate components
- uses tracked scratch values so that the input field values can reset to the saved value on save
  - twitter/facebook URL inputs are different to our other inputs because invalid values won't prevent saving, instead they are reset to their previous value on save
- added `this.validate()` call after a successful save in `settings` service so the service and underlying model validations are both in sync (fixes validation error sticking around after saving with invalid twitter/facebook values that have been reset)
2022-10-04 17:55:24 +01:00
John O'Nolan
5106643871
Updated readme download count 2022-10-04 10:26:33 -05:00
Djordje Vlaisavljevic
b15451dfa6 Deemphasized unavailable sources and added an explainer
refs https://github.com/TryGhost/Team/issues/1986
2022-10-04 13:29:25 +02:00
Kevin Ansfield
d8193da005 Revert "Fixed errors thrown from blank twitter/facebook URL fields"
This reverts commit a523fedccb.

- caused input value to be cleared on focus+blur with no changes
- reverting in favor of an incoming refactor
2022-10-04 10:30:13 +01:00
Kevin Ansfield
a523fedccb Fixed errors thrown from blank twitter/facebook URL fields
no issue

- reset logic was incorrect meaning that if you focused a twitter/facebook URL field then moved to a different field without inputting anything an error would be thrown from trying to use `.match()` on `null`
2022-10-04 10:09:36 +01:00
Sanne de Vries
0124c2f28a Updated member activity page with new breadcrumb styles
Refs https://www.notion.so/ghost/Switch-breadcrumb-style-513a624c0e0d490ca39a2fdb97a6971a

- Filtering on specific member activity now uses new breadcrumb pattern
- Fixed double scrollbar issue on member activity and history page
2022-10-04 13:51:01 +07:00
Sanne de Vries
2c498ab193 Updated breadcrumb and title style across admin
Refs https://www.notion.so/ghost/Switch-breadcrumb-style-513a624c0e0d490ca39a2fdb97a6971a

- Separating out the breadcrumbs and the title makes it easier to navigate back on multiple levels for nested pages.
- Avoids very long titles, as it doesn't include breadcrumbs anymore
2022-10-04 12:35:29 +07:00
Rishabh
09fbe19a31 Fixed anchor chart load for site without paid tiers
refs https://github.com/TryGhost/Team/issues/2019

- the anchor chart keeps showing the loading spinner for a site that has no paid tiers and the source attribution flag switched on.
- this was because it tries to load the the MRR chart by default, which doesn't has any data when paid tiers are disabled.
- updated the chart to use `total members` data when paid tiers is disabled
2022-10-04 10:34:44 +05:30
Ronald Langeveld
226794e201
🐛 Fixed broken close buttons on modals ()
* 🐛 Fixed broken `close` button on modals
no issue

Some modals' close elements containing `{{on "click" @close}}` and `href=""` would not take the 'on cl
ick' function into account, meaning the whole page would get redirected to "/" (back to the root of the dashboard) instead of just closing the modal.
2022-10-04 06:33:49 +04:00
renovate[bot]
8751245fa5 Update sentry-javascript monorepo to v7.14.1 2022-10-04 08:07:37 +07:00
Kevin Ansfield
cd9a50841e Fixed tests
refs 85cce39af7

- removed out of date transfer owner modal integration test
- fixed missing `?` in optional chaining in `<GhImageUploader>` error handling
2022-10-03 22:05:02 +01:00
Kevin Ansfield
bdc5984cdc Fixed linter error
refs 85cce39af7
2022-10-03 21:20:37 +01:00
Kevin Ansfield
85cce39af7 Refactored staff user modals
refs https://github.com/TryGhost/Team/issues/1734
refs https://github.com/TryGhost/Team/issues/559
refs https://github.com/TryGhost/Ghost/issues/14101

- switches to newer modal patterns ready for later Ember upgrades
- cleaned up the `upload-image` modal which had multiple areas of code that were no longer being used
- disabled `no-duplicate-landmark-elements` template lint rule as it's buggy and mostly gives false positives
2022-10-03 21:15:34 +01:00
Kevin Ansfield
74d66ca9be Renamed incorrect test selectors on limit modals
no issue

- selectors hadn't been updated when copy/pasting modal contents
2022-10-03 21:15:34 +01:00
Stephen Sauceda
eb585f9c02
🐛 Fixed active state bug in sidebar nav ()
closes: https://github.com/TryGhost/Ghost/issues/15506

- The sidebar items that don't open the editor were missing some relative current-when attributes so the nested views weren't considered "active".
2022-10-03 19:49:21 +01:00
Djordje Vlaisavljevic
02369ee852 Switched the dash character
refs https://github.com/TryGhost/Team/issues/1986
2022-10-03 17:29:07 +02:00
Fabien 'egg' O'Carroll
35bc5fa08a
Fixed no-shadow lint warnings ()
We're planning to change this from a warning to an error and need to
clean the codebase up before we do so.

In all of these cases the shadowing was known about and was not
causing unexpected behaviour, so the refactor consists entirely of
renaming, rather than refactoring/bug fixes.
2022-10-03 15:50:28 +01:00
Kevin Ansfield
353cad7ed2 Fixed mirage members route permissions checks
refs 568e4183e3
refs 258f56ded9

- when in test environment add a `X-Test-User` header to API requests that allows the mirage endpoints to check the logged in user without having to cross boundaries into the application or test contexts
2022-10-03 14:59:16 +01:00
Rishabh
01249926d5 Refined attribution data on member details page
refs https://github.com/TryGhost/Team/issues/1986

- hides referrer source on member details page if its `Created manually` as its not useful
2022-10-03 18:58:48 +05:30
Djordje Vlaisavljevic
c48df76d9b Updated formatting of the signup info
refs https://github.com/TryGhost/Team/issues/1986
2022-10-03 14:25:32 +02:00
Djordje Vlaisavljevic
f351064726 Commented out the Learn more link
refs https://github.com/TryGhost/Team/issues/1986
2022-10-03 14:20:03 +02:00
Kevin Ansfield
568e4183e3 Disabled mirage member routes permission checks
refs 258f56ded9

- `@ember/test-helpers` is not included outside of test builds but we load mirage in development too so this was causing import errors that completely broke the app in development
- commented out the checks for now to get development working again whilst we look for alternatives to `getContext()`
2022-10-03 13:13:37 +01:00
Hannah Wolfe
04621b1e2e
Fixed ESLint no-shadow warnings in members-api
- I want to upgrade no-shadow to an error, but to do this I need to resolve the outstanding warnings
- This is not all the warnings, just the ones that were easy to fix
2022-10-03 12:08:55 +01:00
Kevin Ansfield
258f56ded9
Added regression test for publishing as editor when over member limit ()
closes https://github.com/TryGhost/Team/issues/2010
refs a67cb265fc

- wrapped all members endpoints in a permission check that returns a 403 response if the logged in member is not an admin
- added a publish-flow acceptance test that goes through the flow as an Editor user that fails if the stats endpoint is hit and throws a permissions error
- removed some unnecessary waits in members acceptance test that were added for earlier versions of Ember
2022-10-03 12:05:58 +01:00
Kevin Ansfield
485b793ee3 Deleted test for component that doesn't exist
no issue

- looks like the test file was left over from development
2022-10-03 11:26:00 +01:00
Djordje Vlaisavljevic
7fea370faf Fixed all sources modal gradient in dark mode
refs https://github.com/TryGhost/Team/issues/1986
2022-10-03 12:24:54 +02:00
Djordje Vlaisavljevic
ee40c92758 Updated cursor for disabled dropdown
refs https://github.com/TryGhost/Team/issues/1986
2022-10-03 11:42:50 +02:00
Rishabh
e57502e02f Handled empty attribution section on member detail page
refs https://github.com/TryGhost/Team/issues/1986

- hides attribution section if there is no source and page/post attribution
2022-10-03 14:58:14 +05:30
Rishabh
6dc5f7ebb0 Added empty state mock option for attribution data
- allows mimicking empty state on dashboard for attribution data
2022-10-03 14:56:37 +05:30
Daniel Lockyer
44f6840a26
Merged v5.17.1 into main
v5.17.1
2022-10-03 15:42:30 +07:00
Ghost CI
f1dad0519c v5.17.1 2022-10-03 09:41:39 +01:00
Fabien 'egg' O'Carroll
1613470a8c
Used the higher of click count and open count for email open count ()
fixes https://github.com/TryGhost/Team/issues/2017

We process clicks much faster than we process Mailgun events which can result in a higher click rater than open rate shown on the dashboard. This ensures that the open rate will never be lower than the click rate. This is a stopgap solution until we can get click events updating the opened_at time for email_recipients
2022-10-03 10:29:58 +02:00
Simon Backx
b80c2cd81b 🐛 Fixed broken activity feed and click filter
fixes https://github.com/TryGhost/Ghost/issues/15515

- The link relation of a member-click-event was still using the link_id as foreign key instead of redirect_id.
- The members_link_click_events table was renamed to members_click_events, but this change was not reflected in a recent change in the member model (which has the custom filters).
2022-10-03 09:52:24 +02:00
renovate[bot]
5140f8a887 Update dependency sqlite3 to v5.1.2 2022-10-03 14:21:24 +07:00
Peter Zimon
349ef4926c Update engagement copy in Post Analytics
closes https://github.com/TryGhost/Team/issues/2016

- the absolute value and percentage for Opened and Clicked metrics in the engagement section of the post analytics page were inconsistent
2022-10-03 08:42:19 +02:00
renovate[bot]
cf5dbb6981 Lock file maintenance 2022-10-03 08:30:32 +07:00
renovate[bot]
828ad5915d Update dependency postcss to v8.4.17 2022-10-03 07:38:42 +07:00
Hannah Wolfe
0b41fbf102
Updated hiring links
- Ghost is still hiring, but we've split our product engineer into two and the URL has changed
2022-09-30 19:56:26 +01:00
Ghost CI
a7556ad9ea v5.17.0 2022-09-30 16:00:36 +01:00
Rishabh
30efab8401 Fixed lint 2022-09-30 09:38:15 +05:30
Fabien 'egg' O'Carroll
45d65663f4
Simplified link tracking related tables naming ()
- Removes superfluous "link" from table names
- Fixes type definititon of dropTables util
- Updates & renames models
- Noop existing migrations to avoid unnecessary work
2022-09-29 22:08:45 +01:00
Rishabh
579ca615f9 Refined member attribution wording 2022-09-30 01:27:26 +05:30
Djordje Vlaisavljevic
198e43daec Updated disabled state
refs https://github.com/TryGhost/Team/issues/1986
2022-09-29 20:49:53 +02:00
Djordje Vlaisavljevic
fb2f0b3d3b Updated the all sources modal grid
refs https://github.com/TryGhost/Team/issues/1986
2022-09-29 20:33:00 +02:00
Rishabh
fa2292806a Refined all sources list on dashboard
refs https://github.com/orgs/TryGhost/projects/77

- shows single selected column on the all referrer sources list in dashboard
2022-09-29 23:47:43 +05:30
Rishabh
5eae093b3c Cleaned up attribution widget on analytics page
- updates attribution widget on analytics page to work same as dashboard with data
2022-09-29 23:33:17 +05:30
Djordje Vlaisavljevic
40c66dae6a Made the attribution widget show if you don't have paid tiers
refs https://github.com/TryGhost/Team/issues/1986
2022-09-29 19:37:09 +02:00
Rishabh Garg
e3600d70ef
Added referrer attribution from request context ()
closes 

- uses request context to add referrer source and medium for a new member
- uses integration name as referrer medium if exists
2022-09-29 22:31:48 +05:30
James Morris
8a6f082b14 Moving opened stats in row over if there are no clickes in post rows
- When there are no clicks, we are moving over the opened stats in it's place
- There shouldn't be too many times these mix so design should be ok

refs https://github.com/TryGhost/Team/issues/2000
2022-09-29 18:01:01 +01:00
James Morris
fd977479ee Tweaked up the analytics resources sections
refs https://github.com/TryGhost/Team/issues/1987
2022-09-29 17:38:50 +01:00