Commit Graph

31903 Commits

Author SHA1 Message Date
Fabien "egg" O'Carroll
dd256f3517 Fixed lint for @tryghost/email-suppression-list 2022-11-18 15:06:56 +07:00
Fabien "egg" O'Carroll
9add72ebb1 Fixed tests for @tryghost/email-suppression-list
These were missing and caused the build to fail
2022-11-18 14:59:06 +07:00
Fabien "egg" O'Carroll
cbe1573fd5 Added email-suppression-list service & mock implementation
refs https://github.com/TryGhost/Team/issues/2267

This will eventually be replaced by a Mailgun specific implementation,
but for now we're using mock one which responds with fake data for
local development.
2022-11-18 14:11:47 +07:00
Fabien "egg" O'Carroll
22fe3ec88b Added @tryghost/email-suppression-list package
refs https://github.com/TryGhost/Team/issues/2267

This package contains definitions for the public interface of the
email suppression list as well as an abstract implementation.
2022-11-18 14:06:11 +07:00
renovate[bot]
426c515f83
Update dependency ember-template-lint to v4.18.2 2022-11-18 01:29:10 +00:00
renovate[bot]
313c1788d9
Update dependency mailgun.js to v8.0.6 2022-11-17 22:31:28 +00:00
Hannah Wolfe
dfffa309a8
Improved member importer error handling (#15843)
refs: https://github.com/TryGhost/Team/issues/1121

- This makes several key changes to the way errors are handled in the member importer, to ensure that we only show error messages to users that we wrote.
- Fundamentally, we no longer trust all API errors, and instead only trust a set of very specific API errors. Anything outside of that is replaced with a generic error message.
- Also switches the server-side error generated for email verification (which can throw during member import) to be a HostLimitError, as that is a more appropriate class.
- Note: there are many other parts of Ghost admin that need a similar overhaul, and a similar change we need to introduce server side to fully resolve the underlying issue of bubbling up code errors to the UI.
2022-11-17 19:41:39 +00:00
Peter Zimon
5bb2b2c614 Added modal-import-content to lint todo 2022-11-17 18:15:17 +01:00
Peter Zimon
75fea80de6 Fixed screen flicker in content import modal
no refs.

- the "Uploading" step on the content import modal was empty which resulted in a quick flicker during upload.
2022-11-17 18:11:11 +01:00
Sam Lord
49605a9559 Enabled browser-based tests to start Ghost with default test fixtures
refs: https://github.com/TryGhost/Toolbox/issues/479
2022-11-17 17:00:54 +00:00
Sam Lord
bbbef3555f Fixed lint-todo file after rebase
no issue
2022-11-17 14:40:24 +00:00
Sam Lord
904fc55648 Fixed lint issue in email-template for content importer 2022-11-17 14:40:24 +00:00
Rishabh
26aa19c36a Added import modal lint errors to todo 2022-11-17 14:40:24 +00:00
Rishabh
3c5b523a43 Revert "Updated ember action usage"
This reverts commit 31b4d34b90.
2022-11-17 14:40:24 +00:00
Rishabh
9dea8f13d8 Updated ember action usage 2022-11-17 14:40:24 +00:00
Sam Lord
881f0b33be Fixed lint issues
no issue
2022-11-17 14:40:24 +00:00
Peter Zimon
0b8a01814b Fixed condition in result email 2022-11-17 14:40:24 +00:00
Peter Zimon
4068d8c65c Fixed content importer UI logic and email
- `result` parameter was wrongly passed to email
- email subject condition was reversed
- udpated email copy (still WIP)
- removed console.log from admin file selector
2022-11-17 14:40:24 +00:00
Sam Lord
4fb05ab165 Prevent warnings from being displayed in email after content import
no issue

Warnings that aren't useful shouldn't be displayed, especially when this is likely someone's first experience of Ghost.
2022-11-17 14:40:24 +00:00
Sam Lord
6a17b684ec Fixed uploading zip files in import job
no issue
Zip files involved a call to `await`, which caused the microtask queue to be processed. The zip file is deleted during this time because the request has already completed.
2022-11-17 14:40:24 +00:00
Peter Zimon
d0c2af7a15 Fixed API params 2022-11-17 14:40:24 +00:00
Peter Zimon
739efa5a36 Fixed file upload bug 2022-11-17 14:40:24 +00:00
Peter Zimon
3eaa00bddb Restructured modal open logic
no refs.

- Navigating to `/settings/labs/import` opened the modal but also transitioned to a blank page in the background. Restructured content import modal so it's opening on top of the Labs page.
2022-11-17 14:40:24 +00:00
Sam Lord
9e54128a39 Reverted unrelated changes in test file
no issue
2022-11-17 14:40:24 +00:00
Sam Lord
5619348c26 Replaced "Open Importer" button with one that works
no issue
2022-11-17 14:40:24 +00:00
Sam Lord
d5f8a2b59d WIP importer modal
no issue
2022-11-17 14:40:24 +00:00
Sam Lord
fc291240d5 Updated importer test to use new object return format
no issue
2022-11-17 14:40:24 +00:00
Sam Lord
56a6b5702a Made content import run inline by default in test environment
refs: https://github.com/TryGhost/Toolbox/issues/431
2022-11-17 14:40:24 +00:00
Sam Lord
3e13918e57 Made content import API return semantic HTTP codes
no issue
2022-11-17 14:40:24 +00:00
Sam Lord
5309660986 Improved content import email
no issue
2022-11-17 14:40:24 +00:00
Sam Lord
ee6415ebd1 Remove bluebird from data-importer.js
no issue

Missed from previous commit
2022-11-17 14:40:24 +00:00
Sam Lord
7c6854651d Added tag to posts when importing content
refs: https://github.com/TryGhost/Toolbox/issues/431
2022-11-17 14:40:24 +00:00
Sam Lord
8ed5f9784d Added a job for content imports
refs: https://github.com/TryGhost/Toolbox/issues/431
2022-11-17 14:40:24 +00:00
Simon Backx
9c12a2a043
Limited Stripe price lookups (#15823)
refs https://github.com/TryGhost/Team/issues/2262

Makes sure we only loop active Stripe prices. If we find an inactive
price, we also update it in our database now after this change.
2022-11-17 14:33:46 +01:00
Simon Backx
69228b2947
🐛 Fixed race condition when sending email (#15829)
refs https://github.com/TryGhost/Team/issues/2246

- This change helps avoid race conditions due to a lack of a transaction
in the email job. It also moves the status check before creating the
email batches (can take a while) to prevent other timing issues in case
the job got scheduled multiple times.
- Sets the patch option to true when changing the status of an email
batch. If we don't do this, the bookshelf-relations plugin might try to
save relations too. This could have caused a 'no rows updated' error.
- Added a test that tests if the email job can only run once
- Added logging to batching logic
2022-11-17 13:36:52 +01:00
Paul Davis
0452d35360
Removed Ghost(Valet) from readme (#15840)
- Ghost(Valet) has been unavailable for some time so linking to it here is redundant. 
- There are other resources available for those who need a handsetting up a self-hosted Ghost site.
2022-11-17 11:46:33 +00:00
Rishabh
ee55892c74 Updated portal tests
refs dc032fac02
2022-11-17 13:16:12 +05:30
Rishabh
8bce7697f1 Fixed UI flash on portal for paid checkout
closes https://github.com/TryGhost/Team/issues/2274

When clicking on a tier, just before being redirected to the Stripe checkout, a Portal modal incorrectly showed the "Now check your email" message. Instead, this now shows a loading popup as expected while the checkout session is being created and redirected to on latest portal version
2022-11-17 12:46:49 +05:30
Rishabh
97f358c389 Released Portal v2.20.0 2022-11-17 12:28:48 +05:30
Rishabh
dc032fac02 Fixed incorrectly showing magic link page on paid checkout
closes https://github.com/TryGhost/Team/issues/2274

When clicking on a tier, just before being redirected to the Stripe checkout, a Portal modal incorrectly showed the "Now check your email" message. Instead, this now shows a loading popup as expected while the checkout session is being created and redirected to.
2022-11-17 12:20:57 +05:30
Daniel Lockyer
6a3ea02fed Enabled codecov coverage uploading for E2E tests
refs https://github.com/TryGhost/Toolbox/issues/475

- this enables uploading to codecov for the E2E tests, and separates the
  unit + E2E test results with flags
2022-11-17 12:44:54 +07:00
Naz
3e0ec26408
Introduced separate config for e2e tests
refs https://github.com/TryGhost/Toolbox/issues/475

- Having a single coverage config file for unit and e2e type of tests doesn't play well for tracking coverage progress. The unit test ones are run often when developing, so one can observe the changes in coverage. The e2e tests are ran mostly on CI environment and have different purposes/reach comparing to unit tests.
2022-11-17 09:58:39 +07:00
Naz
a1b5830269
Updated minimum coverage percentages
refs https://github.com/TryGhost/Toolbox/issues/475

- Increased statements and lines minimum required numbers as we have increased out baseline and should keep the bar as hight as possible
2022-11-17 09:58:39 +07:00
Naz
b7951b5445
Enabled test coverage report for e2e tests
closes https://github.com/TryGhost/Toolbox/issues/475

- We did not have visibility and history into test coverage statistics in non-unit test suites. This data is useful identifying problematic areas and can be used to keep the code quality under control
- Enabled test coverage for e2e tests, including integration and regression tests
- Decreased the "branches" coverage requirement for the tests to pass (did not want to introduce an additional c8 configuration file just yet)
2022-11-17 09:58:39 +07:00
renovate[bot]
174525bc52
Update dependency mailgun.js to v8.0.4 2022-11-16 17:46:29 +00:00
Ronald Langeveld
e0787b4e83
Added specific newsletter support for bulk unsubscribes (#15742)
closes https://github.com/TryGhost/Team/issues/2013

Added support to bulk unsubscribe a selected (filtered) list on members from specific, selected newsletters.
2022-11-16 14:29:00 +07:00
Naz
548a3c7b93
Fixed typo 2022-11-16 13:00:06 +07:00
Sodbileg Gansukh
78bff39c23
Update the cover image in default fixtures (#15817)
- updated the cover image to be simpler
- made the change in text fixtures as well, just to keep the fixtures in sync

Co-authored-by: Hannah Wolfe <github.erisds@gmail.com>
2022-11-15 21:19:50 +00:00
Jacob Simon
64f71a9cb4
Updated amp-youtube placeholder image position (#15833)
refs: ced1fdbdd4

- This is a follow-up to #15826 that I forgot to include in the first commit. Fixes an issue where the placeholder image would offset the youtube iframe embed on initial load.
2022-11-15 19:07:52 +00:00
renovate[bot]
72b57db2e8
Update dependency ember-template-lint to v4.18.1 2022-11-15 14:11:52 +00:00