Commit Graph

9081 Commits

Author SHA1 Message Date
Simon Backx
e6e28a6aa8 Added multiple-newsletters branch to CI trigger 2022-04-21 10:53:50 +01:00
Kevin Ansfield
b152c1ded7 Fixed linter warning
no issue

- updated `.lint-todo` to fix linter complaining about an already-fixed error
2022-04-21 07:18:06 +01:00
Kevin Ansfield
8ca2c6935a Added static mockup of basic publish flow
refs https://github.com/TryGhost/Team/issues/1542

- adds `<EditorLabs::PublishManagement>` component that displays the relevant button for triggering publishing flows and will eventually store publish options for the editing session duration and manage the saving flow
  - displays a "Publish" button that triggers the publish flow modal
- adds `editor-labs/publish-flow` full-screen modal containing a static mockup of the desired sentence-structure publish options design
2022-04-20 18:41:29 +01:00
Kevin Ansfield
f5fef46856 Added publishingFlow labs flag toggle
refs 05da593516

- used for switching between old publish menu and new publishing flow
2022-04-20 16:48:54 +01:00
Kevin Ansfield
c94b80dd4b Added showHeaderName newsletter attr for controlling newsletter title/subtitle
refs https://github.com/TryGhost/Team/issues/1532

- added `showHeaderName` attribute to newsletter model
- added attribute toggle to the newsletter design settings form
- updated newsletter preview behaviour
  - if both title and name are on, show name as a subtitle
  - if title is off but name is on, show name as main title
  - adjusted higher-level "show header" and "show header title" conditionals to account for the new setting
2022-04-20 16:05:10 +01:00
Simon Backx
46fd0e4a27 Added open rate and charts to recent posts
refs https://github.com/TryGhost/Team/issues/1535

Also made some temporary changes in CSS to get the percentage bar in.
2022-04-20 15:31:12 +02:00
Kevin Ansfield
da1621d818 Fixed newsletter header image not showing in design form
closes https://github.com/TryGhost/Team/issues/1541

- copy/pasta from migrating old email design settings to newsletter design form
2022-04-20 14:09:30 +01:00
Simon Backx
a1b9ec830a Moved comped members into paid members counts
no issue

In dashboard 5.0, comped members should be included in paid members and are not considered free members.
2022-04-20 14:45:34 +02:00
James Morris
a06003e7b5 Introduced new layout to bring new Dashboard closer to release (#2342)
refs: https://github.com/TryGhost/Team/issues/1531

- broke apart the combined chart
- added back in the paid mix chart
- separated out the mini charts into separate components
- made top chart work with total, paid and free
- added in an overview section back at the top for total, paid, free
- made metric labels and values larger and easier to parse

Co-authored-by: Simon Backx <simon@ghost.org>
2022-04-20 14:43:11 +02:00
Kevin Ansfield
79eea318a9 Updated existing subscriber count in newsletter create confirmation
refs 50c762e222

- the count should only include members that are subscribed to active newsletters
  - the filter change was accidentally included in a previous commit (50c762e222)
- removed the unnecessary `{{concat}}` usage
2022-04-20 13:20:03 +01:00
Kevin Ansfield
50c762e222 Added confirmation dialog when unarchiving a newsletter
closes https://github.com/TryGhost/Team/issues/1540
refs 58290a6134

- follows same pattern as archiving
2022-04-20 13:15:45 +01:00
Kevin Ansfield
e7ddf8aaef Fixed create newsletter confirmation showing when editing existing newsletter
closes https://github.com/TryGhost/Team/issues/1537

- added conditional around the create confirmation modal display so it's only shown when attempting to save a new newsletter record
2022-04-20 12:52:20 +01:00
Kevin Ansfield
58290a6134 Added confirmation dialog when archiving newsletter
closes https://github.com/TryGhost/Team/issues/1530

- added confirmation modal that uses passed in archive task when confirming to provide feedback on progress
- switched archive link from immediately triggering the archive task to an action that launches the confirm modal
2022-04-20 11:08:57 +01:00
Sanne de Vries
1c34e41ea3 Fixed horizontal position of dropdown menus in newsletter settings
Refs https://github.com/TryGhost/Team/issues/1525
2022-04-20 11:06:05 +01:00
Kevin Ansfield
b349317a9d Fixed interfering actions menus in newsletter management
no issue

When multiple newsletters existed, the actions dropdown menus were all rendered on top of each other but hidden with CSS. This resulted in clicks that you expected to open an actions menu immediately triggering actions on a newsletter higher up in the list.

- switched from `<GhDropdown>` to `<GhBasicDropdown>` which adds/removes the dropdown content elements rather than rendering everything and hiding with CSS
- updated styling to match previous implementation
- added `.anim-fade-in-scale` classes for use with `{{css-transition}}` so we can keep the open/close animation
  - `ember-basic-dropdown` does have support for transitioning in/out CSS classes but they are only triggered on the first open/close for each menu which resulted in oddly inconsistent behaviour with multiple menus in a list
  - close animation doesn't actually work because the outer elements are removed by `ember-basic-dropdown` preventing `css-transitions` from performing it's animation
2022-04-20 10:50:11 +01:00
Sanne de Vries
029cfca415 Added section headings to newsletter modal
Refs https://github.com/TryGhost/Team/issues/1525
2022-04-20 10:40:58 +01:00
Sanne de Vries
64bd016950 Updated edit newsletter modal
Refs https://github.com/TryGhost/Team/issues/1525
2022-04-20 09:34:29 +01:00
Sanne de Vries
b61f45d544 Updated newsletter settings copy
Refs https://github.com/TryGhost/Team/issues/1525
2022-04-20 09:14:17 +01:00
Kevin Ansfield
baf75c39cf Added auto-subscribe newsletter count when confirming newsletter creation
refs https://github.com/TryGhost/Team/issues/1528

- used the already-loaded newsletters list to pass the slugs of active newsletters to the confirm modal, this allows use of the `{{members-count-fetcher}}` resource with the query `/members/?filter=newsletters:[...slugs]` to fetch a member and full count metadata
- added inclusion of `{{join}}` helper from `ember-composable-helpers` addon
2022-04-19 21:56:13 +01:00
Kevin Ansfield
f6c9ffcf60 Fixed conflicting test selector in <GhTaskButton>
refs 8e120a74d6

- we use `data-test-state` inside of some modals which also use `<GhTaskButton>` which caused unrelated tests to start failing due to a change in matching element counts
2022-04-19 20:42:47 +01:00
Kevin Ansfield
8e120a74d6 Fixed <GhTaskButton> behaviour
refs 502fcaba3c

- the conditional for `isFailure` was wrong meaning we were showing the idle state unintentionally
- fixed the conditional so it checks for the return value rather than a `null` error
- updated the template with test selectors so it's easier to determine state where class names are not sufficient to differentiate
2022-04-19 20:25:27 +01:00
Kevin Ansfield
502fcaba3c Added "Opt-in existing subscribers" option to newsletter creation
refs https://github.com/TryGhost/Team/issues/1528

- adds "opt-in existing" toggle to newsletter modal that's only shown when creating a newsletter
  - defaults to true
- updated newsletter save flow to show confirmation before creation
  - alters message to reflect auto-subscribe selection
  - count of existing subscribed members is not implemented as it's not yet supported by the API
- updated newsletter adapter and save flow to use auto opt-in selection
  - when option is checked the save URL is changed to `POST /members/?opt_in_existing=true`
- modified task button component to ignore a task return value of `canceled` so when it's received the buttons returns to the idle state instead of showing a saved or failed state
  - used by save routine when the "Back to edit" button is clicked in the create confirmation modal
2022-04-19 20:01:08 +01:00
Kevin Ansfield
5437063d4b Fixed newsletter subscription toggles on member details screen
no issue

- member records are not re-fetched when navigating from the members list to the member details screen, instead the already loaded member object is passed through to the route directly to provide a faster navigation experience
- however, the objects used in the member list are proxy objects in order to support the lazy-loading infinite scroll. Proxy objects require the use of `get()` so errors were thrown when the newsletter subscription toggles were used
2022-04-19 19:34:59 +01:00
Kevin Ansfield
86a69ece65 Updated newsletter email verification endpoint
refs https://github.com/TryGhost/Ghost/pull/14491

- API endpoint used when completing verification of a newsletter email change has moved to `PUT /newsletters/verifications/` to follow our API patterns
2022-04-19 19:34:59 +01:00
Djordje Vlaisavljevic
0ca9f32d36 Updated design for newsletter preferences
refs https://github.com/TryGhost/Team/issues/1492
2022-04-19 17:04:22 +02:00
Daniel Lockyer
6341b00389 Dropped support for Node 12
refs https://github.com/TryGhost/Toolbox/issues/267

- Node 12 is EOL as of April 30th so we're going to be dropping support
  for it in Ghost too
- the only change in Admin is to update the Node engines range
2022-04-19 15:51:02 +01:00
Sanne de Vries
09467a0bb7 Updated newsletter modal
Refs https://github.com/TryGhost/Team/issues/1525
2022-04-19 12:31:16 +01:00
Sanne de Vries
9271fa581b Updated newsletter modal sidebar layout
https://github.com/TryGhost/Team/issues/1525
2022-04-18 17:10:11 +01:00
Sanne de Vries
ef1411ae29 Fixed archived description in Email newsletter settings
Refs https://github.com/TryGhost/Team/issues/1525
2022-04-18 11:11:51 +01:00
Sanne de Vries
55752d44b7 Added active and archived newsletter descriptions
Refs https://github.com/TryGhost/Team/issues/1525
2022-04-18 10:57:23 +01:00
renovate[bot]
788339124b Update dependency @tryghost/helpers to v1.1.64 (#2340)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 10:28:13 +01:00
renovate[bot]
e37e7b5bdb Update dependency glob to v8 (#2333)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 10:28:01 +01:00
renovate[bot]
c8a26aad68 Update dependency @ember/test-helpers to v2.7.0 (#2326)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 10:27:45 +01:00
renovate[bot]
9959e4301e Update dependency @tryghost/nql-lang to v0.3.1 (#2325)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 10:27:23 +01:00
renovate[bot]
d7d1197a04 Update dependency @tryghost/kg-parser-plugins to v2.11.6 (#2321)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 10:27:11 +01:00
renovate[bot]
31616e9fd8 Update dependency @tryghost/timezone-data to v0.2.63 (#2341)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 09:50:29 +01:00
renovate[bot]
a706800df2 Update dependency @tryghost/color-utils to v0.1.13 (#2339)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 09:49:51 +01:00
renovate[bot]
36d10183c7 Update dependency fs-extra to v10.1.0 (#2338)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 09:49:17 +01:00
renovate[bot]
4c1eb871dc Update dependency ember-simple-auth to v4.2.2 (#2334)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 09:48:50 +01:00
renovate[bot]
2d18c5cdcb Update dependency @tryghost/nql to v0.9.1 (#2324)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 09:48:02 +01:00
renovate[bot]
a4d3d74730 Update dependency @tryghost/kg-clean-basic-html to v2.2.10 (#2320)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 09:47:30 +01:00
renovate[bot]
8c270b2826 Update dependency grunt to v1.5.2 (#2331)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 09:47:16 +01:00
renovate[bot]
02002c08bb Update dependency ember-cli-dependency-checker to v3.3.1 (#2330)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 09:46:54 +01:00
renovate[bot]
59a484638d Update dependency @glimmer/component to v1.1.2 (#2322)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 09:27:00 +01:00
renovate[bot]
0bc75f7030 Update dependency @tryghost/timezone-data to v0.2.62 (#2316)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 09:21:35 +01:00
renovate[bot]
5f811d5ef2 Update dependency @tryghost/helpers to v1.1.63 (#2315)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 09:21:25 +01:00
renovate[bot]
c28ad8d068 Update dependency @tryghost/members-csv to v1.2.10 (#2314)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 09:21:16 +01:00
renovate[bot]
b5e0e0f708 Update dependency @babel/plugin-proposal-decorators to v7.17.9 (#2310)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-04-18 09:21:02 +01:00
Daniel Lockyer
7b527f6e37 v4.44.0 2022-04-15 16:00:39 +01:00
James Morris
685fa19d36 Moved back the breakdown graph to be back with the total paid
refs: https://github.com/TryGhost/Team/issues/1462
2022-04-15 12:18:46 +01:00