mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-21 01:41:46 +03:00
51c9a50c4f
no issue - Additional validation is needed for imported data because in case of bulk insertions (through knex) we bypass model layer validation - this could lead to invalid data in the database, which would be hard to fix. - Chose validation method we use for other endpoints - through JSON Schema. It proved to be very performant (200ms overhead for 50k records). When comparing it with iterative method (validating each record separately) this was adding about 17s of overhead. - Refactored returned values from "sanitizeInput" method to encapsulate more logic so that the caller doesn't have to calculate amount of invalid records and deal with error types - Whole sanitizeInput method could now be easily extracted into separate module (somewhere close to members importer) - Bumped members-csv package. It is meant to handle empty string values - '' and null, which should allow validating member records more consistently!
268 B
268 B
| 1 | name | note | subscribed_to_emails | complimentary_plan | stripe_customer_id | created_at | labels | |
|---|---|---|---|---|---|---|---|---|
| 2 | invalid_email_value1 | ,name starting with coma | not_boolean | false | not_a_date | labels | ||
| 3 | invalid_email_value2 | good name | true | not_boolean | 2019-10-30T14:52:08.000Z | more-labels |