mirror of
https://github.com/TryGhost/Ghost.git
synced 2024-12-21 09:52:06 +03:00
7b443d4b63
no issue
The `config` service has been a source of confusion when writing with modern Ember patterns because it's use of the deprecated `ProxyMixin` forced all property access/setting to go via `.get()` and `.set()` whereas the rest of the system has mostly (there are a few other uses of ProxyObjects remaining) eliminated the use of the non-native get/set methods.
- removed use of `ProxyMixin` in the `config` service by grabbing the API response after fetching and using `Object.defineProperty()` to add native getters/setters that pass through to a tracked object holding the API response data. Ember's autotracking automatically works across the native getters/setters so we can then use the service as if it was any other native object
- updated all code to use `config.{attrName}` directly for getting/setting instead of `.get()` and `.set()`
- removed unnecessary async around `config.availableTimezones` which wasn't making any async calls
86 lines
2.4 KiB
JavaScript
86 lines
2.4 KiB
JavaScript
import ModalBase from 'ghost-admin/components/modal-base';
|
|
import classic from 'ember-classic-decorator';
|
|
import {action} from '@ember/object';
|
|
import {inject as service} from '@ember/service';
|
|
import {task} from 'ember-concurrency';
|
|
import {tracked} from '@glimmer/tracking';
|
|
|
|
// TODO: update modals to work fully with Glimmer components
|
|
@classic
|
|
export default class ModalFreeMembershipSettings extends ModalBase {
|
|
@service settings;
|
|
@service config;
|
|
|
|
@tracked freeSignupRedirect;
|
|
@tracked siteUrl;
|
|
init() {
|
|
super.init(...arguments);
|
|
this.siteUrl = this.config.blogUrl;
|
|
}
|
|
|
|
@action
|
|
close(event) {
|
|
event?.preventDefault?.();
|
|
this.closeModal();
|
|
}
|
|
|
|
actions = {
|
|
// needed because ModalBase uses .send() for keyboard events
|
|
closeModal() {
|
|
this.close();
|
|
},
|
|
updateName(value) {
|
|
this.settings.membersFreePriceName = value;
|
|
},
|
|
updateDescription(value) {
|
|
this.settings.membersFreePriceDescription = value;
|
|
},
|
|
setFreeSignupRedirect(url) {
|
|
this.freeSignupRedirect = url;
|
|
},
|
|
validateFreeSignupRedirect() {
|
|
return this._validateSignupRedirect(this.freeSignupRedirect, 'membersFreeSignupRedirect');
|
|
}
|
|
};
|
|
|
|
@task({drop: true})
|
|
*save() {
|
|
try {
|
|
this.send('validateFreeSignupRedirect');
|
|
if (this.settings.errors.length !== 0) {
|
|
return;
|
|
}
|
|
yield this.settings.save();
|
|
this.send('closeModal');
|
|
} catch (error) {
|
|
this.notifications.showAPIError(error, {key: 'settings.save'});
|
|
} finally {
|
|
this.send('closeModal');
|
|
}
|
|
}
|
|
|
|
_validateSignupRedirect(url, type) {
|
|
let errMessage = `Please enter a valid URL`;
|
|
this.settings.errors.remove(type);
|
|
this.settings.hasValidated.removeObject(type);
|
|
|
|
if (url === null) {
|
|
this.settings.errors.add(type, errMessage);
|
|
this.settings.hasValidated.pushObject(type);
|
|
return false;
|
|
}
|
|
|
|
if (url === undefined) {
|
|
// Not initialised
|
|
return;
|
|
}
|
|
|
|
if (url.href.startsWith(this.siteUrl)) {
|
|
const path = url.href.replace(this.siteUrl, '');
|
|
this.settings.type = path;
|
|
} else {
|
|
this.settings.type = url.href;
|
|
}
|
|
}
|
|
}
|