TryGhost/Ghost
1
0
Fork 0
mirror of https://github.com/TryGhost/Ghost.git synced 2024-12-19 00:11:49 +03:00
Code Issues Projects Releases Wiki Activity
d6b7ebb517
Ghost/ghost/core/test/e2e-api/admin
History
Nicholas Mizoguchi d6b7ebb517
Enforced more Mocha lint rules (#19720) 
ref https://github.com/TryGhost/Ghost/issues/11038

1. Enforced lint rule
**[ghost/mocha/no-identical-title](https://github.com/lo1tuma/eslint-plugin-mocha/blob/main/docs/rules/no-identical-title.md)**
- Fixed relevant tests
2. Enforced lint rule
**[ghost/mocha/max-top-level-suites](https://github.com/lo1tuma/eslint-plugin-mocha/blob/main/docs/rules/max-top-level-suites.md)**
- No required fixes, as tests are compliant already

#### Additional details
Specifically for `ghost/mocha/no-identical-title` most fixes were simple
test description updates. Added comments to aid the PR review for the
ones that had relevant changes, and might require more attention. They
are as follows:
*
[e2e-api/admin/invites.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496397548):
Removed duplicated test (exact same code on both);
*
[e2e-api/admin/members.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496399107):
From the[ PR this was
introduced](73466c1c40 (diff-4dbc7e96e356428561085147e00e9acb5c71b58d4c1bd3d9fc9ac30e77c45be0L236-L237))
seems like author based his test on an existing one but possibly forgot
to rename it;
*
[unit/api/canary/utils/serializers/input/pages.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496400143):
The [page filter](https://github.com/TryGhost/Ghost/pull/14829/files)
was removed, so changed the description accordingly;
*
[unit/api/canary/utils/serializers/input/posts.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496400329):
The [page filter](https://github.com/TryGhost/Ghost/pull/14829/files)
was removed, so changed the description accordingly;
*
[unit/frontend/services/rendering/templates.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496402430):
Removed duplicated test
*
[unit/server/models/post.test.js](https://github.com/TryGhost/Ghost/pull/19720#discussion_r1496403529):
the change in [this
PR](https://github.com/TryGhost/Ghost/pull/14586/files#diff-c351cb589adefbb886570cfadb33b33eb8fdc12bde1024d1188cd18c165fc5e8L1010)
made three tests here mostly the same. Deduplicated them and kept only
one.
2024-04-16 09:37:06 +02:00
..
__snapshots__ 🎨 Improved post-setup onboarding flow (#19996) 2024-04-08 13:03:41 +01:00
actions.test.js Removed usage of unquoted ids in filter strings (#19070) 2023-11-21 09:45:36 +01:00
activity-feed.test.js Removed usage of unquoted ids in filter strings (#19070) 2023-11-21 09:45:36 +01:00
collections.test.js Removed post_revisions default include 2023-10-12 13:10:05 +02:00
config.test.js 💡 Upgraded Tenor API to v2 (#15087) 2022-08-05 12:13:27 +01:00
custom-theme-settings.test.js Prevent simple error logs by stubbing log library 2023-03-03 18:25:53 +00:00
db.test.js Removed all unused variables from test files 2023-03-10 14:29:55 +01:00
email-preview-rate-limiter.test.js Added test email rate limiting (#17505) 2023-07-27 08:46:50 +02:00
email-previews.test.js Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
emails.test.js Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
explore.test.js Added Content-Version header to all API requests 2023-01-18 08:38:07 +01:00
files.test.js Removed all unused variables from test files 2023-03-10 14:29:55 +01:00
images.test.js Switched to throwing error upon failed image processing 2024-03-12 16:24:29 +01:00
integrations.test.js Removed usage of unquoted ids in filter strings (#19070) 2023-11-21 09:45:36 +01:00
invites.test.js Enforced more Mocha lint rules (#19720) 2024-04-16 09:37:06 +02:00
key-authentication.test.js 🐛 Fixed 500 error for premature api token use 2024-03-05 03:04:34 +07:00
labels.test.js Prevent simple error logs by stubbing log library 2023-03-03 18:25:53 +00:00
links.test.js Removed usage of unquoted ids in filter strings (#19070) 2023-11-21 09:45:36 +01:00
mail-events.test.js Add endpoint to record mail events (#16990) 2023-06-23 12:22:01 +01:00
media.test.js Removed all unused variables from test files 2023-03-10 14:29:55 +01:00
members-edit-subscriptions.test.js 🐛 Fixed handling multiple Stripe subscriptions for same member (#17773) 2023-08-22 13:27:21 +02:00
members-exporter.test.js Removed usage of unquoted ids in filter strings (#19070) 2023-11-21 09:45:36 +01:00
members-importer.test.js Removed all unused variables from test files 2023-03-10 14:29:55 +01:00
members-newsletters.test.js Removed all unused variables from test files 2023-03-10 14:29:55 +01:00
members-stripe-connect.test.js Added Content-Version header to all API requests 2023-01-18 08:38:07 +01:00
members.test.js Enforced more Mocha lint rules (#19720) 2024-04-16 09:37:06 +02:00
mentions.test.js Removed required webmentions flag for mentions admin endpoint 2023-09-19 17:31:55 +02:00
newsletters.test.js Fixed clearing invalid sender_email when changing newsletter sender_reply_to (#19555) 2024-01-23 16:10:11 +01:00
notifications.test.js Removed all unused variables from test files 2023-03-10 14:29:55 +01:00
oembed.test.js 🐛 Fixed HTTP 500 responses when oembed endpoint receives error 2024-03-12 12:31:44 +01:00
offers.test.js Fixed create offer API not returning created_at (#19143) 2023-11-28 15:11:35 +00:00
pages-bulk.test.js Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
pages-legacy.test.js Cleaned up lexicalEditor labs flag, switched Post model to lexical-by-default (#18607) 2023-10-23 17:51:34 +01:00
pages.test.js 🐛 Fixed free tier showing in the tiers-only paywall in posts (#19807) 2024-03-06 21:30:00 +01:00
posts-bulk.test.js Fixed collection cards not re-rendering when posts were bulk-edited 2023-09-28 18:05:01 +01:00
posts-legacy.test.js Cleaned up lexicalEditor labs flag, switched Post model to lexical-by-default (#18607) 2023-10-23 17:51:34 +01:00
posts.test.js 🐛 Fixed free tier showing in the tiers-only paywall in posts (#19807) 2024-03-06 21:30:00 +01:00
rate-limiting.test.js Added Content-Version header to all API requests 2023-01-18 08:38:07 +01:00
recommendations.test.js 🐛 Fixed adding recommendation when oembed fails (#19861) 2024-03-14 11:36:28 +01:00
redirects.test.js Improved performance of prepareContentFolder function 2022-08-01 08:58:13 +02:00
roles.test.js Added migrations for Self-Serve Migration Integration and API key 2023-03-24 11:28:29 +01:00
session.test.js Added Content-Version header to all API requests 2023-01-18 08:38:07 +01:00
settings-files.test.js Removed all unused variables from test files 2023-03-10 14:29:55 +01:00
settings.test.js Added portal default plan setting (#19238) 2023-12-06 11:39:58 +01:00
site.test.js Added Content-Version header to all API requests 2023-01-18 08:38:07 +01:00
slugs.test.js Fixed incorrect cache invalidation headers for slugs Admin API endpoint (#19753) 2024-02-26 16:59:29 +00:00
snippets.test.js Added support for filtering snippets to mobiledoc/lexical (#16636) 2023-04-17 10:54:08 +04:00
stats.test.js Updated to use assert/strict everywhere (#17047) 2023-06-21 09:56:59 +01:00
tags.test.js Removed bluebird catch predicates from API endpoints 2022-08-24 11:27:09 +01:00
themes.test.js Updated theme fixtures for casper and source (#18677) 2023-10-18 14:51:35 -07:00
tiers.test.js 🐛 Fixed bug preventing changes to tier benefit capitalization (#18406) 2023-10-05 19:04:11 -07:00
users.test.js Refined cache invalidation when updating a user (#19028) 2023-11-20 14:14:30 +00:00
utils.js 🐛 Fixed 500 error for premature api token use 2024-03-05 03:04:34 +07:00
webhooks.test.js Added Content-Version header to all API requests 2023-01-18 08:38:07 +01:00