upgrade to node v12 (#4171)

* docs: small updates to contributing

* upgrade docker image to node v12

* fix warning
This commit is contained in:
Jason Poon 2019-11-29 09:53:09 -08:00 committed by Jason Fields
parent b9353ae810
commit f69a331f57
2 changed files with 3 additions and 3 deletions

View File

@ -25,7 +25,7 @@ When submitting a PR, please fill out the template that is presented by GitHub w
1. Install prerequisites:
- latest [Visual Studio Code](https://code.visualstudio.com/)
- [Node.js](https://nodejs.org/) v8.0.0 or higher
- [Node.js](https://nodejs.org/) v12.0.0 or higher
- _Optional_: [Docker Community Edition](https://store.docker.com/search?type=edition&offering=community) 🐋
1. In a terminal:

View File

@ -1,9 +1,9 @@
FROM node:10.15
FROM node:12
ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update && \
apt-get install -y xorg xvfb libxss-dev libgtk-3-0 gconf2 libnss3 libasound2
apt-get install -y xorg xvfb libxss-dev libgtk-3-0 gconf2 libnss3 libasound2 libsecret-1-0
ENV CXX="g++-4.9"
ENV CC="gcc-4.9"