Fix toolbar item hang on macOS 10.12

CHANGELOG.md

@@ -16,6 +16,7 @@ Change Log
 
 ### Fixes
 
+- Fix an issue under macOS 10.12 where application hung up if “Text Orientation” toolbar item is visible.
 - Fix an issue where the “Discard Changes” and “Cancel” buttons in the dialog for encoding reinterpretation performed oppositely (Thanks to Aurélien Roy!).
 - Fix an issue where color code editor was invisible under macOS 10.12.
 - Fix an issue where the Go to Line command did not jump to the input number of line when performed by clicking “Go” button.

CotEditor/CotEditor.help/Contents/Resources/en.lproj/pgs/releasenotes.html

@@ -46,6 +46,7 @@
 <h2>Fixes</h2>
 
 <ul>
+	<li>Fix an issue under macOS 10.12 where application hung up if some specific toolbar items are visible.</li>
 	<li>Fix an issue where the “Discard Changes” and “Cancel” buttons in the dialog for encoding reinterpretation performed oppositely (Thanks to Aurélien Roy!).</li>
 	<li>Fix an issue where color code editor was invisible under macOS 10.12.</li>
 	<li>Fix an issue where the Go to Line command did not jump to the input number of line when performed by clicking “Go” button.</li>

CotEditor/CotEditor.help/Contents/Resources/ja.lproj/pgs/releasenotes.html

@@ -46,6 +46,7 @@
 <h2>修正</h2>
 
 <ul>
+	<li>macOS 10.12でいくつかの特定のツールバー項目が表示されているとアプリケーションがハングした不具合を修正</li>
 	<li>エンコーディングの再解釈ダイアログで「変更内容を破棄」と「キャンセル」ボタンの動作が逆になっていた不具合を修正（Aurélien Royさんに感謝!）</li>
 	<li>macOS 10.12でカラーコードエディタが非表示になっていた不具合を修正</li>
 	<li>行に移動コマンドで「移動」ボタンをクリックして行を移動したとき、指定した行番号に飛ばなかった不具合を修正</li>

CotEditor/Sources/SegmentedToolbarItem.swift

@@ -8,7 +8,7 @@
 //
 //  ---------------------------------------------------------------------------
 //
-//  © 2018 1024jp
+//  © 2018-2019 1024jp
 //
 //  Licensed under the Apache License, Version 2.0 (the "License");
 //  you may not use this file except in compliance with the License.
@@ -67,6 +67,8 @@ final class SegmentedToolbarItem: ControlToolbarItem {
                 switch validator {
                 case let validator as NSUserInterfaceValidations:
                     return validator.validateUserInterfaceItem(item)
+                case _ where validator.responds(to: #selector(NSUserInterfaceValidations.validateUserInterfaceItem)):  // workaround for macOS 10.12 and earier
+                    return validator.validateUserInterfaceItem(item)
                 default:
                     return validator.validateMenuItem(item)
                 }