Use .barrier for rangesQueue in syntax highlight

2024-09-11 11:25:57 +03:00 · 2018-05-10 12:17:20 +09:00 · 2018-05-10 12:17:20 +09:00 · 46c6d33508
commit 46c6d33508
parent 2254286bc7
2 changed files with 3 additions and 2 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -14,6 +14,7 @@ unreleased

 ### Fixes

+- [beta] Fix an issue the application could crash while typing.
 - [tirivial] Fix an issue on macOS 10.12 and earlier where the Japanese label of the menu item toggling toolbar visibility did not reflect the current visibility state.


--- a/CotEditor/Sources/SyntaxHighlightParseOperation.swift
+++ b/CotEditor/Sources/SyntaxHighlightParseOperation.swift
@ -154,12 +154,12 @@ final class SyntaxHighlightParseOperation: AsynchronousOperation, ProgressReport
                
                guard !extractedRanges.isEmpty else { return }
                
-                rangesQueue.sync {
+                rangesQueue.async(flags: .barrier) {
                    ranges += extractedRanges
                }
            }
            
-            highlights[syntaxType] = ranges
+            highlights[syntaxType] = rangesQueue.sync { ranges }
            
            childProgress.completedUnitCount = childProgress.totalUnitCount
        }