Change condition to pretend ubiquitous strage is not used

CHANGELOG.md

@@ -18,6 +18,7 @@ Change Log
 - Fix an issue that the application did not terminate when all windows are closed.
 - Fix an issue in the script menu that a script bundle (.scptd) was handled not as a script but as a folder.
 - Fix an issue in the snippet key bindings that shortcuts with only Shift key for modifier keys were accepted though does not work correctly.
+- Fix an issue that the application rarely showed the open dialog on launch even when the user setting for the startup behavior is not “show open dialog.”
 - Fix literal number highlight with Ruby syntax style.
 - Address an issue that annoying dialog that alerts saving was failed could be shown while typing when autosaving is disabled.
 

CotEditor/CotEditor.help/Contents/Resources/en.lproj/pgs/releasenotes.html

@@ -25,7 +25,7 @@
 <article>
 <header>
 	<h1>CotEditor 4.0.4</h1>
-	<p>release: <time>2021-05-31</time></p>
+	<p>release: <time>2021-06-02</time></p>
 </header>
 
 
@@ -48,6 +48,7 @@
 	<li>Fix an issue that the application did not terminate when all windows are closed.</li>
 	<li>Fix an issue in the script menu that a script bundle (.scptd) was handled not as a script but as a folder.</li>
 	<li>Fix an issue in the snippet key bindings that shortcuts with only Shift key for modifier keys were accepted though does not work correctly.</li>
+	<li>Fix an issue that the application rarely showed the open dialog on launch even when the user setting for the startup behavior is not “show open dialog.”</li>
 	<li>Fix literal number highlight with Ruby syntax style.</li>
 	<li>Address an issue that annoying dialog that alerts saving was failed could be shown while typing when autosaving is disabled.</li>
 </ul>

CotEditor/CotEditor.help/Contents/Resources/ja.lproj/pgs/releasenotes.html

@@ -25,7 +25,7 @@
 <article>
 <header>
 	<h1>CotEditor 4.0.4</h1>
-	<p>リリース: <time>2021-05-31</time></p>
+	<p>リリース: <time>2021-06-02</time></p>
 </header>
 
 
@@ -48,6 +48,7 @@
 	<li>すべてのウインドウを閉じてもアプリケーションが自動で終了しなかったCotEditor 4.0.0以降の不具合を修正</li>
 	<li>スクリプトバンドル (.scptd) がスクリプトでなくフォルダとして扱われていたスクリプトメニューの不具合を修正</li>
 	<li>Shiftキーのみを修飾キーとするショートカットが実際には正しく機能しないにも関わらず登録できたスニペットキーバインディングの不具合を修正</li>
+	<li>起動時の設定が“「開く」ダイアログを表示”でないにもかかわらず稀に「開く」ダイアログが表示されることがあった不具合を修正</li>
 	<li>Rubyシンタックススタイルのリテラルナンバーハイライトを修正</li>
 	<li>オートセーブを無効にしているとき、テキスト編集中に保存ができなかったことを告げるダイアログが表示されることがあった不具合に対処</li>
 </ul>

CotEditor/Sources/Document.swift

@@ -163,7 +163,7 @@ final class Document: NSDocument, AdditionalDocumentPreparing, EncodingHolder {
         
         // pretend as if iCloud storage is disabled to let the system give up opening the open panel on launch (2018-02 macOS 10.13)
         if UserDefaults.standard[.noDocumentOnLaunchBehavior] != .openPanel,
-            NSAppleEventManager.shared().isOpenEvent
+           NSDocumentController.shared.documents.isEmpty
         {
             return false
         }