* interface methods: Haskell AST for methods
Part of #11006. This leaves typechecker and LF conversion for later, on
the haskell side.
changelog_begin
changelog_end
* Forgot ECallInterface in DecodeV1
* fix a test
Tested manually that it worked. It didn’t work before actually since
the `webpack serve` switch was needed even for the old version but now
it does.
Unfortunately this still doesn’t get rid of the dependency on setvalue.
changelog_begin
changelog_end
We really don’t need 600 lines of mostly deprecated and unmaintained
dependencies which get flagged by blackduck & dependabot if we can
inline this into a static array which we never changed since we first
added the docs.
changelog_begin
changelog_end
Disks are currently at 75% fullness, so seems like a good idea to bump a
bit. #10857 should reduce our needs, too, so this should last us a
while.
CHANGELOG_BEGIN
CHANGELOG_END
* For the client binding propagate the full original completion.
Because more fields are added to the completion it gets more difficult to deconstruct it into our own models while keeping the same external API. Because of this, we are propagating the full completion as well
CHANGELOG_BEGIN
java-client-bindings - the original full completion is included in the `CompletionResponse` when available
CHANGELOG_END
* Check protobuf compatibility of release commits w.r.t. previous stable release
CHANGELOG_BEGIN
CHANGELOG_END
* Remove blank line
* Don't persist credentials
Co-authored-by: Gary Verhaegen <gary.verhaegen@digitalasset.com>
* check-protobuf-against-stable.sh: SRC_DIR -> PROJECT ROOT + simplify
* Don't set LATEST_STABLE global in a function
* Simplify by using only the main work tree
* Simplify further as the check will be only run from `main`
* Move the check to `ci/build.yml` so that it is also run on PRs
* Enter the development environment to use tools
* Make variables read-only
* Support release branches and PRs targeting them
* Fix and document the reference tag finding logic
* Fix SYSTEM_PULLREQUEST_TARGETBRANCH and print it
* Don't log the source branch
* Fix comment formatting
Co-authored-by: Gary Verhaegen <gary.verhaegen@digitalasset.com>
* Enable Slack integration
Co-authored-by: Gary Verhaegen <gary.verhaegen@digitalasset.com>
* Don't check if the branch is a release one
...as the check won't be run on release branches.
* Add compatibility_stable_protobuf to collect_build_data
* Do not activate dev-env globally but only in sub-shells
* Add an explanation about why the check is not run on release branch commits
* Simplify further by leveraging `buf`'s ability to compare against branches
* Use `buf`'s `tag` locator instead of `branch`
* Split buf checks by module and remove previous manual check
* Explain how to run locally
* Use more future-proof WIRE_JSON for participant-integration-api
Co-authored-by: Simon Meier <meiersi-da@users.noreply.github.com>
* Use stricter FILE for the ledger gRPC API
* Propose an explanation for WIRE in kvutils
* Fix comment typo
* Re-introduce linting configuration for kvutils
* Simplify explanation for KVUtils' breaking check rule
* Remove extra (C) header from 3rd-party proto
* Don't touch the copyright of google/rpc/status.proto
Co-authored-by: Gary Verhaegen <gary.verhaegen@digitalasset.com>
Co-authored-by: Simon Meier <meiersi-da@users.noreply.github.com>
* interface methods: Add protobuf
Adds protobuf definitions for interface methods and calling them.
Encoders/decoders just ignore the extra stuff or error out.
Part of #10810 (maybe)
changelog_begin
changelog_end
* Update issue numbers where appropriate
* update stable protos
(Also: generalize type of `enrichTransaction` to work for _submitted_ and _committed_ transactions & adapt existing callers)
This change paves the way to remove the `transactionNormalization` flag, and always normalize transactions coming out of the engine.
CHANGELOG_BEGIN
CHANGELOG_END
@garyverhaegen-da is taking care of 1.17.0-snapshot.20210921.7889.0.1b473c2b (#10971), so they get pushed back to the end of the line.
Please do not merge this before #10971.
CHANGELOG_BEGIN
CHANGELOG_END
Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
* Add MINIMAL pragma for Additive type class
This ensures that the compiler gives an error if both (-) and negate are missing in an instance
Fixes#11000
changelog_begin
changelog_end
* Add test case to ensure incomplete Additive instance declaration triggers error message
@garyverhaegen-da is in charge of this release.
This supersedes the failed #10971 and #10993.
Commit log:
```
ced4a27240 Include concurrency info in output (#10970)
a0b6800a93 Limit maximum number of concurrent tests (#10969)
a0fe0f6239 release 1.18.0-snapshot.20210921.7889.1.1b473c2b (#10993)
58c82b6e41 LF: reduce usage of NodeCreate.coinst (#10988)
f56ce2a757 kvutils: Add structured error data to the error metadata [KVL-1032] (#10964)
3f4dbf6f8e interfaces: Syntax highlighting for interfaces (#10987)
d52a2857da interface: Add test for conversion functions (#10991)
28b8d9a1f7 bump dotnet (#10979)
fe10ffbe8f Use ValueEnricher in ScenarioRunner. (#10897)
bdad7d5c99 Upgrade Java on Windows (#10965)
34390f7062 interfaces: Implemented conversions, added test. (#10982)
7740b60836 participant-integration-api: Improve the CommandConfiguration docs. (#10978)
04f322e2aa Bump resources for daml-ledger tests (#10984)
6d9922e1f1 Retry upsert of command deduplication on oracle and h2 [DPP-609] (#10976)
eb4f1b2a05 LF: Move lookup tests out of EngineTest (#10973)
99836d2610 Handle fetchByKey callback correctly in scenario runner (#10980)
23e6a2dddb Improve feedback from failing match in AuthMatchers (#10981)
e299103450 [Short] Small test tool's CLI parser refactor (#10923)
fc153a91b2 release 1.18.0-snapshot.20210921.7889.0.1b473c2b (#10971)
1b473c2b9a Switch trigger service time provider default to wall-clock time (#10967)
4acf34b5fc Add conversions from/to interfaces in Daml parser (#10954)
d50df11f77 interface: Add to/from interface in scala ast (#10960)
9f88e0919f Drop jdk8 override (#10963)
e0587bcdd2 Add a bit of detail to RegisteredTemplates documentation, motivated by: (#10962)
cebe6ed482 Refactor safetyStep in the simplifier. (#10948)
ac192fc6db interfaces: Add to/from interface in Haskell typechecker (#10951)
4b4d7a3af7 Remove update normalizer which was too aggresive (#10925)
66e1098070 Add tests for the `CompletionFromTransaction` converter [KVL-1104] (#10885)
724e50d739 interfaces: Add to/from interface in Haskell AST (#10945)
9a8d55ad13 Change slack link to discuss wiki. Fixes#10946 (#10947)
8b3b033fad LF: Test preprocessor resuming (#10936)
2edfc062a0 ifaces: name collision, typecheck fetch/exercise (#10896)
5dc15c6911 LF: rename language Interface to PackageInterface (#10938)
054c6abb63 Upgrade canton to a more recent version (#10944)
b8533d50e9 [JSON-API] Production/HA documentation. (#10903)
a33176265a Clarify `CommandTracker` [KVL-1104] (#10943)
5244643d16 Changes to increase timeout and remove assertions around mock CommandSubmissionServiceImpl (#10942)
6cc42ee9f4 rotate release duty after 1.17.0-snapshot.20210915.7832.0.38227a8e (#10892)
88ef05e557 sandbox-classic: Only allow `--max-parallel-submissions` here. (#10941)
ac02dbdeb9 LF: Exhaustive test for valueTranslator. (#10927)
409c0b4f60 interfaces: Add to/from_interface in proto (#10937)
02c8a9dfb8 Split CommonStorageBackend (#10871)
dc71a6aea8 update NOTICES file (#10932)
0ba54a4bf9 Add a missing test case to the `CommandTrackerFlowTest` (#10939)
855ecdf1a7 [DPP-572] Add ledger API test case for verifying conformance to `--min-tls-version` flag. (#10898)
3e13e3d87e Switch to stable urls in scoop python manifest (#10933)
fc2c87d950 ledger-api-client: Generate a submission id if it's empty in the `CommandClient` [KVL-1104] (#10926)
04d8f753b2 Clean up sandbox-on-x conformance tests. (#10766)
b4541b5a4d Logging delay of submitted commands (#10912)
b8e21d8f48 Fix takeFilter for the test StreamConsumer (#10918)
906368d7e2 LF: exhaustive test for CommandPreprocessor (#10914)
61d214e451 Add fetch, exercise implementations for interfaces in speedy. (#10911)
d01f8e1c35 Fix flaky ApiConfigManagementServiceSpec test (#10922)
50291ed61b interfaces: scala typechecker implementation (#10867)
cac8391d4c Bump ghc-lib to include daml interfaces parser (#10747)
b6a6bf7aac [Ledger API error codes] Extracted common errors and groups [DPP-607] (#10890)
308f938512 Dpp 494 unit testing ha coordinator (#10862)
30f74adc99 Mark Extractor's VeryLargeArchiveSpec test as flaky (#10916)
9582e019ec LF: Refactor PreprocessorSpec test (#10909)
9b0fa29aec Separate exercise & fetch for interfaces from templates (#10908)
f4adee91ca Add conformance test for command deduplication using the CommandService [KVL-1099] (#10883)
8a391189a6 Rename Completion.deduplication_time to deduplication_duration [KVL-1057] (#10900)
8e22bb6b2d Drop ContractId typeparameter from Value (#10827)
45437059d4 Drop cocreature as a codeowner from runtime things (#10906)
e6e81470bb Release 1.17.0 RC from second to last commit (#10904)
f08ac5f65c Desugar interface implements declarations (#10895)
b5648c0e3d Make `CommandTracker` distinguish submissions of the same command using `submissionId` [KVL-1104] (#10868)
```
Changelog:
```
[Triggers Service] The service now starts by default using wall-clock time instead
of static time. If you want to run using static time, you need to do so explicitly
using the new '-s' or '--static-time' CLI option. If you were already using '-w'
or '--wall-clock-time' the flag has no effect. It's anyway safe to leave it there.
Sandbox: Add CLI flag `--min-tls-version` to select minimum enabled TLS version for participant server.
```
CHANGELOG_BEGIN
CHANGELOG_END
The `main` branch build for #10971 failed. #10979 should have fixed it,
so let's try again.
This needs to be merged _after_ #10979.
CHANGELOG_BEGIN
CHANGELOG_END
This bumps dotnet to the version required by the latest azuresigntool,
and pins azuresigntool for the future.
As usual for live CI upgrades, this will be rolled out using the
blue/green approach. I'll keep each deployed commit in this PR.
For future reference, this is PR [#10979].
[#10979]: https://github.com/digital-asset/daml/pull/10979
CHANGELOG_BEGIN
CHANGELOG_END
1st attempt. Causes package recompilation (bad!).
CHANGELOG_BEGIN
CHANGELOG_END
fix build
Change ValueEnricher interface to work without passing an Engine
ValueEnricher has optional preprocessor
simplify new interface to ValueEnricher: caller passes translateValue function
Part of #10810
- Implemented ToInterface, FromInterface in speedy
- Added a test that exercises and fetches an interface
- Fixed a bug in SBUChoiceInterface
Hey, interfaces work now!
changelog_begin
changelog_end
Explaining the limits in more detail.
There were some discrepancies between the documentation and the code; in
particular, if there are too many commands in flight, new ones will just
be held in the queue.
CHANGELOG_BEGIN
CHANGELOG_END
fixes#10977
Turns out assertions are good unless they’re wrong …
This only affects scenarios, the engine never looks at the callback.
changelog_begin
changelog_end
changelog_begin
changelog_end
Visualizes the top-most exception as part of the test failure when the expected
gRPC error code is not found in the stack trace. This should hopefully improve
our chances to identify the cause of flakes such as the one reported as part of
https://github.com/digital-asset/daml/issues/10974.
Example output in case of a failing match:
```
- should deny access without sufficient authorization *** FAILED *** (39 milliseconds)
listPackages java.lang.RuntimeException: java.util.concurrent.ExecutionException: io.grpc.StatusRuntimeException: UNAUTHENTICATED: did not equal DEADLINE_EXCEEDED (AuthMatchers.scala:38)
```
Before this commit, the output for a similar failure would be the something like:
```
- should deny access without sufficient authorization *** FAILED *** (208 milliseconds)
getPackageStatus <iterator> was empty (AuthMatchers.scala:16)
```
* release 1.17.0-snapshot.20210921.7889.0.1b473c2b
This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.
@garyverhaegen-da is in charge of this release.
Commit log:
```
1b473c2b9a Switch trigger service time provider default to wall-clock time (#10967)
4acf34b5fc Add conversions from/to interfaces in Daml parser (#10954)
d50df11f77 interface: Add to/from interface in scala ast (#10960)
9f88e0919f Drop jdk8 override (#10963)
e0587bcdd2 Add a bit of detail to RegisteredTemplates documentation, motivated by: (#10962)
cebe6ed482 Refactor safetyStep in the simplifier. (#10948)
ac192fc6db interfaces: Add to/from interface in Haskell typechecker (#10951)
4b4d7a3af7 Remove update normalizer which was too aggresive (#10925)
66e1098070 Add tests for the `CompletionFromTransaction` converter [KVL-1104] (#10885)
724e50d739 interfaces: Add to/from interface in Haskell AST (#10945)
9a8d55ad13 Change slack link to discuss wiki. Fixes#10946 (#10947)
8b3b033fad LF: Test preprocessor resuming (#10936)
2edfc062a0 ifaces: name collision, typecheck fetch/exercise (#10896)
5dc15c6911 LF: rename language Interface to PackageInterface (#10938)
054c6abb63 Upgrade canton to a more recent version (#10944)
b8533d50e9 [JSON-API] Production/HA documentation. (#10903)
a33176265a Clarify `CommandTracker` [KVL-1104] (#10943)
5244643d16 Changes to increase timeout and remove assertions around mock CommandSubmissionServiceImpl (#10942)
6cc42ee9f4 rotate release duty after 1.17.0-snapshot.20210915.7832.0.38227a8e (#10892)
88ef05e557 sandbox-classic: Only allow `--max-parallel-submissions` here. (#10941)
ac02dbdeb9 LF: Exhaustive test for valueTranslator. (#10927)
409c0b4f60 interfaces: Add to/from_interface in proto (#10937)
02c8a9dfb8 Split CommonStorageBackend (#10871)
dc71a6aea8 update NOTICES file (#10932)
0ba54a4bf9 Add a missing test case to the `CommandTrackerFlowTest` (#10939)
855ecdf1a7 [DPP-572] Add ledger API test case for verifying conformance to `--min-tls-version` flag. (#10898)
3e13e3d87e Switch to stable urls in scoop python manifest (#10933)
fc2c87d950 ledger-api-client: Generate a submission id if it's empty in the `CommandClient` [KVL-1104] (#10926)
04d8f753b2 Clean up sandbox-on-x conformance tests. (#10766)
b4541b5a4d Logging delay of submitted commands (#10912)
b8e21d8f48 Fix takeFilter for the test StreamConsumer (#10918)
906368d7e2 LF: exhaustive test for CommandPreprocessor (#10914)
61d214e451 Add fetch, exercise implementations for interfaces in speedy. (#10911)
d01f8e1c35 Fix flaky ApiConfigManagementServiceSpec test (#10922)
50291ed61b interfaces: scala typechecker implementation (#10867)
cac8391d4c Bump ghc-lib to include daml interfaces parser (#10747)
b6a6bf7aac [Ledger API error codes] Extracted common errors and groups [DPP-607] (#10890)
308f938512 Dpp 494 unit testing ha coordinator (#10862)
30f74adc99 Mark Extractor's VeryLargeArchiveSpec test as flaky (#10916)
9582e019ec LF: Refactor PreprocessorSpec test (#10909)
9b0fa29aec Separate exercise & fetch for interfaces from templates (#10908)
f4adee91ca Add conformance test for command deduplication using the CommandService [KVL-1099] (#10883)
8a391189a6 Rename Completion.deduplication_time to deduplication_duration [KVL-1057] (#10900)
8e22bb6b2d Drop ContractId typeparameter from Value (#10827)
45437059d4 Drop cocreature as a codeowner from runtime things (#10906)
e6e81470bb Release 1.17.0 RC from second to last commit (#10904)
f08ac5f65c Desugar interface implements declarations (#10895)
b5648c0e3d Make `CommandTracker` distinguish submissions of the same command using `submissionId` [KVL-1104] (#10868)
```
Changelog:
```
[Triggers Service] The service now starts by default using wall-clock time instead
of static time. If you want to run using static time, you need to do so explicitly
using the new '-s' or '--static-time' CLI option. If you were already using '-w'
or '--wall-clock-time' the flag has no effect. It's anyway safe to leave it there.
Sandbox: Add CLI flag `--min-tls-version` to select minimum enabled TLS version for participant server.
```
CHANGELOG_BEGIN
CHANGELOG_END
* 1.18 not 1.17
changelog_begin
changelog_end
Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Fixes#10957
changelog_begin
[Triggers Service] The service now starts by default using wall-clock time instead
of static time. If you want to run using static time, you need to do so explicitly
using the new '-s' or '--static-time' CLI option. If you were already using '-w'
or '--wall-clock-time' the flag has no effect. It's anyway safe to leave it there.
changelog_end
The comment here is no longer accurate, Nix upgraded since so we
actually pin an older version for no reason. Perhaps somewhat
ironically while Nix upgraded they left the comment in their
derivation to not upgrade because of jvmci.
changelog_begin
changelog_end
