Commit Graph

10490 Commits

Author SHA1 Message Date
Remy
45bfb26ade
LF clean up proto snapshot of LF 1.15 (#14799)
CHANGELOG_BEGIN
CHANGELOG_END
2022-08-29 10:40:19 +00:00
azure-pipelines[bot]
a848a41d8e
update NOTICES file (#14852)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
2022-08-29 12:05:45 +02:00
Meriam Lachkar
3c3a8f874d
document how to enable dev on both Daml and Canton (#14838)
* document how to enable dev on both Daml and Canton

changelog_begin
changelog_end

* Update docs/source/daml/reference/interfaces.rst

Co-authored-by: carrielaben-da <91496516+carrielaben-da@users.noreply.github.com>

* Update docs/source/daml/reference/interfaces.rst

Co-authored-by: carrielaben-da <91496516+carrielaben-da@users.noreply.github.com>

* Update docs/source/daml/reference/interfaces.rst

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

* Update docs/source/daml/reference/interfaces.rst

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

* change the link reference to a ref

Co-authored-by: carrielaben-da <91496516+carrielaben-da@users.noreply.github.com>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
2022-08-29 11:01:50 +02:00
azure-pipelines[bot]
f21b165c78
bump canton to 20220826 (#14847)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
2022-08-29 10:12:17 +02:00
pbatko-da
db5966574a
Add base class for persistent store tests. Add such test for PersistentUserManagementStore [DPP-1198] (#14793)
changelog_begin
changelog_end
2022-08-26 15:01:34 +02:00
Sergey Kisel
53c5291e89
Adding metrics to interface subscription related execution paths [DPP-1151] (#14808)
* Adding metrics to interface subscription related execution paths [DPP-1151]

CHANGELOG_BEGIN
CHANGELOG_END
2022-08-26 08:30:41 +02:00
Chun Lok Ling
47216d1f1a
Pass retroImplements from Ast.DefInterface to DefInterface (#14843)
* pass retroImplements from Ast.DefInterface to DefInterface and addted test case

CHANGELOG_BEGIN
CHANGELOG_END

* added todo

CHANGELOG_BEGIN
CHANGELOG_END

* fixed findTemplate , added test cases

CHANGELOG_BEGIN
CHANGELOG_END

* add test data

CHANGELOG_BEGIN
CHANGELOG_END

* add copyright

CHANGELOG_BEGIN
CHANGELOG_END
2022-08-25 23:53:01 +01:00
azure-pipelines[bot]
e0ca74bdd6
rotate release duty after 2022-08-24 (#14804)
@basvangijzel-DA is taking care of [testing](https://github.com/digital-asset/daml/blob/main/release/RELEASE.md) today's release, so they get pushed back to the end of the line.

Please do not merge this before the release is fully tested.

CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
2022-08-25 20:32:24 +01:00
atriantafyllos-da
cde5de6d01
Fixes error message for HMAC256Verifier. (#14839)
Fixes error message for HMAC256Verifier.

CHANGELOG_BEGIN
CHANGELOG_END
2022-08-25 19:00:36 +02:00
dylant-da
4f4aa63fde
Change ghc version to point to merged distinguish guards commit in GHC (#14840)
CHANGELOG_BEGIN
CHANGELOG_END
2022-08-25 14:37:51 +00:00
dylant-da
6ece737e46
Desugar guards compatibly with 1.15/1.dev split (#14773)
* Add version 1.15 - move interfaces into them

* Update Ast/Version & docs for 1.15, split interface into simple/extended

* Stage 1.15 protobuf

* Remove references to dev from 1.15 protobufs

* Add Tests file for 1.15 in ledger API testtool

* Update Version 1.15 changelog with Call/implements

* Make 1.14 default again

* Add 1.15 as preview version

* Add 1.15 test suite to testtool

* Reinclude 1.15 in COMPILER_LF_VERSIONS to build model-tests-1.15

* Move v1_15 ledger-api-tests into own suite

* Fix InterfaceNotSupported message to 1.15 or higher

* satisfy changelog check

CHANGELOG_BEGIN
CHANGELOG_END

* Update tests with extended interface features to only run on 1.dev

* Allow unsafe_from_interface and interface_template_type_rep in 1.15

* Fix StableVersions back to 1.14, make EarlyAccessVersions 1.15

* Run retroactive implements tests only in extended interfaces

* lint

* Temporarily disable 1.15 conformance tests - handle in another PR

* Also disable conformance-test-tls1.2-or-newer-1.15

* Disable PureConfigReaderWriter tests that assume early-access == stable

* lint

* Temporarily disable decode extended interface primitives test

* Use dictionary comprehension to generate ledger/test-common test_names

* Move InterfaceSubscriptionsIT test back into 1.dev suite

* lint

* Make exercise guards nullable, ignore Nothing in decode/encode

* Desugar UExerciseInterface[Guarded] differently, point to updated GHC

* Update to new GHC revision, removes pred argument from `exercise`

* Attach correct range to guard support error (if any)

Co-Authored-By: Moisés Ackerman <6054733+akrmn@users.noreply.github.com>

* Rename interface features

Co-Authored-By: Moisés Ackerman <6054733+akrmn@users.noreply.github.com>

* Remove unnecessary mention of v1_14 from supportedInputVersions

Co-Authored-By: Moisés Ackerman <6054733+akrmn@users.noreply.github.com>

* Clarify purpose of `Maybe Expr` type for exercise guard

Co-Authored-By: Moisés Ackerman <6054733+akrmn@users.noreply.github.com>

* Remove guarded exercise when Extended Interfaces are not enabled

* Remove all instances of guarded exercises in versions <= 1.15

* Add check for isId to splitDFunId

* Exclude via $cexerciseGuarded check - ClassOpId approach did not work

* Run damlc interface tests w/o requires when since DAML_INTERFACE

* Update desugared daml for UExerciseInterface[Guarded] generation

* Temporarily disable failing damlc tests

* Remove 1.dev-only references from 1.15 protobuf

Co-authored-by: Moisés Ackerman <6054733+akrmn@users.noreply.github.com>
2022-08-25 14:20:03 +01:00
atriantafyllos-da
cba5068769
Respect leeway parameters also in the manual JWT verification [DPP-1145]. (#14676)
Respect leeway parameters in the manual JWT verification [DPP-1145].

CHANGELOG_BEGIN
CHANGELOG_END
2022-08-25 15:13:32 +02:00
Matthias Schmalz
7728d61565
Ignore non-singleton subtypes of ErrorCode when creating error code documentation. (#14829)
CHANGELOG_BEGIN
CHANGELOG_END
2022-08-25 14:59:42 +02:00
Sergey Kisel
fe703c6c67
Conformance test for Interface subscriptions with retroactive interfaces [DPP-1175] (#14807)
Conformance test for Interface subscriptions with retroactive interfaces [DPP-1175]

CHANGELOG_BEGIN
CHANGELOG_END
2022-08-25 12:32:10 +00:00
Remy
0f662a66a9
LF: simplify error about unserializability of view (#14803)
CHANGELOG_BEGIN
CHANGELOG_END
2022-08-25 09:53:03 +00:00
Chun Lok Ling
51ce902e6e
14796 front end change (#14811)
* added graphql resolve field

CHANGELOG_BEGIN
CHANGELOG_END

* render interface prefix; add interface in the route path; added graphql resolve field

* pass in interface id if the choice exercised via interface

* render interface choice in popup when click wrench icon
2022-08-25 10:42:31 +01:00
Moisés Ackerman
1a90e9c117
Extend daml-doc to support retroactive interface instances and viewtypes (#14774)
* Add daml-doc EXPECTED.{md,rst} files for QualifiedInterface.daml

* Add daml-doc EXPECTED.{md,rst} files for {,Qualified}RetroactiveInterfaceInstance.daml

* 'implements' in templates are now rendered as 'interface instance's

* Update daml-test-files {,Qualified}Interface.daml EXPECTED daml-doc output

* daml-doc now includes interface instances in interfaces

* Update daml-test-files {,Qualified}RetroactiveInterfaceInstance.daml EXPECTED daml-doc

* Add daml-doc test case for interface instance in interface

* Generalize runDamldoc to runDamldocMany

* Generalize damldocExpect to damldocExpectMany

* Add daml-doc test cases for qualified interface instance anchors

* Extract interface viewtypes in daml-doc

* Render interface viewtypes in daml-doc

* Update EXPECTED daml-doc for daml-test-files with interface viewtypes

* Add comment for use of partial function (Data.Map.Strict.!)

changelog_begin
changelog_end
2022-08-25 09:30:44 +00:00
mziolekda
31cc435331
small corrections in the specification of the lf transaction (#14827)
CHANGELOG_BEGIN
CHANGELOG_END
2022-08-25 10:16:41 +02:00
Remy
5a07b6596f
LF: check viewtype is a monomorphic record (#14802)
CHANGELOG_BEGIN
CHANGELOG_END
2022-08-25 10:02:13 +02:00
Moisés Ackerman
d1c0cff106
Fix for interface instance of interface from data-dependency (#14813)
* Add failing test cases

* fix unhandled string in convertTemplateTyCon

* data-dependencies: Add DamlTemplate context on template data declarations

changelog_begin
changelog_end
2022-08-25 09:50:24 +02:00
Rafael Guglielmetti
00705af419
Add retry in ISTransactionsSubscribeBeforeTemplateCreated (#14809)
CHANGELOG_BEGIN
CHANGELOG_END
2022-08-24 16:53:20 +02:00
Chun Lok Ling
f0686d44c6
Load interface and interface instance from packages in the Ledger (#14757)
* Added internal interface case class

CHANGELOG_BEGIN
CHANGELOG_END

* resolveRetroImplements WIP

* remove not used def

* added astInterfaces in PackageRegistry

* provide implementedInterfaces set

* Use def from interface library to resolve choice interface and retroactive implements

* use resolvedChoices instead of directChoices to get resolved choices from template.

* renming AstInterface -> Interface

* Address Stephen's comment

* format
2022-08-24 15:39:28 +01:00
azure-pipelines[bot]
d8874a3ae2
bump canton to 20220823 (#14805)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
2022-08-24 10:21:52 +02:00
Sergey Kisel
480554e653
Check if package metadata view initialisation takes too long [DPP-1160] (#14782)
* Check if package metadata view initialisation takes too long [DPP-1160]

CHANGELOG_BEGIN
CHANGELOG_END
2022-08-24 05:59:10 +00:00
Sergey Kisel
1ab1605948
Make test not fail if package has been uploaded already [DPP-1159] (#14798)
CHANGELOG_BEGIN
CHANGELOG_END
2022-08-23 21:11:51 +02:00
Stephen Compall
f43bc5c8d1
use new api-type-signature names in some dependents (#14785)
* use new names in json-api

* use new names in java codegen

* use new names in Scala codegen

* use new names in TypedValueGenerators

CHANGELOG_BEGIN
CHANGELOG_END
2022-08-23 17:52:10 +00:00
azure-pipelines[bot]
d74240af2b
update compat versions (2022-08-23) (#14788)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
2022-08-23 17:59:40 +02:00
Simon Maxen
e7fc7019f8
Patch issue with loading community metering key from classpath (#14797)
* Patch issue with loading community metering key from classpath

changelog_begin
changelog_end
2022-08-23 17:59:08 +02:00
Stephen Compall
f85f7816c7
rename interface library to api-type-signature; alias symbols (#14783)
* move interface directory to api-type-signature; change bazel target; move scala files

* rename iface package to typesig; rename EnvironmentInterface to EnvironmentSignature

* rename Interface to PackageSignature

* rename fromReaderInterfaces to fromPackageSignatures

* rename InterfaceReader to SignatureReader

* rename InterfaceReader to SignatureReader in deprecation note

* rename readInterface to readPackageSignature

* rename InterfaceReaderError to Error

* rename InterfaceReaderMain to SignatureReaderMain

* rename InterfaceType to PackageSignature.TypeDecl

* rename astInterfaces to interfaces

* rename astInterfaces to interfaces in PackageSignature

* rename findAstInterface to findInterface

* rename a couple arguments

CHANGELOG_BEGIN
- [Scala API] The "quasi-public" API in ``com.daml.lf.iface`` has moved
  to the new ``com.daml.lf.typesig`` package, with many accompanying
  name changes as documented in `issue #13669
  <https://github.com/digital-asset/daml/issues/13669>`__.

  Daml 2.5.0 or later will remove the old names, and also rename the
  Maven artifact from ``daml-lf-interface`` to
  ``daml-lf-api-type-signature``.  We recommend that users of this API
  use the deprecation guidance in 2.4.0 to port their applications
  before this happens.
CHANGELOG_END
2022-08-23 15:21:45 +00:00
Marton Nagy
2f90845cc2
Removes indexer benchmark binary, which is not an indexer benchmark. (#14791)
changelog_begin
changelog_end
2022-08-23 16:56:48 +02:00
dylant-da
a74c020ddd
Add version 1.15 - move interfaces into them (#14770)
* Add version 1.15 - move interfaces into them

* Update Ast/Version & docs for 1.15, split interface into simple/extended

* Stage 1.15 protobuf

* Remove references to dev from 1.15 protobufs

* Add Tests file for 1.15 in ledger API testtool

* Update Version 1.15 changelog with Call/implements

* Make 1.14 default again

* Add 1.15 as preview version

* Add 1.15 test suite to testtool

* Reinclude 1.15 in COMPILER_LF_VERSIONS to build model-tests-1.15

* Move v1_15 ledger-api-tests into own suite

* Fix InterfaceNotSupported message to 1.15 or higher

* satisfy changelog check

CHANGELOG_BEGIN
CHANGELOG_END

* Update tests with extended interface features to only run on 1.dev

* Allow unsafe_from_interface and interface_template_type_rep in 1.15

* Fix StableVersions back to 1.14, make EarlyAccessVersions 1.15

* Run retroactive implements tests only in extended interfaces

* lint

* Temporarily disable 1.15 conformance tests - handle in another PR

* Also disable conformance-test-tls1.2-or-newer-1.15

* Disable PureConfigReaderWriter tests that assume early-access == stable

* lint
2022-08-23 13:39:16 +00:00
Nicu Reut
ac3d5f9bf9
rs-grpc-bridge - Close gRPC client call when downstream cancels and no elements were received [KVL-1544] (#14771) 2022-08-23 12:41:19 +00:00
azure-pipelines[bot]
ec4c86ac2d
update NOTICES file (#14790)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
2022-08-23 10:29:31 +02:00
atriantafyllos-da
7ff003a6aa
Rename the leeway options [DPP-1183]. (#14679)
* Rename the leeway options [DPP-1183].

CHANGELOG_BEGIN
CHANGELOG_END
2022-08-23 10:24:41 +02:00
azure-pipelines[bot]
0c7b20f811
bump canton to 20220822 (#14787)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
2022-08-23 10:13:06 +02:00
tudor-da
ba6f377f29
Adds release notes for LLP performance improvements (#14784)
changelog_begin
Ledger API clients will see a reduction in latency of ~50 milliseconds for end-to-end requests in the Canton participant because the following optimizations were made:
* New buffering and caching efficiencies.
* Removed a fixed latency polling step.
* Under low load, introduced a processing optimization in the ingestion to the Index database, which allows updates to be stored immediately to the index DB. However, batching of updates still happens under high load for increased efficiency.

These optimizations significantly speed up integration testing during development and allow a better user-experience in production due to a swifter reaction to the ledger.
changelog_end
2022-08-23 08:06:44 +00:00
Chun Lok Ling
56a4d6476f
Added logging for time elapsed of ledger client call (#14711)
* Added logging for time elapsed of ledger client call

CHANGELOG_BEGIN
CHANGELOG_END

fixes #14673

* rename logging def

* ADDED TODO

* ADDED TODO

* pass in boolean for determining if it should log based on the log level

* address Ray's comment. Wrong name Ledge -? Ledger

* make isEnable public and use it to determin whether it is debug level

* refactoring. put everything in a inner object LedgerClientRequestTimeLogger

* remove useless line

* address Ray's comment

* address Ray's comment

* log the time used for source as well

* address Stephen's address
2022-08-22 21:14:38 +01:00
Sergey Kisel
2cecaf9726
Package Upload within interface subscription conformance test [DPP-1159] (#14768)
Package Upload within interface subscription conformance test [DPP-1159]

CHANGELOG_BEGIN
CHANGELOG_END
2022-08-22 18:59:03 +02:00
Sergey Kisel
6382d5b619
Cleanup unused classes. (#14781)
* Cleanup unused classes.

CHANGELOG_BEGIN
CHANGELOG_END
2022-08-22 18:16:55 +02:00
Moisés Ackerman
95d00c4e8a
Add conformance test for retroactive interface instances (#14753)
changelog_begin
changelog_end

Co-authored-by: Remy <remy.haemmerle@daml.com>
2022-08-22 13:58:24 +02:00
Gary Verhaegen
64378a2ff5
release: prepare for 2.3.3 (#14775)
This is a Canton-only fix, so no change in source SHA on this side.

CHANGELOG_BEGIN
CHANGELOG_END
2022-08-22 13:38:30 +02:00
azure-pipelines[bot]
b66e3b74d2
bump canton to 20220819 (#14776)
* bump canton to 20220819

CHANGELOG_BEGIN
CHANGELOG_END

* Fix canton bootstrap script

Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
Co-authored-by: Rafael Guglielmetti <rafael.guglielmetti@digitalasset.com>
2022-08-22 11:34:49 +02:00
Carl Pulley
c69548fe21
Quick fix for interface and transaction versioning issues
CHANGELOG_BEGIN

* Ensure SBUBeginExercise has a version that is max(template version, interface version)

CHANGELOG_END
2022-08-22 10:01:18 +01:00
azure-pipelines[bot]
211d1a88e3
update NOTICES file (#14779)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
2022-08-22 10:07:18 +02:00
Simon Maxen
937f8d1d45
Switch metering report to using Struct [DPP-1135] (#14767)
* Switch metering report to using Struct

changelog_begin
changelog_end
2022-08-22 08:55:06 +01:00
Sergey Kisel
1f7dd3c018
Conformance Tests for Interface Subscriptions [DPP-1159] (#14750)
* Conformance Tests for Interface Subscriptions [DPP-1159]

CHANGELOG_BEGIN
CHANGELOG_END
2022-08-22 08:01:47 +02:00
Simon Maxen
24268b25ae
Update yarn lock (#14769)
changelog_begin
changelog_end
2022-08-19 16:35:06 +01:00
Remy
28f261ab5d
LF: Drop old deprecate definition (#14761)
CHANGELOG_BEGIN
CHANGELOG_END
2022-08-19 15:48:42 +02:00
Remy
769e26e104
LF: Remove unecesary spaces in LF snippet (#14762)
CHANGELOG_BEGIN
CHANGELOG_END
2022-08-19 15:29:32 +02:00
Remy
48abfeb9dc
LF: distinguish template Id from interface Id in exercise command (#14755)
preliminary work for #14747

CHANGELOG_BEGIN
CHANGELOG_END
2022-08-19 14:00:40 +02:00