Commit Graph

9013 Commits

Author SHA1 Message Date
Marton Nagy
54339ada82
Safeguard Oracle CI tests with lockIdSeed [DPP-802] (#12573)
* Fixes OracleAround so it creates unique oracle users
* Fixes rouge connection pool in JdbcLedgerDaoTransactionsSpec
* Fixes cleanup in OracleAroundAll
* Introduces lockIdSeed for test frameworks
* Adapts usage

changelog_begin
changelog_end
2022-01-26 00:54:17 +01:00
Gary Verhaegen
5cccec2fe3
release: use-devenv (#12583)
CHANGELOG_BEGIN
CHANGELOG_END
2022-01-25 20:58:51 +00:00
Gary Verhaegen
90aacea36c
split-release (#12577)
The main goal here is to discover how I screwed up in #12574 and #12575.

CHANGELOG_BEGIN
CHANGELOG_END
2022-01-25 19:11:41 +00:00
Simon Maxen
cc19df44a8
Persist transaction metering info [DPP-814,DPP-821] (#12274)
* Add transaction metering information to batch and persist to database

changelog_begin
Transaction Metering now persisted to database
changelog_end
2022-01-25 18:29:49 +00:00
Sofia Faro
cb77c84cc7
damlc: Don't rely on worker for zero argument polymorphic type constructors (#12581)
* damlc: Don't rely on polymorphic constant worker

Fixes https://github.com/digital-asset/daml/issues/12166 which was
caused by assuming that GHC would create a "worker function" for
all constructors. GHC doesn't create one if the constructor takes
no arguments. This only caused a problem with partially applied
constructors, so, it only applies to zero argument constructors of
polymorphic types in situations where the type argument is eta-reduced.

changelog_begin
changelog_end

* rename the test file

* Update compiler/damlc/daml-lf-conversion/src/DA/Daml/LFConversion.hs

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
2022-01-25 18:26:14 +00:00
Gary Verhaegen
ed33c0d5db
split: flat(ter) files in Artifactory (#12575)
The github/split-release split doesn't make sense at this level.

CHANGELOG_BEGIN
CHANGELOG_END
2022-01-25 16:41:55 +01:00
Gary Verhaegen
e355832bc1
split: do not push exe (#12574)
In the split release process, the executable installer has to be created
later in the pipeline, once we have the Canton parts available.

CHANGELOG_BEGIN
CHANGELOG_END
2022-01-25 16:29:57 +01:00
Gary Verhaegen
0afc4a5553
split: do not tag (#12569)
We use tags to track releases; in particular, we want tags to correspond
to GitHub releases. In the split release process, the `assembly` repo is
responsible for creating GitHub releases, so it would make sense that it
is also the one responsible for creating tags.

I would also like to take this opportunity to manually remove all the
tags that have been created by the split release process so far and that
don't correspond to any release (which is all of them as we haven't done
a full split release yet), since they have already caused some
confusion.

CHANGELOG_BEGIN
CHANGELOG_END
2022-01-25 15:39:12 +01:00
Remy
ebf7908007
LF: check contracts are consumed when found them in the cache (#12527)
fixes #11874

CHANGELOG_BEGIN
CHANGELOG_END
2022-01-25 13:33:54 +00:00
Moritz Kiefer
ce06eb00fb
Add serializability check for interface payloads in Haskell (#12560)
* Add serializability check for interface payloads in Haskell

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* cleanup

changelog_begin
changelog_end

* .

changelog_begin
changelog_end
2022-01-25 14:20:25 +01:00
Moritz Kiefer
aced78f0b4
Drop dadew uninstall (#12566)
Shouldn’t be necessary anymore now that all nodes have been reset and
it makes things slower and potentially more flaky.

changelog_begin
changelog_end
2022-01-25 12:11:16 +00:00
Samir Talwar
ac3ca1d20c
ledger-api-test-tool: Enable command deduplication tests by default [KVL-1261] (#12541)
* ledger-api-test-tool: Enable command deduplication tests by default.

CHANGELOG_BEGIN
- [Ledger API Test Tool] More command deduplication tests have been
  enabled by default. This should not affect testing a fully functioning
  ledger. If any tests fail, they can be temporarily excluded.
CHANGELOG_END
2022-01-25 12:51:45 +01:00
Victor Peter Rouven Müller
5f58698ba6
[JSON-API] Add list-specific-users-rights, grant & revoke user rights endpoints (#12352)
* Add an endpoint used for querying user rights of a specific user

changelog_begin

- [HTTP-JSON] Added endpoint /user/rights that if called with POST will return user rights of the user specified via the payload

changelog_end

* Add grant&revoke user rights endpoint

changelog_begin

- [HTTP-JSON] Added endpoints user/rights/grant & user/rights/revoke which allow granting & revoking user rights for a specific user

changelog_end

* Switch to using the UserRights list instead of a case class with fields

* fix type annotation

* Rename allocateUser func to createUser to comform with the endpoint path

* Response format simplification & cleanup

* Add one last test that ensure that the JSON format of UserRight doesn't change without us noticing

* Apply suggestions from code review

Co-authored-by: Stephen Compall <stephen.compall@daml.com>

* Remove unnecessary conversations and also just use unwrap for tagged strings

Co-authored-by: Stephen Compall <stephen.compall@daml.com>
2022-01-25 11:21:55 +00:00
Moritz Kiefer
42aadec073
Cleanup Haskell serializability check (#12565)
I got unreasonably confused why we sometimes pass `Nothing` here and
why the templates are sometimes unused so this PR attempts to clarify
this a bit.

changelog_begin
changelog_end
2022-01-25 10:03:30 +00:00
tudor-da
5d93eb93e8
Engine stacktraces are disabled by default (#12562)
changelog_begin
changelog_end
2022-01-25 09:02:29 +00:00
pbatko-da
42d86acd06
[User management] Disabling user management in auth when user management feature is disabled [DPP-827] (#12503)
CHANGELOG_BEGIN
CHANGELOG_END
2022-01-25 09:55:37 +01:00
azure-pipelines[bot]
13153de88f
update NOTICES file (#12564)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
2022-01-25 08:18:11 +01:00
Moritz Kiefer
5bfe4ed589
Wait for server process in client_server_test (#12551)
withCreateProcess kills the server process but it doesn’t wait for it
to finish. The `typed-process` version does things properly here which
is also why we switched to it in other places.

changelog_begin
changelog_end
2022-01-24 20:21:23 +00:00
Stefano Baghino
f1cd4b1c7c
Remove dependencies on compatibility libraries (#12548)
Continues the work started in https://github.com/digital-asset/daml/pull/12543

These libraries were only needed to transition from Scala 2.12 to 2.13
and are no longer useful as all the necessary items are now available
in Scala 2.13.

changelog_begin
changelog_end
2022-01-24 18:04:07 +00:00
Moisés Ackerman
dcd721da99
Drop scenarios (#12484)
* Remove scenarios from user examples

* Remove scenarios from tests

* implicitly enable scenario service for doctests

changelog_begin
changelog_end
2022-01-24 18:42:42 +01:00
Gary Verhaegen
170d839ed0
Fix es (#12554)
It's down again. I wish I knew why it does that.

CHANGELOG_BEGIN
CHANGELOG_END
2022-01-24 18:33:59 +01:00
Simon Maxen
8fa54c67ce
Experimental daml assistant support for metering report [DPP-816] (#12485)
* Add experimental Daml assistant support for ledger metering

CHANGELOG_BEGIN
Add experimental Daml assistant support for ledger metering
CHANGELOG_END

* Update with review comments

* Update with review comments
2022-01-24 16:11:59 +00:00
Moritz Kiefer
9802028380
Cut a new split release (#12547)
* Cut a new split release

I want one including the latest docs tweaks so I can pick them up in
the assembly repo.

changelog_begin
changelog_end

* bump to include msys fix

changelog_begin
changelog_end
2022-01-24 16:23:35 +01:00
Stefano Baghino
aec3390904
Replace silencer plugin with built-in warning configuration (#12543)
Since Scala 2.13.2, Scala introduced built-in support to
manage warnings in a more granular fashion, thus making
the silencer plugin we are currently using no longer
strictly useful. Removing compiler plugins also removes
friction from migrating to Scala 3 in the future. As a
cherry on top, the built-in warning configuration also
allows to check whether a `@nowarn` actually does
anything, allowing us to proactively remove unused
warnings should the need arise.

[Here][1] is s a blog post by the Scala team about it.

Warnings have been either solved or preserved if useful,
trying to minimize the scope (keeping it at the single
expression scope if possible). In particular, all
remaining usages of the Scala Collection API compatibility
module have been removed.

Using the silencer plugin also apparently hid a few
remaining usages of compatibility libraries that were used
as part of the transition from Scala 2.12 to Scala 2.13
that are no longer needed. Removing those warnings
highlighted those.

changelog_begin
changelog_end

[1]: https://www.scala-lang.org/2021/01/12/configuring-and-suppressing-warnings.html
2022-01-24 15:01:35 +00:00
Stefano Baghino
93cfe043f8
Remove from the Java bindings constructors that were deprecated since 0.x (#12536)
changelog_begin
[Java bindings] `DamlLedgerClient.forLedgerIdAndHost` and `DamlLedgerClient.forHostWithLedgerIdDiscovery` static methods
and the constructor taking a `ManagedChannel`, which were all deprecated since 0.13.38, have been removed.
changelog_end
2022-01-24 14:43:01 +00:00
tudor-da
8d65aa3b4d
Remove Sandbox classic stores and related unit tests (#12532)
* Remove Sandbox classic stores and related unit tests

changelog_begin
changelog_end

* Add missing test case in SequenceSpec
2022-01-24 15:03:27 +01:00
Moritz Kiefer
24b2325d19
Bump node-fetch to address dependabot alerts (#12553)
changelog_begin
changelog_end
2022-01-24 13:23:52 +00:00
Gary Verhaegen
fdb034ca94
split-release: Canton dependencies to public GCS (#12552)
CHANGELOG_BEGIN
CHANGELOG_END
2022-01-24 13:19:18 +00:00
Moritz Kiefer
3f8ec07bdf
Upgrade to the latest Canton snapshot (#12544)
* Upgrade to the latest Canton snapshot

Nothing super important that we need in there but I’d rather sync more
than less frequently.

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end
2022-01-24 12:48:34 +00:00
Sofia Faro
8692d80b33
Fix trigger compat test for canton sandbox (#12549)
This fixes the timeout on trigger compat tests for the new sandbox (with LF >= 1.14).

The issue was that the trigger was "readAs"-ing with a party that
doesn't exist, since party ids aren't predictable with the new sandbox.

The solution is to allocate the Alice party ahead of time, and then
pass the allocated party in when calling `daml trigger`.

changelog_begin
changelog_end
2022-01-24 12:24:33 +00:00
Remy
3ea8aded13
LF: Test evaluation order of exercise and exercise_by_key (#12519)
CHANGELOG_BEGIN
CHANGELOG_END
2022-01-24 12:23:31 +00:00
Stefano Baghino
36f8d67c59
Upgrade css-loader to 5.2.7 (#12550)
changelog_begin
changelog_end

Fixes the transitive vulnerable dependency on `nanoid`.

Verified via `yarn audit`. Ran a quick manual test to check that
this did not break `navigator`.
2022-01-24 12:07:21 +00:00
Moritz Kiefer
a150737d17
Upgrade msys2 (#12545)
* Upgrade msys2

We’ve seen some weird errors with outdated signatures and it seems
plausible that an upgrade may help.

changelog_begin
changelog_end

* .

changelog_begin
changelog_end
2022-01-24 10:58:34 +00:00
Simon Meier
01447fd489
docs: typos and minor clarification for authz docs (#12534)
CHANGELOG_BEGIN
CHANGELOG_END
2022-01-24 10:42:30 +01:00
Moritz Kiefer
fbf244e2f8
alert on invalid users in create-daml-app (#12518)
`alert` isn’t exactly great error handling but matches what we do in
other places of create-daml-app and I’m not all that keen on reworking
that everywhere for 2.0

fixes #12275

changelog_begin
changelog_end
2022-01-23 10:28:48 +01:00
azure-pipelines[bot]
f2b4abe187
update NOTICES file (#12542)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
2022-01-23 10:27:34 +01:00
tudor-da
bd0ae0239b
Startup initialization header for runners [DPP-860] (#12525)
* Startup header of kvutils Runner

changelog_begin
changelog_end

* Added initialization header for Sandbox-on-X

* Updated Sandbox-on-X init message

* Updated initialization log for kvutils.Runner
2022-01-21 21:11:22 +00:00
Marton Nagy
15c0ad7efa
Migration DB unit testing for PostgreSQL v111 to v116 [DPP-756] (#12517)
* Adding minimal dynamic framework of independent DB migration unit testing
* Implementing (relevant parts of) PG 111 and 116 DB schema
* Adding test scenarios to test data migration for string interning and create-filter table population

changelog_begin
changelog_end
2022-01-21 20:41:39 +01:00
Samir Talwar
7218e6f95d
ledger-api-test-tool: Remove retired tests. (#12535)
CHANGELOG_BEGIN
- [Ledger API Test Tool] The retired test suites, ``LotsOfPartiesIT``
  and ``TransactionScaleIT``, have been removed in favor of more
  targeted benchmarking tests. If you are actively including these tests
  in your test run, you will need to remove them. These tests are
  disabled by default so it is likely that no change will be needed.
CHANGELOG_END
2022-01-21 16:46:13 +00:00
Simon Maxen
cbb4986e89
Add Empty GRPC Metering Report Service [DPP-856] (#12515)
* With mock metering service

* Reformat

changelog_begin
changelog_end

* Include nanos in generation time

* Update with review comments

* Update service count
2022-01-21 16:39:16 +00:00
Samir Talwar
4d26f0899e
ledger-api-test-tool: Enable ParticipantPruningIT for everyone. [KVL-1261] (#12529)
* ledger-api-test-tool: Enable `ParticipantPruningIT` for everyone.

CHANGELOG_BEGIN
- [Ledger API Test Tool] The ``ParticipantPruningIT`` test case has
  been enabled by default. You may need to disable specific test cases
  accordingly.
CHANGELOG_END

run-full-compat: true

* Enable more ParticipantPruningIT tests across the board.

* ledger-api-test-tool: Exclude a multi-participant test by default.

The test, `PRImmediateAndRetroactiveDivulgence`, will now only run if
more than one participant is specified.

* ledger-api-test-tool: Use a `for` comprehension for readability.

Co-authored-by: tudor-da <tudor.voicu@digitalasset.com>

Co-authored-by: tudor-da <tudor.voicu@digitalasset.com>
2022-01-21 16:16:57 +00:00
Samir Talwar
3044958cdf
ledger-api-test-tool: Remove deprecated options. (#12533)
CHANGELOG_BEGIN
CHANGELOG_END
2022-01-21 16:00:33 +00:00
Marton Nagy
5ab9eae033
Make mutable-contract-state-cache the default and only option (#12528)
* remove configuration flag
* remove ReadOnlySqlLedgerWithTranslationCache
* adapt condebase

changelog_begin
changelog_end
2022-01-21 16:47:33 +01:00
Simon Meier
89d95e6d6c
user management: allow ':' in user ids (#12531)
Fixes #12520

CHANGELOG_BEGIN
CHANGELOG_END
2022-01-21 15:39:42 +00:00
Samir Talwar
f5d7821ace
compatibility: Disable MultiParticipantIT for old versions. (#12526)
They don't support the `definite_answer` gRPC error metadata entry.

CHANGELOG_BEGIN
CHANGELOG_END
2022-01-21 16:08:14 +01:00
pbatko-da
2deeabf3fa
[User management] Add feature flag to enable user management [DPP-827] (#12420)
CHANGELOG_BEGIN
Sandbox: Participant server now supports '--feature-user-management' flag to turn on or off user management feature.
CHANGELOG_END
2022-01-21 14:05:41 +01:00
Moritz Kiefer
b843117501
Drop feature flag for v0 cid support (#12522)
I’ve kept it on the same test infrastructure that we used before that
can test both ways since it seems nicer to keep this consistent with v1.

changelog_begin
changelog_end

Breaks-protobuf: true
2022-01-21 12:54:08 +00:00
Brian Healey
73277f4210
Upgrade to oracle 19.14 image for ci (#12523)
CHANGELOG_BEGIN
CHANGELOG_END
2022-01-21 07:50:55 -05:00
Hubert Slojewski
cdde8df9fd
ledger-api-test-tool: Add assertions and a test case for successful completions when converting deduplication durations to offsets [KVL-1220] (#12462)
CHANGELOG_BEGIN
CHANGELOG_END
2022-01-21 13:44:24 +01:00
tudor-da
2267d1a15d
sandbox-classic uses Sandbox-on-X internals [DPP-860] (#12466)
* Sandbox-classic uses Sandbox-on-X internals

changelog_begin
changelog_end

* Removed conformance tests targeting in-memory ledger

* Adapt pruning test exclusions

* Refactoring

* Dedicated execution context for resource management

* Rebased

* Keep Sandbox logging initialization header

* Addressed Samir's review comments

* Addressed Martino's review comments
* Wired more CLI params from SandboxConfig to SoX config
2022-01-21 09:44:26 +00:00