* Define DA.Bazel.Runfiles.locateResource as an alternative to locateRunfiles
* Use locateResource to get default dlint rules file
Fixes#15443
* Use locateResource to get scenario-service.jar
* Use locateResource to get ghc-pkg executable
* Use locateResource to get stable-packages directory
* Use locateResource to get ghcversion.h
* Use locateResource to get hpp executable
* Use locateResource to get builtin package dbs
* Drop unused function DA.Daml.Options.Types.getBaseDir
* Use locateResource to get d3{,plus}.min.js
* Use locateResource to get repl-service.jar
* data Resource now takes a runfilesPathPrefix instead of a runfilesPath
* Add hlint warning 'locateRunfiles/package_app'
* Let locateRunfiles crash when used outside of bazel target
* typo
updateTime can return an error and the code correctly tried to turn
that into invalidArgument and logged it. However, the Either returned
by that then got completely discarded and the overall request
succeeded which definitely seems like a bug.
I added a test and verified that it fails withotu this change.
The code seems fairly messy. There are a few reasons for that:
1. We use Future[Either[…]] and we treat failures in the Either
differently from future failures. I'm not quite convinced that
makes sense but for this PR I didn’t want to introduce unrelated
changed.
2. Future[Either[…]] without some form of EitherT is inherently messy
but afaik you don’t use cats here so I kept it like this.
Note: this _replaces_ 2.4.1 because, _if_ we want to have #15511 in the
next release, it doesn't really make sense (in my opinion) to go through
the rest of the 2.4.1 process.
Happy to discuss, though: it's possible we still want both releases,
it's also possible we don't really need #15511. I really don't have
enough context to say, so I'm just opening this to provide the option.
@chunlokling-da is taking care of [testing](https://github.com/digital-asset/daml/blob/main/release/RELEASE.md) today's release, so they get pushed back to the end of the line.
Please do not merge this before the release is fully tested.
CHANGELOG_BEGIN
CHANGELOG_END
Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
* Support for golden signals metrics on akka-http
Adds metrics support needed for throughput, error rate, latency,
and data size on both the classic http endpoints and
the websocket endpoints.
Installed the support on the JSON API endpoints.
CHANGELOG_BEGIN
JSON API - additional metrics for endpoints
daml_http_json_api_requests_total
daml_http_json_api_errors_total
daml_http_json_api_requests_duration_seconds
daml_http_json_api_requests_size_bytes
daml_http_json_api_responses_size_bytes
daml_http_json_api_websocket_messages_received_total
daml_http_json_api_websocket_messages_received_size_bytes
daml_http_json_api_websocket_messages_sent_total
daml_http_json_api_websocket_messages_sent_size_bytes
CHANGELOG_END
Co-authored-by: Miklos <57664299+miklos-da@users.noreply.github.com>
CHANGELOG_BEGIN
* triggers may now control (via configuration) the rate at which they submit commands to the ledger. Command submission may be rate limited (to control trigger burst behaviour) and ledger submissions will *only* occur if in-flight command submissions are below threshold values.
CHANGELOG_END
* point to updated GHC
* satisfy changelog
CHANGELOG_BEGIN
CHANGELOG_END
* Point to updated GHC
* Expect new interface view error message in ImplementsNonInterface
* Add test for trying to implement a non-interface
* Point to GHC with better error suppression, fix tests
* Remove unused TryImplementNonInterface
* Point to merged GHC
* add Contract, ContractId type params to ContractTypeCompanion
* move fromCreatedEvent, toContractId to ContractTypeCompanion
* ContractFilter can be simpler with this
* javadoc for toContractId
* Extract Ledger API error definitions in //ledger/error-definitions
changelog_begin
SERVICE_INTERNAL_ERROR error code is created in CommonErrors and replaces the usage of LEDGER_API_INTERNAL_ERROR in ledger-api-client (as a fix).
changelog_end
* Tests in //ledger/error do not depend on //ledger/ledger-api-errors
* Remove unused dependency from //ledger/error
changelog_begin
changelog_end
* Address Martino's comment
* split JSON API production setup doc to separate documents
CHANGELOG_BEGIN
CHANGELOG_END
* remove json-api and production-setup TOCs
- properly placed in digital-asset/docs.daml.com#55
- suggested by @garyverhaegen-da; thanks
* Success!
* Remove dead / unnecessary code from debugging
* Remove unused `userWrittenTuple` helper
* Import `GHC.Types.magic` where necessary
* Test for example in issue #15338
* satisfy changelog check
CHANGELOG_BEGIN
CHANGELOG_END
* Remove fst/snd lint tests, which weren't correct/useful anyways
* Update DocTest to import GHC.Types where necessary
* Update desugar tests
* Fix daml repl to include GHC.Types import
* Add GHC.Types to the doctest
* style improvement: if cond then action else pure () -> when cond action
* Point to merged GHC
* do the module collision check on generated item only
* Revert "do the module collision check on generated item only"
This reverts commit a6a38425ab.
* added test for detectModuleCollisions
* added test to reproduce issue #15341
* Revert "Revert "do the module collision check on generated item only""
This reverts commit cd4c5a24fd.
* fix test case
* use `daml.lf.language.Reference.Module` instead
* add change log
CHANGELOG_BEGIN
Bug fix: Module name collision check performed on modules which is not to be generated #15340#15341
CHANGELOG_END
* remove debug log
* Minor renaming
* refine name test case name
* add comment
* format
Co-authored-by: Fayi Femi-Balogun <fayimora.femibalogun@digitalasset.com>
* Precompute ScalaPB serializedSize for stream messages
changelog_begin
Introduces a gRPC streams optimization targeting complex protobuf payloads.
When enabled, it can allow up to 60-80% throughput increase for GetTransactions/GetTransactionTrees/GetActiveContracts.
The optimization is toggleable by an additional config parameter for the API server: `api-server.optimize-grpc-streams-throughput`
changelog_end
* Address Marton's review comment
* Update ledger/participant-integration-api/src/main/scala/platform/store/ScalaPbStreamingOptimizations.scala
Co-authored-by: mziolekda <marcin.ziolek@digitalasset.com>
* Rename to withPrecomputedSerializedSize
Co-authored-by: mziolekda <marcin.ziolek@digitalasset.com>
@ray-roestenburg-da is taking care of [testing](https://github.com/digital-asset/daml/blob/main/release/RELEASE.md) today's release, so they get pushed back to the end of the line.
Please do not merge this before the release is fully tested.
CHANGELOG_BEGIN
CHANGELOG_END
Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
* Retire changelog entries mechanism
It is no longer used these days, so it simply imposes unnecessary
work. If it ever becomes useful again, retrieving the relevant
scripts from history should be relatively easy.
* Remove references to `unreleased.sh`
* Re-add `unreleased.sh` for summarization -- feedback from @mziolekda`
The comments refer to 0.x and can be misleading for 2.x users
(since the default is not 1.8 anymore and have not been for a
long time at this point). Furthermore, I am also relatively
sure that 1.8 is not even an option at all for 2.x users.
changelog_begin
changelog_end
Somehow our setup doesn't work with puppeteer 19+.
CHANGELOG_BEGIN
- GSG: Several TypeScript warnings have been fixed in the final "Testing
Your Web App" section of the Getting Started Guide. The
`create-daml-app` template includes an updated `config.ts` file, and the
documentation page as been updated to pin the `puppeteer` version to a
known-working one and tweak the `index.test.ts` file.
CHANGELOG_END