Commit Graph

8052 Commits

Author SHA1 Message Date
nickchapman-da
9c107a7aa8
Fix fishy discards (#11197)
* dont discard errors

CHANGELOG_BEGIN
CHANGELOG_END

* remove redundant match case
2021-10-12 11:18:34 +00:00
Robin Krom
9835ccb1ef
trigger runner: added hidden dev-mode-unsafe flag (#11205)
This adds a hidden `dev-mode-unsafe` flag to the trigger runner to allow
running against a daml-lf 1.dev version dar.

CHANGELOG_BEGIN
CHANGELOG_END
2021-10-12 10:54:23 +00:00
Gary Verhaegen
ae41aa2c14
releases: check component status page (#11116)
The component status page have been neglected as of late. Craig
suggested adding a step to the release checklist.

CHANGELOG_BEGIN
CHANGELOG_END
2021-10-12 11:46:01 +02:00
nicu-da
d045ffaf1f
Extract the envelope from daml_kvutils.proto [KVL-1090] (#11192)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-12 02:00:59 -07:00
Stefano Baghino
eb834907d7
Add @stefanobaghino-da and @adriaanm-da for approval of stable releases (#11203)
Also a couple of tweaks to `CODEOWNERS`

changelog_begin
changelog_end
2021-10-12 08:42:43 +00:00
azure-pipelines[bot]
2a6dd3db37
update NOTICES file (#11202)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
2021-10-12 10:35:44 +02:00
Robert Autenrieth
66adbc0366
DPP-463 switch conformance tests to append only (#11101)
* Use append-only schema in tests

changelog_begin
changelog_end

* Fix Oracle build

* Update ledger/ledger-on-memory/BUILD.bazel

Co-authored-by: tudor-da <tudor.voicu@digitalasset.com>

* Run more conformance tests on append-only

* Run pruning tests in split-participant mode

* Disable multi-participant test in split participant

* Add missing ContractIdIT test

Co-authored-by: tudor-da <tudor.voicu@digitalasset.com>
2021-10-11 23:31:30 +02:00
Miklos
7a54ca1926
Damlification of metrics prefix (#9665)
* Damlification of metrics prefix.
CHANGELOG_BEGIN
CHANGELOG_END

* Fixed reference to metrics prefix.

CHANGELOG_BEGIN
CHANGELOG_END
2021-10-11 19:00:27 +00:00
Robin Krom
3115d104aa
daml script interfaces (#11124)
* interfaces: introduce TemplateOrInterface class in stdlib

The template typeclass is to strong for many applications. The new
constraint `TemplateOrInterface` only contains the methods to convert
contract IDs and choices.

CHANGELOG_BEGIN
CHANGELOG_END

* ghc-lib update, interface script tests

* pinned stackage on unix

* added missing implementation in preprocessor

* added test

* fixing tests

* remove Iface type

* pinned stackage windows

* make sure createAndExercise is not called on interfaces
2021-10-11 18:22:40 +02:00
Remy
4af98a63a2
LF: clarify compilation of choice body. (#11195)
* LF: clarify compilation of choice Body.

This is a purely cosmetic choice.

We move up the intro of the choice arg binder to make it clear it
affect the compilation of every expression in the body of a choices (
namely controllers, observers, and update expression).

CHANGELOG_BEGIN
CHANGELOG_END

* formatting
2021-10-11 16:16:05 +00:00
nicu-da
d8651fae32
Extract configuration submission from daml_kvutils.proto [KVL-1090] (#11194)
CHANGELOG_BEGIN

CHANGELOG_END
2021-10-11 07:53:44 -07:00
nickchapman-da
67d4011fcd
Fix NonUnitStatements in daml-lf code (#11145)
* build daml-lf/* with lf_scalacopts_stricter; and fix NonUnitStatements

fix daml-lf/archive

CHANGELOG_BEGIN
CHANGELOG_END

fix daml-lf/data/

fix daml-lf/engine

fixes for scala 2.12

data-scalacheck, interface, kv-transaction-support: switch on; nothing to do

* daml-lf/parser -- switch on; nothing to do

* daml-lf/validation : switch on lf_scalacopts_stricter & fix wartremover:NonUnitStatements

* lf_scalacopts_stricter in daml-lf/transaction-test-lib

* lf_scalacopts_stricter in daml-lf/scenario-interpreter
2021-10-11 14:54:33 +01:00
Miklos
06834936bc
Removed InterpretationCostBasedLedgerWriterChooser*. (#11190)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-11 11:31:54 +00:00
Sofia Faro
174e23a6f8
interfaces: Sync InterfaceDesugared with Interface (#11191)
I think it's helpful for us to keep these two in sync.

changelog_begin
changelog_end
2021-10-11 12:22:02 +01:00
matevarga-da
61a5603acf
cheat sheet: update (#11133)
* cheat sheet: update
CHANGELOG_BEGIN
CHANGELOG_END

* cheat sheet: update 

CHANGELOG_BEGIN
CHANGELOG_END
2021-10-11 11:32:39 +02:00
Marton Nagy
af883fc109
Cleanup and activate unconditionally participant HA feature [DPP-497] (#10870)
* Removes flag and related configuration
* Removes unnecessary keepAlive approach from indexer

CHANGELOG_BEGIN
Participant HA feature added: Indexer component is guarded by database locks, and executes in a critical section (prevents overlapping indexer activity). Supported by Oracle and Postgresql database backends, and not supported by H2.
CHANGELOG_END
2021-10-11 11:13:15 +02:00
Robert Autenrieth
227a27daaa
DPP-641 Fix EndlessReadService and add tests (#11170)
* Fix EndlessReadService and add tests

changelog_begin
changelog_end

* Fix integrity query for H2
2021-10-11 11:10:12 +02:00
nicu-da
664aedd31b
Extract state.proto from daml_kvutils.proto [KVL-1090] (#11174)
CHANGELOG_BEGIN

CHANGELOG_END
2021-10-11 08:56:16 +00:00
Stefano Baghino
6f7ee0b092
Update issue templates (#11181)
* Update issue templates

Add two separate templates for bug reports and feature requests, explicitly ask for the affected Daml version for bug reports.

changelog_begin
changelog_end

* Apply suggestions from code review

Co-authored-by: Gary Verhaegen <gary.verhaegen@digitalasset.com>

Co-authored-by: Gary Verhaegen <gary.verhaegen@digitalasset.com>
2021-10-11 09:21:51 +02:00
azure-pipelines[bot]
a932c9ff0f
update NOTICES file (#11188)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
2021-10-11 09:09:17 +02:00
Stefano Baghino
12598df78f
Release SDK 1.17.1 (#11182)
changelog_begin
changelog_end
2021-10-11 09:04:21 +02:00
Artúr Poór
0f265fd715
[Docs] Improve manual-download.html phrasing. (#11084)
Emphasize that SDK version 1.4.0 was the latest at the time
of writing instructions, and is outdated now.

changelog_begin
changelog_end
2021-10-11 08:40:50 +02:00
nicu-da
9b2a8c7eb5
Enable top level statement blank lines scalafmt rule, which adds a blank line after imports (#11180)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-10 23:16:48 -07:00
Sofia Faro
7e2edbdfaf
interface fixed choices: Haskell Typechecker (#11177)
Part of #11137

changelog_begin
changelog_end
2021-10-08 15:42:29 +01:00
Sofia Faro
c876bd82a8
interfaces: Add a test for runtime errors (#11179)
changelog_begin
changelog_end
2021-10-08 15:27:24 +01:00
nicu-da
ce24fc8679
Update scalafmt to 3.0.6 (#11178)
* Update scalafmt to 3.0.6

CHANGELOG_BEGIN

CHANGELOG_END

* Disable just docstring wrap for the new scalafmt version
2021-10-08 13:36:36 +00:00
Samir Talwar
e15487422d
kvutils: Add a SubmissionInfo parameter to the replaying read service. [KVL-1082] (#11169)
* kvutils: Tidy up LogAppendingReadServiceFactorySpec.

* kvutils: Add a `SubmissionInfo` parameter to the replaying read service.

Required for other KV ledger implementations.

CHANGELOG_BEGIN
CHANGELOG_END

* kvutils: Rename some constants in LogAppendingReadServiceFactorySpec.
2021-10-08 13:48:24 +02:00
nicu-da
5abedac9ab
Check the commit message to skip the compatibility check [KVL-1111] (#11162)
* Check the commit message to skip the compatibility check

CHANGELOG_BEGIN

CHANGELOG_END

* Use git trailers to skip the check conditionally
2021-10-08 02:18:36 -07:00
Samir Talwar
d3810af47e
CI: Upgrade Nix. (#11173)
Inspired by seeing `curl` TLS errors in a different repository's CI.

I don't know if this will help, but it's worth a try. Note that the
domain name has changed.

CHANGELOG_BEGIN
CHANGELOG_END
2021-10-08 09:13:50 +00:00
Remy
4336184a79
LF: Add interface fixed choices in scala AST and type checker (#11146)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-08 08:59:26 +02:00
Gary Verhaegen
08b9f82614
fix templates build for Windows (#11165)
On Windows, we run without a sandbox, which means that the `gsg-trigger`
folder might already exist and be patched, because we work directly in
the source tree.

This changes the script to work with temp dirs instead.

CHANGELOG_BEGIN
CHANGELOG_END
2021-10-07 18:25:05 +02:00
Gary Verhaegen
fcd4549569
test release rotation: factor out selection (#11161)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-07 12:46:55 +00:00
Remy
dd233ef155
LF: clean daml-lf/language module (#11152)
- enable NonUnitStatements, and find a useless statement.

- add missing `final`s,

- replace `{ ... }` by `( ... )` for one statement anonymous function

- drop useless `new` for case class.

- replace `sealed class X { ... object Y extend X` by
  `class X private[Z] { ... val Y = new X` to avoid unecessary class
  alocation.

- move invariant check inside the body of some case class instead of
  the companion object.

- other cosmetic changes.

CHANGELOG_BEGIN
CHANGELOG_END
2021-10-07 13:56:36 +02:00
Hubert Slojewski
15712a2a33
Add a missing test and documentation for the gRPC error factory [KVL-1119] (#11106)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-07 11:10:48 +00:00
Sofia Faro
53c76d47c3
interface fixed choices: Haskell AST (#11160)
* interface fixed choices: Haskell AST

Part of #11137

changelog_begin
changelog_end

* Make intParam strict
2021-10-07 10:46:50 +00:00
azure-pipelines[bot]
4cb46f2742
update compat versions for 1.17.1-snapshot.20211006.7853.0.e05be365 (#11153)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
2021-10-07 12:18:56 +02:00
nicu-da
a3b90499fd
Check proto compatiblity with target head for PRs [KVL-1110] (#11123)
* Add the ability to check protobuf compatibility with the branch head alongside the latest release tag.

CHANGELOG_BEGIN
CI - add check to PR for protobuf breaking changes against the target branch head
CHANGELOG_END
2021-10-07 08:55:38 +00:00
Hubert Slojewski
b9e8eb81e8
daml-script: Switch integration-tests to the append-only-schema (#11149)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-07 10:18:29 +02:00
Stefano Baghino
265e36255c
Add a notice to the release testing rotation file (#11142)
Reminds people adding new users to the rotation that they should also
be added to DACH-NY/daml-language-ad-hoc to have a box in the cloud
for Windows testing.

Adds the possibility of adding comments at the beginning of the rotation file.

changelog_begin
changelog_end
2021-10-06 21:08:11 +00:00
fabiotudone-da
4295ecd1d0
Fix compatibility exclusions introduced by #11095 [KVL-1083] (#11141)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-06 21:58:33 +02:00
Gary Verhaegen
4f805c4013
1.17.1 RC2 (#11148)
RC1 did not include #11102.

CHANGELOG_BEGIN
CHANGELOG_END
2021-10-06 20:04:17 +02:00
azure-pipelines[bot]
1e9089552f
rotate release duty after 1.18.0-snapshot.20211006.8003.0.cfcdc13c (#11135)
@adriaanm-da is taking care of 1.18.0-snapshot.20211006.8003.0.cfcdc13c (#11134), so they get pushed back to the end of the line.

Please do not merge this before #11134.

CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
2021-10-06 17:13:01 +02:00
Sofia Faro
7f6c8608bd
Interface fixed choices: protobuf (#11139)
Adds protobuf for fixed choices. ASTs left for later.

changelog_begin
changelog_end
2021-10-06 16:01:41 +01:00
tudor-da
325c5ac303
Release RC for SDK 1.17.1 (#11138)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-06 14:58:36 +02:00
nickchapman-da
1522c84bae
Unit tests for FailedAuthorization (#11082)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-06 12:25:42 +01:00
Andreas Herrmann
51873ff344
Support empty party display name in scenario service (#11131)
* Add regression test for #11099

https://github.com/digital-asset/daml/issues/11099

* Support empty party display name in scenario service

changelog_begin
- [Daml Studio] Scripts no longer fail when allocating a party with an
  empty display name. See https://github.com/digital-asset/daml/issues/11099.
changelog_end

* fmt

Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
2021-10-06 10:28:11 +00:00
Gary Verhaegen
4cb521b406
don't remove Standard-Change label on failed releases (#11126)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-06 12:12:11 +02:00
azure-pipelines[bot]
261d4db656
update NOTICES file (#11136)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
2021-10-06 11:24:17 +02:00
azure-pipelines[bot]
deddfd7ec8
release 1.18.0-snapshot.20211006.8003.0.cfcdc13c (#11134)
This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@adriaanm-da is in charge of this release.

Commit log:
```
cfcdc13c6e Add deprecation output for sandbox classic (#11119)
ac5c52dbe4 DPP-609 Add StorageBackendTestsDeduplication (#11088)
55af7ad729 HttpServiceTestFixture provides a sandbox-classic ledger used for performance tests (#11128)
63ab3f3e50 Fix change ID references in services.rst (#11130)
31db15d555 Port error code changes (#11113)
9fd8182bbb move reusable functions from ContractsFetch to new fetch-contracts library (#11057)
c2084f6e14 Try and improve the explanation of compatibility test exclusions (#11114)
4df9b7c8f1 Rename command completion dedup time to duration in participant code [KVL-1057] (#10901)
11bc22d085 LF: builtins to create, signatory, and obersver on interface payload. (#11120)
d4cb1f945e KV ledgers: disable participant side command de-duplication [KVL-1083] (#11095)
b9a5a83175 Minor: fix trace logging in `TimeBasedWriteSetSelector` (#11117)
018e90854c [JSON-API] Make key_hash idx non unique  (#11102)
429f43731a Remove HA indexer integration test on H2 (#11104)
9cffa1faf6 LF: check LF transaction protobuf aginst local snapshots (#11064)
d7ee278518 Optional table prefix for trigger service  (#11047)
268b2d3da0 Command deduplication - test case that uses CommandService and CommandSubmissionService [KVL-1106] (#11098)
fac05f657b bypass value enrichment for the performance test (#11112)
4860271a53 Port file was not written to... where? (#11108)
a8d703b996 Increase akka server request-timeout for HttpServiceIntegrationTests (#11109)
37d94aaef6 Add unit for daily performance tests (#11107)
eb4ac8a397 Increase timeouts for resetting database (#11103)
db75f7da0f interface methods: Scala Typechecker (#11097)
d3e6f16c61 [JSON-API] Migrating tests to use sandbox next (#11034)
ffc8d6894f Data dependencies deserialize imports (#11037)
4b31bf088f update compat versions for 1.17.0 (#11075)
9fd6326ae7 interfaces: consuming/non-consuming iface choices (#11009)
229ce4776f Data dependencies serialize imports (#11038)
5d9ec65cc6 Add test case for parallel command deduplication using mixed clients [KVL-1090] (#11093)
d64d965230 kvutils: Print state updates before and after normalization. (#11096)
be216aa872 update NOTICES file (#11089)
517e866df5 Extract common code for command dedup conformance tests [KVL-1090] (#11092)
7a4963b43d add `--max-inbound-message-size` flag to `daml ledger export` (#11087)
26d10b267d Drop NodeId type parameter (#10921)
3cbd9229aa More NonEmpty functions (#10930)
bcd468625c interface methods: Speedy (#11076)
85adaab550 [DPP-417][DPP-595] Error codes switching - follow-up (#11074)
d7b280b60c Remove debug print in daml-lf/interpreter build (#11091)
1ed6428980 LF: move archive snapshots in a separate directory (#11081)
5e424f8d1c Command dedup conformance suites readme (#11051)
8290347f74 DPP-496 HA indexer integration test (#11033)
735c3090a3 Switch from InputStream to Byte Array at the binary content JDBC transport (#11072)
6ae3afa8fb fix perf reporting (#11073)
bf801a6e1b Fix SimpleDeduplicationBasic when participant deduplication is disabled (#11083)
62234dc763 [Short] Remove unused code (#11079)
c1d1521a14 interface methods: Scala AST (#11070)
7dd9c2d3f0 Remove expectations for internal failures from parallel command dedup tests (#11061)
51125991e5 Explicit discard in daml-lf/interpreter (#11067)
554b36c817 rotate release duty after 1.18.0-snapshot.20210928.7948.0.b4d00317 (#11059)
d156964f0c Release SDK 1.17.0 (#11062)
6d8cf7089c Handle interface methods in LF conversion (#11054)
87ecf1fe63 daml-ledger: better errors for non-json responses. (#11055)
ec2d26f31f [Divulgence pruning] Fixes divulgence pruning offset update query (#11046)
f13c6d61ec release 1.18.0-snapshot.20210928.7948.0.b4d00317 (#11058)
d1805a3000 More dependabot fun (#11063)
07b273aab5 update NOTICES file (#11060)
```
Changelog:
```

- [JSON-API] make key_hash indexes non-unique, this fixes a bug where a duplicate key conflict was raised on the query store when the same contract was being witnessed twice by two separate parties

* [Trigger Service] Enable the new `tablePrefix` setting in the `--jdbc`
  flag to add a prefix to all tables used by the trigger service to
  avoid collisions with other components using the same db-schema.
* [Trigger Service] Enable the new ``--allow-existing-schema`` flag to
  initialize the trigger service on a database with a pre-existing
  schema.

- [Daml Assistant] Add support for `--max-inbound-message-size` flag to the Ledger Export tool.

Add cons, find, delete and deleteBy functions to NonEmpty module.
```

CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
2021-10-06 11:00:10 +02:00
Robert Autenrieth
cfcdc13c6e
Add deprecation output for sandbox classic (#11119)
changelog_begin
changelog_end
2021-10-06 00:04:18 +02:00