Commit Graph

1020 Commits

Author SHA1 Message Date
Moritz Kiefer
addb2edc03
Drop Scala 2.13 version guards from Bazel definitions (#11819)
changelog_begin
changelog_end
2021-11-22 17:37:49 +00:00
tudor-da
8e31e8e6a8
[Self-service error codes] Enabled by default [DPP-691] (#11685)
* [Self-service error codes] Enabled by default
* Flag changed to `use-pre-1.18-error-codes` (disabled by default)

CHANGELOG_BEGIN
[Ledger API Specification] The Ledger API returns enriched error codes (see https://docs.daml.com/error-codes/self-service/index.html)
For backwards-compatibility, a new API flag `--use-pre-1.18-error-codes` is introduced for preserving the legacy behavior for
clients that want to migrate incrementally to the changed gRPC status code responses and error details format.
CHANGELOG_END

* Adapted HttpServiceIntegrationTest

* Renamed `Feature Flag` to `Configuration` in docs

* Fix Daml Script tests

changelog_begin
changelog_end

* Fix Repl functests

changelog_begin
changelog_end

* Fix haskell binding tests

changelog_begin
changelog_end

* Fix CommandClientIT test

* Fixed Sandbox and CommandServiceBackpressureIT tests
 Please enter the commit message for your changes. Lines starting

* Adapt //compiler/damlc/tests:repl-functests again

* Fix more tests and address Miklos' comments
* Flag name changed to `grpc-status-codes-compatibility-mode`

* Remove useless flags sandbox-classic

* Sandbox-classic tests fix for ContractKeysIT and ExceptionsIT
* Created 2 deprecated test suites that have the more generic assertions as returned
by the deprecated in-memory backend

* More fixes for CommandServiceIT
* Fixes compilation issue with the deprecated exceptionsIT class for Sandbox-classic in-memory

* Compatibility mode for old test tools

* Change flag name to `use-pre-1.18-error-codes`

* Apply suggestions from code review

Co-authored-by: Miklos <57664299+miklos-da@users.noreply.github.com>

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Co-authored-by: Miklos <57664299+miklos-da@users.noreply.github.com>
2021-11-22 12:26:48 +00:00
pbatko-da
2e789ddf37
[DPP-417][Self-service error codes][Docs] Add more complete information for forking gRPC status codes. (#11739)
CHANGELOG_BEGIN
CHANGELOG_END
2021-11-18 17:03:10 +01:00
Miklos
4106222ab8
Fix docs regarding deduplication periods [KVL-1194] (#11738)
CHANGELOG_BEGIN
CHANGELOG_END
2021-11-18 11:45:01 +01:00
tudor-da
b0a1bf79df
More missing error codes (#11749)
* Missing error codes in Sandbox classic

CHANGELOG_BEGIN
CHANGELOG_END

* Covering more errors above the persistence layer

* Fix wrong contextualizedErrorLoggers

* Compilation fixes
2021-11-18 10:00:43 +00:00
Stephen Compall
7e4acf97fc
link to doc detailing gRPC-to-HTTP code mapping (#11742)
CHANGELOG_BEGIN
CHANGELOG_END
2021-11-17 15:44:08 +00:00
tudor-da
a05a40aeec
[Self-service error codes] Adapt ResetService in Sandbox classic (#11731)
CHANGELOG_BEGIN
CHANGELOG_END
2021-11-17 11:11:54 +01:00
pbatko-da
122a4ccd0d
[DPP-417][Self-service error codes][Docs] Mention that correlation id is usually submission id. (#11728)
CHANGELOG_BEGING
CHANGELOG_END
2021-11-17 08:07:44 +00:00
mziolekda
ccbf714078
expand the text about errors in the log [DPP-755] (#11723)
* expand the text about errors in the log

* scrap the entire logging section
2021-11-16 22:21:35 +00:00
tudor-da
fbc436d70a
[DPP-739][Self-service error codes] Adapt QueueBackedTracker error codes (#11719)
* [Self-service error codes] Adapt QueueBasedTracker

CHANGELOG_BEGIN
CHANGELOG_END

* Added changed error codes to migration guide

* Fixed ErrorFactoriesSpec

* Update ledger/error/src/main/scala/com/daml/error/definitions/LedgerApiErrors.scala

Co-authored-by: mziolekda <marcin.ziolek@digitalasset.com>

Co-authored-by: Pawel Batko <pawel.batko@digitalasset.com>
Co-authored-by: mziolekda <marcin.ziolek@digitalasset.com>
2021-11-16 22:21:29 +00:00
pbatko-da
07cff7cdb7
[DPP-417][Self-service error-codes] Document error categories. (#11727)
* [Self-service error-codes] Docs intro WIP

* CHANGELOG_BEGIN
CHANGELOG_END

* 1

* Fix rst

CHANGELOG_BEGIN
CHANGELOG_END

* [DPP-417][Self-service error-codes] Document error categories.

CHANGELOG_BEGIN
CHANGELOG_END

* 1

* Fix
2021-11-16 22:55:35 +01:00
tudor-da
c1f4beb328
Ledger ID mismatch does not change error codes. (#11720)
* Remains NOT_FOUND

CHANGELOG_BEGIN
CHANGELOG_END
2021-11-16 17:05:09 +00:00
pbatko-da
a29fee925c
[Self-service error-codes] Add introductory section to self-service error codes page. (#11712) 2021-11-16 16:41:41 +01:00
tudor-da
05f604d672
[Self-service error codes] Enrich migration guide [DPP-755] (#11711)
* Adapted migration guide to include changes from https://github.com/digital-asset/daml/pull/11686

CHANGELOG_BEGIN
CHANGELOG_END

* Enriched migration guide with Sandbox-classic changed gRPC error codes

* Added migration guide for error codes changed in KV committer

* Extract the KV and Sandbox-classic migration guides

* Hierarchical order of error codes docs

* Added back full grpc error code description to columns
* Using "gRPC status code" instead of "gRPC error code"
* Addressed review comments from Hubert

* Apply suggestions from code review

Co-authored-by: Miklos <57664299+miklos-da@users.noreply.github.com>

* Addressed review comments
* Use 'Error codes' instead of 'Self-service error codes'

Co-authored-by: Miklos <57664299+miklos-da@users.noreply.github.com>
2021-11-16 14:25:53 +00:00
tudor-da
ec6d7cc3db
[Self-service error codes] Error code definitions revisiting [DPP-675] (#11686)
* Error definitions revisiting and hierarchical grouping refactoring

CHANGELOG_BEGIN
CHANGELOG_END

* Full hierarchical path for error grouping

* Addressed Pawel's review comments

* Apply suggestions from code review

Co-authored-by: mziolekda <marcin.ziolek@digitalasset.com>
Co-authored-by: pbatko-da <pawel.batko@digitalasset.com>

* Do not strip margin in error code explanations

* Revert changing LEDGER_ID_MISMATCH from NOT_FOUND to FAILED_PRECONDITION

Co-authored-by: mziolekda <marcin.ziolek@digitalasset.com>
Co-authored-by: pbatko-da <pawel.batko@digitalasset.com>
2021-11-15 21:28:13 +00:00
pbatko-da
81e24504d4
[DDP-596][Self-service error codes] Add migration guide (#11632)
CHANGELOG_BEGIN
CHANGELOG_END
2021-11-12 10:07:37 +01:00
Stephen Compall
22d916baed
party-set arguments for JSON API (#11454)
* add actAs, readAs to `meta` for create, exercise, createAndExercise endpoints

* use meta actAs, readAs to control how contract IDs are looked up for exercise

* outdated comments on JwtWritePayload and JwtPayload

* toSet1 operator to clean up some NEL manipulation

* take optional readAs argument for query endpoint

* use readAs for query POST

* check whether readAs is safe in query endpoint

* missed CommandMeta args in tests

* FetchRequest, a domain model to layer on "fetch" endpoint's ContractLocator

- ContractLocator was overloaded as a domain request model *and* a component
  of other domain request models; the addition of new arguments means it can
  no longer exactly meet the former, and adding "readAs" to it would poison it
  for the latter cases.

* take readAs argument from fetch endpoint

* add readAs security check from query to fetch

* move jwt parties functions to util

* testing the party-set/JWT functions

* missing headers

* caught boolean blindness in readAs security checks

* test that meta params are used for commands

* make resolveRefParties do a subset check, too

* Revert "make resolveRefParties do a subset check, too"

This reverts commit 40a66f102c.

* test that the readAs auth check actually applies

* test that command service uses meta readAs, actAs

* note on test coverage

* add changelog

CHANGELOG_BEGIN
- [JSON API] ``actAs`` and ``readAs`` may be specified for create, exercise,
  create-and-exercise, non-WS fetch, and non-WS query.
  See `issue #11454 <https://github.com/digital-asset/daml/pull/11454>`__.
CHANGELOG_END

* no saving mallocs

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

* untabify

Co-authored-by: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>

* move design comment to comment from function name

- suggested by @cocreature; thanks

* remove unneeded variable

* refactor single-key callers of requestJsonReader

- suggested by @cocreature; thanks

* build error in ce

* diagnose Windows failure

* add missed http-json-testing requirement

* use readers as fetch/query party-set name

- suggested by @cocreature and @realvictorprm, thanks

* extra import

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Co-authored-by: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>
2021-11-12 02:10:15 +00:00
Gary Verhaegen
f4689691ca
document helm chart (#11648)
CHANGELOG_BEGIN

* There is now an Early Access Helm chart to start all of the Connect components on a Kubernetes cluster.

CHANGELOG_END
2021-11-11 13:31:02 +01:00
Moritz Kiefer
3588284fad
Fix screenshots in daml intro 2 (#11617)
The screenshots use a different module name.

fixes #9644

changelog_begin
changelog_end
2021-11-09 18:44:43 +00:00
Gary Verhaegen
a3195fd62d
fix link to blog (#11570)
I'm not entirely sure that this is the intended link (v. say
`https://daml.com/blog`), but the current one is dead so presumably this
is better.

CHANGELOG_BEGIN
CHANGELOG_END
2021-11-08 10:38:37 +01:00
fabiotudone-da
08236012af
Self-service errors: generate error deprecation docs [KVL-1187] (#11539)
* Render error deprecation in generated docs

CHANGELOG_BEGIN
CHANGELOG_END

* Build export-error-codes-json-app with Scala 2.13 only

* Generate docs only with Scala 2.13

* Generate daml-on-sql docs only with Scala 2.13

* Split the error codes JSON generator off from the error lib

* Build all docs only with Scala 2.13
2021-11-05 01:23:38 +01:00
fabiotudone-da
214c7ab445
Self-service errors: generate groups documentation [KVL-1186] (#11526)
* Add groups information to JSON

CHANGELOG_BEGIN
CHANGELOG_END

* Code cleanup

* Fix docs generation

* Fix KVErrors group explanation string

* Render error group explanations in generated docs

* Fix ErrorCodeDocumentationGeneratorSpec
2021-11-04 12:07:29 +01:00
Stefano Baghino
6c45f099bb
Remove TODO (#11446)
Fixes #11425

changelog_begin
changelog_end
2021-10-28 11:11:07 +00:00
carrielaben-da
54c400a341
Update wording in Deploying to a generic Daml ledger (#11327)
* Update generic_ledger.rst

* Changelog

Additional wording changes for grammar and style.

CHANGELOG_BEGIN

CHANGELOG_END

Co-authored-by: carrie-laben <91496516+carrie-laben@users.noreply.github.com>
2021-10-25 17:12:25 +00:00
Gerolf Seitz
ab8a863734
[docs] Add Daml Driver for VMBC to the commercial integrations section (#11360)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-22 15:44:11 +00:00
Moritz Kiefer
07ad3e0d9a
Suport multi-party readAs in triggers (#11299)
* Suport multi-party readAs in triggers

fixes #7640

This does not yet include the trigger service. We’ll tackle that separately.

changelog_begin

- [Daml Triggers] Triggers now support readAs parties. They can be
  specified via `--ledger-readas a,b,c`. As part of this change
  ``testRule`` gained an extra argument to specify the `readAs`
  parties. If you previously used

  ```
  testRule trigger party acsBuilder commandsInFlight s
  ```

  you now need to use

  ```
  testRule trigger party [] acsBuilder commandsInFlight s
  ```

changelog_end

* Update triggers/tests/src/test/scala/com/digitalasset/daml/lf/engine/trigger/test/AbstractFuncTests.scala

Co-authored-by: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com>

Co-authored-by: Andreas Herrmann <42969706+aherrmann-da@users.noreply.github.com>
2021-10-20 18:17:15 +00:00
Moritz Kiefer
728296575b
Fix component status for triggers (#11311)
changelog_begin
changelog_end
2021-10-20 15:28:13 +02:00
pbatko-da
d3dad75d00
[DPP-592] Generate docs for self-service error codes. (#11129)
Adding `Daml Documentation >> Building applications >> "Self-Service Error Codes (Experimental)` section in the HTML documentation. 

The section is populated automatically with error code information retrieved from the classpath.
The process of generating documentation for error codes looks like this:
- first we find error codes information from the classpath,
- then we save it to a json file,
- then the json file is made available to a custom Sphinx extension,
- then the custom Sphinx extension generates documentation wherever we put a new custom Sphinx directive.

Try it out with
`./docs/scripts/live-preview.sh`
or
`./docs/scripts/preview.sh`


CHANGELOG_BEGIN
CHANGELOG_END
2021-10-20 08:47:54 +02:00
Stephen Compall
f4df1cc4d0
converting server errors to proper client errors (#11184)
* a model for trapping client errors in Scala bindings shim and reporting correctly

* clean up some nesting with an alias

* filter out client-side command service errors

* fix flattening error propagation of CommandService errors in endpoints

* remove todo

* Daml evaluation triggers INVALID_ARGUMENT; handle this for creates/exercises

* clean up lookupResult

* remove stripLeft utility; it is unused

* proper error propagation for /parties endpoint

* map grpc status codes to HTTP error codes

* add a case to pass-through gRPC errors in Endpoints errors

* handle gRPC status in all explicit top-level catches

* pass through gRPC errors in CommandService as well

* treat a gRPC status anywhere in the causal chain as indicating participant-server error

* propagate ContractsService errors without assuming they will always be ServerErrors

* filter ServerErrors' contents when rendering errorful streams

* log errors from websocket output instead of rendering full messages

* hide message in ServerError case

* remove Aborted

* transfer with bad contract ID now returns 409

* mention new error codes

* add changelog

CHANGELOG_BEGIN
- [JSON API] Several kinds of gRPC server errors are now reported with
  associated HTTP statuses; for example, a Daml-LF interpreter error now
  returns a 400 instead of a 500, and an exercise on an archived contract
  returns a 409 Conflict instead of a 500.  Errors internal to JSON API
  (e.g. internal assertion failures) are no longer detailed in the HTTP
  response; their details are only logged.
  See `issue #11184 <https://github.com/digital-asset/daml/pull/11184>`__.
CHANGELOG_END

* remove unused Show and liftErr utility

* adapt daml-script to new error codes

* adapt typescript tests to new error codes

* adapt json-api failure tests to new error codes
2021-10-19 13:54:29 -04:00
Stefano Baghino
9ed1eb3ce3
Address security notice on ansi-regex (#11243)
* Address security notice on `ansi-regex`

Addressed this via resolution of `chalk` on a common version
which seems close enough to other old versions not to break
anything (tested manually) while removing the `ansi-regex`
transitive dependency that causes our daily builds to break.

Also removed `package-lock.json` since we are using `yarn`.

changelog_begin
changelog_end
2021-10-14 11:15:34 +00:00
Artúr Poór
0f265fd715
[Docs] Improve manual-download.html phrasing. (#11084)
Emphasize that SDK version 1.4.0 was the latest at the time
of writing instructions, and is outdated now.

changelog_begin
changelog_end
2021-10-11 08:40:50 +02:00
fabiotudone-da
63ab3f3e50
Fix change ID references in services.rst (#11130)
CHANGELOG_BEGIN
CHANGELOG_END
2021-10-05 17:44:49 +00:00
Moritz Kiefer
7c1fd50469
Bump grunt-browserify (#11026)
Missed it in #11023

changelog_begin
changelog_end
2021-09-27 09:03:35 +00:00
Moritz Kiefer
91be1e1659
Drop matchdep dependency from docs build (#11023)
We really don’t need 600 lines of mostly deprecated and unmaintained
dependencies which get flagged by blackduck & dependabot if we can
inline this into a static array which we never changed since we first
added the docs.

changelog_begin
changelog_end
2021-09-27 09:48:00 +02:00
Richard Kapolnai
e0587bcdd2
Add a bit of detail to RegisteredTemplates documentation, motivated by: (#10962)
https://discuss.daml.com/t/does-the-registeredtemplates-field-in-a-daml-trigger-affect-the-acs-which-is-threaded-through-my-rule/145
https://discuss.daml.com/t/do-triggers-get-full-acs-or-prefiltered/403

CHANGELOG_BEGIN
CHANGELOG_END
2021-09-21 15:36:40 +00:00
akshayshirahatti-da
b8533d50e9
[JSON-API] Production/HA documentation. (#10903)
* Initial draft documentation for JSON API production recommendations

CHANGELOG_BEGIN
CHANGELOG_END

* changes based on draft review

* changes based on code-review

* more changes based on review comments

* add note on performance impact for rebuilding query store
2021-09-20 17:41:18 +00:00
Stefano Baghino
9093c6c7b3
Improve wording for the active contracts service description (#10880)
* Improve wording for the active contracts service description

This should eliminate sources of confusion as mentioned here: https://discuss.daml.com/t/offset-is-null-while-getting-active-contracts/3118

changelog_begin
[Docs] Improved description of the purpose and usage of the active contracts service
changelog_end

* Address https://github.com/digital-asset/daml/pull/10880#pullrequestreview-754078207

* Remove sand-which.
2021-09-15 10:27:40 +02:00
Stefano Baghino
c12f546774
Document #10780 (#10781)
changelog_begin
[Docs/JSON API] documented 256B limitation of Oracle query store
changelog_end
2021-09-15 10:26:28 +02:00
Gary Verhaegen
6c1c02aeea
document complete authorized auth0 setup (#10881)
CHANGELOG_BEGIN
CHANGELOG_END
2021-09-14 19:11:21 +00:00
Moisés Ackerman
9e918c37a3
Update trigger-service docs to use --dar option in the corresponding example (#10877)
changelog_begin
changelog_end
2021-09-14 14:46:31 +02:00
Miklos
6faddc90c8
Update Daml Documentation to reflect command deduplication related changes [KVL-1094] (#10852)
* Minor tweaks.

* Use deduplication period instead of deduplication time.

* Introduced change ID and consistent use of deduplication duration/period.

* Consistent use of deduplication duration/period.

* Added ALREADY_EXISTS to the described gRPC errors.

* Minor tweak.

CHANGELOG_BEGIN
CHANGELOG_END

* Emphasize that applications should not change the deduplication time upon a resubmission

* Fix definition of change ID and always refer to it

* Try to clarify "Application-specific IDs"

* Make command deduplication explanation unspecific w.r.t. direction

Co-authored-by: Fabio Tudone <fabio.tudone@digitalasset.com>
2021-09-14 11:28:27 +02:00
akshayshirahatti-da
99f0362aac
[JSON-API] drop package token doc changes (#10865)
* Update daml documentation to reflect the deprecation of the package/internal access token

CHANGELOG_BEGIN
CHANGELOG_END

* drop the whole internal access token section
2021-09-13 16:53:19 +00:00
Moritz Kiefer
842c5b1605
Drop early access notice from profiler docs (#10856)
changelog_begin
changelog_end
2021-09-13 09:07:00 +00:00
Gary Verhaegen
567fe43cc6
tweak trigger-service docs (#10845)
CHANGELOG_BEGIN
CHANGELOG_END
2021-09-10 16:06:20 +02:00
Adriaan Moors
7225c0415c
[docs] Replace AdoptOpenJDK suggestion by Adoptium (#10837)
* [docs] Replace AdoptOpenJDK suggestion by Adoptium

In the installation instructions, suggest Adoptium as JDK source

[AdoptOpenJDK has moved to the Eclipse foundation](
https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/)

* Without changelog entry

CHANGELOG_BEGIN
CHANGELOG_END
2021-09-10 13:45:03 +00:00
Gerolf Seitz
648acf52f8
Fix typo in app-arch.rst (#10798)
CHANGELOG_BEGIN
CHANGELOG_END
2021-09-09 14:11:35 +00:00
tudor-da
deb8a8b740
[Divulgence pruning] Daml SDK docs update [DPP-536] (#10764)
* [Divulgence pruning] Minor update to participant_pruning_service.proto divulgence docs

CHANGELOG_BEGIN
[Ledger API Specification] Participant pruning of all divulged contracts is fully implemented: Participant operators can choose to prune all immediately and retroactively divulged contracts, by setting the newly-added prune_all_divulged_contracts flag in the ParticipantPruningService/Prune request.
CHANGELOG_END

* Enrich `Daml Participant Pruning` in the `Operating Daml` docs section

* Apply suggestions from code review

Co-authored-by: mziolekda <marcin.ziolek@digitalasset.com>

Co-authored-by: mziolekda <marcin.ziolek@digitalasset.com>
2021-09-08 07:58:55 +00:00
Leonid Rozenberg
bb908d04fb
Create a link to party management service in main Ledger API page. (#10138)
CHANGELOG_BEGIN
CHANGELOG_END
2021-09-02 23:03:19 -04:00
Victor Peter Rouven Müller
ff1308ee3d
[Docs] Add info on logs on Kubernetes & metrics in the ops section (#10525)
* [Docs] Add info on logs on Kubernetes & metrics in the ops section

changelog_begin

- [Docs] Information was added in the `Operating Daml` section on how to aggregate logs on Kubernetes in conjuction with Daml services & what options exists for exporting metrics from daml services (not Kubernetes specific)

changelog_end

* Move the new docs into a seperate section 'Operating Daml Connect'

* Move section again, now it's a subsection under Operating Daml

* Update docs/source/ops/connect/content.rst

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

* Apply suggestions from code review

Co-authored-by: Gary Verhaegen <gary.verhaegen@digitalasset.com>

* Rename file

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Co-authored-by: Gary Verhaegen <gary.verhaegen@digitalasset.com>
2021-09-02 14:52:27 +00:00
pbatko-da
b28afcf7ae
[DPP-438] Update docs on metrics that no longer use <party_name> in their name (#10728)
CHANGELOG_BEGIN
CHANGELOG_END
2021-09-02 10:07:36 +02:00