Commit Graph

9356 Commits

Author SHA1 Message Date
carrielaben-da
040c92f382
Getting Started Guide Update - First Draft (#12752)
* Update app-architecture.rst

* Update first-feature.rst

* Update index.rst

* Update installation.rst

* Update manual-download.rst

* Update path-variables.rst

* Revert "Update path-variables.rst"

This reverts commit 62f5554f2e.

* Revert "Update manual-download.rst"

This reverts commit e1cf0248a4.

* Revert "Update installation.rst"

This reverts commit ba229215ab.

* Revert "Update index.rst"

This reverts commit 052be7dc19.

* Revert "Update first-feature.rst"

This reverts commit 120d894ad6.

* Revert "Update app-architecture.rst"

This reverts commit 78ffa6d2c1.

* Getting Started Guide first draft updates

Changes to the individual pages of the Getting Started Guide

[CHANGELOG_BEGIN]
app-architecture.rst content and style edits
first-feature.rst style edits
index.rst style edits
installation.rst style edits
manual-download.rst style edits
path-variables.rst style edits
[CHANGELOG_END]

* Revert "Update path-variables.rst"

This reverts commit 62f5554f2e.

* Revert "Revert "Update path-variables.rst""

This reverts commit 674ca81999.

CHANGELOG_BEGIN
CHANGELOG_END

* Update docs/source/getting-started/index.rst

Accepting correction of type

[CHANGELOG_BEGIN]
"mke" to "make"
[CHANGELOG_END]

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

* Update docs/source/getting-started/installation.rst

Changing header separation line (?)

[CHANGELOG_BEGIN]
Accepted line 70 comment
CHANGELOG_END]

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

* Addressing reviewer comments for PR "Getting Started Guide Update - First Draft"

Addressing comments related to the text. Screenshot updates to follow.

[CHANGELOG_BEGIN]
Line 97: New user name requirements
Lines 105-106: Adjusted terminology
[CHANGELOG_END]

* Update first-feature.rst to address comments in the Getting Started Guide Update - First Draft PR

Addressing @cocreature 's feedback

[CHANGELOG_BEGIN]
Line 23: Removed redundant instruction.
Line 85: Tense issue.
[CHANGELOG_END]

* Update app-architecture.rst for PR Getting Started Guide Update - First Draft

Incorporating suggested changes

[CHANGELOG_BEGIN]
Line 54: Adjusted description of naming terminology and behavior
[CHANGELOG_END]

* GSG changes attempt 3

Addresses existing comments; checks for heading formatting; updated screenshots.

[CHANGELOG_BEGIN]
Addresses existing comments; checks for heading formatting; updated screenshots.
[CHANGELOG_END]

* Update docs/source/getting-started/installation.rst

Formatting fix
[CHANGELOG_BEGIN]
Formatting fix
[CHANGELOG_END]

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

* fix more formatting

changelog_begin
changelog_end

* Update docs/source/getting-started/index.rst

Further clarification of alias vs id
[CHANGELOG_BEGIN]
UI by their alias instead of their user id,
[CHANGELOG_END]

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

Co-authored-by: carrie-laben <91496516+carrie-laben@users.noreply.github.com>
Co-authored-by: Jennifer <jennifer.whyte@digitalasset.com>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
2022-02-15 17:48:27 +00:00
Moritz Kiefer
6ed6ea36e8
Drop parties from daml templates (#12953)
Complements #12952 which drops it from create-daml-app by also
dropping it from the rest.

Couldn’t find any docs or other stuff that is broken by this.

changelog_begin
changelog_end
2022-02-15 17:21:32 +00:00
Samir Talwar
ac12112dad
ledger-api-tests: Remove the performance-testing functionality. (#12948)
* ledger-api-tests: Remove the performance-testing functionality.

This has been superseded by the Ledger API Bench Tool.

CHANGELOG_BEGIN
- [Ledger API Test Tool] The performance tests have been removed from
  this tool, in favor of the Ledger API Bench Tool, which is much more
  capable and configurable.
CHANGELOG_END

* ledger-on-sql/sandbox-on-x: Stop running performance tests.

We don't check the results anyway.
2022-02-15 17:06:23 +00:00
Adriaan Moors
612bf97b05
No parties in create-daml-app's daml.yaml template, (#12952)
... so that Navigator shows users for login by default.

When parties are specified explicitly in daml.yaml,
navigator uses those instead of querying user management
for the list of users a user can log in as.

These days, it actually doesn't make sense to list the
parties in the daml.yaml. Navigator will query party
mgmt for a list of known parties. We don't implicitly
allocate parties (anymore), so unclear why this section
is still here.

The users for the template are created by the init script
(see Setup.daml).

See #12945

CHANGELOG_BEGIN
CHANGELOG_END
2022-02-15 17:04:50 +00:00
Samir Talwar
f3af828fb9
ledger-on-(memory|sql): Stop publishing to Maven. (#12947)
* ledger-on-(memory|sql): Stop publishing to Maven.

Nothing depends on these any more.

We plan on removing them entirely, but for now we can just make sure
they're not published.

CHANGELOG_BEGIN
CHANGELOG_END

* Changelog.

CHANGELOG_BEGIN
- [Maven] Two internal components, "ledger-on-memory" and
  "ledger-on-sql", are no longer published to Maven Central. If you were
  relying on these components to implement a simple ledger, we encourage
  you to migrate to the community edition of Canton.
CHANGELOG_END
2022-02-15 15:39:16 +00:00
Kamil Bozek
f950690f1a
Fix ledger-api-bench-tool reporting NaN result [DPP-989] (#12928)
* Do not calculate too frequent periodic reports in ledger-api-bench-tool.

CHANGELOG_BEGIN
CHANGELOG_END

* Deduplicate MetricsCollectorSpec
2022-02-15 16:30:49 +01:00
tudor-da
2a06a0a78c
Conflict checking enabled by default (#12924)
changelog_begin
changelog_end
2022-02-15 15:51:42 +01:00
Kamil Bozek
dfd38186fe
Remove pre-1.18 error codes [DPP-773] (#12841)
* Remove legacy error codes

CHANGELOG_BEGIN
CHANGELOG_END

* Remove ValidatorFixture

* Removed redundant helper function

* Remove redundant object

* Rebased.

run-full-compat: true

* Rebased.

run-full-compat: true
2022-02-15 15:28:36 +01:00
tudor-da
d97f9815b2
Cleaned Sandbox-on-X logging (#12931)
changelog_begin
changelog_end
2022-02-15 15:23:38 +01:00
mziolekda
183caab8c9
Fix incorrect documentation in versioning bazel utilities (#12938)
CHANGELOG_BEGIN
CHANGELOG_END
2022-02-15 13:18:08 +01:00
Samir Talwar
8540ba8f6a
daml-sdk-head: Fix help text so it doesn't refer to an unbound var. (#12944)
CHANGELOG_BEGIN
CHANGELOG_END
2022-02-15 11:49:42 +00:00
Gary Verhaegen
1b3ae53249
remove license-checker symlink (#12946)
Actual code removed in #12909.

CHANGELOG_BEGIN
CHANGELOG_END
2022-02-15 11:48:49 +00:00
Moritz Kiefer
04eff2722c
Drop daml-lf-verify (#12942)
This is completely unmaintained, unused and partially broken so delete
it for now. Worst case, we recover it from Git history.

closes #6550 because it now refers to deleted code.

changelog_begin
changelog_end
2022-02-15 12:31:32 +01:00
Moritz Kiefer
4b0beda87c
Drop KV sandbox (#12937)
changelog_begin
changelog_end
2022-02-15 10:31:46 +00:00
Moritz Kiefer
bedc7c7326
Allocate parties explicitly in create-daml-app compat tests (#12936)
fixes #12932

changelog_begin
changelog_end
2022-02-15 10:51:18 +01:00
Moritz Kiefer
704de6dc35
Drop patch for mod package in lsp-types (#12921)
We needed this before the upgrade to GHC 9.0 due to our use of
integer-simple. With GHC 9.0 and the corresponding switch from
integer-simple to ghc-bignum native this is no longer required.

changelog_begin
changelog_end
2022-02-15 10:24:05 +01:00
Moritz Kiefer
2de470de31
Upgrade nixpkgs (#12926)
Partially just to keep things up2date, partially to get a chance to
upgrade to Bazel 5.

changelog_begin
changelog_end
2022-02-15 08:59:47 +00:00
Moritz Kiefer
67f214b1d1
Fix daml script reference in copy-unix-release-artifacts (#12933)
I also changed CI config so we run this on every build but only upload
on releases. That should hopefully make sure we catch this immediately
next time. The script is fast enough that this shouldn’t slow this
down meaningfully.

changelog_begin
changelog_end
2022-02-15 09:53:15 +01:00
azure-pipelines[bot]
1e8e1e1edb
update NOTICES file (#12930)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
2022-02-15 09:47:04 +01:00
Moisés Ackerman
4848519fc6
Enable go-to-definition for interface methods and choices (#12903)
* Extend interface go to def test to cover methods and choices

changelog_begin
changelog_end
2022-02-15 08:30:30 +00:00
Moritz Kiefer
756b8bc406
Raise akka log-lveel for CoordinatedShutdown in daml-script (#12919)
Trying to work around https://github.com/akka/akka/pull/30944/files
having introduced rather confusing log messages in Daml script.

There are probably some other tools where we might want to do this but
I think daml script is the main one as the other ones are long-running
services where you don’t expect to shutdown the actor system during
regular operatino.

changelog_begin
changelog_end
2022-02-15 09:07:13 +01:00
Jennifer Whyte
4df4db11e8
Add new toctrees in daml docs (#12880)
* Add toctrees in daml docs

CHANGELOG_BEGIN
CHANGELOG_END

* Update operating-daml.rst

Remove wrong link (ops/index>

CHANGELOG_BEGIN
CHANGELOG_END

* Making toc visible on new pages

Making toctrees visible so new pages aren't empty

* Update docs/source/building-applications.rst

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

* Fix underlines

CHANGELOG_BEGIN
CHANGELOG_END

* Fix missing from toctree messages

CHANGELOG_BEGIN
CHANGELOG_END

* Fix pdf docs

changelog_begin
changelog_end

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
2022-02-15 07:34:29 +00:00
Stefano Baghino
dc5f203323
Address CVE-2022-0144, resolve shelljs to 0.8.5 (#12927)
changelog_begin
changelog_end
2022-02-14 22:30:06 +00:00
Kamil Bozek
9a1742ccea
Fix compatiblity tests failures after removing legacy error codes. (#12920)
* Fix compatiblity tests failures after removing legacy error codes.

CHANGELOG_BEGIN
CHANGELOG_END

run-full-compat: true

* Fix formatting

run-full-compat: true
2022-02-14 22:44:50 +01:00
Stefano Baghino
a49c321902
Add party identifier autocompletion to Navigator (#12923)
Fixes #12789

Adds a new query endpoint to Navigator's GraphQL backend that
lists all the parties registered by Navigator. The parties are
filtered on the server based on a query from the frontend and
served back. The frontend uses this to provide suggestion and
autocompletion features whenever a party identifier input is
required.

changelog_begin
[Navigator] Whenever you have to input a party identifier you
are now offered suggestions and the possibility to
autocomplete. See #12789.
changelog_end
2022-02-14 20:55:46 +00:00
Gary Verhaegen
c04fa81d6a
ci: bump Windows workdirs (#12918)
Since #12645, we added a new pipeline, so we need to add a corresponding
entry.

As for #12645, the content of the files and the directory structure is
taken directly from a live CI node, as printed by the (now-named)
`workdirs` step.

CHANGELOG_BEGIN
CHANGELOG_END
2022-02-14 18:49:32 +00:00
dependabot[bot]
afef1a3827
Bump follow-redirects from 1.14.7 to 1.14.8 in /navigator/frontend (#12911)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-14 18:47:26 +00:00
Moritz Kiefer
3bcfaa7dcb
Support building via rosetta (#12910)
* Support building via rosetta

Not as nice as a native build but seems useful enough until we have
that working.

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end

* .

changelog_begin
changelog_end
2022-02-14 19:06:17 +01:00
Simon Maxen
e56676e871
Minimal change needed to support is_final proto update (#12917)
changelog_begin
changelog_end

Breaks-Protobuf: true
2022-02-14 16:45:09 +00:00
mziolekda
8786f81aa2
Remove daml-on-sql (#12891)
* Remove daml-on-sql

CHANGELOG_BEGIN
Remove daml-on-sql
CHANGELOG_END

* migrate daml-on-sql documentation to sandbox-on-x
2022-02-14 17:17:27 +01:00
Samir Talwar
5d6fa519d2
ledger-api-test-tool: Remove MonotonicRecordTimeIT. [KVL-1076] (#12914)
* ledger-api-test-tool: Remove MonotonicRecordTimeIT.

This only makes sense for KV ledgers; they can implement it themselves
now.

CHANGELOG_BEGIN
- [Ledger API Test Tool] The optional ``MonotonicRecordTimeIT`` test
  suite has been removed as it doesn't apply to most ledgers. If it is
  necessary, ledger driver implementors are encouraged to write their
  own and/or copy it from the last published version.
CHANGELOG_END

* ledger-api-test-tool-on-canton: Forget about MonotonicRecordTimeIT.
2022-02-14 16:09:27 +00:00
Stefano Baghino
7252a66b2f
Wire contract identifier autocompletion in Navigator (#12916)
Navigator already had the possibility of autocompleting contract
identifiers, the only thing missing was to wire it in in full. This is
done mostly to inform how to address the more involved #12789.

changelog_begin
[Navigator] All input fields where a contract identifier can be passed
now provide the possibility of auto-completing based on the contracts
existing on the ledger.
changelog_end
2022-02-14 15:55:46 +00:00
Stefano Baghino
09a3eeab0c
Shorten contract and party identifiers in Navigator (#12913)
As we transition to Canton, we use a new format of contract and party
identifiers that can break the UI of Navigator here and there. In
order to prevent this, we use the same rules as Canton does to shorten
identifiers (basically, elide any hash longer than 12 characters).
Full identifiers are still shown as part of the tooltip.

Furthermore, a tooltip suggests that clicking on the shortened
identifier copies it in full length on the clipboard (which is indeed
what happens). There are a couple of possible improvements to this
interaction, which cannot be handled as part of this PR due to time
constraint:

- the visual cue suggesting that the identifier can be copied can be
improved by adding a clipboard icon besides the label
- there is no visual feedback from copying the identifier, ideally the
user should somehow see that the copying took place (e.g. by turning the
clipboard icon suggested in the point above into a checkmark for a
couple of seconds)

changelog_begin
[Navigator] Contract and party identifiers are shortened on the UI
but can be copied in full by clicking on their label.
changelog_end
2022-02-14 16:10:09 +01:00
Samir Talwar
23de5e364b
ledger-api-test-tool: Make certain classes public. (#12915)
They're necessary to implement suites elsewhere.

CHANGELOG_BEGIN
CHANGELOG_END
2022-02-14 15:55:11 +01:00
Moritz Kiefer
8e32842f57
Switch docs for upgrade automation to Canton Sandbox (#12908)
changelog_begin
changelog_end
2022-02-14 14:08:32 +00:00
dependabot[bot]
f0a2fe9129
Bump follow-redirects from 1.14.7 to 1.14.8 (#12912)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-14 13:57:13 +00:00
tudor-da
307931d5b4
Extracted kvutils Config to //leger/ledger-runner-common [DPP-865] (#12889)
* Extracted kvutils Config to //leger/ledger-runner-config

changelog_begin
changelog_end

* Sandbox-on-X logback.xml does not depend on the kvutils/app one

* Remove unused dependencies

* Add copyright header back

* Remove dependency of SoX on kvutils
2022-02-14 13:52:06 +00:00
Moritz Kiefer
d6e6c568fe
Fold daml test-script under daml script --all (#12895)
I tried to keep the changes somewhat minimal and reuse what is already
there. I think there is a fair amount of cleanup we can do afterwards
but hopefully this way it’s easier to review.

fixes #12837

changelog_begin

- [Daml Script] `daml test-script` has been replaced by `daml script
  --all`. The option to spin up a ledger automatically has been
  removed and you always have to specify one.

changelog_end
2022-02-14 14:23:21 +01:00
Moritz Kiefer
a30c5c2ebc
Switch upgrade docs to Canton sandbox (#12904)
* Switch upgrade docs to Canton sandbox

Mainly requires explicitly allocating parties & users and dealing with
Navigator being annoying.

changelog_begin
changelog_end

* .

changelog_begin
changelog_end
2022-02-14 13:55:53 +01:00
Moritz Kiefer
6a585c9eca
Drop license-checker from dev-env (#12909)
No reason to keep a custom nix deriv around for something we don’t
use.

changelog_begin
changelog_end
2022-02-14 13:50:12 +01:00
Simon Maxen
cc4c06c640
Metering Aggregation [DPP-818] (#12723)
* Add support for aggregated transaction metering

changelog_begin
Support added for aggregated transaction metering
changelog_end

* Update with review comments
2022-02-14 11:36:23 +00:00
Gary Verhaegen
c2a6397751
re-enabble patch-bazel-windows (#12905)
This reverts a small part of 9e1e42d27c
(#12901).

Microsoft seems to have given us our free parallel jobs back, so we can
run the patch_bazel job again.

Fixes #12900.

CHANGELOG_BEGIN
CHANGELOG_END
2022-02-14 11:23:48 +00:00
Marton Nagy
830963e629
Remove event_id indexes (#12743)
changelog_begin
changelog_end
2022-02-14 08:47:32 +01:00
azure-pipelines[bot]
473c8be6a7
update NOTICES file (#12902)
CHANGELOG_BEGIN
CHANGELOG_END

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
2022-02-14 08:42:03 +01:00
Moritz Kiefer
9e1e42d27c
Drop dependency on hosted nodes (#12901)
This should hopefully get CI working again.

There are two changes in here:

1. We can no longer change our patched Bazel. I didn’t switch away
   from the current patched version for now (we upload it to gcp bucket
   so it still works fine even if we cannot build it) but if we upgrade,
   we need to go to an unpatched version for now.
2. We need to get `az` from dev-env. I tested the self service compat
   job stuff and it works fine with this but there is a chance other
   parts don’t.

changelog_begin
changelog_end
2022-02-14 02:49:38 +01:00
Adriaan Moors
3ebd9d7be0
Navigator: don't leak memory via PartyState (#12896)
Undoing an unnecessary refactoring from #12187

stefanobaghino-da confirmed this fixes the memory leak he observed
in "long" running navigator sessions.

CHANGELOG_BEGIN
CHANGELOG_END
2022-02-12 11:37:21 +01:00
Samir Talwar
3dccabf6ba
ledger/cli-opts: Add tests for --auth-* CLI parameters. (#12894)
These were previously untested.

CHANGELOG_BEGIN
CHANGELOG_END
2022-02-11 19:42:21 +01:00
tudor-da
dd6dab6e6b
[Sandbox-on-X] Address various TODOs (#12823)
* Removed no-action TODOs

changelog_begin
changelog_end

* Assert self-service error codes in SequenceSpec

* Move InternallyInconsistentKeys and InternallyDuplicateKeys to LedgerApiErrors.WriteServiceRejections

* Restructured ledger bridge metrics
* Buffers before each processing stage

* Do not log the failure stacktrace on ledgerId lookup

* Addressed review comments

* Buffer size before prepare submission is 128
2022-02-11 17:03:41 +00:00
Moritz Kiefer
a230de2f82
Support getting started guide on Daml Hub (#12878)
* Support getting started guide on Daml Hub

This is annoyingly complex so let me try to provide an explanation for
the changes:

1. On Daml hub, we need to use a separate token for the public party
   and the user party.
2. This means that we need separate contexts. I cannot get access to
   the default context (not exposed) so annoyingly even for the user context we need to
   use a custom context
3. The way to get access to the public party in Daml hub is via a
   hook that reads it from the context. However, we cannot call that
   within the login callback so the way things work now that we login
   immediately show a "Logging in..." loading screen while we run the
   background query. This is actually kinda nice since it means
   something happens immediately after clicking login.

I’m sure there are better ways of handling this, my react foo is very
weak but this is what I managed to get to work.

Tested locally as well as on Daml hub and both work fine.

changelog_begin
changelog_end

.

.

.

.

.

.

.

* s/any/void/

* fmt
2022-02-11 16:41:07 +00:00
Kamil Bozek
cab76a9a65
Remove legacy error codes docs sources (#12892)
CHANGELOG_BEGIN
CHANGELOG_END
2022-02-11 17:34:10 +01:00