* make http-json:integration-tests into test suites
* make http-json-oracle:integration-tests into test suite
* no changelog
CHANGELOG_BEGIN
CHANGELOG_END
* remove commented libraries
* Adapted migration guide to include changes from https://github.com/digital-asset/daml/pull/11686
CHANGELOG_BEGIN
CHANGELOG_END
* Enriched migration guide with Sandbox-classic changed gRPC error codes
* Added migration guide for error codes changed in KV committer
* Extract the KV and Sandbox-classic migration guides
* Hierarchical order of error codes docs
* Added back full grpc error code description to columns
* Using "gRPC status code" instead of "gRPC error code"
* Addressed review comments from Hubert
* Apply suggestions from code review
Co-authored-by: Miklos <57664299+miklos-da@users.noreply.github.com>
* Addressed review comments
* Use 'Error codes' instead of 'Self-service error codes'
Co-authored-by: Miklos <57664299+miklos-da@users.noreply.github.com>
* Use explicit party specifications in Daml Script over JSON API
This uses the new party set arguments from #11454 to allow Daml Script
over the JSON API to `submit p` even if we have a token with more
claims.
changelog_begin
- [Daml Script] When run over the JSON API, Daml Script can now use a
subset of the claims in the token. E.g., `submit p` works even if you
have a token with `actAs = [p, p2]`.
changelog_end
* Apply suggestions from code review
Co-authored-by: Remy <remy.haemmerle@daml.com>
* Drop opt prefix
changelog_begin
changelog_end
* switch around error & success cases
changelog_begin
changelog_end
Co-authored-by: Remy <remy.haemmerle@daml.com>
* Moved StreamConfig to a separate class WorkflowConfig
* Change streams from Option[List[]] to List[]
* Simplifying
* Dedicated PartyFilter case class
* Use String instead of Identifier in filter config to allow using short names
* Submission config
* Switched to unified WorkflowConfig
* Minor change
* Minor change
* Workflow config parser tests
* Removed leftovers
* Added more tests
* Removed leftovers
* Updated CLI
* Complete stream configuration support in the YAML file in the ledger-api-bench-tool
CHANGELOG_BEGIN
- [Integration Kit] - ledger-api-bench-tool - All stream configuration parameters can be defined through the YAML configuration file.
CHANGELOG_END
* Addressed review comments (renaming).
* Changes to renable ws multiplexing
CHANGELOG_BEGIN
[TS-BINDINGS] Re-enable ws multiplexing for stream queries after resolving the reconnect connection close bug associated with ws state and liveness.
CHANGELOG_END
* websocket is passed as an argument to the onMessage handler
* consistently use 'manager' reference instead of 'this' in the handleQueries change method
* LF: Reintroduce TransactionVersion.asVersionedTransaction
This have been drop in #11626, but canton is using it.
CHANGELOG_BEGIN
CHANGELOG_END
* cosmetic
* cosmetic
This will limit the parallelism of extractor integration tests.
Each test runs now a bit faster although overall all tests seem
to run a bit slower. This seems a good compromise as it should
limit the contention over system resources between various
integration tests, each running a PostgreSQL instance and sharing
various system resources.\
changelog_begin
changelog_end
* Adding new table, indexes
* Adding data migration (PostgreSQL only)
* Removing unnecessary indexes
* Adding DbDto, Schema integration for the filter table
* Adding generation of CreateFilter Dto-s to UpdateToDbDto
* Adding sequential ID generation to sandbox-classic and parallel-ingestion
* Adding StorageBackend support for pruning, reset
* Adding EventStorageBackend support for two phase retrival queries
* Extending/adapting unit tests
* Adding PostgreSQL VACUUM ANALYZE Flyway migration script as well (since this is the last persistence change in the ACS feature track)
changelog_begin
changelog_end
@remyhaemmerle-da is taking care of 1.18.0-snapshot.20211109.8328.0.92181161 (#11623), so they get pushed back to the end of the line.
Please do not merge this before #11623.
CHANGELOG_BEGIN
CHANGELOG_END
Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
Because a bug in the scala compiler deprecated pattern matching are
not detected (See https://github.com/scala/bug/issues/12493).
Hence some deprecated usage of Node aliases have been forgotten in
CHANGELOG_BEGIN
CHANGELOG_END
This seems like a more sensible default. There are really only very
few places where it makes sense to do things automagically (mainly the
IDE). For everything else we might just end up wasting time by
compiling stuff we don’t need.
changelog_begin
changelog_end
* [Self-service error codes] Fill in missing places with submission id for correlation id
* KVConsumption
* GrpcCommandSubmissionService
CHANGELOG_BEGIN
CHANGELOG_END
* Addressed review comments
* WriteService uses submission id as correlation id
* Populate the submission id in command submissions in ledger-api-test-tool
* Do not fail submission on missing submission id
* Fix KeyValueParticipantStateWriterSpec
* Addressed review comments
* add actAs, readAs to `meta` for create, exercise, createAndExercise endpoints
* use meta actAs, readAs to control how contract IDs are looked up for exercise
* outdated comments on JwtWritePayload and JwtPayload
* toSet1 operator to clean up some NEL manipulation
* take optional readAs argument for query endpoint
* use readAs for query POST
* check whether readAs is safe in query endpoint
* missed CommandMeta args in tests
* FetchRequest, a domain model to layer on "fetch" endpoint's ContractLocator
- ContractLocator was overloaded as a domain request model *and* a component
of other domain request models; the addition of new arguments means it can
no longer exactly meet the former, and adding "readAs" to it would poison it
for the latter cases.
* take readAs argument from fetch endpoint
* add readAs security check from query to fetch
* move jwt parties functions to util
* testing the party-set/JWT functions
* missing headers
* caught boolean blindness in readAs security checks
* test that meta params are used for commands
* make resolveRefParties do a subset check, too
* Revert "make resolveRefParties do a subset check, too"
This reverts commit 40a66f102c.
* test that the readAs auth check actually applies
* test that command service uses meta readAs, actAs
* note on test coverage
* add changelog
CHANGELOG_BEGIN
- [JSON API] ``actAs`` and ``readAs`` may be specified for create, exercise,
create-and-exercise, non-WS fetch, and non-WS query.
See `issue #11454 <https://github.com/digital-asset/daml/pull/11454>`__.
CHANGELOG_END
* no saving mallocs
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
* untabify
Co-authored-by: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>
* move design comment to comment from function name
- suggested by @cocreature; thanks
* remove unneeded variable
* refactor single-key callers of requestJsonReader
- suggested by @cocreature; thanks
* build error in ce
* diagnose Windows failure
* add missed http-json-testing requirement
* use readers as fetch/query party-set name
- suggested by @cocreature and @realvictorprm, thanks
* extra import
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Co-authored-by: Stefano Baghino <43749967+stefanobaghino-da@users.noreply.github.com>
changelog_begin
changelog_end
CHANGELOG ENTRIES
```
[TS-Bindings] Ws multiplexing for stream queries is disabled by default as we investigate issues
of intermittent websocket closures.
* There is now an Early Access Helm chart to start all of the Connect components on a Kubernetes cluster.
[JSON-API] Make certain Hikari cp connection pool properties configurable via jdbc conf string, the properties are listed below
poolSize -- specifies the max pool size for the database connection pool
minIdle -- specifies the min idle connections for database connection pool
connectionTimeout -- long value, specifies the connection timeout for database connection pool
idleTimeout -- long value, specifies the idle timeout for the database connection pool
- [Integration Kit] - ledger-api-bench-tool can run a workflow consisting of the command submission phase and stream benchmark phase.
- [JSON API] While updating the contract table for a query, if the DB appears to be slow,
JSON API will slow down its own inserts and deletes at some point rather than construct
ever-larger INSERT and DELETE batch commands.
See `issue #11589 <https://github.com/digital-asset/daml/pull/11589>`__.
[Ledger API] Retry the interpretation of a command in case of a race
with other transactions. This fix drastically reduces the likelihood of the error
"Could not find a suitable ledger time after 0 retries".
[ledger-api] - Return max_deduplication_duration as part of the metadata sent with the gRPC status for commands rejected because of invalid deduplication periods
- [Integration Kit] - ledger-api-bench-tool - added flexible party and template filters for transactions, transaction trees and active contract streams
```
COMMITS
```
d938a44ccd ws multiplexing is disabled by default as we investigate issues with intermittent web socket closures (#11657)
0f0a865f29 Make string interning available at ingestion [DPP-711] (#11645)
7296ba4dfb Move closureConvert and validate compiler phases into separate files. (#11656)
87f282c7f3 interfaces: Preserve/provide by_interface data for create actions. (#11639)
a9de728575 Update rules_scala (#11616)
f4689691ca document helm chart (#11648)
55d4a037a7 Release 1.11.3 snapshot (#11652)
2dd5289a35 different types for different speedy phases (#11605)
44d604dec5 Release new 1.18 snapshot (#11642)
e69a871e2f [JSON-API] Configurable Hikari connection pool props (#11621)
cb7099b22d release 1.11.3 snapshot (#11628)
fd61d0bcbc String interning read integration [DPP-706] (#11638)
c5a1f0bb61 Republish error codes generator lib (#11633)
a6f745f98f Add two phase retrieval merge function [DPP-718] (#11571)
743ee46f0e ledger-api-bench-tool - command submission and stream reading complete workflow [DPP-668] (#11544)
f8f88072ee Activate interning write side [DPP-710] (#11614)
93c07f41fa Extend synonym expansion caching in data-dependencies (#11629)
cf445b2e73 Skip platform independence tests on release PRs (#11631)
b8f384e193 LF: Drop typeparameter from KeyWithMaintainers (#11625)
d0c313d801 Share dependencyInfo in data-dependencies (#11620)
4eed1d90c5 release 1.18.0-snapshot.20211109.8328.0.92181161 (#11623)
92181161cc LF: Abstract VersionedValue and VersionedContractInstance (#11533)
b87acab897 foldLeft, foldRight, other Foldable specializations (#11592)
92dfcdeb24 [Self-service error codes] Use error validators in ApiPackageManagementService (#11575)
6372d41d13 limit contract insertion/deletion batching on backpressure (#11589)
3588284fad Fix screenshots in daml intro 2 (#11617)
ef3fc0ef4b Cache type synonym expansion in safeToReexport (#11612)
70b2fe3534 Provide byInterface fields for fetch, exercise. (#11607)
830779ff78 LF: drop useless class com.daml.lf.transaction (#11601)
7c92cabff7 Cache type synonym expansion in isDuplicate (#11611)
cfd521ff86 Fix GHC build errors on macOS (#11560)
a7559d047e LF: Rename GenTransaction to Transaction (#11599)
3b61a1b748 LF: allow exercise command by template for inherited choice. (#11584)
af1bee7b82 precondition lf conversion (#11538)
f722cf13cd Bump extractor init timeout to 60s (#11598)
1e0a221379 Set symlink_node_modules = False (#11606)
ac19c8cff5 Synchronize in multi-participant script tests (#11594)
dd1b0347ec Restart the submission interpretation in case of a race [DPP-737] (#11579)
8d2b1b9ffe [JSON-API] Port of http-perf-test to sandbox(aka next) (#11543)
56a6db8f73 codeowners: reflect change in onwership of meiersi-da (#11505)
d4336510af fix a few typos in Daml-LF spec (#11583)
5dee88b038 Refactoring store factories [DPP-709] (#11572)
41fb2890d6 Port LedgerApiServer rate limiter interface from canton (#11577)
04cc5d7a76 Mark JSON API integration tests as flaky (#11586)
3bed7a9b4f Drop unused defaultFeatureFlags (#11580)
cbc3c8c686 Add by_interface field in Create, Fetch, & Exercise transaction nodes. (#11576)
7d68e05f7f Remove virtual choices (#11482)
9b94fa9769 [ledger-api] - metadata for invalid deduplication period [KVL-1170] (#11534)
e7eb60f087 update compat versions for 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11531)
a3d04cafaf Migrate matches-docs tests to sandbox on postgres (#11573)
21c97453bd [Self-service error codes] ValueSwitch parameterized method (#11567)
6a0b84e3d0 Run Script export tests against BR (#11574)
a3195fd62d fix link to blog (#11570)
08236012af Self-service errors: generate error deprecation docs [KVL-1187] (#11539)
8d48cf669d DPP-664 Create contracts in batches (#11515)
9ef2eaf803 Remove parameter table join from SQL queries [DPP-705] (#11562)
af7f7f3f01 Fix LF coedowners (#11563)
445031114f Exclude/fix compatibility tests (#11529)
699c28f59e rotate release duty after 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11522)
4d4869f06e interfaces: Improve fixed choice lookup (#11551)
ba96bf784c Add DbDtoToStringsForInterning [DPP-708] (#11557)
692dac665d LF: deprecate remaining type alias in Transaction (#11554)
7bc0f82733 [kvutils] - Extract command deduplication steps from the TransactionCommitter [KVL-1174] (#11547)
0e95ccb354 Wire LedgerEndCache to relevant StorageBackend factories [DPP-704] (#11549)
73cb42e102 LF: deprecate ensureNoCid and assertNoCid in CidContainer (#11502)
30bfee9822 Upgrade canton for conformance tests (#11550)
b84a9142d1 Extractor: replace `sandbox-classic`-based fixtures with `sandbox`-based ones (#11489)
d86fe92950 ledger-api-bench-tool - flexible stream filters [DPP-667] (#11458)
214c7ab445 Self-service errors: generate groups documentation [KVL-1186] (#11526)
60dc2869e7 Avoid unnecessarily decoding DALFs during dependency installation (#11541)
afd79b6729 Improve logging for dependency installation (#11540)
fdde5353f4 fix hoogle by pinning nixpkgs (#11548)
5e93df6b52 Full conformance test with self-service error codes on ledger-on-memory (#11524)
efaf20b042 update NOTICES file (#11546)
c7bb94be65 Modify contract key attribute age for createAndExercise to avoid contract key violation on slow running tests (#11530)
541d07c3a9 Add string-interning data access [DPP-707] (#11484)
6c9416492d Switching to composition at StorageBackend [DPP-704] (#11520)
d006ad0e8b Add string-interning view primitives [DPP-702] (#11475)
a917520851 Save the submission time in the command deduplication value [KVL-1173] (#11509)
669186f118 Add priority-queue based worker Source [DPP-717] (#11500)
2091f59aac Remove cats from kvutils (#11537)
b83af37077 Fix recache log statement (#11536)
776790e386 Add choice collisions in scala name collision checker (#11528)
2efcb21f3e Extract the setting of the time bounds on the commit context [KVL-1173] (#11516)
9bb1d6443c [ledger-api] - Return FAILED_PRECONDITION gRPC status code for invalid deduplication duration [KVL-1170] (#11483)
c098d75621 Add a --log-level flag to damlc (#11514)
afee94858f Bump rules_nixpkgs (#11517)
d6fb67c71e release 1.18.0-snapshot.20211102.8257.0.7391a3cd (#11521)
ac49d69e13 Ensure that -Werror converts parser warnings into errors (#11511)
bda35ca234 ledger-offset: Add a conversion to ByteString. (#11491)
8a9f15b8de [DPP-686][Self-service error codes] Removing default error factories (#11403)
bb37eef156 Switch script & trigger tests to postgres-backed Sadbonx (#11525)
```
Since `v1.18.0-snapshot.20211102.8257.0.7391a3cd`
CHANGELOG_BEGIN
[TS-Bindings] Ws multiplexing for stream queries is disabled by default as we investigate issues
of intermittent websocket closures.
CHANGELOG_END
We need to support mapping to internal ids at ingestion.
* Wire StringInterning to Schema
* Wire StringInterning to IngestionStorageBackend
* Fixing tests
* Renames MockStringInterning (post-review work from different PR)
changelog_begin
changelog_end
* interfaces: Preserve by_interface data for create.
Part of #10915
This was a lot more involved than fetch or exercise. The first issue is
that we need to preserve the interface id into speedy, so it needs a
separate primitive ("experimental" won't cut it). Second, because
speedy's create requires the template definition, and now the interface
id as well, we basically need to compile a separate version of "create"
for each interface that a template implements, hence the separate
`CreateByInterfaceDefRef(templateId, ifaceId)`.
changelog_begin
changelog_end
* scalafmt and refactoring
* fixx merge conflict
* fix silly mistakes
* Update rules_scala
Two patches have since been upstreamed and can be removed.
changelog_begin
changelog_end
* JMH deps were moved into a toolchain
https://github.com/bazelbuild/rules_scala/pull/1106
changelog_begin
changelog_end
Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
