mirror of
https://github.com/digital-asset/daml.git
synced 2024-09-19 16:57:40 +03:00
66b407467f
* Try to upgrade protobuf docs plugin changelog_begin changelog_end * Fix extension number 65020 is already registered Building `//ledger-api/grpc-definitions:ledger-api-docs` [failed with](https://github.com/digital-asset/daml/issues/11761#issuecomment-978947565) ``` panic: proto: extension number 65020 is already registered on message google.protobuf.FieldOptions ``` Go dependencies are now pulled in via Gazelle. By default Gazelle will generate new proto rules for any `.proto` files encountered in third party Go dependencies. However, many of these already have pregenerated `.pb.go` files generate with the appropriate configuration. The problem can be avoided by configuring Gazelle to not generate new proto rules, but instead use pre-existing `.pb.go` files. For reference the field number is set in [go-proto-validators](32a686adf8/validator.proto (L19)) which is an indirect dependency through protoc-gen-doc. In this case we need to update protoc-gen-validate to v0.6.2 to include4f41f10ddewhich fixes unknown label errors. * ./fmt * Expose gRPC status.proto for Haskell bindings * Update Gazelle to support embedsrcs on Windows `protoc-gen-doc` relies on `go:embed` file embedding2dde01902b/resources.go (L8). Gazelle supports `embedsrcs`, however, it did not generate the attribute correctly on Windows due to the different directory separator. This is fixed in https://github.com/bazelbuild/bazel-gazelle/pull/1101. * Add gazelle to compatibility workspace It's loaded into `@daml`'s top-level `BUILD` file and ends up being a dependency of the compatibility workspace as well. * shift go_googleapis import * Delete dead code protobuf is imported transitively. * Document how to add Go dependencies Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org> Co-authored-by: Andreas Herrmann <andreas.herrmann@tweag.io>
21 lines
586 B
Markdown
21 lines
586 B
Markdown
# Working with Go in Bazel
|
|
|
|
## Dependencies
|
|
|
|
Go dependencies are managed by [`go.mod`][go-deps] and [Gazelle][gazelle].
|
|
To add a new Go dependency
|
|
|
|
1. Run `go get` to add the dependency to `go.mod`. E.g.
|
|
```
|
|
go get github.com/envoyproxy/protoc-gen-validate@v0.6.2
|
|
```
|
|
This should update `go.mod` and `go.sum`.
|
|
2. Run Gazelle to import the dependencies to Bazel.
|
|
```
|
|
bazel run //:gazelle-update-repos
|
|
```
|
|
This should update `go_deps.bzl`.
|
|
|
|
[go-deps]: https://go.dev/doc/modules/managing-dependencies
|
|
[gazelle]: https://github.com/bazelbuild/bazel-gazelle
|