digital-asset/daml
1
1
Fork 0
mirror of https://github.com/digital-asset/daml.git synced 2024-11-10 10:46:11 +03:00
Code Issues Projects Releases Wiki Activity
a0aee0f248
daml/release/RELEASE.md
Sofia Faro a0aee0f248
Rename daml sandbox to daml sandbox-kv (#12394) 
* Rename daml sandbox to daml sandbox-kv

Also drop the default sandbox on `daml start`

Part of #11831

changelog_begin
changelog_end

* update release test instructions

* try to fix a couple compat tests

* dont need special 0.0.0 logic

* buildifier-fixx
2022-01-17 10:36:06 +00:00

15 KiB
Raw Blame History

Making a Release

For snapshot releases, skip the steps marked [STABLE]. For stable releases, skip the steps marked [SNAPSHOT].

Valid commits for a release should come from either the main branch or one of the support release/a.b.x branches (e.g. release/1.0.x branch is for patches we backport to the 1.0 release branch).

Important

: If the release fails, please delete it from the releases page and write how it failed on the PR.

  1. [STABLE] Go through the checklist before making the release. Note that the checklist is not available publicly.

  2. [STABLE] Stable releases are promoted from snapshot releases. Open a PR that changes the LATEST file to remove the -snapshot suffix on the corresponding snapshot, and add the Standard-Change label.

  3. [SNAPSHOT] For most snapshot releases, the PR is created automatically. Double-check the snapshot version: it may need incrementing. Ask on Slack (#team-daml) if you're not sure.

    If you are manually creating the PR for an out-of-schedule snapshot, start from latest main and run

    ./release.sh new snapshot

    If you want to have a stricter control over the specific commit and version prefix the command can also be used as follows:

    ./release.sh snapshot <sha> <prefix>

    for example:

    $ ./release.sh snapshot cc880e2 0.1.2
cc880e290b2311d0bf05d58c7d75c50784c0131c 0.1.2-snapshot.20200513.4174.0.cc880e29

    The former version of the command defaults to HEAD as the commit and tries to figure out the version prefix to use based on the first line of the LATEST file. This also mean that you will have to use the latter form for maintenance releases. Once the script has run, open a PR to be merged to main (even if it's for a maintenance release) with the changed LATEST file, add the line produced by the release.sh invocation in a meaningful position (if you’re not sure, semver ordering is probably the right thing to do) and add the Standard-Change label. It is better to add such a label before confirming the PR's creation, else the associated CI check will fail and merging the PR will require you to re-run it after all the other ones have completed successfully.

  4. Once the PR has built, check that it was considered a release build by our CI. If you are working from an automated PR, check that it sent a message to #team-daml to say it has finished building. If the PR was manually created, you can look at the output of the check_for_release build step.

  5. [STABLE] The PR must be approved by a team lead before merging. As of this writing (2021-10-12), @bame-da, @gerolf-da, @cocreature, @stefanobaghino-da or @adriaanm-da.

  6. Merge the PR and wait for the corresponding main build to finish. You will be notified on #team-daml.

  7. On Windows, install the new SDK using the installer on https://github.com/digital-asset/daml/releases.

    On macOS/Linux:

    curl -sSL https://get.daml.com/ | sh -s "$VERSION"

    where $VERSION is the full version tag of the new release you are making, i.e. the second column of the LATEST file.

    Tips for Windows testing in an ad-hoc machine

    If you are part of the release rotation, you can create Windows VMs through the ad-hoc project. The created machine is a bit raw, though, so here are a few tips to help you along.

    ad-hoc.sh prints IP address, username and password for the created Windows VM. Save this output. You will need this information later when you create an RDP connection.

    If you're on a Mac, you can use Microsoft Remote Desktop to connect; on Linux, you can use Remmina.

    Remmina notes: when creating an RDP connection, you may want to specify custom resolution. The default setting is to use client resolution. You may notice a failure due to color depth settings. You can adjust those in the settings panel right below the resolution settings.

    The ad-hoc machines take a bit of time to be available after being reported as created, so be patient for a bit if your first connection attempt(s) fail.

    Windows machines come with both Internet Explorer and Firefox installed. Do not make the mistake of trying to use Internet Explorer.

    Ad-hoc machines also come with Node, VSCode and OpenJDK preinstalled, so you don't need to worry about those.

    The script that installs Firefox, Node, VSCode and OpenJDK runs once the machine is available for login. If you can't find the software you need immediately, just wait for a couple of minutes.

    All of the commands mentioned in this document can be run from a simple DOS prompt (start menu -> type "cmd" -> click "Command prompt").

  8. Prerequisites for running the tests:

    • Visual Studio Code, Java-SDK
    • Node.js
      • Just the bare install; no need to build C dependencies.
      • create-daml-app doesn't work with the latest version 17.x of node.js. If you have nix installed, you can use a suitable version of nodejs by running nix-shell -p nodejs-12_x before running the npm commands below.

  9. Run daml version --assistant=yes and verify that the new version is selected as the assistant version and the default version for new projects.

  10. Tests for the getting started guide (macOS/Linux and Windows). Note: if using a remote Windows VM and an RDP client that supports copy/paste, you can run through this on both Windows and your local unix in parallel fairly easily.

    1. For these steps you will need the documentation for the release you are about to make. Documentation is published at every hour so if you wait for a bit you can go to https://docs.daml.com/$VERSION/getting-started/index.html. Otherwise, check out the commit that you are referencing in the LATEST file and build documentation locally via ./docs/scripts/preview.sh.

    2. daml new create-daml-app --template create-daml-app

    3. cd create-daml-app

      1. daml start --sandbox-kv

    4. In a new terminal, from the ui folder:

      1. npm install

      2. npm start

    5. Open two browser windows (you want to see them simultaneously ideally) at localhost:3000.

    6. Log in as Alice in the first window, log in as Bob in the second window.

    7. In the first window, where you are logged in as Alice, follow Bob by typing their name in the text input and pressing enter. Verify that Bob appears in the list of users Alice is following. Verify in the other browser window that Alice shows up in Bob’s network.

    8. In the second window, where you are logged in as Bob, follow Alice by clicking on the "add user" logo to right of Alice name below the "The Network" heading. Verify that Alice appears in the list of users Bob is following. Verify in the other browser window that Bob shows up in Alice’s network.

    9. Open the your first feature section of the GSG, e.g., from https://docs.daml.com/$VERSION/getting-started/first-feature.html if you did not build docs locally.

    10. Run daml studio --replace=always from the project root directory and open User.daml.

    11. Copy the Message template from the documentation to the end of User.daml.

    12. Copy the SendMessage choice from the documentation to the User template below the Follow choice.

    13. Close VSCode.

    14. In the terminal where daml start is running, press 'r' respectively 'r' + 'Enter' on Windows.

    15. Run code . from the project root directory (the extension is already installed, no need to use daml studio).

    16. Create MessageList.tsx, MessageEdit.tsx and modify MainView.tsx as described in the documentation.

    17. Verify that you do not see errors in the typescript code in VSCode.

    18. Close VSCode.

    19. As before, open two browser windows at localhost:3000 and log in as Alice and Bob.

    20. Make Alice follow Bob.

    21. From Bob, select Alice in the Select a follower drop down, insert hi alice in the message field and click on Send.

    22. Verify that Alice has received the message in the other window.

    23. Make Bob follow Alice.

    24. From Alice, select Bob in the drop down insert hi bob in the message field and click on Send.

    25. Verify that Bob has received the message in the other window.

    26. You can now close both browser windows and both running processes (daml start and npm start).

    27. Don't forget to run this on the other platform! E.g. if you just ran through on Linux or macOS, you still need to run on Windows, and vice versa.

  11. Run through the following test plan on Windows. This is slightly shortened to make testing faster and since most issues are not platform specific.

    1. Run daml new quickstart to create a new project and switch to it using cd quickstart.
    2. Run daml start.
    3. Open your browser at http://localhost:7500, verify that you can login as Alice and there is one template and one contract.
    4. Kill daml start with Ctrl-C.
    5. Run daml studio --replace=always and open daml/Main.daml. Verify that the script result appears within 30 seconds.
    6. Add + at the end of line 25 after (PartyIdHint "Alice") and verify that you get an error on line 26.

  12. On your PR, add the comment:

    Manual tests passed on Windows.

  13. Tests for quickstart-java (Linux/macOS)

    While this is no longer the default getting started guide we still test it for now since it covers things not covered by the new GSG (Navigator, Scripts, Maven artifacts, …)

    1. Create a new project with daml new quickstart --template quickstart-java and switch to it using cd quickstart.

    2. Verify the new version is specified in daml.yaml as the sdk-version.

    3. Run daml start --sandbox-kv. Your browser should be opened automatically at http://localhost:7500. Login as Alice and verify that there is 1 contract and 3 templates. Close the tab and kill daml start using Ctrl-C.

    4. Run daml build.

    5. In 3 separate terminals (since each command blocks), run:

      1. daml sandbox-kv --wall-clock-time --port 6865 .daml/dist/quickstart-0.0.1.dar
      2. daml script --dar .daml/dist/quickstart-0.0.1.dar --script-name Main:initialize --ledger-host localhost --ledger-port 6865 --wall-clock-time && daml navigator server localhost 6865 --port 7500
      3. daml codegen java && mvn compile exec:java@run-quickstart

      Note: It takes some time (typically around half-an-hour) for our artifacts to be available on Maven Central. If you try running the last command before the artifacts are available, you will get a "not found" error. Trying to build again in the next 24 hours will result in:

      Failure to find ... was cached in the local repository, resolution will not be reattempted until the update interval of digitalasset-releases has elapsed or updates are forced

      This is Maven telling you it has locally cached that "not found" result and will consider it valid for 24h. To bypass that and force Maven to try the network call again, add a -U option, as in mvn compile exec:java@run-quickstart -U. Note that this is required to bypass your local cache of the failure; it will not be required for a user trying to run the quickstart after the artifacts have been published.

      Another common problem is that artifacts fail to resolve because of custom Maven settings. Check your ~/.m2/settings.xml configuration and try disabling them temporarily.

    6. Point your browser to http://localhost:7500, login as Alice and verify that there is 1 contract, 3 templates and 1 owned IOU.

    7. Check that curl http://localhost:8080/iou returns:

      {"0":{"issuer":"EUR_Bank","owner":"Alice","currency":"EUR","amount":100.0000000000,"observers":[]}}

    8. Kill all processes.

    9. Run daml studio --replace=always. This should open VSCode and trigger the Daml extension that's bundled with the new SDK version. (The new VSCode extension will not be in the marketplace at this point.)

    10. Open daml/Main.daml.

    11. Click on Script results above initialize and wait for the script results to appear.

    12. Add + at the end of line 14, after "Alice") and confirm you get an error in line 15.

    13. Add 1 after the + and confirm you get a type error in line 14, which says that Script Party does not match Int.

    14. Delete the +1 and the e in the second "Alice" and verify that the script results are updated to the misspelled name.

    15. Right click on eurBank in line 20 and verify that "Go to Definition" takes you to the definition in line 17.

    16. Close all files.

    Note: when running daml studio --replace=always, you force the installation of the VSCode extension bundled with the Daml SDK, and disable the autoupgrade mechanism in VSCode. To instruct VSCode to go back to the published version of the extension, including auto-upgrades, you can run daml studio --replace=published.

  14. On your PR, add the comment:

    Manual tests passed on [Linux/macOS].

    specifying which platform you tested on.

  15. If the release is bad, delete the release from the releases page. Mention why it is bad as a comment on your PR, and stop the process here.

    Note that the Standard-Change label must remain on the PR, even if the release has failed.

  16. Announce the release on the relevant internal Slack channels (#product-daml, #team-daml). For a stable release, direct people to the release blog post; for a prerelease, you can include the raw output of the unreleased.sh script.

  17. [STABLE] Go to the releases page and remove the prerelease marker on the release. Also change the text to See [the release notes blog]() for details. adding in the direct link to this version's release notes. Documentation for this release will be added to docs.daml.com on the next hour.

  18. [STABLE] Coordinate with product (& marketing) for the relevant public announcements (Daml Forum, Twitter, etc.).

  19. [STABLE] Documentation is published automatically once the release is public on GitHub, though this runs on an hourly cron.

Thanks for making a release!