Commit Graph

5172 Commits

Author SHA1 Message Date
Jaroslav Tulach
a6fbdb11ce
Avoid using assert in Scala, use assertInJvm to elide it in production (#11027)
Fixes #11022 and in general fixes #5787 by avoiding calls to Scala's `assert` function and using regular one written in Java that uses `assert` keyword and is thus sensitive to `-ea` command line option of the JVM. Use `assertInJvm` in newly written Scala code to get typical JVM behavior on `assert`.
2024-09-16 06:32:47 +00:00
Hubert Plociniczak
d795518a8f
Poor man's hack to deal with stuck index generation (#11065)
* Poor man's hack to stuck index generation

CI has started experiencing instability when generating libraries
indexes. This change ensures that we don't wait 360(!) minutes until it
gives up.

A proper diagnosis is in progress, obviously.

* Get threaddump of the stuck process

* remove deprecation
2024-09-15 10:59:54 +02:00
Hubert Plociniczak
d7e8b083f8
Regenerate workflows after bumping wasm-pack (#11079) 2024-09-15 08:59:23 +00:00
Hubert Plociniczak
742fc5f9ea
Fix invalid version of wasm-pack (#11078)
Long shot to potentially fix wasm-pack/wasm-bindgen generation issues.
Hosted MacOS ARM runner uses `0.12.1` and that one works.
2024-09-14 21:06:13 +02:00
Hubert Plociniczak
8fab4f5ea6
Workaround for Electron sanbox issues on Ubuntu (#11038)
* Workaround for Electron sanbox issues on Ubuntu

Disabling sanbox, while a non-secure option, appears to be currently the
only option to workaround Electron issues on latest Ubuntu (24.04).
When passed to Enso it is treated as a regular argument, preventing the
start of the product.
This change treats `--no-sandbox` specially by ignoring all arguments
that precede it (and including itself).

* address review
2024-09-13 23:25:32 +02:00
somebody1234
066d4ea609
Local dashboard fixes (#11066)
- Fix https://github.com/enso-org/cloud-v2/issues/1479
- See #11059 for rest of fixes.
- When you add a new folder it is now selected and in rename mode
- Double click opening no longer adds (2) to the name when there are no duplicates
- When dragging a file to upload, the "Drop here to upload box" now properly disappears after dropping
- Fix removing folder from favorites list

Other changes:
- Switch "delete user" modal to new "Dialog" and "Form" components instead of old "Modal" and HTML "form" components

# Important Notes
None
2024-09-13 16:49:14 +00:00
Sergei Garin
bdadedbde5
Cloud backend issues (#11067)
Closes: enso-org/cloud-v2#1481
2024-09-13 15:46:30 +00:00
Sergei Garin
b5122348da
MFA (#10875)
* Draft checkbox component

* Fixes in Setup Page

* Invite Users

* Add usergroup setup after subscription

* Fix comments

* Refetch Interval + Feature Toggles

* Fix lint

* Address issues

* Fix Dialog

* Assign users to the user group

* Use transitions to navigate between steps

* Small fixes

* Improve styling for scrollbars

* Fix typescript

* OTP input

* Fix setup logic

* Show Setup dialog only for admins

* Add otp

* OTP input

* 2FA settings section

* Small improvements

* Fixes

* Small fixes

* Remove w-full

* TOTP at login

* Fixes in 2FA

* Fixes in types

* Fix totp

* Merge fixes

* Merge fixes x2

* Merge fixes x2

* Fix types

* Fix types

* Fix cancel button

* Fix reset button

* Fix types

* Fix prettier

* Fix prettier

* Fix lint

* Fix lint

* Fix control

* Address prettier

* Fix MFA mock

* Fix sign in message

* Fix tests

* Address CR

* Fix types
2024-09-13 16:00:31 +03:00
Sergei Garin
3c1db7dbc1
Remove edit name on mod+click (#11058)
Closes: enso-org/cloud-v2#1476
2024-09-13 12:51:35 +00:00
Sergei Garin
16a4466156
Handle 403 for listGroups and getOrganization (#11044)
Closes: enso-org/cloud-v2#1470

This PR handles 403 responses for certain RemoteBackend endpoints
2024-09-13 12:43:02 +00:00
Dmitry Bushev
e77a6067a0
Fix cached method pointers in expression updates (#11060)
close #11028

Changelog:
- update: hide cached method pointer info in expression updates of evaluated values

# Important Notes
https://github.com/user-attachments/assets/861bb2c8-7613-4fcf-a976-0e37acff4ec0
2024-09-13 11:02:30 +00:00
James Dunkerley
8eb9e21e40
Updated feature list (#11061)
Update the list of what is in what...
![image](https://github.com/user-attachments/assets/65abca35-9e39-4a7c-a001-230923ff04d3)
2024-09-12 20:09:00 +00:00
Adam Obuchowicz
8908a73f6a
Fix Vector Drag (#11057) 2024-09-12 11:20:49 +01:00
AdRiley
b8516f7b4a
Make all Common_Spec tests pass for SQLSerever (#10810)
* More SQL tests

* Remove duplicate

* Fix another test

* Temp fix

* More temporay fixes

* More green

* Another green

* Another one

* Fix counts

* Temporary change

* Fix tests

* Auto-commit work in progress before clean build on 2024-09-06 10:53:46

* Another fix

* Green

* Specialise ensure_query_has_no_holes

* cleanup

* Cleanup

* Cleanup

* Clean

* Code review changes
2024-09-12 10:08:55 +01:00
GregoryTravis
f409cb8aac
fix test (#11049)
Repairs a test not run in CI
2024-09-11 16:34:07 +01:00
Sergei Garin
ea0f5a1962
Open a welcome dialog after user signed up (#11029)
Closes: enso-org/cloud-v2#1475
2024-09-11 15:26:14 +00:00
AdRiley
a666585afe
Add update mode to Running (#11045) 2024-09-11 17:41:33 +03:00
GregoryTravis
97a1628017
Add a banker's rounding primitive for Snowflake (#11037)
* log table_builder create

* fix log, 38,12

* fix scale in rounding tests

* shorten some decimals

* fix test

* dialect flags

* revert native bankers

* missing import

* sf builtin

* runs

* works on +/-2/4.5

* remove extreme precision limit tests

* remove another extreme precision test, and restore batching for bankers rounding tests

* cleanup

* cleanup

* cleanup, comment
2024-09-11 10:29:41 -04:00
marthasharkey
4ac59827df
Scatterplot fixes (#11041) 2024-09-11 14:03:40 +00:00
James Dunkerley
a33376c8d7
Better workaround for missing root folder. (#11046)
With the changes for asset directory the auto-creation condition was failing.

This should make it work again.
2024-09-11 13:18:27 +00:00
Ilya Bogdanov
a0a4a2fef3
Add regression e2e test for empty graph (#11031)
Closes #11026
2024-09-11 11:40:24 +00:00
Adam Obuchowicz
497da82b10
Fix file associations on Windows + opening project bug (#11030)
* Fixes [#10983](https://github.com/enso-org/enso/issues/10983) The `ext` field was not set according to the documentation in rust
* Also discovered a regression in opening project by passing argument/clicking the file: we store the file location as `file://` URL, but without caution, it made a havoc with windows paths.

# Important Notes
- [x] **Need to confirm that everything works on macOS** (installation with file associations + opening project when process is running and when not)
2024-09-11 10:44:52 +00:00
Dmitry Bushev
bea9e068b4
Remove pool of FileManager actors (#11036)
close #10970

Changelog:
- remove: FileManager actors pool

Language Server executes IO on a separate thread pool for blocking operations and does not block the actor
2024-09-11 08:15:54 +00:00
Jaroslav Tulach
8b5c6338f7
Log details when to_display_text invocation fails (#11025)
Closes #10770 by dumping out more information when `to_display_text` invocations fails.
2024-09-11 03:18:06 +00:00
Kaz Wesley
1bcbc00004
Update Vue (#11016)
See: https://blog.vuejs.org/posts/vue-3-5
2024-09-10 13:18:35 -04:00
somebody1234
097f5b231d
Fix Datalinks (#11003)
- Fix https://github.com/enso-org/enso/pull/10929#issuecomment-2333467567
- Fix incorrect requests being sent for newly created Datalinks
- Fix Datalinks being created in the root folder instead of the current folder due to clicks on the dialog deselecting the currently selected folder
- Fix auto-scroll caused by Assets Table refreshing

# Important Notes
None
2024-09-10 14:59:04 +00:00
Dmitry Bushev
ab0a5e0c36
Improve the speed of preorder operation on IR (#11019)
close #10537

Changelog:
- add: implement `IR.preorder` method with callback
- update: update `IR.preorder` method usages

# Important Notes
Shows ~10% speed improvement during the compilation
2024-09-10 14:47:50 +00:00
Hubert Plociniczak
62e15696ec
Re-compile module if IdMap is present (#11032)
Loading IR caches and IdMap for a module don't play very well. Rather
than complicating logic and introducing yet another re-compilation
request let's not even attempt to deserialize a module if IdMap is
present. The cost of compiling a single module (right now containing the
project itself) is negligble, compared to a possibility of bugs that
we've encountered so far.
2024-09-10 16:24:57 +02:00
Adam Obuchowicz
32f10a55f4
Use enso paths in cloud browser (#11001)
Fixes #10947
2024-09-09 22:56:52 +00:00
Sergei Garin
1fdaf37add
Fix skipping creating a user if we don't change the default name (#11013)
Closes: enso-org/cloud-v2#1473

This PR fixes a bug introduced in #10946
2024-09-09 22:30:53 +00:00
James Dunkerley
7b4b635fa8
Add Row Number starts at 0 and other tweaks. (#11017)
- Change default to be from 0.
- Alter widgets so always shown.
- Tweaks to the Welcome screen following review with Product Team.
- Use 0 for default seed option in `Index_Sub_Range.Sample`.
- Add ALIASES for aggregate and running.
- Add more imports for `Widgets.enso` to fix extension methods not working.
2024-09-09 20:26:59 +00:00
GregoryTravis
2adb8bb86d
Use NUMBER(38, 12) as default range for Snowflake DECIMALs (#10971) 2024-09-09 18:31:09 +00:00
Adam Obuchowicz
414eee0b48
Fix initialization after reconnecting (#11014)
Fixes #10948

The problem was in the binary reconnecting: we sent the first "initProtocol" message, but the connection was reset, and then we try to initialize again. While looking good, the problem was that the party websocket we use queued the first initProtocol message and re-send it by itself on reconnect. Our initProtocol was also sent, but it did not get any response, blocking any further request like `writeBytes`.
2024-09-09 13:49:03 +00:00
Jaroslav Tulach
93252ee358
Avoid AliasAnalysis for Hello_World.enso (#10996) 2024-09-09 14:21:22 +02:00
James Dunkerley
7556d8f794
Add file to be signed. (#11010) 2024-09-09 11:49:16 +01:00
Jaroslav Tulach
89c5b31144
Fold output of each benchmark (#10914) 2024-09-09 12:30:22 +02:00
James Dunkerley
a86e37b36f
Expand Templates (#10994)
- Update all the templates to the newest versions.
- Fix any defects in the templates.
- Update the rust and scala code to package and download the templates.
- Update the front end to have images for every template (with some Gemini assists).

https://github.com/user-attachments/assets/59a1f845-f409-45bb-9c77-fe3a2d1262b1
2024-09-09 10:27:04 +00:00
Ilya Bogdanov
7431f1c1b9
Fix CB visualization buttons (#11005)
Fixes #10472

Remove fullscreen button, fix Show/hide button, remove resize handles.

https://github.com/user-attachments/assets/7108bf7e-2f45-4c24-a8c3-d0b3c0135a20
2024-09-09 09:18:05 +00:00
Sergei Garin
f418f49ea5
Fix edge cut off in plan select at first (#11007)
- Closes: enso-org/cloud-v2#1454

This PR fixes the Plan selector grid. Also it aligns cards vertically
2024-09-09 08:38:42 +00:00
Hubert Plociniczak
92dd3c9613
Add retries when fetching tableau artifacts in sbt (#10984)
* Add retries when fetching tableau artifacts in sbt

Seeing frequent network failures when fetching tableau artifacts e.g.,
https://github.com/enso-org/enso/actions/runs/10705660288/job/29681570936#step:7:918

Network failures are OK but we shouldn't kill builds immediately because
of that. Let's try harder.

* update codeowners

* use backoff

* fighting with sbt
2024-09-09 10:16:54 +02:00
somebody1234
51733ee876
Move some Drive state to zustand (#10913)
- Move Asset Panel open state to zustand
- This avoids re-rendering the entire Data Catalog view every time an asset is clicked
- Move Asset Panel props to zustand
- Move search suggestions to zustand
- Memoize `AssetRow` to avoid re-rendering every row when unnecessary

# Important Notes
It's not a perfect solution to the performance issues, however selection performance seems to have improved quite nicely.
2024-09-08 07:38:13 +00:00
somebody1234
9ec60299e4
Local Dashboard fixes (#10958)
- Fix most of https://github.com/enso-org/cloud-v2/issues/1459
- Prevent click + click from triggering rename on Windows and Linux. Behavior is preserved on macOS.
- Fix text in Drive when root folder is empty
- Properly remove the "Drop here to upload box" after a file is dropped
- "Copy as path" now unconditionally uses `/` for path delimiters, even on Windows
- Duplicating a project in the root folder on Windows no longer errors
- Extra folders in the sidebar now (correctly) show folder name, rather than path, on Windows
- Mouse pointer when dragging to a folder is now move, not copy

Not addressed:
- [no-repro] Tooltips should have some latency before showing up
- This should already be the case, although it may work weirdly (once the tooltip opens, there is no delay on subsequent tooltips opening until the last tooltip closes.)
- [no-repro] Ctrl-click should add to selection
- Column width should be resizable
- This requires a refactor and therefore is considered out of scope for this PR
- [no-repro] Choosing root folder needs a file browser
- [no-repro] Choosing root folder doesn't do anything get the same list as we had before
- [no-repro] Open in explorer didn't work in a file but did on project - possibly fixed by path changes.
- [no-repro] Opening an enso-project by double clicking resulted on it being renamed with a (2)

Related changes:
- Make "root directory" picker's file browser default to the current root directory

# Important Notes
None
2024-09-08 06:54:41 +00:00
GregoryTravis
6f97e8041b
Upgrade SQLite to 3.46 (#10911)
Before 3.46, the SQLite parser had a limited stack, which could overflow for certain complex queries.

CTE optimizations make some of our queries much smaller, but also a little bit more deeply nested, causing the parser stack to overflow. 3.46 removes this stack limitation.

Closes #10910.
2024-09-07 17:58:59 +00:00
AdRiley
60ea64e799
Add Not Paragraph icon (#11006)
![image](https://github.com/user-attachments/assets/d597b972-d154-4669-8f9b-fb9fa162e4cf)
2024-09-06 21:59:47 +00:00
Paweł Grabarz
6bfdda33a9
Do not crash on empty main function body. (#10990)
Fixes #10976

https://github.com/user-attachments/assets/00b2279d-2acf-468b-8c3c-aa6885cba23d


Addressed issue of empty body block being incorrectly "repaired" into an empty group, geneating invalid `()` syntax. Appending nodes to an empty function now actually replaces its body block, instead of creating a temporary orphan body block node.

Note that empty main function is still considered an error on the engine side, but it doesn't impact the IDE in negative way. Things work again as soon as a node is inserted.

Also fixed a few issues causing hot-reloading to break. Now edited AST code properly hot-reloads all affected modules without breaking the app.
2024-09-06 18:45:20 +00:00
somebody1234
3420a05a84
Dashboard improvements 08/26/2024 (#10946)
- Address part of https://github.com/enso-org/cloud-v2/issues/1453
- Many of the other issues are addressed in other PRs.
- Username in "Set username" dialog defaults to user email
- Hide "Share with" column for Free and Solo plans
- Reorder categories in left sidebar
- Previous: Cloud, My Files, Recent, Trash, ...Users, ...Teams
- New: Cloud, Me (formerly My Files), ...Users, Teams, Recent, Trash

- Fix #10968
- Show column toggles on Local category too (previously was explicitly specialcased to only be visible on Cloud categories as a remnant of the old design with the backend switcher at the top)
- Added to this PR as this PR already touches the column toggles

# Important Notes
None
2024-09-06 15:13:56 +00:00
somebody1234
3bcc694af9
Settings improvements (#10924)
- Address https://github.com/enso-org/cloud-v2/issues/1457
- Show x instead of a circle for close tab icon on Windows and Linux
- Free / Solo no longer shows Organization, Members, User Groups, and Activity Log
- Invite button should only be there for the admin in Team or above (should already be present)
- Should list the required symbols in the password change.
- Changing headshot appeared briefly and then disappeared.
- Fix https://github.com/enso-org/cloud-v2/issues/1455
- The `Alert` component no longer focuses itself on every keystroke.
- Fix #10988
- Same issue as above.

Other related changes:
- Fix word wrapping in tooltips when a word is wider than the entire tooltip
- Add word wrapping to "members" table in members tab
- Limit length of "email" column of members table in "user groups" tab
- Hide empty sections
- Add text to empty "user groups" table in "user groups" tab
- ~~Close "set organization name" modal when organization name is set~~
- Already fixed by another PR

# Important Notes
None
2024-09-06 14:29:26 +00:00
somebody1234
c87053d600
Compute correct root path for Solo users (#10993)
- Change paths for cloud assets for users on Solo plan to be `enso://User/<username>/<path>` instead of the legacy `enso://<username>/<path>`

# Important Notes
None
2024-09-06 13:58:12 +00:00
Sergei Garin
d242ed18bb
Mark cloud as beta (#10992) 2024-09-06 14:17:57 +01:00
Hubert Plociniczak
6617dd9d86
Remove module that was causing failures for enterprise edition of GraalVM (#10991)
We still seem to be able to build runner on community and enterprise editions of GraalVM without the problematic `jdk.compiler.graal` module.

Closes #10895.
2024-09-06 13:04:35 +00:00