Commit Graph

5221 Commits

Author SHA1 Message Date
somebody1234
c18d581c3e
Fix rest of user/team permissions checks and "new label" dialog (#11126)
- Fix remaining permissions checks to check for team permissions as well, not just user permissions
- Fix https://github.com/enso-org/cloud-v2/issues/1498
- Switch "new label" dialog from `Modal` (old) to `Popover` (new)
- Fix https://github.com/enso-org/cloud-v2/issues/1500
- Show correct project state even for projects not opened as tabs
- Unconditionally show project play icon instead of network (graph) icon, even when user lacks access (no exec permissions, or in the trash category)
- Disable (attempting to) open project in trash via double click

# Important Notes
None
2024-09-25 13:15:52 +00:00
Jaroslav Tulach
f37e50e87b
Propagate comparator warnings via Any.== (#11009)
Fixes #10679 by changing the return type of `EqualsXyzNode`s to `EqualsAndInfo`. This class holds the result of the comparation as well as any attached warnings. `EqualsBuiltinNode` then re-attaches the warnings, if there are any.
2024-09-25 09:48:34 +00:00
Kaz Wesley
edb4a11c28
Toolbar fixes (#11157)
Fix a couple of issues in the new viz toolbar API.
2024-09-24 13:11:54 +00:00
Paweł Grabarz
e2cf20af5f
Fix application start when YDOC_SERVER_URL is undefined (#11160) 2024-09-24 11:05:25 +00:00
Sergei Garin
e6c038513b
Fix focusing after clicking "Rename" in context menu (#11130)
This PR fixes a behavior when we try to focus an editable span after clicking on "Rename" in the  Context menu
2024-09-24 10:56:26 +00:00
marthasharkey
a04ae1c9ad
scatterplot- on point click (#11142) 2024-09-24 09:14:39 +00:00
Sergei Garin
7baca4d2a1
Fix selecting directory after creating (#11109)
This PR fixes a bug, when directories after creation were not toggled into editing mode
2024-09-24 08:19:38 +00:00
Jaroslav Tulach
c3456ad2df
Eliminate Blanks inside of Type.Ascription (#11155) 2024-09-24 08:57:27 +02:00
Jaroslav Tulach
c6d18576cc
Initialize Enso Terminal in a background thread (#11149) 2024-09-24 08:56:13 +02:00
Kaz Wesley
a8810e19f2
New visualization UI API (#11077)
- Improve visualization UI APIs:
- Isolate visualizations within a Vue Custom Element to prevent any unintended interaction between GUI and visualization CSS/JS.
- New visualization-menus API: Visualizations no longer create toolbars using the GUI's components; a simpler JS interface moves the responsibility for appearance of controls to the GUI.
- Simplify visualization configuration interface. Properties that should not be exposed to visualizations have been removed. Visualizations no longer need logic implementing fullscreen mode; the `size` property reflects the current renderable area.
- Visualizations no longer use a `VisualizationContainer`; the visualization simply renders its content at its root.
- Viz dropdowns: Buttons always show arrows (fixes #10809)
- Fullscreen mode: Fix rendering size of scatter plot and other visualizations
- JSON visualization interactivity: Fix intermittent incorrectly non-interactive state
- Viz toolbars: Fix squished-looking rightmost button.

Other API changes:
- `Interaction` no longer includes `GraphNavigator` with pointer events.
2024-09-23 18:31:26 +00:00
James Dunkerley
3f748fdf5c
Change new project text (#11152)
Following feedback from @NedHarding and @AdRiley
![image](https://github.com/user-attachments/assets/820f53e6-70ef-4355-a8a3-52dda1fce6ab)

![image](https://github.com/user-attachments/assets/aa474c2c-73d3-4355-a4aa-ef3990ff6207)
2024-09-23 16:51:32 +00:00
Adam Obuchowicz
3941634036
Table Widget: removing columns and rows (#11151)
Fixes: #10758

[Screencast from 2024-09-23 13-19-31.webm](https://github.com/user-attachments/assets/aa28708e-f4c9-400a-966d-1d82abe99f1e)

# Important Notes
To add custom options, I needed to bump AGGrid version. But not the newest one, as it made some bugs I failed to fix.
2024-09-23 14:24:40 +00:00
Kaz Wesley
3481d20dc6
Component comment fixes (#11144)
<img width="315" alt="Screenshot 2024-09-20 at 10 07 36" src="https://github.com/user-attachments/assets/8886feb7-99f3-4c44-bd2a-c7795f951f8e">

- Comment position when menu is hidden does not obscure input arrow (fixes #11114)
- Comment is not inside a larger invisible bounding box (fixes #11140)
2024-09-23 12:51:19 +00:00
somebody1234
1fc4fe6b6e
Fix width of settings sections when only a single column is visible (#11138)
- Fix settings columns having zero width when only a single column is visible

# Important Notes
None
2024-09-23 09:35:18 +00:00
Hubert Plociniczak
7c413298fb
More info when critical failure occurs (#11092)
* More info when critical failure occurs

Log problematic module to help with debugging critical failure.

* One more exception

* s/System.err/Logger.error/

* maybe append slf4j deps

* fix what looks like a long standing typo

`GeneratedFormatTests.java` not `GeneratedFormatTests..java`

* one more typo

* Fix directory where to look for classpath

`./run java-gen test --skip-version-check` now works. At least locally.

* Local is fine, CI is not. More temporary debugging...

* Ensure project's managedClasspath is exported

Running java tests requires us knowing all additional dependencies as
they have to be added to the classpath manually. That can only be
ensured by invoking the right sbt target.

* Move sbt call after graalvm setup

* removing CI debugging

* Apply suggestions from code review

Co-authored-by: Kaz Wesley <kaz@lambdaverse.org>

---------

Co-authored-by: Kaz Wesley <kaz@lambdaverse.org>
2024-09-23 10:59:56 +02:00
Hubert Plociniczak
c4ace00a4d
Disable signing artifacts for PRs and develop (#11094)
* Disable signing artifacts for PRs and develop

Added `*-sign-artifacts` to disable/enable signing. By default it is
true, except for PRs and develop.

* nit

* typo

* lint

* linting
2024-09-23 10:00:27 +02:00
Paweł Grabarz
c996707027
Add support for touch-based graph navigation and selection (#11056)
Fixes #9493

Tested on windows desktop (standard mouse), macbook touchpad and iphone, which should behave similarily to windows touchscreen devices.
2024-09-20 16:31:45 +00:00
marthasharkey
b53d7b0521
scatterplot- time series support (#11085) 2024-09-20 15:48:28 +00:00
Kaz Wesley
e587d564f8
Improve backend error handling (#11136)
- Fix debug logging for #11088 case--attempt to create an exception that is its own cause fails.
- In case the parser is used after closing, throw an `IllegalStateException` instead of UB. (This case is not known to occur and doesn't seem to be behind the #11121, but we should handle it more safely if it does.)
2024-09-20 13:23:52 +00:00
Jaroslav Tulach
f05997d58c
Removing serialization metadata (#11128) 2024-09-19 15:44:42 +02:00
Hubert Plociniczak
2c362ea519
More info when NPE is encountered (#11125)
We are seeing this problem almost daily and need more info rather
urgently.
Related to #11088.
2024-09-18 23:14:36 +02:00
Jaroslav Tulach
37688033c8
Don't convert type to the same type (#11122) 2024-09-18 18:15:58 +02:00
Gregory Michael Travis
859b572242
Better error message for NULLs in primary key columns (#11055) 2024-09-18 11:56:21 -04:00
Adam Obuchowicz
8eb6aaa188
Fix changelog (#11124)
The version is wrong
2024-09-18 13:49:02 +00:00
Adam Obuchowicz
f732ae9790
Update CHANGELOG after 2024.4.1 (#11123) 2024-09-18 10:38:08 +00:00
somebody1234
9126ab23e4
Decode URL pathname for opened file (#11118)
- Attempt to fix an issue where a project opened by double clicking does not URL decode the path to be opened.
- Unable to properly test as I don't normally use Windows (file associations do not work on Linux as we use an AppImage for that platform.)

# Important Notes
None
2024-09-18 09:51:11 +00:00
Sergei Garin
38685dafa9
Fix JsonSchema input sizing (#11097)
* Fix closing delete dialog

* FIx json schema input

* Fix input

* Remove test line
2024-09-18 12:28:34 +03:00
Sergei Garin
55869327d9
Wip/sergeigarin/fix-focus (#11112)
* Fix selecting directory after creating

* Fix focusing
2024-09-18 12:28:05 +03:00
Hubert Plociniczak
862100c7c0
More info when we fail to log AssertError (#11113)
Motivation:
```
Caused by: java.lang.AssertionError: No polyglot context is entered. A language or context reference must not be used if there is no polyglot context entered.
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotFastThreadLocals.assertValidGet(PolyglotFastThreadLocals.java:481)
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotFastThreadLocals$ContextReferenceImpl.get(PolyglotFastThreadLocals.java:513)
 	at org.enso.runtime/org.enso.interpreter.runtime.EnsoContext.get(EnsoContext.java:246)
	at org.enso.runtime/org.enso.interpreter.runtime.error.PanicException.computeMessage(PanicException.java:90)
```
2024-09-17 23:20:14 +02:00
Hubert Plociniczak
567910ae14
Try harder to deal with stuck index generation (#11098)
`Process.destroy` sends `SIGTERM` instead of `SIGKILL` meaning that we
have to try harder to deal with stuck index generation.
2024-09-17 23:19:49 +02:00
Dmitry Bushev
9179dff89f
Move execution environment from State to EnsoContext (#11075)
related #10719

Changelog:
- refactor: move execution environment from `State` to `EnsoContext`
2024-09-17 20:50:03 +00:00
Pavel Marek
78597fb74c
Benchmark static site generator does not include so many records (#11115)
Limit the starting date to fetch the benchmarks from to 01-04-2024. As of today, [Upload Benchmarks GH Action](https://github.com/enso-org/enso/actions/workflows/bench-upload.yml) is [failing](https://github.com/enso-org/enso/actions/runs/10896413686/job/30236182995#step:6:6303) because it tries to push a HTML file bigger than 100 MB.
2024-09-17 20:39:11 +00:00
Dmitry Bushev
8e0095e1f8
Stack Overflow Error not shown in GUI (#11064)
close #8648

Changelog:
- update: handle null messages in execution exceptions
2024-09-17 18:43:35 +00:00
dependabot[bot]
343f6830a7
Bump send and express in /tools/simple-library-server (#11072)
Bumps [send](https://github.com/pillarjs/send) to 0.19.0 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `send` from 0.18.0 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases)
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md)
- [Commits](https://github.com/pillarjs/send/compare/0.18.0...0.19.0)

Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: send
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-17 18:51:29 +01:00
dependabot[bot]
8bb9edab54
Bump path-to-regexp and express in /tools/legal-review-helper (#11074)
Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.10 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.7 to 0.1.10
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](https://github.com/pillarjs/path-to-regexp/compare/v0.1.7...v0.1.10)

Updates `express` from 4.18.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.18.2...4.21.0)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-17 16:49:26 +02:00
Hubert Plociniczak
031300dfb3
Don't NPE when Throwable is missing message (#11102)
Looks like `Throwable` thrown by the execution may be missing a message,
which later crashes when we want to send it over the wire.
Added some guards to prevent NPE.
2024-09-17 16:37:38 +02:00
Pavel Marek
3dd0fb95ae
Better error message for unresolved symbol (#11008)
* Add failing tests

* ExtensiomMethod resolution in the current module might be an error in GlobalNames

* Add another successful test

* Fix compilation error test

* Fix compilation of RedShift_Spec - `setup` is provided in compile scope
2024-09-17 15:38:31 +02:00
James Dunkerley
b2545b8b96
Small tweaks from using Process.run (#11110)
* Once more unto the lint dear friends.

* Default the arguments for process run.
Allow delimiter to be used to convert Text to Table.
2024-09-17 14:27:25 +01:00
Adam Obuchowicz
5725e2427d
Allow numbers starting with dot in WidgetNumber (#11108)
[Screencast from 2024-09-17 13-20-40.webm](https://github.com/user-attachments/assets/561adebb-7d93-4939-9dde-5453d5f304be)
2024-09-17 13:07:06 +00:00
Adam Obuchowicz
dfc04f4222
Renaming project: fix invalid state when the name does not change (#11103)
Fixes #11101

I did not add tests for it, because I think we'll remove this rename feature in the future.
2024-09-17 13:26:06 +02:00
Jaroslav Tulach
f2a809c4e1
Avoid dependency on org.graalvm.collections (#11107)
I am trying to compile Enso with GraalVM 24.2.0 snapshot to verify that https://github.com/oracle/graal/pull/8266 changes would work for Enso. Among the problems I am facing is a dependency on `org.graalvm.collections` because of using `Pair`. I don't think we need such dependency. Let's avoid it by using our own `record` with two components.
2024-09-17 11:25:18 +00:00
Adam Obuchowicz
667ce038e7
Fix node removing bug, caused by spurious watchEffect effect. (#11099)
Fixes [#11062](https://github.com/enso-org/enso/issues/11062)

Modified watchEffect to be consistent with Vue behavior + tests. Before the scheduled effects were run even if stopped.

Why it fixes nodes removal? See [this comment](https://github.com/enso-org/enso/issues/11062#issuecomment-2352975474)
2024-09-17 07:12:59 +00:00
Sergei Garin
b14f19f8f7
Fix table dissapear after switching tabs (#11096) 2024-09-16 19:14:09 +00:00
James Dunkerley
0e9821519d
Widget work for AWS (#11095)
- Added `to_display_text` for `S3_File` and `Enso_File`.
- Improved widget for `AWS_Credential` allowing use of Enso secrets.
- Adjust `S3.list_objects` to return `S3_File` objects, allowing easier drill down.
- Fix for merging inherited config with direct config in widgets.
- Add missing constant types to Date.Diff widget.

![image](https://github.com/user-attachments/assets/ea125a09-5067-4dee-bef2-3d7c8d551260)
2024-09-16 18:56:14 +00:00
Sergei Garin
0b91002933
Fix importing conflicting files (#11087)
Closes: enso-org/cloud-v2#1484
2024-09-16 16:16:11 +00:00
James Dunkerley
6ca2c337d0
Disable Invite button for solo/free. (#11089)
Currently shows up in solo mode, enough to just have the Upgrade button.
2024-09-16 15:18:09 +00:00
Adam Obuchowicz
53e101566a
Fix Numeric Input cooperation with Drop Down (#11091)
Fixes #11063

The blur on Numeric Input was removed in https://github.com/enso-org/enso/pull/10337 and then reintroduced in https://github.com/enso-org/enso/pull/10512. I guess it was to handle `tab` properly, so I added another way of handling `tab` and removed blur again (with explanation).
2024-09-16 14:46:58 +00:00
Sergei Garin
bea9d3670a
Follow-up for Remote backend fixes PR (#11080)
This PR is a follow-up for https://github.com/enso-org/enso/pull/11067 that addresses the issues raised in the PR
2024-09-16 12:18:03 +00:00
somebody1234
cad50a5b63
Dashboard fixes (#11059)
- Fix https://github.com/enso-org/cloud-v2/issues/1482
- Fix "clear trash" not doing anything
- Show "shared with" column as "root folder", but only owners (TODO: actually it should only show the first item in the permissions list)
- Fix https://github.com/enso-org/cloud-v2/issues/1480
- Fix importing .enso-projects not doing anything
- Could not repro crash. Also note that we do want to be able to upload files
- Partly address https://github.com/enso-org/cloud-v2/issues/1479
- Remove "invite" and "share" buttons on top right
- Hide "upgrade" button on top right if on Team or Enterprise plan
- Warn when deleting folder (for now warns for all folders otherwise we may need to expand the folder to know whether it is empty)
- Fix importing projects via upload button
- Fix importing projects via drag
- Hide cut on running projects
- Partly address https://github.com/enso-org/cloud-v2/issues/1481
- Fix "edit secret" not showing dialog
- Fix multiple selection context menu in Team space

# Important Notes
None
2024-09-16 09:03:49 +00:00
Jaroslav Tulach
a6fbdb11ce
Avoid using assert in Scala, use assertInJvm to elide it in production (#11027)
Fixes #11022 and in general fixes #5787 by avoiding calls to Scala's `assert` function and using regular one written in Java that uses `assert` keyword and is thus sensitive to `-ea` command line option of the JVM. Use `assertInJvm` in newly written Scala code to get typical JVM behavior on `assert`.
2024-09-16 06:32:47 +00:00