enso-org/enso
1
1
Fork 0
mirror of https://github.com/enso-org/enso.git synced 2024-11-22 22:10:15 +03:00
Code Issues Projects Releases Wiki Activity
67db825587
enso/lib
History
Jaroslav Tulach 67db825587
MetadataStorage is mutable - structural equals in copy isn't enough (#11513) 
`MetadataStorage` is mutable. Using `Object.equals` in `IR.copy` methods to check whether a _copy is needed_ isn't enough. The fact that two storages are `Object.equal` may be just temporary. Replacing the checks in 69 `IR.copy` methods with identity check - e.g. `ne` in Scala which is `==` in Java.

Using proper structural check inside of `MetadataStorage` fixes #11171.

# Important Notes
I [used this regex](https://github.com/enso-org/enso/issues/11171#issuecomment-2463908932) to find out 69 instances of `IR.copy`:

![69 copy methods](https://github.com/user-attachments/assets/257580b9-54fc-4199-88ad-a22103b0041f)

and I modified all 69 of them.
2024-11-08 17:29:41 +00:00
..
java MetadataStorage is mutable - structural equals in copy isn't enough (#11513) 2024-11-08 17:29:41 +00:00
js/runner Unify Frontend App (#11287) 2024-10-11 18:23:02 +00:00
rust Move documentation into documentable types (#11441) 2024-11-04 15:33:53 +00:00
scala Don't cancel aborted jobs immediately (#11375) 2024-11-05 10:33:02 +01:00
README.md Add a markdown style guide (#1022) 2020-07-21 13:59:40 +01:00

README.md

Libraries

This directory contains the libraries that should remain in this project, but that are not technically part of the main language implementation itself.