enso-org/enso
1
1
Fork 0
mirror of https://github.com/enso-org/enso.git synced 2024-12-23 17:03:32 +03:00
Code Issues Projects Releases Wiki Activity
67db825587
enso/lib/java
History
Jaroslav Tulach 67db825587
MetadataStorage is mutable - structural equals in copy isn't enough (#11513) 
`MetadataStorage` is mutable. Using `Object.equals` in `IR.copy` methods to check whether a _copy is needed_ isn't enough. The fact that two storages are `Object.equal` may be just temporary. Replacing the checks in 69 `IR.copy` methods with identity check - e.g. `ne` in Scala which is `==` in Java.

Using proper structural check inside of `MetadataStorage` fixes #11171.

# Important Notes
I [used this regex](https://github.com/enso-org/enso/issues/11171#issuecomment-2463908932) to find out 69 instances of `IR.copy`:

![69 copy methods](https://github.com/user-attachments/assets/257580b9-54fc-4199-88ad-a22103b0041f)

and I modified all 69 of them.
2024-11-08 17:29:41 +00:00
..
akka-wrapper/src/main/java engine-runner and language-server are separate JPMS modules (#10823) 2024-09-25 21:33:13 +02:00
benchmarks-common/src/main/java engine-runner and language-server are separate JPMS modules (#10823) 2024-09-25 21:33:13 +02:00
desktop-environment/src Soft delete projects by moving them to trash (#10440) 2024-07-27 13:37:43 +00:00
directory-watcher-wrapper/src/main/java Ensure wrapper projects are listed in aggregates (#11323) 2024-10-14 20:46:08 +02:00
fansi-wrapper/src/main/java engine-runner and language-server are separate JPMS modules (#10823) 2024-09-25 21:33:13 +02:00
jna-wrapper/src/main/java Fix booting enso on MacOS (#11212) 2024-09-30 15:58:12 +00:00
language-server-deps-wrapper/src/main/java engine-runner and language-server are separate JPMS modules (#10823) 2024-09-25 21:33:13 +02:00
persistance/src MetadataStorage is mutable - structural equals in copy isn't enough (#11513) 2024-11-08 17:29:41 +00:00
persistance-dsl/src/main/java/org/enso/persist/impl Make Graph.nextId() private (#11486) 2024-11-05 05:21:10 +01:00
scala-libs-wrapper/src/main/java Ensure wrapper projects are listed in aggregates (#11323) 2024-10-14 20:46:08 +02:00
test-utils/src/main/java/org/enso/test/utils Inline doc comment is a compiler error (#11333) 2024-10-16 06:24:18 -07:00
ydoc-server/src Add compression to the metadata code snapshot (#11470) 2024-11-05 11:57:43 +00:00
zio-wrapper/src/main/java Ensure wrapper projects are listed in aggregates (#11323) 2024-10-14 20:46:08 +02:00