facebook/duckling
1
1
Fork 0
mirror of https://github.com/facebook/duckling.git synced 2024-08-17 17:20:55 +03:00
Code Issues Packages Projects Releases Wiki Activity

Specify where the note on regex + text lives

Browse Source 
Summary:
I spent a surprising amount of time trying to figure out what
this comment was referring to because it wasn't at all clear to me
that it meant a comment in another file. Making it more specific

Reviewed By: chessai

Differential Revision: D28411103

fbshipit-source-id: 26cd29b47367a7e0d865f616f289fef570544c39
This commit is contained in:
Steven Troxler 2021-05-13 11:12:25 -07:00 committed by Facebook GitHub Bot
parent fcdd8047a3
commit 9151f9e1ab
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Duckling/Engine.hs
View File

@ -86,8 +86,8 @@ lookupRegexCommon
-> Duckling [Node]
lookupRegexCommon doc regex position matchFun = return nodes
where
-- See Note [Regular expressions and Text] to understand what's going
-- on here
-- See Note [Regular expressions and Text] from Document.hs to understand
-- what's going on here
(substring, rangeToText, translateRange) =
Document.byteStringFromPos doc position
nodes = mapMaybe (f . Array.elems)