facebook/duckling
1
1
Fork 0
mirror of https://github.com/facebook/duckling.git synced 2025-01-06 04:53:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Combine duplicated examples

Browse Source 
Summary:
I was looking at adding support for "next week" constructions in Spanish to
close https://github.com/facebook/duckling/issues/553 (which it appears has
already been handled), when I noticed that the equivalent logic for English
has been split into two separate examples: "coming week" isn't in the same
example as other equivalent constructs like "upcoming week" and "next week".

This diff combines them, which I think is clearer and fewer lines of code

Reviewed By: chessai

Differential Revision: D26892322

fbshipit-source-id: 68ca4644759198fc79d963ae080495c3f2d4a923
This commit is contained in:
Steven Troxler 2021-03-08 13:41:05 -08:00 committed by Facebook GitHub Bot
parent b671d75d02
commit fc5278855d
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Duckling/Time/EN/Corpus.hs
View File

@ -323,9 +323,6 @@ allExamples = concat
[ "this week"
, "current week"
]
, examples (datetime (2013, 2, 18, 0, 0, 0) Week)
[ "coming week"
]
, examples (datetime (2013, 2, 4, 0, 0, 0) Week)
[ "last week"
, "past week"
@ -336,6 +333,7 @@ allExamples = concat
, "the following week"
, "around next week"
, "upcoming week"
, "coming week"
]
, examples (datetime (2013, 1, 1, 0, 0, 0) Month)
[ "last month"