facebook/sapling
1
1
Fork 0
mirror of https://github.com/facebook/sapling.git synced 2024-10-05 06:18:07 +03:00
Code Issues Projects Releases Wiki Activity

log: do not calculate files() if --verbose is not set

Browse Source 
Summary:
Discovered by martinvonz. `sl log` without arguments in a Git repo spends a
lot of time on `ctx.files()` but not render them. Update the logic to check
the `--verbose` first to avoid slow `.files()` calculation.

Reviewed By: bolinfest

Differential Revision: D41343821

fbshipit-source-id: c2ad760e2749e1222c6bec7923b62310296d4d56
This commit is contained in:
Jun Wu 2022-11-16 14:06:46 -08:00 committed by Facebook GitHub Bot
parent fada6764c4
commit e68cdbba95
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
eden/scm/edenscm/cmdutil.py
View File

@ -1992,7 +1992,7 @@ class changeset_printer(object):
self.ui.write(
columns[key] % " ".join(value), label="ui.debug log.files"
)
elif ctx.files() and self.ui.verbose:
elif self.ui.verbose and ctx.files():
self.ui.write(
columns["files"] % " ".join(ctx.files()), label="ui.note log.files"
)