Summary:
We have the ability to (attempt to) kill processes preventing eden rm to succeed, but we don't have logging to estimate who often that happens and what the success rate is.
This diff introduces such logging.
Reviewed By: kmancini
Differential Revision: D54380383
fbshipit-source-id: 255f5f80b8df83c5db89086414cbe725f62d4fe3
Summary:
eden rm now has the ability to try to kill processes holding on to files we want to delete.
If the user rejects the offer and prefers to solve things manually, we're showing "success" even though the rm wasn't successful.
This just returns the right code so we don't display that message.
Differential Revision: D54379250
fbshipit-source-id: 8f75a827f2d2c563aecfe29bb8e56dfdbea950d9
Summary: Add or increase the level of concurrency to hgid lookups for the various commit graph methods.
Reviewed By: YousefSalama
Differential Revision: D54482103
fbshipit-source-id: 0d5ba6cd28f54f2018930aba6a8a3d1d046171a0
Summary: Currently we fetch the target mutation entries and then expand them out to their predecessors. This is left over from the method that used primordial lookups, but is no longer necessary as the recursive CTE can return all that we need.
Reviewed By: mitrandir77
Differential Revision: D54375207
fbshipit-source-id: d7da1f48ac5a3545ba192c171b513bad338b2cf6
Summary:
add a getter to CoreContext object itself
I think it is reasonable due to amount of usage in the codebase.
Reviewed By: mzr
Differential Revision: D54416763
fbshipit-source-id: 9b5971ba7367f8518265b6c3bb1bd21fb7a6d7f0
Summary:
This diff is part of the codemod for https://fb.workplace.com/groups/rust.language/posts/25780668961555042.
Generated using the code in P1191436630 and the procedure from D54430332.
Reviewed By: zertosh
Differential Revision: D54465853
fbshipit-source-id: 40af6353a0c616dfdfe647ccd3eaaaaddad81389
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.
This change moves FileUtils and PathFuncs from eden to edencommon.
NOTE: FileUtils and PathFuncs are mutally dependent so they were migrated togehter. Most of the files touched, however, was due to PathFuncs.
Reviewed By: genevievehelsel
Differential Revision: D54393041
fbshipit-source-id: 6dc404b1b1066704584da512220475e9ee486247
Summary: Typed interceptors (aka `ServiceMethodDecorator`) is taking a backseat while we revisit the approach. Let's clean up this unused code.
Reviewed By: thedavekwon
Differential Revision: D54316280
fbshipit-source-id: 49c5a0e93216e1b267ce743fd760741a0123e481
Summary:
X-link: https://github.com/facebookincubator/zstrong/pull/720
When running getdeps as part of Github CI, the toolchains employed are found in "C:\Program Files" or "C:\Program Files(x86)" - both requiring quoting to execute.
Lets add quotes and fix tha.
Reviewed By: vitaut
Differential Revision: D54433098
fbshipit-source-id: d3570486a2a2b12f4649becc987f9da1ca65c796
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.
This change moves Try from eden to edencommon.
Reviewed By: genevievehelsel
Differential Revision: D54379294
fbshipit-source-id: 9fdc8c896a6a09f959a25d0bee82a623650ced32
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.
This change moves Match from eden to edencommon.
Reviewed By: genevievehelsel
Differential Revision: D54378643
fbshipit-source-id: f291126d2455cc2fdddffa4914be0c9d3f44f634
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.
This change moves TempFile from eden to edencommon.
Reviewed By: genevievehelsel
Differential Revision: D54372850
fbshipit-source-id: 681f00c2b8b2c353b802c680fe62382d86ee7c8d
Summary:
Used [here](https://fburl.com/code/wlpa65ui) by the Predictive Prefetch Profile endpoint, there are a couple of issues:
a) `repoName_` looks to never be populated
b) the `datapackStore_` has this information via `SaplingNativeBackingStore`, so it makes sense to plug this function in here
it can be seen to be unpopulated here:
```
I0227 15:17:11.005260 1248935 EdenFSSmartPlatformServiceEndpoint.cpp:97] Getting 1500 top used directories from the edenfs/edenfs_service smartservice for user 'helsel' in repo '' for OS Linux
```
corresponding to this message in the smartplatform service:
```
E0227 15:17:11.484886 266 EdenFSServiceHandler.cpp:84 req:00400000000000ad] Required parameters are not all specified, throwing a thrift exception
```
Reviewed By: MichaelCuevas
Differential Revision: D54282302
fbshipit-source-id: e8f42ea15ef58096bc50ad20ec7e09ac6505b5b8
Summary: Allow <Tag> to take in other props, and use that to add a `title` for bookmarks. This way, long bookmark names that get truncated can be hovered to see the full name.
Reviewed By: quark-zju
Differential Revision: D54426513
fbshipit-source-id: 23162d13e3453153dded74b48161b780b4ba63d0
Summary: Add a util so you don't have to type "React.DetailedHTMLProps<React.HTMLAttributes<HTMLDivElement>, HTMLDivElement>" all over the place, since almost always you just use HTMLDivElement or whatever twice.
Reviewed By: quark-zju
Differential Revision: D54426514
fbshipit-source-id: 8c3ab9555534a03809e7b102107e4ad538918a0a
Summary:
jest test output had a lot of lines like:
```
ts-jest[ts-compiler] (WARN) src/TopLevelAlert.tsx:89:30 - error TS2554: Expected 0 arguments, but got 1.
89 const styles = stylex.create({
~
90 alertContainer: {
~~~~~~~~~~~~~~~~~~~
...
122 UBN: {backgroundColor: colors.purple},
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
123 });
~
```
This is because our mock for stylex had no types for the parameters. Just updating our mock with unused arg defs fixes this.
Reviewed By: quark-zju
Differential Revision: D54424188
fbshipit-source-id: 179ff36db7e6f2f563cdbd0bcf248db79126e86c
Summary:
If you multi-select commits, we show a submit button in the sidebar. But that's kind of out of the way, making submitting a partial selection kind of slow.
Instead, let's add the submit selected button next to the bottommost selected commit when you have multiple selected.
We already had this submit selected in the sidebar, so we can refactor it slightly to be reusable.
While doing this, I also fixed a couple of other issues:
- the sidebar multi-select buttons were kind of badly laid out and didn't wrap well. This is fixed by two lines of CSS.
- the update message when multi-selecting was extra fragile because it was selection order-dependent. We can sort the hashes to be resilient to selection order
Reviewed By: quark-zju
Differential Revision: D54397854
fbshipit-source-id: 3afde8e2750d7648172b8d21e8d41a751fafa9e6
Summary: Wrap <Tag> in <Bookmark>, for slightly more declarative and reusable bookmarks. We also have one set of special styles for some bookmarks (arc pulled etc). We'll want to reuse that in the bookmarks manager.
Reviewed By: quark-zju
Differential Revision: D54391159
fbshipit-source-id: 99ae04e5627e1113639db6821ad6eae84c9cb0ff
Summary: Add a new <Tag> component, which is styled the same as the <VSCodeTag>, but without the capitlzation and with our own implementation. See also D54317950
Reviewed By: quark-zju
Differential Revision: D54391158
fbshipit-source-id: a1b3c0c018491853f37674e1973b8801f83975c3
Summary:
I noticed we had both <Row> and <FlexRow>, ostensibly doing the same thing...?
Here I combine these, and rewrite the API to allow passing xstyle with stylex styles. This makes it easier to use these components when using stylex.
Reviewed By: quark-zju
Differential Revision: D54391157
fbshipit-source-id: e4f88aaac2d8564967b27b904f23b0b9b308ee00
Summary:
Use the new thrift `DerivedDataType` enum which is tied to derived_data_manager to ensure it stays in sync.
It is forward compatible with the old type (only adding enum variants), so it is safe to do.
Reviewed By: markbt
Differential Revision: D54311642
fbshipit-source-id: 2900f9045e8d1c1992be4fd299f540a434bb21d0
Summary: Various tests were failing when running them wiht `opt` mode on Buck since the `features.py` file was not properly read, which in turn caused various kinds of errors including allowing using rev numbers as valid revsets
Reviewed By: muirdm
Differential Revision: D54392948
fbshipit-source-id: 1008fc258a662791bb753371f6119bf27cd9f68f
Summary:
we have enabled xdiff for 5+ years, let's remove the experimental.xdiff
config
Reviewed By: quark-zju
Differential Revision: D54324349
fbshipit-source-id: e058bd77c8c48c2e809a4ea4649d1a3ccb2d53e7
Summary:
complete annotation for bonsai <=> hg mapping queries with e2e
telemetry
we have already covered queries to translate from bonsai to hg, here we are
covering the opposite queries
Reviewed By: mzr
Differential Revision: D54412246
fbshipit-source-id: 3de3bccce9c203facf131fdbe0dedc8a3731c893
Summary:
instrument mutation queries with SQL perf counters
this will give us correct scuba logging
increment counters before sql queries
==== this is a sev follow up task ====
Reviewed By: markbt
Differential Revision: D54362984
fbshipit-source-id: 898df4b53faec650385e0b20b045023f087186cd
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.
This change moves SystemError from eden to edencommon.
Reviewed By: MichaelCuevas
Differential Revision: D54343729
fbshipit-source-id: 7861e3effc9d242fbeda34333078c14c4d021a80
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.
This change moves Utf8 from eden to edencommon.
Reviewed By: fanzeyi
Differential Revision: D54341648
fbshipit-source-id: b1461a7f92963100914733d69de6eb574af3e1f9
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.
This change moves String from eden to edencommon.
Reviewed By: fanzeyi
Differential Revision: D54341192
fbshipit-source-id: 8f0763313e5585efeb336038f41c646d84986ec3
Summary:
The "SL_GIT" ident is only used by "sniff_dir". Other references of "all()"
expect different user identities. Move it to only affect "sniff_dir" to
reduce overhead.
Reviewed By: muirdm
Differential Revision: D54218753
fbshipit-source-id: dddc796e46738839fb2c6c17051c7a082fe7d6cc
Summary:
Forbid `hg` from working in `.git`. This avoids breaking potential automation
expectations that `hg root` will fail in a Git repo.
Reviewed By: muirdm
Differential Revision: D54218731
fbshipit-source-id: f289611bd3170cec84991de1691e819f61f9f6da
Summary: This is similar to `SL` but the dot dir is "git/sl".
Reviewed By: muirdm
Differential Revision: D54218769
fbshipit-source-id: 8ef76a46dbb6c5a180b1d0f3550e7aac81f987cc
Summary:
Reduces size of `Identity` from 216 bytes to 16 bytes so copy is more
efficient.
Reviewed By: muirdm
Differential Revision: D54218748
fbshipit-source-id: 73be754c4bd5002e6f63c5e2628c370a6c0e388f
Summary:
To prepare `.git/sl` setup:
- Sniff uses `.git/` but the "dot dir" is `.git/sl`.
- When both `a/b/.git` and `a/.sl` exist, pick `a/.sl`.
Reviewed By: muirdm
Differential Revision: D54218758
fbshipit-source-id: dd7da42b492557bfa1117013ce197401e4272cfb
Summary: Provide the "parent" which can be useful to detect changes.
Reviewed By: muirdm
Differential Revision: D54201002
fbshipit-source-id: c0139cca29a2cd683d273423fdd6d0d0b3aec35d
Summary:
Somehow I cannot typecheck progress data with the union type:
const onProgress = (progress: OperationProgress) => {
// progressEmitter is TypedEventEmitter<'progress', OperationProgress>
this.progressEmitter.emit('progress', progress);
^^^^^^^^^^^^^^^^^^^^
};
Error:
Argument of type '["progress", OperationProgress]' is not assignable to parameter of type '[event: "error", data: Error] | [event: "progress", data: { id: string; kind: "queue"; queue: string[]; }] | [event: "progress", data: { id: string; kind: "spawn"; queue: string[]; }] | [event: "progress", data: { id: string; kind: "stderr"; message: string; }] | ... 5 more ... | [event: ...]'.
Type '["progress", OperationProgress]' is not assignable to type '[event: "progress", data: { id: string; kind: "queue"; queue: string[]; }] | [event: "progress", data: { id: string; kind: "spawn"; queue: string[]; }] | [event: "progress", data: { id: string; kind: "stderr"; message: string; }] | [event: "progress", data: { ...; }] | ... 4 more ... | [event: ...]'.
Type '["progress", OperationProgress]' is not assignable to type '[event: "progress", data: { id: string; kind: "forgot"; }]'.
Type at position 1 in source is not compatible with type at position 1 in target.
Type 'OperationProgress' is not assignable to type '{ id: string; kind: "forgot"; }'.
Type '{ id: string; kind: "queue"; queue: string[]; }' is not assignable to type '{ id: string; kind: "forgot"; }'.
Types of property 'kind' are incompatible.
Type '"queue"' is not assignable to type '"forgot"'.ts(2345)
This diff changes the signature to make it easier for tsc to understand.
Reviewed By: evangrayk
Differential Revision: D54364589
fbshipit-source-id: 841dd82449d1b21a2287b3a36b755b081094280d
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.
This change moves Memory from eden to edencommon.
Reviewed By: fanzeyi
Differential Revision: D54340336
fbshipit-source-id: cd209be7f39452123ffc41312cf370a48e4923bc
Summary:
To support better telemetry and logging in watchman we want to use Eden's components. Lets migrate and detangle the needed pieces.
This change moves CaseSensitvity from eden to edencommon.
Reviewed By: fanzeyi
Differential Revision: D54339283
fbshipit-source-id: f96a421f4390578e5d2281b307532c62e22935d3
