Commit Graph

59283 Commits

Author SHA1 Message Date
Stanislau Hlebik
4ddf071f7e mononoke: update walker to visit content referenced by fsnodes
Summary: If fsnodes point to non-existent content we should be able to detect that.

Reviewed By: farnz

Differential Revision: D22723866

fbshipit-source-id: 31510aada5e21109b498a26e28e0f6f3b7358ec4
2020-07-24 09:03:47 -07:00
Stanislau Hlebik
b8e68c433c mononoke: fix help message
Reviewed By: krallin

Differential Revision: D22723876

fbshipit-source-id: 68e46dcd3fe3998cca49abf5d7f11068186341ea
2020-07-24 08:52:32 -07:00
Ailin Zhang
03a2308028 get priority from ObjectFetchContext in BackingStore
Summary: Previously, `BackingStore` and all its sub-classes' `getBlob` and `getTree` methods accepted both `ObjectFetchContext` and `ImportPriority`  as arguments. Now, `ImportPriority`  is removed because we can get the priority from `ObjectFetchContext `

Reviewed By: kmancini

Differential Revision: D22650629

fbshipit-source-id: e1b0c57a059f11504b28b2c17d698bb58f51e1ee
2020-07-24 08:24:02 -07:00
Ailin Zhang
ce28ec8caa deprioiritize when fetch count exceeds threshold
Summary:
check fetch count before `getPriority()` is used. If fetch count has exceeded `fetchThreshold_`, lower the priority by 1.

Note: this diff only guarantees that the `getPriority()` function is returning the lowered priority. How the returned value is used for scheduling is handled by `HgQueuedBackingStore`

Reviewed By: kmancini

Differential Revision: D22550640

fbshipit-source-id: c032f8f72ca658618ac118dfb3ad3dcae61e9735
2020-07-24 08:24:02 -07:00
Ailin Zhang
102d8586cc make ObjectFetchContext own a copy of ImportPriority
Summary: Previously `getPriority()` always returned a fixed priority. Now that we want `ObjectFetchContext` to lower its priority, it is better to make it have its own copy of `ImportPriority`.

Reviewed By: kmancini

Differential Revision: D22550587

fbshipit-source-id: 029c797def477ae4533f66cfba146a3972cfb65d
2020-07-24 08:24:02 -07:00
Ailin Zhang
faa691ec33 change default value of ImportPriority
Summary: This diff ensures that the value of ImportPriority is always positive and changes offset from 0 to half of the maximum offset to allow lowering offset in the future.

Reviewed By: kmancini

Differential Revision: D22550462

fbshipit-source-id: 69f45369359c7b2c39a0c6831e9b33982e26a16a
2020-07-24 08:24:02 -07:00
svcscm
4128e7e0a7 Updating submodules
Summary:
GitHub commits:

c6235f9c41

Reviewed By: bigfootjon

fbshipit-source-id: a130e1be7759bb4f77977689012795af4b522926
2020-07-24 01:47:37 -07:00
Arun Kulshreshtha
2566915fcd edenapi_server: fix comment in errors.rs
Reviewed By: StanislavGlebik

Differential Revision: D22705442

fbshipit-source-id: efa51077372ec9381c56d47f240f54fec573bc3c
2020-07-24 00:56:30 -07:00
svcscm
d36ebea881 Updating submodules
Summary:
GitHub commits:

af758d2942
004eb4ad12
3d25aff7d9

Reviewed By: bigfootjon

fbshipit-source-id: f7b2aa1add81555981d05487ec9c5b44940f001a
2020-07-23 22:51:50 -07:00
Xavier Deguillard
51aca36721 asyncrevisionstore: remove it
Summary:
I thought I had removed that code a while back, it turns out I didn't, so let's
do it.

Reviewed By: singhsrb

Differential Revision: D22583556

fbshipit-source-id: b92644195994e0a83bdbcd8019253ea217474486
2020-07-23 22:49:21 -07:00
Chad Austin
9ddaa5ff8e fix flakiness in mountIsShuttingDownWhileInodeIsReferencedDuringShutdown
Summary:
within() schedules work on the singleton timekeeper thread which
sometimes scheduled a timer callback on the ServerExecutor while
TestMount was shutting down, causing an assertion failure. Since
TestMount's executor is deterministic, just make the entire test
deterministic.

Reviewed By: genevievehelsel

Differential Revision: D22709150

fbshipit-source-id: 0a1621df0a9934bb7944fc259f7f83d110b35e93
2020-07-23 22:23:17 -07:00
svcscm
4deb01d630 Updating submodules
Summary:
GitHub commits:

e0b19cc243
bddd247e27
efd76401bf
8872745f00
36b2b13ac6
8008c4bdad
b0e0995a72

Reviewed By: bigfootjon

fbshipit-source-id: eb1b6111cdfde2e830b3d2bb614853ba42f38b7c
2020-07-23 21:14:36 -07:00
Durham Goode
ae14395ec2 py3: fix commit -i + 'e'
Summary:
Interactive hunk editting allows pressing 'e' to manually edit the
hunk. This was broken in Python 3.

Reviewed By: sfilipco

Differential Revision: D22701948

fbshipit-source-id: 80a3781566fa3e6a0854cd2d69bc3a4a36c5c6bd
2020-07-23 20:48:10 -07:00
svcscm
edc216bc25 Updating submodules
Summary:
GitHub commits:

613428df99

Reviewed By: bigfootjon

fbshipit-source-id: fa7af25df21d249897582e9153cbbec1d55d710a
2020-07-23 20:48:10 -07:00
svcscm
cbed17176f Updating submodules
Summary:
GitHub commits:

c11c0ee9ac
f4e04d32fb
a14dcb9d94
d34e015417
d8cdd46e34
481752dc1a
ddeb1e812c

Reviewed By: bigfootjon

fbshipit-source-id: 66a0958ea9babcedc9404f6db50f7b152e2616a6
2020-07-23 17:27:15 -07:00
Durham Goode
2a9bec9bd6 py3: fix test-simplemerge.py and test-simplekeyvaluefile.py
Summary:
I'm not sure how these landed, but they need fixes to work correctly in
python.

Reviewed By: sfilipco

Differential Revision: D22699596

fbshipit-source-id: fb6d237f4de92c5efa3b422ddb86117fc256460f
2020-07-23 15:27:41 -07:00
Stefan Filip
ca09a04945 regenerate projects
Summary: A few projects out of sync between TARGETS and Cargo.toml.

Reviewed By: dtolnay

Differential Revision: D22704460

fbshipit-source-id: 3d809292d50cc42cfbc4973f7b26af38d931121f
2020-07-23 15:03:46 -07:00
Stanislau Hlebik
4e252cbf2e mononoke: add --limit to backfill_derived_data
Summary: It's nice to have this flag available

Reviewed By: krallin

Differential Revision: D22693732

fbshipit-source-id: 9d0d8f44cb0f5f7263a33e86e9c5b8a9927c0c85
2020-07-23 13:33:16 -07:00
svcscm
721f13590c Updating submodules
Summary:
GitHub commits:

80d0394031
b22ad64d09

Reviewed By: bigfootjon

fbshipit-source-id: aef3a6eccf0541dfcb5978e8615f5be611a3d926
2020-07-23 13:12:57 -07:00
Ailin Zhang
fb5d18666a allow specifying a mount for 'eden debug gc_process_fetch'
Summary: If the user specifies a mount, only clear for that mount, otherwise clear for all mounts.

Reviewed By: fanzeyi

Differential Revision: D22674210

fbshipit-source-id: 832c4fd37a63fdb44cb12844378b61d113731016
2020-07-23 11:54:12 -07:00
Ailin Zhang
20ae54a69b clear fetch counts using eden debug gc_process_fetch
Summary: add a thrift call to clear `pidFetchCount_` in `ObjectStore` and call it in `eden debug gc_process_fetch`. Users might want this command to start a new recording of process fetch counts.

Reviewed By: kmancini

Differential Revision: D22583430

fbshipit-source-id: eba7d63b08da5134fd09b7512895aba06f6a7ca5
2020-07-23 11:54:12 -07:00
svcscm
0b183a474a Updating submodules
Summary:
GitHub commits:

75aa5bb191
389c5514bb
bfdb87b8f9
0f4e649f21
fb5e9b7e4b

Reviewed By: bigfootjon

fbshipit-source-id: abb0c329d5f58059e12c7e0d39cbedeb60ad1e84
2020-07-23 11:54:12 -07:00
svcscm
6131bdf05c Updating submodules
Summary:
GitHub commits:

ccd77b8543
ecd595b590
7af1fab443
35154c0cf7
e822e4dd1d

Reviewed By: bigfootjon

fbshipit-source-id: c7145c548a8f049f94c3ccfcc8958a6b504de60c
2020-07-23 11:04:53 -07:00
Mateusz Kwapich
2bf5cf7ca1 add descendants_of argument to commit_path_history
Differential Revision: D22502592

fbshipit-source-id: 8e3acf00a6c4dc9b651551a6723b582d9bcaca39
2020-07-23 07:34:52 -07:00
Mateusz Kwapich
3b36868c5c add descendants_of arg to changeset_path history
Summary: Thiss turned out to be quite complex

Differential Revision: D22502591

fbshipit-source-id: 4bd9b90e9c88c234b84fbea2221036387a037ba3
2020-07-23 07:34:52 -07:00
Mateusz Kwapich
52863fa3e3 remove terminator argument
Summary: now the terminator argument is unused - we can get rid of it.

Differential Revision: D22502594

fbshipit-source-id: e8ecec01002421baee38be0c7e048d08068f2d74
2020-07-23 07:34:52 -07:00
Mateusz Kwapich
39c0b018ce migrate time filters to use visitor
Summary:
`until_timestamp` will benefit from checking each node - this will allow for
less filtering on the caller side.

Differential Revision: D22502595

fbshipit-source-id: 23c574b0a4eeb700cf7ea8c1ea29e3a6520097a9
2020-07-23 07:34:52 -07:00
Mateusz Kwapich
451c5e9827 introduce a Visitor trait
Summary:
This new trait is going to replace the `Terminator` argument to fastlog
traversal function. Insted of deciding if we should fetch or/not given fastlog
batch this trait allows us to make decisions based on each visited changeset.

Differential Revision: D22502590

fbshipit-source-id: 19f9218958604b2bcb68203c9646b3c9b433541d
2020-07-23 07:34:52 -07:00
Mateusz Kwapich
646e321d7c better public api for deleted files manifest
Summary:
The function for finding the commit where the file was deleted
in the fastlog module doesn't depend on fastlog at all.
It also seems generic enough to be a good public API for deleted files
manifests module.

Differential Revision: D22502596

fbshipit-source-id: 2e226bf14339da886668ee8e3402a08e8120266e
2020-07-23 07:34:51 -07:00
Mateusz Kwapich
b08005947a encapsulate visiting a node
Summary:
Let's centralize the logic that adds new nodes to BFS queue during fastlog
traversal, this will allow me to hook into it in the next diffs.

Differential Revision: D22502593

fbshipit-source-id: 63f4e7adb3a7e11b4a2b2dcc65cab3bb4bf6f015
2020-07-23 07:34:51 -07:00
Mateusz Kwapich
41d11ca236 introduce find_merges feature
Summary:
This new skiplist feature allows to find merges between any two related
commits.

Reviewed By: StanislavGlebik

Differential Revision: D22457894

fbshipit-source-id: 203d43588040759b89a895395058a21c9b5ca43d
2020-07-23 07:34:51 -07:00
Mateusz Kwapich
091f06f47d save the visited nodes during skiplist traversal
Summary: I'm planning to use it in my next diff to power `find_merges` functionality.

Reviewed By: StanislavGlebik

Differential Revision: D22457898

fbshipit-source-id: 76c3f107fd8b5bbef96e978037be31efca0f9841
2020-07-23 07:34:51 -07:00
Mateusz Kwapich
3f8db5fda3 extract processing non-skippable nodes into separate function
Summary:
The `process_frontier` function is THE function that powers skiplist traversal
and it's quite complex. To make the core more readable I'm moving part of the
code into separate functions.

Differential Revision: D22457896

fbshipit-source-id: e3521855ae7ab889c21d7aff0204e27dc23cf906
2020-07-23 07:34:51 -07:00
Mateusz Kwapich
08462ea85c extract single skiplist traversal step to a separate
Summary:
The `process_frontier` function is THE function that powers skiplist traversal
and it's quite complex. To make the core more readable I'm moving parts of the
code into separate functions.

I'm also planning to use the single step function to simplify lowest common
ancestor algorithm later.

Differential Revision: D22457895

fbshipit-source-id: 1234118705ca6b1b61e09fdd7867ce4366045a28
2020-07-23 07:34:51 -07:00
svcscm
df15763da6 Updating submodules
Summary:
GitHub commits:

732fc4455d
d609fed3a1
cf91b308e7

Reviewed By: bigfootjon

fbshipit-source-id: 07e11a96caca7f2d72d77668600cee6f82e85b65
2020-07-23 07:08:24 -07:00
Kostia Balytskyi
dde78cb83e backsyncer: move under commit_rewriting
Summary: Same as a previous diff. Let's keep the top-level dir tidy.

Reviewed By: krallin

Differential Revision: D22691638

fbshipit-source-id: 7f9a21f307efd9bbe37f515f475409c89b99cd31
2020-07-23 06:32:52 -07:00
Kostia Balytskyi
d99cae1ba5 megarepolib: move under commit_rewriting
Summary:
There seems to be too many things at the top level of `Mononoke` already.
Let's make sure all x-repo thingies live under the same directory.

Reviewed By: krallin

Differential Revision: D22691539

fbshipit-source-id: 19feeb6777309b9034f8620bd211041b61b08bfc
2020-07-23 06:32:52 -07:00
svcscm
981c719d8d Updating submodules
Summary:
GitHub commits:

cdc67f96da
8bf4f0a4b3

Reviewed By: bigfootjon

fbshipit-source-id: 595027e217e24d341f9956732d31e4dbc89965a8
2020-07-23 06:32:52 -07:00
svcscm
94f7a8f939 Updating submodules
Summary:
GitHub commits:

6f132f3805
c41be18f24
a83bb0bdff
88ff31c0f1
6e756101df
cc40a5590a
b0c5ecd6b3
baaddb74c0
180f59de04
d2a5ad4b2b
c484dcdf74
dc6e2c1127

Reviewed By: bigfootjon

fbshipit-source-id: 60834bbda915e029e76b7fea63c1bfe9bad6e502
2020-07-22 19:40:34 -07:00
Durham Goode
fd61d337ea py3: fix test-revset-t.py
Summary:
It now passes

This also caught an issue with our wireprotocol serialization for non-ascii
bookmark names.

Reviewed By: quark-zju

Differential Revision: D22655896

fbshipit-source-id: 3312ff2fd13ebaea7988b18ace9a83137f40daa3
2020-07-22 19:00:42 -07:00
Durham Goode
b5e61e5486 py3: fix test-simplemerge.py
Summary: It now passes

Reviewed By: quark-zju

Differential Revision: D22654491

fbshipit-source-id: bdb6de0ac0ca181ce70915e3dd9bd72421375328
2020-07-22 19:00:42 -07:00
Durham Goode
823759ecc4 py3: fix test-simplekeyvaluefile.py
Summary: It now passes

Reviewed By: quark-zju

Differential Revision: D22654321

fbshipit-source-id: c1e327be69c4b0d41461422a4c0ff2e0d1bc28fd
2020-07-22 19:00:42 -07:00
Durham Goode
e336dd55d7 py3: fix test-fb-hgext-diff-since-last-submit-t.py
Summary: It now passes

Reviewed By: quark-zju

Differential Revision: D22654015

fbshipit-source-id: 8a0d97fa35b593ed012a2653e8ccf629854afc71
2020-07-22 19:00:42 -07:00
Durham Goode
e1b037aa35 py3: fix test-fb-hgext-remotefilelog-datapack.py
Summary: It now passes

Reviewed By: quark-zju

Differential Revision: D22653975

fbshipit-source-id: 8b6b39d9ff3dd8fa6d4bdc4fe28fc13a22efd9ff
2020-07-22 19:00:42 -07:00
Durham Goode
7011986ac2 py3: fix test-sparse-fetch-t.py
Summary: The test now passes

Reviewed By: quark-zju

Differential Revision: D22653782

fbshipit-source-id: 69dc2a364013848e8640c9f89e0552b6ce0fcd2b
2020-07-22 19:00:42 -07:00
Durham Goode
4cc3731d03 py3: fix test-sparse-profiles.t
Summary: It now passes

Reviewed By: quark-zju

Differential Revision: D22653171

fbshipit-source-id: 1c59bb0ab0140f569bdd24f0c19f651041be2f9c
2020-07-22 19:00:42 -07:00
Durham Goode
9eeb1d6412 py3: fix test-push.t
Summary: It now passes

Reviewed By: quark-zju

Differential Revision: D22652658

fbshipit-source-id: f7eb9e34067898e0220f3572fa142199eb5f7803
2020-07-22 19:00:41 -07:00
Durham Goode
065db9681c py3: fix test-merge-tools.t
Summary: It now passes

Reviewed By: quark-zju

Differential Revision: D22652124

fbshipit-source-id: 145ef33507ce1cf774a22841c1809a068720a80b
2020-07-22 19:00:41 -07:00
Durham Goode
6b12fdb38b py3: fix test-worker.t
Summary: It now passes

Reviewed By: singhsrb

Differential Revision: D22651796

fbshipit-source-id: 3383b42396127c5121b326d426f83d293bc49ed1
2020-07-22 19:00:41 -07:00
Durham Goode
b9d2e97a12 py3: fix test-journal.t
Summary: It now passes

Reviewed By: singhsrb

Differential Revision: D22651738

fbshipit-source-id: 24635ee344018574fd99e37781221fab82a2b4d7
2020-07-22 19:00:41 -07:00