Summary: Adds a function to collate two different path maps by entry name.
Reviewed By: genevievehelsel
Differential Revision: D50989168
fbshipit-source-id: dc6d94970cbb45230e334269d415b8ea226a3878
Summary:
Tiny bug, I noticed focus outlines were thicker in the corners when focusing on some elements in the commit info view.
Looks like our 2px focus outline is getting clipped somewhere. We can fix it with a slight inward offset. This way it matches other fields.
Reviewed By: muirdm
Differential Revision: D50820584
fbshipit-source-id: 78311b9b268fa252533260384b064f9cfd4f0b47
Summary:
The update message box for adding a message when resubmitting was only one line long. Let's make it multiple lines long so you can more easily write longer messages.
It still defaults to one line so that it's not really in your way if you don't add an update message. But it then expands to fit all the content as you type.
Reviewed By: muirdm
Differential Revision: D50820374
fbshipit-source-id: e59ce6f5eade052075a70ca9bb4b54cf53f6780d
Summary: I found the text area buttons (image upload and AI generation) would get in the way when I'm typing a message. Let's just move these buttons below the text area, and reduce their margins a little to not take up too much extra room.
Reviewed By: muirdm
Differential Revision: D50816067
fbshipit-source-id: fa2151f9261b516e62515f5f1614660d4244b865
Summary:
The top bar doesn't take up all that much room, but it's fairly valuable options.
Let's make it position: sticky so it stays at the top at all times.
Sticky allows it to take up as much room as necessary in the non-scrolled state, which is what we want so that if the bar wraps or takes variable height, it still pushes down the rest of the content correctly.
Reviewed By: zats
Differential Revision: D50993794
fbshipit-source-id: 78cffc42cddf29b46c463e65bb55489804d988fc
Summary:
Two reasons for this refactor:
* compilation speed - now repo_client doesn't depend on warm_bookmarks_cache and its transitive dependencies
* I intend to add new implementation of this trait that also doesn't need those ddeps
Differential Revision: D51025219
fbshipit-source-id: c328a06d7cebf4a0de53a1f398b8167460c2b0a0
Summary:
This diff removes tunables related to periodic logging of long running requests.
For the case of EdenAPI requests I am keeping it the same way it is set.
For wireproto requests I'm removing the code since the tunables are currently unset. I expect as we use wireproto less and less we will never need those again. The commands will still be logged upon completion as they were up until now
Differential Revision: D50974802
fbshipit-source-id: d54f3686949447a504194e8313a669d99fe83d74
Summary: `region` uses long region names, like `sweden` instead of `lla`, which sometimes is more convenient. So add the DC prefix too.
Reviewed By: vjt
Differential Revision: D50790743
fbshipit-source-id: d57104795180155701d7d12a7bc53134dc2728fa
Summary:
remove filter_pre_existing_commits_on_infinitepush tunable
this was for roll out, the feature is there to stay
the value is true (in configerator)
Reviewed By: clara-9
Differential Revision: D50991771
fbshipit-source-id: 7f24838f868280885ec726acb024770083c5394d
Summary: Some folks found these debugging tools, so let's make it clear this is data referring to sl command performance and other ISL internal state. Adding the command name makes this much more clear.
Reviewed By: shunfu
Differential Revision: D50994363
fbshipit-source-id: 1cb5942686ea1d9bba93686fce4beb53bf04d1df
Summary: These appear to not be used
Reviewed By: quark-zju
Differential Revision: D50992180
fbshipit-source-id: 7bf1e1b1b9ec2696e63fc8496fb0900e3994db3c
Summary:
makeFutureWith is strictly equivalent to a try/catch but requires less code to
handle exceptions, use it.
Reviewed By: genevievehelsel
Differential Revision: D50902990
fbshipit-source-id: 8d887e2c0efd97244763b27c2b3ec2b20145e97e
Summary:
instrument in Commit Cloud Updates with client request info
this is the first time we will be able to match hg rage logs with dev command timers and with Commit Cloud Updates, that should greatly simplify debugging for Commit Cloud issues
this is the first time we will be able to identify in Commit Cloud Updates if the update was initiated from sapling vs scm daemon
Reviewed By: zzl0
Differential Revision: D50973878
fbshipit-source-id: 536e7c741807bd398db01cd4e6ee3e72a442babf
Summary:
set up correct client entry point and also enable printing of Client Correlators in logs
These changes will allow us greatly improve debugging experience of Commit Cloud issues
More precisely, it will allow us to easily match a command from hg rage with 3 scuba tables: dev command timers, CommitCloud Updates and Commit Cloud Requests (and more like Mononoke Test Perf, etc).
Reviewed By: zzl0
Differential Revision: D50967961
fbshipit-source-id: 07ccccc0790194078649c6798bff34a13479a247
Summary:
enable printing of the Client Correlator in the logs for background commands
It has been really really hard to debug Commit Cloud issues for years. Now we will change that.
The first step is enabling printing of the Client Correlator for background
commands. This way, looking into "hg rage" you will be able to easily match a
command with the telemetry in the Dev Command Timers scuba table!
Moreover, we are going to instrument the Commitcloud Updates and Commit Cloud
Requests scuba tables with Client Request Info as well in the following
diffs, so then it will be just awesome.
Reviewed By: zzl0
Differential Revision: D50967834
fbshipit-source-id: b5f864cb1971630d57b007fa698216fdc8eca231
Summary:
add scm daemon
this will be used to instrument scm daemon
Reviewed By: zzl0
Differential Revision: D50967508
fbshipit-source-id: 87fe3cde032ba605d11df0d86a592ab793e61244
Summary:
This tunable controls the amount or blobsotre reads and writes within a single request.
Since it was set in January 2021 (3 years ago) (https://www.internalfb.com/code/configerator/[773df72c41aa]/source/scm/mononoke/tunables/default.cconf?lines=70-71) it has not been changed, so removing it and setting it to the specified value in configerator
Reviewed By: mzr
Differential Revision: D50968709
fbshipit-source-id: c713e0ffde42aab379a3cb6486fab77c1fb506d7
