Summary:
Now that crecord is in core we no longer need it here.
This diff is part of a series to cleanup fb-hgext and make it pass check-code.
Test Plan: All tests pass
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.fb.com/D2811836
Summary:
Something in core changed the way we compute the hashes and it was
changing the output of this test. We change one hash to another and the test
seems to run well like before
Test Plan: Test pass
Reviewers: ericsumner
Differential Revision: https://phabricator.fb.com/D2804307
Summary:
This flag is used by an in-progress series.
This has no compatibility implications because all the users of it in Mercurial's current `@` do `args[0]` rather than something like `fl, = args`.
Test Plan: Ran `test-sparse.t` with and without my series.
Reviewers: #sourcecontrol, durham, ttung, ericsumner
Reviewed By: ericsumner
Differential Revision: https://phabricator.fb.com/D2803566
Tasks: 9583477
Signature: t1:2803566:1452021310:a24edd460b8a33dff34ea05f03e334950ca87c03
Summary:
- use decorator to add action
- add torule, tostate and verify methods
- use actions objects instead of pairs in rebase -i code
Test Plan: the fbhistedit tests are passing
Reviewers: #sourcecontrol, ttung, ericsumner
Reviewed By: ericsumner
Subscribers: ericsumner
Differential Revision: https://phabricator.fb.com/D2800161
Tasks: 9539722
Signature: t1:2800161:1451939637:c46875133eed576eb418723b44321b1b52ed3e77
Summary: Due to recent upstream changes the output of histedit is a bit less verbose
Test Plan: ran tests - less failures
Reviewers: #sourcecontrol, ttung, ericsumner
Reviewed By: ericsumner
Differential Revision: https://phabricator.fb.com/D2800039
Tasks: 9539722
Signature: t1:2800039:1451935970:7fa0b21f1639e167891430c89d5aa8b32a15ec49
Summary:
Before this patch, the test was giving different output on mac os and
on centos.
This patch makes the test output more portable and legible by adding two
helpers functions, one to check if a file is present and one to check if a file is absent.
Test Plan: test pass
Reviewers: ericsumner, ttung
Differential Revision: https://phabricator.fb.com/D2796056
Summary:
The test output got reordered, I tried to figure out why but I didn't
find the root cause. It does not look like an issue, so let's just patch the
changes.
Test Plan: test pass
Reviewers: ericsumner
Differential Revision: https://phabricator.fb.com/D2794131
Summary:
Before this patch we were testing against the fbhistedit installed on the
system. This patch makes us use the module under test from the fb-hgext repo.
Test Plan: test is using the right implementation
Reviewers: ericsumner
Differential Revision: https://phabricator.fb.com/D2795908
Summary: Simple rename to make it clear what this is testing
Test Plan: Simple rename, no test change
Reviewers: ericsumner
Differential Revision: https://phabricator.fb.com/D2793594
Summary:
Bundle format seems to have changed in core, test-writecg2's output
consequently changed. We have been hotfixing this test for the past two
releases, this patch fixes it in trunk.
Test Plan: Test is passing
Reviewers: ericsumner
Differential Revision: https://phabricator.fb.com/D2793776
Summary:
7dbd3db608c5 in core removed the cast to string in ui.write, we now
have to do it in the extension code.
Test Plan: The test pass
Reviewers: ericsumner
Differential Revision: https://phabricator.fb.com/D2793797
Summary:
Before this patch we were not holding a lock when calling repair.strip that
required it. This patch adds locking around the call to repair.strip.
With this change the tests of reset is not failing anymore.
Test Plan: Test is passing now
Reviewers: ericsumner
Differential Revision: https://phabricator.fb.com/D2793359
Summary: This will make it easier to move it into core
Test Plan: tests still pass
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2784459
Summary: This makes it easier to move it into core if we want to
Test Plan: All tests that passed before still pass
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2788053
Summary: This will make it easier to move it into core
Test Plan: All the tests that passed before are still passing
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2788061
Summary: This will make it easier to move the functionality into core
Test Plan: No test before, seems simple enough
Reviewers: #sourcecontrol
Differential Revision: https://phabricator.fb.com/D2784422
Summary:
hg backups has been broken since mid october (see 2b16ffcd3 in core)
This patch fixes it and adds a test for it.
Test Plan: Adds a new test
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2788217
A warning was there because core was using a deprecated API for writing
bookmarks. Now that the issue is fixed in core, this test has to be updated to
remove the warning.
Summary: obsolete.createmarkers expects a lock to be taken
Test Plan:
The devel-warning message disappears from the test output, test is
clean with new changes submitted to core
Reviewers: ericsumner
Differential Revision: https://phabricator.fb.com/D2791694
Summary: This will allow us to move it into core
Test Plan: it still works
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2784362
Summary: This will allow us to move it into core under contrib more easily.
Test Plan: N/A
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2784334
Summary: This will make it easier to move it into core
Test Plan: Tests are still passing
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2784492
Summary:
Before this patch we were using {} as a default argument.
{} is mutable and would have leads to confusion if the function was to
be called multiple times.
Test Plan: Tests are passing
Reviewers: #sourcecontrol, ttung
Differential Revision: https://phabricator.fb.com/D2784485
Summary: It exists in core as contrib/debugshell.py
Test Plan: N/A
Reviewers: pyd, durham, rmcelroy, cdelahousse
Differential Revision: https://phabricator.fb.com/D2784306
Summary:
This is only an issue for large numbers of revs, but it has a big
impact.
Performance of "hg sl -r 0::tip" in the main Mercurial repo improves
from 19 seconds to 15 as a result of this change.
Test Plan: works on my machine
Reviewers: #sourcecontrol, ttung, cdelahousse
Reviewed By: cdelahousse
Subscribers: cdelahousse
Differential Revision: https://phabricator.fb.com/D2785882
Signature: t1:2785882:1450832482:9248787390fff398ae44a285d0f879b970a5fc55
Shipping your own `run-tests.py` is a bad practice as the custom version will
slowly diverge from important fixes and upgrade from the upstream one. Using the
core one is simple and we should use it.
I'm not convinced by the arguments used in the re-installation (e221a52),
- It is easy to run the test against any version of Mercurial including the
installed one using `--with-hg=`,
- If you have people contributing to this level of extensions, having them
clone Mercurial is fairly cheap. If this is really seen a blocker, completing
the Mercurial's upstream plan to have run-tests.py installable as a developer
tools seems a cheap way to move forward instead,
- If you own a complex installation with multiple Mercurial related dependencies,
you already have a way to handle version dependency in this context and your
contributor can use this very same infrastructure to make sure they run at the
right version. And they probably should use it already anyway to make sure
they are testing the stack properly.
This changesets also install a README explaining how to obtains the test runner
and runs it against various Mercurial version.
Summary: D2745769 added a enabled=True flag, which needs to be in the test.
Test Plan: passed unit test.
Reviewers: #sourcecontrol, durham
Reviewed By: durham
Subscribers: mitrandir
Differential Revision: https://phabricator.fb.com/D2773075
Signature: t1:2773075:1450463047:9a29f677bf5bec7b9b1789ec2791ead5ebfd8a7a
Blame Revision: D2745769
Summary: repo.parents() is deprecated, we should use repo[None].parents()
Test Plan: Test is still passing
Reviewers: cdelahousse, durham
Differential Revision: https://phabricator.fb.com/D2770918
Summary:
Before this patch, fbamend with inhibit was leaving commits behind
when using --fixup. This was because we had two separates transaction, one for
the bookmarks and one for the markers. This patchs makes the marker creation
happen in the same transaction as the bookmark move.
Test Plan: check hg amend --fixup and hg amend --rebase
https://phabricator.fb.com/P56056980
Reviewers: ericsumner, durham
Differential Revision: https://phabricator.fb.com/D2771188
Summary:
Add $WARNING to make it easier to get the original behavior (print the
`***` contact support stuff). Remove misc environment variables included
in $WARNING to make the code simpler and less dependent.
Besides, store traceback in $TRACE so that it will be easier to read it
for multiple times. For example, try to upload it (first read) and if
failed, print it locally (second read). Otherwise we need ugly hack like
`A=$(cat)` in the script.
Test Plan: Check the new examples manually and run test-errorredirect.t
Reviewers: #sourcecontrol, ttung, rmcelroy
Reviewed By: rmcelroy
Differential Revision: https://phabricator.fb.com/D2770557
Tasks: 9259456
Signature: t1:2770557:1450384683:672e76752040d3d1b440522dd54ac43306c76bf9
Summary:
Upstream commit a0f2789070ce changes the signature of `cmdutil.displaygraph`
This patch detects it and use the new signature when needed.
Test Plan: Run `hg sl` with new hg on my laptop and old hg on devserver.
Reviewers: #sourcecontrol, ttung, durham
Reviewed By: durham
Differential Revision: https://phabricator.fb.com/D2769659
Tasks: 9446957
Signature: t1:2769659:1450376979:83f94e9bf30dea5b3c6115295ee92fdd456263af
Summary:
The old behavior would check that the cached sparse matcher was up to date by
performing a checksum on the contents of the .hg/sparse and .hg/tempsparse
files. This caused a lot of extra syscalls when sparse match was used inside a
loop.
The fix is to cache the .hg/sparse signature, and only refresh them when the
lock is acquired (similar to how most caches in Mercurial already work).
Test Plan: Ran the tests
Reviewers: #sourcecontrol, ttung, mitrandir
Reviewed By: mitrandir
Differential Revision: https://phabricator.fb.com/D2758452
Tasks: 9259321
Signature: t1:2758452:1450317072:6b0a962d336eda616cb27ef1b5e761d5153f64a3
Summary:
There were some comments under my diff after landing. Included:
* Old "Task ID" syntax
* Removing the "T" prefix
* Fixing the copypasted docstring
Test Plan: tests
Reviewers: #sourcecontrol, rmcelroy, ttung
Reviewed By: rmcelroy
Differential Revision: https://phabricator.fb.com/D2765417
Signature: t1:2765417:1450294877:4a50ecfdb1fb295ffaf01ecee6fe257b52e359bc
Summary:
Verified that the issue does occur.
Verified that using `hg shelve -d my_shelve_name` works for default and arbitrary shelve name.
Test Plan: Updated the tests for githelp
Reviewers: ericsumner, durham
Reviewed By: durham
Subscribers: de-engagement-diffs@
Differential Revision: https://phabricator.fb.com/D2762983
Tasks: 7632472
Signature: t1:2762983:1450289196:f25d757d158d110e8fc5503f974170c4a9892718
Summary:
When pushing a rewritten merge commit, we were trying to look up it's original
parent in the current repo (which no longer had that commit). We need to look in
the bundle repo instead.
Test Plan: Added a test. Also tried it manually on one of the hg servers
Reviewers: #sourcecontrol, ttung, mitrandir
Reviewed By: mitrandir
Differential Revision: https://phabricator.fb.com/D2763182
Signature: t1:2763182:1450230086:c560d4b8bbfe5d5387e23c1cc2e09109f49f255b
Summary:
Devel warnings are pointing at issues in the code that need to be fixed. The
right way to get the tests to pass is to fix the warning cause, not to the
warning to the tests.
This practically backout an handful of test that added such warning output in
the test.
Test Plan:
Well, test are now broken to match the state of the borken code.
Reviewers: lcharignon
Differential Revision: https://phabricator.fb.com/D2760523
Summary: bookmarks.write is deprecated
Test Plan: The test still passes
Reviewers: ericsumner, pyd, durham
Reviewed By: durham
Differential Revision: https://phabricator.fb.com/D2747007
Signature: t1:2747007:1449794510:09af0635c722a7aaf3b8aa444a116deaebada9b2
Summary: bookmarks.write is deprecated
Test Plan: the test is still passing
Reviewers: ericsumner, pyd, durham
Reviewed By: durham
Differential Revision: https://phabricator.fb.com/D2747002
Signature: t1:2747002:1449794465:a6ded4ed8f5249812c97cea13d9d6ce809109bd2
Summary: Our extensions dependecies are getting tricky. Let's make it right. (the logic still need to be tested - it worked on one very simple example so far).
Test Plan: no tests yet
Reviewers: pyd, lcharignon, rmcelroy
Reviewed By: rmcelroy
Subscribers: lcharignon, #sourcecontrol
Differential Revision: https://phabricator.fb.com/D2710943
Signature: t1:2710943:1449881799:16abe49529aa79df7d6ebe84a0bae0c0970b419a
