Summary: Recently we have partially or entirely ported some Rust commands (`clone`, `config`, `status`), but those commands are missing the type hints for some of its option. These type hints were available in the Python version of these commands, and this diff restores that.
Reviewed By: quark-zju
Differential Revision: D38503325
fbshipit-source-id: f6ef531cf0b655d8fcde1acabc478b866338da79
Summary: Previously, commands that were written in Python would allow to specify types such as `PATTERN`, or `REV` in the help options. This diff modifies the `define_flags` macro to allow Rust commands to add such type of help.
Reviewed By: quark-zju
Differential Revision: D38494676
fbshipit-source-id: d314707b5cf4e72954051fc383b61432ec316c88
Summary:
I thought fileslog handles it at transaction close but this turns out to be
necessary.
Reviewed By: jordanwebster
Differential Revision: D38446489
fbshipit-source-id: f0034fb15751dbaf5e4e661bf7d113e8911b5d8f
Summary:
EagerRepo format does not maintain meaningful linrkevs. Use the store
requirement to clarify.
Reviewed By: jordanwebster
Differential Revision: D38446490
fbshipit-source-id: 6cbdcaa8851b335239f91b2c29a5779bdb05f79f
Summary:
This API will be used by the next change.
As we're here, fix the `_get_content` implementation.
Reviewed By: jordanwebster
Differential Revision: D38446488
fbshipit-source-id: 9b730fc07db4d1e9e6bce438006fede42bd9e649
Summary: This will be used by the next change.
Reviewed By: jordanwebster
Differential Revision: D38446491
fbshipit-source-id: 4ee66d8bc62866f28897fa48b9365ebdf7e5ca54
Summary: Take `repo` and `nodes` instead of a `pullop` so it can be used in other cases.
Reviewed By: jordanwebster
Differential Revision: D38434429
fbshipit-source-id: 07e1887db750a51bb2bac21bf7ff3224fd7536a4
Summary: A recent changed made some PyByteArrayObject logic require a python version number. We specify it via buck and via make, but this cargo test logic didn't. Let's add it.
Differential Revision: D38261443
fbshipit-source-id: ce7e794f99d0e0acf890c615f6f9c93b4ab68689
Summary:
Adds an optional parameter diff_size_limit to the commit_file_diffs thrift API, that limits the total byte size of the returned diffs. If that limit is reached the API returns the diff so far and the names of the file pair it stopped at.
Also adds diff_size_limit option to the scs client.
Reviewed By: markbt
Differential Revision: D38352190
fbshipit-source-id: 419ce0cc14bc10325da7e2d63962b61f0fec22ce
Summary:
The OSS build has included warnings for a while. Fix them up by removing some
imports and renaming `fb` to `_fb`.
This log includes some of the warnings that I am fixing:
https://fburl.com/sandcastle/7cu7gsbz
Reviewed By: mzr
Differential Revision: D38429943
fbshipit-source-id: 27145be3891913fd56cf85e570d1fa2d0d0cc4ae
Summary:
This method is a footgun: it's easy to find for bootcampers working
on migration to new CLI and it's not a good choice for all usecases.
Let's rename it to stress out that it provided basic logging which won't suit
every usecase.
Reviewed By: clara-9
Differential Revision: D38469579
fbshipit-source-id: 5b08b0b1e5de4d2a54f2ed32f7a8585e19fd3c22
Summary:
D38282271 (59b5ae7e1f) accidentally broke it. The next diff makes that mistake a bit harder
to make.
Reviewed By: clara-9
Differential Revision: D38469580
fbshipit-source-id: bed71f6d7f39df3f3f25934f5c6a6a1c7bb19dcc
Summary: Linter says this isn't used and it doesn't look to be used, so removing it (`fnctl.flock` is used in `eden/fs/cli/overlay.py` but that file already handles the import)
Reviewed By: xavierd
Differential Revision: D38467234
fbshipit-source-id: dcf37b47d987ae27e480f3df2767ac022797cc80
