Summary: Some folks found these debugging tools, so let's make it clear this is data referring to sl command performance and other ISL internal state. Adding the command name makes this much more clear.
Reviewed By: shunfu
Differential Revision: D50994363
fbshipit-source-id: 1cb5942686ea1d9bba93686fce4beb53bf04d1df
Summary: These appear to not be used
Reviewed By: quark-zju
Differential Revision: D50992180
fbshipit-source-id: 7bf1e1b1b9ec2696e63fc8496fb0900e3994db3c
Summary:
makeFutureWith is strictly equivalent to a try/catch but requires less code to
handle exceptions, use it.
Reviewed By: genevievehelsel
Differential Revision: D50902990
fbshipit-source-id: 8d887e2c0efd97244763b27c2b3ec2b20145e97e
Summary:
instrument in Commit Cloud Updates with client request info
this is the first time we will be able to match hg rage logs with dev command timers and with Commit Cloud Updates, that should greatly simplify debugging for Commit Cloud issues
this is the first time we will be able to identify in Commit Cloud Updates if the update was initiated from sapling vs scm daemon
Reviewed By: zzl0
Differential Revision: D50973878
fbshipit-source-id: 536e7c741807bd398db01cd4e6ee3e72a442babf
Summary:
set up correct client entry point and also enable printing of Client Correlators in logs
These changes will allow us greatly improve debugging experience of Commit Cloud issues
More precisely, it will allow us to easily match a command from hg rage with 3 scuba tables: dev command timers, CommitCloud Updates and Commit Cloud Requests (and more like Mononoke Test Perf, etc).
Reviewed By: zzl0
Differential Revision: D50967961
fbshipit-source-id: 07ccccc0790194078649c6798bff34a13479a247
Summary:
enable printing of the Client Correlator in the logs for background commands
It has been really really hard to debug Commit Cloud issues for years. Now we will change that.
The first step is enabling printing of the Client Correlator for background
commands. This way, looking into "hg rage" you will be able to easily match a
command with the telemetry in the Dev Command Timers scuba table!
Moreover, we are going to instrument the Commitcloud Updates and Commit Cloud
Requests scuba tables with Client Request Info as well in the following
diffs, so then it will be just awesome.
Reviewed By: zzl0
Differential Revision: D50967834
fbshipit-source-id: b5f864cb1971630d57b007fa698216fdc8eca231
Summary:
add scm daemon
this will be used to instrument scm daemon
Reviewed By: zzl0
Differential Revision: D50967508
fbshipit-source-id: 87fe3cde032ba605d11df0d86a592ab793e61244
Summary:
This tunable controls the amount or blobsotre reads and writes within a single request.
Since it was set in January 2021 (3 years ago) (https://www.internalfb.com/code/configerator/[773df72c41aa]/source/scm/mononoke/tunables/default.cconf?lines=70-71) it has not been changed, so removing it and setting it to the specified value in configerator
Reviewed By: mzr
Differential Revision: D50968709
fbshipit-source-id: c713e0ffde42aab379a3cb6486fab77c1fb506d7
Summary: Only check for metrics we logged ourselves in the test for stability.
Reviewed By: sggutier
Differential Revision: D50945520
fbshipit-source-id: f087271cfba818e78e40ed019ed635f3610e3db5
Summary:
It seems some semantics of /usr/bin/open may have changed in macOS Sonoma. We used to have `sl isl` open the generated app bundle using `/usr/bin/open /path/to/Sapling.app`. This now seems to exit immediately. I'm not quite sure why.
Instead, we can simply invoke the inner executable directly. That still opens the app, shows the webview, and appears in the dock and everything, but it doesn't exit immediately.
Reviewed By: sggutier
Differential Revision: D50939280
fbshipit-source-id: 3680e93a7dbd06d3dce63cce3d38e5a72a2c7ae1
Summary: With the optimizations made so far, we should be able to support deltafication of merges in addition to regular commits.
Reviewed By: mitrandir77
Differential Revision: D50943028
fbshipit-source-id: fcb822c4dd505b6ec2834d3cb7e2f92c7e9d69ef
Summary:
bugfix (one element of enum wasn't covered) and adding comprehensive unit tests for conversion
add tests for converting from and to a string
Reviewed By: clara-9
Differential Revision: D50927331
fbshipit-source-id: d4393da70eaec6ad203f7a41a612d8e1211e4bfd
Summary: Adds some helper functions that will be used for resolving symlinks on D50793884
Reviewed By: xavierd
Differential Revision: D50888103
fbshipit-source-id: dadf02e4635cc86ef9470c4f925386711d42d0e6
Summary: This is a facepalm bug that I left in the current code which led us to creating bundles that do include deltas at all. Also, the size comparison that we do for deltas is too aggressive so this diff relaxes that constraint.
Reviewed By: mitrandir77
Differential Revision: D50936705
fbshipit-source-id: 54900a96c0b87e809cfbf17f09231fd7e47c2932
Summary:
add a test showing the we indeed enforce client info header from now
on in lfs
Differential Revision: D50930502
fbshipit-source-id: 2d056728a9f8c3dbfd9b4977d07c61977aa5ff76
Summary:
add a test showing the we indeed enforce client info header from now
on
Differential Revision: D50930216
fbshipit-source-id: 0e419a7dbfc99bc7c1deefb2f461f71a3f103fb8
Summary:
make x-client-info header mandatory in POST/GET requests
a custom mandatory header would protect us from CSRF attacks
we are excluding the health checks for now since they are used by proxygen and tupperware that don't provide the header
Reviewed By: mitrandir77
Differential Revision: D50882840
fbshipit-source-id: 21a9a89af6156046dd03f4fbcb94dc6d268566b9
Summary:
log client request info
there are some blobstore acceses where we don't log, logging here should help
Reviewed By: clara-9
Differential Revision: D50905311
fbshipit-source-id: fe4cc393b1e34be4171901055ed8f4769e951b78
