Summary: It is no longer referred in other CMakeLists files.
Reviewed By: muirdm
Differential Revision: D42021268
fbshipit-source-id: d172a8ecf82c4764fc4477d0391015a3ec89961e
Summary:
It is only used by hg.rs. Move it to decouple the core ConfigSet features from
hg's business logic (`--config` flags).
Reviewed By: muirdm
Differential Revision: D42018679
fbshipit-source-id: a33b9adf0217288ec7bea997a6e3b81fb35cc123
Summary:
Previously it requires the sub-configs to match their parent config.
That actually seems inflexible. Relax the requirement so it can be
used in more places.
Reviewed By: muirdm
Differential Revision: D42018680
fbshipit-source-id: bf2be4cfe23175ce32738872a16efe906fbc5d29
Summary: Use abstraction to be more flexible.
Reviewed By: muirdm
Differential Revision: D42011185
fbshipit-source-id: 419edb17376a6939a8eac98653b6cac20464544f
Summary:
This allows `workingcopy` to work with other config implementations like
`UnionConfig` not just `ConfigSet`.
Reviewed By: muirdm
Differential Revision: D42011186
fbshipit-source-id: a721922511b900a977e9e629088197f0742ea21c
Summary: move GraphQL queries into consts module, so they can be reused by tests.
Reviewed By: bolinfest
Differential Revision: D42035497
fbshipit-source-id: 0f43e6b43a43c15b61f696858abdd5ae230a2c45
Summary: this formatting choice was a remnant of a codemod
Reviewed By: chadaustin
Differential Revision: D41755813
fbshipit-source-id: aee8dcd0231f807d205530478cb74bb36785fef5
Summary: on macOS, a redirection target is the absolute repo_path of the redirection. Therefore, we need to modify the expected output for macOS integration tests.
Reviewed By: fanzeyi
Differential Revision: D41691840
fbshipit-source-id: 6d6975c9e1f74b5ef56a95b2d0a49f76704ebde7
Summary: on macOS, we default to NFS instead of FUSE, therefore use_nfs() should always return True on macOS
Reviewed By: chadaustin
Differential Revision: D41707744
fbshipit-source-id: 0b987682fe3268a216770b8b0e0b2ee9a99c11e0
Summary: Enable integration tests and disable all tests that are failing. We will slowly resolve all of these test failures over time.
Reviewed By: xavierd
Differential Revision: D41691841
fbshipit-source-id: b36eadee2cfdc5cc367bc5a3b4d224ba4a6968a5
Summary:
This re=implements the backed-out D41393677 (6384a0f39a) with some changes:
- Only log if the size metadata is _less than_ the size of the file contents
we're returning. This way we avoid erroneously logging partial reads, as
happened in T139036919.
- Only log once per Nfsd3ServerProcessor instance.
Reviewed By: chadaustin
Differential Revision: D41751040
fbshipit-source-id: 2503ecb488b0600bdeabbb11e532e4590edbd280
Summary: define `sl` as a shell function to `HGIDENTITY=sl hg`
Reviewed By: quark-zju
Differential Revision: D41965294
fbshipit-source-id: eb3eebb0dc184a3aae4bcb6ab541a42f9e8b82f8
Summary: Adds installation instructions for installing from Homebrew-core on macOS so that users don't have to manually download our bottle. It also adds one additional installation method for non-Ubuntu Linux users.
Reviewed By: bolinfest
Differential Revision: D42008426
fbshipit-source-id: 76757f43739bca3133e3265d5bbe6175edbc9f11
Summary:
This diff changes our versioning scheme from `MAJOR.MINOR-%Y%m%d-%H%M%S-rHASH` to `MAJOR.MINOR-%Y%m%d-%H%M%S-hHASH`
At the moment we cannot send another PR to Homebrew-core since our lastest release (`0.1.20221212-142634-r7ae28228`) gets detected [as an Erlang version](9c88c39bae/Library/Homebrew/version.rb (L411)) instead of a [hyphenated version](9c88c39bae/Library/Homebrew/version.rb (L427)). This was not an issue in the past since the hashes of our previous releases didn't happen to be of the form (`[Rr]\d+[AaBb]\d*(?:-\d+)?)`).
Reviewed By: bolinfest
Differential Revision: D42006425
fbshipit-source-id: 8dd4c52e1f49b79763bcc5863f7578a0f36dda73
Summary: In D34217873 (bb5656edfc) pyre wrongly assumed 'root' was int, while it is actually str. This diff solves that and removes the related coments
Differential Revision: D42003278
fbshipit-source-id: 91088303b2a671e20fe83aa156b97e97f9cc81d7
Summary: Move the update_distance log up so it fires for the Edenfs case as well.
Reviewed By: quark-zju
Differential Revision: D41750022
fbshipit-source-id: 48df0a58c009bc5bb87d76495d942a53f3089d1a
Summary: Point to the wiki, which is clearer and more similar to the error for large files.
Reviewed By: markbt
Differential Revision: D41840992
fbshipit-source-id: 292f30c0e92cf8627f0646ed503d0e0ba30eae82
Summary: This command allows fetching multiple keys at once. It can be used to tell how many exist, but is most useful to allow repairing/scrubbing many keys at once.
Differential Revision: D41660456
fbshipit-source-id: afcaf789479dc0050817d15c1f54299851cb81db
Summary: This stopped being used on D39698723 (3338746679), but we forgot to remove the code that creates it on integration tests.
Differential Revision: D41874472
fbshipit-source-id: bbb2eccdd53103999523b3e5be2fd9ff7ba85e83
Summary:
`ratelimit_meter` is a deprecated crate. It's owner/maintainer has since forked their own library into `governor` which is actively being worked on and offers a similar API. They have also provided a migration guide.
While functional, `ratelimit_meter` is the only crate vendoring in `smallvec@0.6.13`, which is affected by [`RUSTSEC-2021-0003` - 2021-01-08: Buffer overflow in `SmallVec::insert_many`](https://rustsec.org/advisories/RUSTSEC-2021-0003.html). Since upgrading ratelimit_meter is not an option, the only path forward is to migrate away from it.
Notably, `governer`'s `RateLimiter` also offers an async api surface, which removes the need for portions of `async_limiter`. It also offers one algorithm, a slightly modified GCRA, unlike `ratelimit_meter` which offered two, but according to the author, both algorithms ultimately did the same thing.
Please see `governor`'s migration [guide](https://docs.rs/governor/latest/governor/_guide/index.html) and `ratelimit_meter`'s [github page](https://github.com/antifuchs/ratelimit_meter) for more information.
Reviewed By: chriskonstad
Differential Revision: D41690189
fbshipit-source-id: 0b686f95a9a0346b2b0426f660bcc41e8c6657d3
Summary:
This fixes a fairly annoying issue in the VS Code extension.
Now outstanding issues fall more in the "feature request" than
"bug" category.
Reviewed By: ndmitchell
Differential Revision: D41976202
fbshipit-source-id: 31e6a38df50d90e4e0df2b21450f9175ba57f680
Summary:
This was requested for `sl pr` in
https://github.com/facebook/sapling/issues/218,
though this diff adds support for signing commits in general, in Sapling.
Here's how it works:
- `sl config --local gpg.key <KEY>` to specify your key
- Now `gitcommittext()` takes an optional `str` for the `gpgsigningkey` if `gpg.key` is set and `gpg.enabled` is `true` (which is the default).
- The text of the unsigned commit object is constructed and then signed using `gpg --status-fd=2 -bsau <KEY>` with the text passed via stdin.
- The resulting signature is embedded into the original text to sign it. Note that the original PGP key goes through some minor formatting (`\r` is removed; lines must start with a space to avoid a `\n\n` sequence) before it is embedded.
I documented things to the best of my knowledge in `eden/website/docs/git/signing.md`.
Follow-up items:
- Show signed status in smartlog?
- Update `sl ghstack` to honor signing configuration when running `git commit-tree`.
- Update `sl pr` to honor signing configuration when running `git commit-tree`.
Reviewed By: quark-zju
Differential Revision: D41778874
fbshipit-source-id: 5018a0d8bea1b5e9293c05954db65f35dd3c7aff
Summary:
This was flagged in D41921132 (a443a6cfef), but I ignored it so I could
land the diff without commandeering to give sggutier credit
for authoring it while he's OOO.
Reviewed By: quark-zju
Differential Revision: D41972389
fbshipit-source-id: 9e0a4e6aff9371f70a4fba8257a88c4c77e2d190
Summary:
The latest Homebrew bottles for Apple Sillicon macOS built by our Github Actions were broken, as mentioned in https://github.com/facebook/sapling/issues/315 . This was caused due to updating the Formula template used by our Github actions to 3.11 but not updating the Github actions themselves to Python 3.11. This commit fixes that last part.
Pull Request resolved: https://github.com/facebook/sapling/pull/319
Test Plan:
Triggered a [build on a fork of the sapling repo](https://github.com/sggutier/sapling/releases/tag/0.1.20221211-120017-rcd410769), downloaded the bottle built by it, and checked that it ran properly on my M1 mac:
```
$ sl --version
Sapling 0.1.20221211-120017-rcd410769
$ file $(which sl)
/Users/sggutier/homebrew/bin/sl: Mach-O 64-bit executable arm64
$ otool -L $(which sl)
/Users/sggutier/homebrew/bin/sl:
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.100.3)
/usr/lib/libiconv.2.dylib (compatibility version 7.0.0, current version 7.0.0)
/System/Library/Frameworks/Security.framework/Versions/A/Security (compatibility version 1.0.0, current version 60158.100.133)
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (compatibility version 150.0.0, current version 1858.112.0)
/Users/sggutier/homebrew/opt/openssl@1.1/lib/libssl.1.1.dylib (compatibility version 1.1.0, current version 1.1.0)
/Users/sggutier/homebrew/opt/openssl@1.1/lib/libcrypto.1.1.dylib (compatibility version 1.1.0, current version 1.1.0)
/System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration (compatibility version 1.0.0, current version 1163.100.19)
/usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.11)
/System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices (compatibility version 1.0.0, current version 1141.1.0)
/Users/sggutier/homebrew/opt/python@3.11/Frameworks/Python.framework/Versions/3.11/Python (compatibility version 3.11.0, current version 3.11.0)
/usr/lib/libresolv.9.dylib (compatibility version 1.0.0, current version 1.0.0)
$ sl dbsh -c "import sys; print(sys.version)"
3.11.0 (main, Nov 28 2022, 13:49:33) [Clang 14.0.0 (clang-1400.0.29.202)]
$ sl clone https://github.com/sggutier/sapling/ saplingtest && cd saplingtest && sl
remote: Enumerating objects: 677771, done.
remote: Counting objects: 100% (2847/2847), done.
remote: Compressing objects: 100% (1469/1469), done.
remote: Total 677771 (delta 1396), reused 2692 (delta 1261), pack-reused 674924
Receiving objects: 100% (677771/677771), 175.60 MiB | 2.59 MiB/s, done.
Resolving deltas: 100% (454743/454743), done.
From https://github.com/sggutier/sapling
* [new ref] 2857ac6b96 -> remote/main
6535 files updated, 0 files merged, 0 files removed, 0 files unresolved
@ 2857ac6b9 Today at 11:33 mbolin https://github.com/facebook/sapling/issues/317 remote/main
│ Add build instructions for Windows (https://github.com/facebook/sapling/issues/317)
~
$ touch something && sl st
warning: watchman has recently started (pid 1093) - operation will be slower than usual
? something
$ cd eden/scm && sl root
/Users/sggutier/saplingtest
```
Reviewed By: bolinfest
Differential Revision: D41921132
Pulled By: sggutier
fbshipit-source-id: 0ed4f2d6f214f02669e45c9c4b8cced7de9caa2e
Summary:
Currently the sparse profile checker treats the changes in unmonitored sparse
profile as-if they were files and will only report the size change in the
sparse profile size. Let's match them.
This also matches the behaviour of the legacy sandcsatle job.
Differential Revision: D41942576
fbshipit-source-id: e11768abaf57c85aa5ccdc72c528435f98ba9cee
Summary:
fix "repo changed while backing up" errors for non best effort runs
metalog reloads on transaction, so let's add a transaction
before that, we had lots of **false positives** "repo changed while backing up" errors because we read cached values
also, enable best effort mode for scm daemon, it locks the whole working copy after https://www.internalfb.com/diff/D34797187 (2e1b3436b3), which is not expected
Reviewed By: markbt
Differential Revision: D41871718
fbshipit-source-id: 14e222d0ccbcd6aa4a6dd773f2889aa0721c9842
