Summary:
From the folly format docs
> Use fmt::format instead of folly::format for better performance, build times and compatibility with std::format
eden build times have gotten a bit high, cutting out folly format will help reduce build time, so let's start
by banishing it from eden
see the last change in this group for the difference
Reviewed By: xavierd
Differential Revision: D38251000
fbshipit-source-id: a5aee79f7f0acbf969a351c3aa5ac32bb6c01b2a
Summary:
From the folly format docs
> Use fmt::format instead of folly::format for better performance, build times and compatibility with std::format
eden build times have gotten a bit high, cutting out folly format will help reduce build time, so let's start
by banishing it from eden
see the last change in this group for the difference
Reviewed By: chadaustin
Differential Revision: D38250996
fbshipit-source-id: 7f1ffc4a13c2751b503c26792ae841090b119c9c
Summary:
Mononoke server on push (currently only wireproto) forwards cats that are supposed to contain extra identities used by verify integrity and stored in a db and logged to scuba here: https://fburl.com/scuba/commit_integrity/ibk4ysx5
Since remote pushrebase was rolled out, we lost these cats along the way. I'm forwarding them to SCS with this diff.
Reviewed By: markbt
Differential Revision: D38198880
fbshipit-source-id: c10973ac5f46a22b2c4b6f4de6d2ddb3b77630af
Summary:
As reported in https://github.com/markbt/streampager/issues/57,
we saw extra backslashes in the output of the `hyperlink()` function.
Changing the ANSI escape sequence appears to fix things,
at least in iTerm+streampager.
Reviewed By: markbt
Differential Revision: D38268807
fbshipit-source-id: d47e3cf5fa9e2f93485221bdc0cd4aa62a812ea5
Summary:
For some scenarios (e.g. mirroring commits) it may be necessary to bypass the
recently-added author write permissions checks. Add a `bypass_allowlist` option
to the hook config which lets us define identities of pushers who are allowed to
bypass this check.
Reviewed By: mzr
Differential Revision: D38350812
fbshipit-source-id: c4ddefd631cef1053573426b05e35481d999aa62
Summary:
The hook manager factory was used in a couple of places to make it
simpler to create a `HookManager`. However, `HookManager` is now a facet and
can therefore be created using the facet factory methods.
Remove the hook manager factory code and move its logic into `repo_factory`.
Further, update `mononoke_api::Repo`'s `new_test_common` method to create a
`HookManager` using `TestRepoFactory`. In the future, we should get rid of the
custom test methods inside of `Repo` and rely on `TestRepoFactory` instead.
Reviewed By: markbt
Differential Revision: D38352454
fbshipit-source-id: aa127ad3408a049576dafe6e21bc65f50203ead2
Summary:
Now that all of the components of `Repo` are facets, the struct can be
converted to a container. This means that the struct can be built using a
`RepoFactory` rather than calling `Repo::new()`.
In later diffs, we can remove the helper methods (e.g. `hook_manager()`,
`ephemeral_store()` etc) and update callers to import traits instead.
Reviewed By: yancouto
Differential Revision: D38349354
fbshipit-source-id: bd9ae8b3d1e6aa1d0230306860fcff852161fad0
Summary:
`mononoke_api::Repo` has logic to disable skiplists if there
`skiplist_enabled` isn't set in `MononokeEnvironment`. In order to migrate
`Repo` to be a container, this logic needs to live inside of the repo_factory.
Update the code to create a skiplist index to check the same environment
setting and disable skiplists if it's not set.
Reviewed By: yancouto
Differential Revision: D38349355
fbshipit-source-id: 0550607506b91e0a42a63bcec5995c20f12b03a0
Summary:
The Warm Bookmark Cache isn't a facet, which means that it can't be
built with `repo_factory`. Turn it into a facet and add code into
`repo_factory` to build it from the required components.
Reviewed By: yancouto
Differential Revision: D38349357
fbshipit-source-id: b89f73178a9be1b2811daae8614ff09cc80d1068
Summary:
The Warm Bookmark Cache builder stores a `Repo` like object. However,
in a later diff I'm going to modify the code to be built from a factory. In
order to do that, I'm updating the WBC to store components rather than a
container of components.
Reviewed By: yancouto
Differential Revision: D38349356
fbshipit-source-id: 74999ed45e58f5a282632861b53366113872a845
Summary:
Replicate the functionality from `cmdlib_x_repo` as closely as possible with `cmdlib_cross_repo`.
`cmdlib_cross_repo` uses the clap 3 compatible constructs, like `MononokeApp`.
This currently adds some duplication, but the idea is to remove `cmdlib_x_repo` once no target depends on it anymore.
Reviewed By: mitrandir77
Differential Revision: D38318114
fbshipit-source-id: 028557f9f954148c85f66b8503dcb532641c2889
Summary:
These can be added as command line arguments to dependent targets.
This addition offers a clap 3 compatible alternative to functionality that is currently only present in cmdlib::args with a clap 2 compatible interface.
This diff is necessary to enable the migration of `mirror_hg_commits` to clap 3.
Reviewed By: mitrandir77
Differential Revision: D38315867
fbshipit-source-id: 73b6ea8c40d66c8d5605ab1b8efaf45e98de74e9
Summary: By the end of this stack, I plan to facetize `RepoHandler`. The first step in that process is to ensure that the `RepoHandler` struct and its dependencies do not depend on `BlobRepo`.
Reviewed By: yancouto
Differential Revision: D38314196
fbshipit-source-id: 99cc4936ef1eaf8e73a900dc025575b34fdd3271
Summary:
This does not seem easily reproducible. With the commit cloud state stored in
metalog, metalog ensures the data integrity so invalid json cannot happen.
Therefore, remove the test case.
Reviewed By: sggutier
Differential Revision: D38318764
fbshipit-source-id: 98ad2977d177977d993da0bc311d26999b61658c
Summary:
X-link: https://github.com/facebookresearch/Private-ID/pull/71
Previous codemod left some crust. This commit cleans up useless uses to use less uses.
Reviewed By: stepancheg
Differential Revision: D38211793
fbshipit-source-id: c852dd1ec617fe81a1d9bd0d8a9e5d2357b9b502
Summary: This fixes `test-clone-hook.t`, which had some missing output due to adding an early `wait_pager` in D38288111 (b8d14f309e)
Reviewed By: jordanwebster
Differential Revision: D38303439
fbshipit-source-id: b37b16af944290dddb6d8303fee984f2ee27406d
Summary:
Replace `codePointToUtf8` with `appendCodePointToUtf8` (D38305991)
where it makes sense.
Reviewed By: luciang
Differential Revision: D38306295
fbshipit-source-id: 6203f3509cc5bedd8cf8d484305ac8be583c16d6
