Commit Graph

60418 Commits

Author SHA1 Message Date
Alex Hornby
dfb8a524bf mononoke: add a MPath::get_path_hash test
Summary: Add tests for get_path_hash as there weren't any.

Reviewed By: farnz

Differential Revision: D23703343

fbshipit-source-id: 99f7056d71d01a9ecdf6526f6aed2e27cd4834a0
2020-09-15 03:42:43 -07:00
svcscm
a7290beb3a Updating submodules
Summary:
GitHub commits:

e31f63b0e4
e5491d6701
e8f084cb63
c8c0c0bc7c
c884af5a7f
afe7982e0a
2f2e8a8212
4f5c49ca63
7e021728a0
83db5f031f
a1d05ee617

Reviewed By: yns88

fbshipit-source-id: f357db1e806d8bdec6082f83c77c30a745cd6220
2020-09-15 02:42:20 -07:00
Stanislau Hlebik
bfc3410fdd mononoke: allow syncing XRepoSync bookmarks
Summary:
Facebook
We need them since we are going to sync ovrsource commits into fbsource

Reviewed By: krallin

Differential Revision: D23701667

fbshipit-source-id: 61db00c7205d5d4047a4040992e7195f769005d3
2020-09-15 02:28:35 -07:00
svcscm
0b031454f3 Updating submodules
Summary:
GitHub commits:

d127906722
e8c4c4da12
45f24ee9f8
841d5087ed
1de10dc4b9
e645243f68
bacb876d84
d6d7fc6655
5419274a99
aa416f5bc9
ac33c9e7d3
2a641ffb87

Reviewed By: yns88

fbshipit-source-id: 31a63366b3023d6adf832541c9cd61cd120e1a1d
2020-09-15 01:41:11 -07:00
Alex Hornby
7316eeac75 rust: vendor dashmap 3.11.10
Summary: Noticed there had been an upstream 3.11.10 release with a fix for a performance regression in 3.11.9, PR was https://github.com/xacrimon/dashmap/issues/100

Reviewed By: krallin

Differential Revision: D23690797

fbshipit-source-id: aff3951e5b7dbb7c21d6259e357d06654c6a6923
2020-09-15 00:59:33 -07:00
Luca Niccolini
55bf30a475 googletest 1.8.0
Summary: required. not installed with CMake ExternalProject anymore

Reviewed By: xttjsn

Differential Revision: D23700095

fbshipit-source-id: 807105a1e3d4bd837a35e39c6dced53744edd8de
2020-09-14 23:59:08 -07:00
Stanislau Hlebik
8a37cd4b07 mononoke: extend pre merge delete command to delete only files not found in
Reviewed By: aslpavel

Differential Revision: D23679215

fbshipit-source-id: 1942886ad0c1ebe0a27dd6b1a2535405d4ca3dac
2020-09-14 23:26:16 -07:00
svcscm
a1bfe1b8f5 Updating submodules
Summary:
GitHub commits:

bf36711a52
da6a69cf51
c03eee7a2c
c31646684d
fb9a6f78b3
22b436ce4f
87255c07c8
32ca7c945a
9523d58a01
5988548bcc
2e91a6066d

Reviewed By: bigfootjon

fbshipit-source-id: 53696e1d4f1ef0722b6946748453c8e3301c9ece
2020-09-14 23:26:16 -07:00
svcscm
b85498b200 Updating submodules
Summary:
GitHub commits:

d38be9a7e8
373dd9a8a6
737a25d853
9f72af220e
d801d46ed2
f4a5463c77
842ace10fa
3860269f50
b252589967
f3a4f8fa61
1aec6b57f0
a265a2f68c

Reviewed By: bigfootjon

fbshipit-source-id: 61786dbcde33db86ced3c1284f4402c87264cea5
2020-09-14 22:58:42 -07:00
Luca Niccolini
f451d8f2e3 enable tests in getdeps
Summary:
in getdeps we currently don't build and run the tests
There are a few issues:
  1. we need to also build tests for fizz, wangle, mvfst since proxygen tests include headers only exported if building tests in dependencies
  2. we use `ExternalProject_add` for gtest/gmock. but doesn't seem to be playing nicely with getdeps

Reviewed By: dddmello, mjoras

Differential Revision: D16934955

fbshipit-source-id: fb1c52237f9f0c71da86643409972c94d16e6a71
2020-09-14 22:04:49 -07:00
Luca Niccolini
ec10abc583 enable tests in getdeps
Summary: properly find the required GMock version (1.8.0) and allow building tests in getdeps

Reviewed By: mjoras

Differential Revision: D16935741

fbshipit-source-id: 46f62511e2feaf553d028e286a862aa5b30393c6
2020-09-14 22:04:49 -07:00
Luca Niccolini
2c773cc515 enable tests in getdeps
Summary: also always install fizz test headers for mvfst and proxygen tests to consume without needing to build fizz tests

Reviewed By: yfeldblum

Differential Revision: D23676344

fbshipit-source-id: 7ae78c81c2d67bb8da135fcd69d4be119b50a27e
2020-09-14 22:04:48 -07:00
Luca Niccolini
49e3719cd0 fizz, mvfst, wangle, proxygen: add gmock as fbcode_build dependency
Summary: they were all transitively pulling it from folly

Reviewed By: mjoras

Differential Revision: D23683292

fbshipit-source-id: 2085a580584891b3fd0960c14505c0f675a11bd5
2020-09-14 22:04:48 -07:00
Chad Austin
dca9f7bbfb use python 3 for the eden_scm getdeps build
Summary:
EdenFS is adding a Python 3 Thrift client intended for use by other
projects, and the Mercurial Python 2 build doesn't understand Python 3
syntax files, so switch the default getdeps build to Python 3.

Reviewed By: quark-zju

Differential Revision: D23587932

fbshipit-source-id: 6f47f1605987f9b37f888d29b49a848370d2eb0e
2020-09-14 21:39:51 -07:00
Xavier Deguillard
7d230956b7 win: remove unecessary headers from Stub.h
Summary: These headers aren't needed, and are slowing compile time at best, remove them.

Reviewed By: chadaustin

Differential Revision: D23693491

fbshipit-source-id: 4aebdfbbe56897623f62017bd498dc5c90ea6532
2020-09-14 19:25:49 -07:00
Xavier Deguillard
f95066e4ca win: remove FuseChannelData from Stub.h
Summary:
This was only used in EdenMount.h, to declare a method that was not compiled on
Windows, let's ifdef that method instead.

Reviewed By: chadaustin

Differential Revision: D23693494

fbshipit-source-id: 1eda62f2ae3a38a30aa0b517911635ef3d3896c2
2020-09-14 19:25:49 -07:00
Xavier Deguillard
601eab97f8 win: remove SerializedFileHandleMap and unlink from Stub.h
Summary: These 2 are unused, remove them.

Reviewed By: chadaustin

Differential Revision: D23693495

fbshipit-source-id: 9835de857d103c7079eda53d7e5f1914ad025fca
2020-09-14 19:25:48 -07:00
Xavier Deguillard
88c748e3b9 win: remove ProcessNameCache from Stub.h
Summary:
The ProcessNameCache code is compiled on Windows now, this definiton could
cause issues with different cpp files compiling different version of the
ProcessNameCache. To avoid this, let's remove it from Stub.h, this also removes
a bunch of #ifdef.

Reviewed By: chadaustin

Differential Revision: D23693490

fbshipit-source-id: 8f3f7b1128235b9a60f850e688b9e98910c202fc
2020-09-14 19:25:48 -07:00
Xavier Deguillard
8498760bf0 win: remove fuse_in_header from Stub.h
Summary: This is not needed, remove it.

Reviewed By: chadaustin

Differential Revision: D23693489

fbshipit-source-id: 0d7674f3001410b2d9ff02ef95049c5391d8528c
2020-09-14 19:25:48 -07:00
svcscm
0b94e6bbd9 Updating submodules
Summary:
GitHub commits:

a84a214ddf
587ad0d62e
02f127e417
25e3fd32e2
efa1624780
64aed325fe
c5b7753876
7d472accdc
ca2dfd0389
abf9c2d768
f7f8a03e9e
05c6c0a084
15b3f0599a
8a98805d70
e70bbceef5

Reviewed By: bigfootjon

fbshipit-source-id: 50b8b9cd03cb30e6696f0448d9306106f22c1c1a
2020-09-14 18:06:26 -07:00
Xavier Deguillard
38bc544f7e win: remove win/service/main.cpp
Summary: This code is the same as the service/oss/main.cpp, no need to keep this one around.

Reviewed By: chadaustin

Differential Revision: D23689607

fbshipit-source-id: bb72a0623dcdb36beca40c3766e8d6817b99dea2
2020-09-14 18:03:07 -07:00
Katie Mancini
9c0be6c7c8 teach eden to parse arrays in configs
Summary:
This stack updates eden to be able to check all of the locations that able
users certificate may reside.

There can be multiple places where a cert may reside (we cant always
definitively choose one place to look based on the platform). Thus we
need to be able to configure multiple locations for certs in our eden
config.

Thus we need to be able to parse a list of options for a key in our config
parsing.

**Disclaimer this is really icky**

Our `FieldConverter` interface takes a string to parse. So this means
that after parsing the config file for each value we have to re-serialize it
into a string to pass it in here. Previously we only supported string and
bool values so this re-serialization was not too terrible. Now that we want
to support arrays this re-serialization is extra gross. To minimize the grossness,
I am reusing cpptoml for serializing / deserializing around the `FieldConverter`
interface.

Long term it would be better if FieldConverter took a cpptoml::base or
something more generic instead of a string so we dont have to do this.
But that will be a big refactor, and I don't currently have bandwidth for it :(

Reviewed By: wez

Differential Revision: D23359928

fbshipit-source-id: 7c89de485706dd13a05adf19df28425d2c1756a8
2020-09-14 17:40:13 -07:00
generatedunixname89002005307016
827498fc82 suppress errors in eden - batch 1
Differential Revision: D23685952

fbshipit-source-id: e545fd2625c36a8f811179091b3043c95281ff7a
2020-09-14 15:56:35 -07:00
Chad Austin
5f8fde4570 remove an irredeemably flaky test
Summary:
This test can't be non-flaky, because it relies on the kernel deciding
when to drop inodes from cache, and we've investigated it multiple
times. Given it tests a rarely-used function that would be better
expressed as a unit test in C++, just remove it for now.

Reviewed By: wez

Differential Revision: D23665455

fbshipit-source-id: 522e47113857eff399be4f2bb60e26e801d61e9a
2020-09-14 14:57:44 -07:00
svcscm
5392ec81ea Updating submodules
Summary:
GitHub commits:

b3eb120290
e675c45208
91c6fbeda2
8f60f63386
5529a44fe1
627ddba89a
6b72342a12
9fa11fdfad
09fb719da1
8e9abfac46
98b23a143f
89430b8528
a92dfc18eb
1d710393d5
38a46d3302

Reviewed By: bigfootjon

fbshipit-source-id: 341b1ff882dc4b96dc7b57ee534c6624d2894f9e
2020-09-14 13:56:54 -07:00
Genevieve Helsel
2965c5f74c remove extra printed lines and sort result in prefetch profile finish
Summary: For ease of consumption, remove the descriptive line and the extra newline at the bottom of the generated prefetch profile. Also, sort the files for smaller generated diffs upon iteration.

Reviewed By: kmancini

Differential Revision: D23683153

fbshipit-source-id: e2bd510d5fbd7095f199e70b2556b84e0984a914
2020-09-14 12:59:28 -07:00
Durham Goode
a674b25157 hgcache: add config driven cache nuking
Summary:
We've often had cases where we need to nuke peoples caches for various
reasons. It's a hug pain since we haven't a way to communicate with all hg
clients. Now that we have configerator dynamicconfigs, we can use that to reach
all clients.

This diff adds support for configs like:
```
[hgcache-purge]
foo=2020-08-20
```
The key, 'foo' in this case, is an identifier used to only run this purge once.
The value is a date after which this purge will no longer run. This is useful
for bounding the damager from forgetting about a purge and having it delete caches
over and over in the future for new repos or repos where the run once marker
file is deleted for some reason.

Reviewed By: quark-zju

Differential Revision: D23044205

fbshipit-source-id: 8394fcf9ba6df09f391b5317bad134f369e9b416
2020-09-14 11:01:02 -07:00
Luca Niccolini
b259a5c949 add gtest version 1.8
Summary:
needed by a few projects [wangle, mvfst, proxygen]

it's already in lfs
https://www.internalfb.com/intern/diffusion/FBS/browse/master/fbcode/tools/lfs/.lfs-pointers?lines=41

Reviewed By: mzlee

Differential Revision: D23676343

fbshipit-source-id: 0fa04d4224f27e756f683924af0c21ea63a90647
2020-09-14 10:17:01 -07:00
svcscm
75055110f0 Updating submodules
Summary:
GitHub commits:

3e27ae81b8

Reviewed By: wittgenst

fbshipit-source-id: a727e58e2bed1ba36487f3699e08e8d10d3f736c
2020-09-14 10:17:01 -07:00
svcscm
7a4ea426c4 Updating submodules
Summary:
GitHub commits:

5763a8f730

Reviewed By: wittgenst

fbshipit-source-id: 02d3f73f16f30149786e7c24d4f82a1d27b55434
2020-09-14 03:23:55 -07:00
svcscm
6dda6270a1 Updating submodules
Summary:
GitHub commits:

4c78848f6e
aed460488f
700ca5e928
36cc983c50
0dc4481126
e26d854953
3071547c10
2ead19c9ff
094614e514
23a4418f0f

Reviewed By: wittgenst

fbshipit-source-id: 292c4cf82192e60b99ee55266932cc24738374bd
2020-09-14 03:23:55 -07:00
svcscm
89aae4a7bf Updating submodules
Summary:
GitHub commits:

269c5931d1
007ab0fe3c
368e68bb7c
1011548320
a8580c6bab
edec931a53
6c13933d30
c27436c106
664219226e

Reviewed By: wittgenst

fbshipit-source-id: fe5e049e3581b89fb3a9a057c93fe7dbfa9290c4
2020-09-13 12:38:54 -07:00
Chad Austin
d58f0d9451 prevent spurious configuration reloads when a config file doesn't exist
Summary:
getConfigStat had a bug where it, instead of clearing the bits of
*configStat, cleared the bits of the pointer itself. This caused the
stat struct for missing files to be uninitialized memory, causing
configs to reload. Write a test and fix the bug.

Reviewed By: xavierd

Differential Revision: D23645087

fbshipit-source-id: ad42f7ec1b313f668604e3a7f6c8200f6b94b23d
2020-09-13 01:37:14 -07:00
Chad Austin
be7a6b5cb3 introduce an assertZeroBits function to double-check the compiler
Summary:
While hacking on some code, I ran into a situation where some
zero-initialized stat structs weren't actually being zeroed. This was
either a compiler bug or a situation where the build system was not
correctly rebuilding everything after my changes, and I did not have
enough disassembly available to investigate.

Either way, since this code assumes zero bits in some nonobvious ways,
explicitly assert they are.

Reviewed By: xavierd

Differential Revision: D23644819

fbshipit-source-id: eb6bff9ff997379113db1e1bf9d6a0a538f10f0b
2020-09-13 01:37:14 -07:00
svcscm
d0628d0f39 Updating submodules
Summary:
GitHub commits:

c2cdb9b805

Reviewed By: wittgenst

fbshipit-source-id: 10fbb44ddc52ac098050d1ed7d3282d1e2debdf8
2020-09-13 01:37:14 -07:00
svcscm
4e2760f001 Updating submodules
Summary:
GitHub commits:

b404e15981
c33144a817
03e6927e45

Reviewed By: wittgenst

fbshipit-source-id: e3544f652effe3253fdefd715ed1048ba816c710
2020-09-12 21:24:32 -07:00
svcscm
55438142ca Updating submodules
Summary:
GitHub commits:

77f7fbdf15
b004397720
881677eef5

Reviewed By: wittgenst

fbshipit-source-id: bd535f381f81da88bb5dad8e3a2e4a39b1349467
2020-09-11 20:07:27 -07:00
svcscm
86964210e0 Updating submodules
Summary:
GitHub commits:

8c0bd81893
5f813e67c0
205e577694
327af996e2
caaeb874b5
0725301da5

Reviewed By: wittgenst

fbshipit-source-id: 5526e384cade32c48b2b9a92fa75f0c3cbf738fa
2020-09-11 20:07:27 -07:00
svcscm
ee5c83ada8 Updating submodules
Summary:
GitHub commits:

2d8dccaa95
7a818548f1
8d571f23f0

Reviewed By: wittgenst

fbshipit-source-id: 09c6144ac11f908c2dd18ac281e48c1a67397897
2020-09-11 17:35:00 -07:00
Kostia Balytskyi
7f504c741b impl LCAHint for Arc<impl LCAHint>
Summary:
This just makes it more convenient to use in circumstances when fns expects
`impl LCAHint` and we have `Arc<dyn LCAHint`.

Reviewed By: farnz

Differential Revision: D23650380

fbshipit-source-id: dacbfcafe6f3806317a81ed4677af190027f010b
2020-09-11 16:56:13 -07:00
svcscm
1f87ed9a25 Updating submodules
Summary:
GitHub commits:

35ea7a00ed
7c0a56baec
e66c32d29c
423425040c
3afa07d4dd
08292ca2da
50b941a43e
65cb59cd9b
60053cbcd4
d5c8669813
689cdcc943
465262d45e

Reviewed By: wittgenst

fbshipit-source-id: 232dbc697c622a8401ed6c4cde74dc004e8142eb
2020-09-11 16:53:50 -07:00
Chad Austin
e392eca46e log the path that caused configs to be reloaded
Summary:
We noticed spurious config file reloads, so add some logging to help
track that down.

Reviewed By: xavierd

Differential Revision: D23644447

fbshipit-source-id: 9953a17de402660c7f6491fb9abd8d702fa290e8
2020-09-11 16:53:49 -07:00
svcscm
7f4e674481 Updating submodules
Summary:
GitHub commits:

2b51f5edb1
f5744f58a8
796e8a5511
a6c9bce352
cba6d028f0

Reviewed By: wittgenst

fbshipit-source-id: 9c21ce90a24479688336f5bda132a13bd64ced4e
2020-09-11 13:35:04 -07:00
Chad Austin
2d86a960ad indicate to coreutils that edenfs is a remote filesystem
Summary:
GNU `df` (and any other coreutil that relies on gnulib's ME_REMOTE
flag) detects remote filesystems with some heuristics. One of which is
whether the device type contains a colon. Since edenfs is a remote
filesystem, include a colon, so it's properly detected as such.

Reviewed By: genevievehelsel

Differential Revision: D23520233

fbshipit-source-id: f4816b303e198d4e2a446efdcc5b49a593e09a05
2020-09-11 13:35:03 -07:00
Chad Austin
850999df92 handle mounts with device type starting with edenfs:
Summary:
We intend to rename the edenfs device type to include a colon (and
possibly the backing repo basename). In preparation, update code that
detects edenfs mounts to include anything that starts with "edenfs:".

Reviewed By: genevievehelsel

Differential Revision: D23520008

fbshipit-source-id: 280f7617d5c96e23d548041b3482bca388076a7b
2020-09-11 13:35:03 -07:00
Xavier Deguillard
c957d40ff7 cli: properly pass --edenfsctlPath on Windows
Summary:
For some unknown reason, we weren't setting this on Windows, which meant that
whenever edenfs would need to call edenfsctl (like at mount time when fixing up
redirections), it would always use the binary found in the PATH. While in most
cases this is OK, this is not the intended behavior for tests that are expected
to use the just compiled binary, not the one in the PATH.

Reviewed By: genevievehelsel

Differential Revision: D23653027

fbshipit-source-id: f1cc977e44b10c379d2b90bc7972bfec1fccad23
2020-09-11 11:57:12 -07:00
Stanislau Hlebik
d5cafbb432 mononoke: add catchup delete head subcommand to megarepo
Reviewed By: ikostia

Differential Revision: D23597187

fbshipit-source-id: da4710aabfc161a69d80c361dd593a3e7749e941
2020-09-11 10:39:07 -07:00
Arun Kulshreshtha
4d76a4c241 gotham_ext: don't end SignalStream on error
Summary: Previously, `SignalStream` would assume that an error would always end the `Stream`, and would therefore stop and report the amount of transferred data upon encountering any error. This isn't always the desired behavior, as it is possible for `TryStream`s to return mid-stream errors without immediately ending. `SignalStream` should allow for this kind of usage.

Reviewed By: farnz

Differential Revision: D23643337

fbshipit-source-id: 2c7ffd9d02c05bc09c6ec0e282c0b2cca166e079
2020-09-11 09:51:10 -07:00
svcscm
eb7dc081c3 Updating submodules
Summary:
GitHub commits:

28bc1035c1
be8445eea8
a12f045cc1
36bef91503

Reviewed By: wittgenst

fbshipit-source-id: e5ae68aa7e5cee7aaa44f19a610cafa1c3770073
2020-09-11 09:19:09 -07:00
Xavier Deguillard
f2cd32ea4e win: add PrjfsRequestContext class
Summary:
Similarly to FuseRequestContext, this will be allocated whenever ProjectedFS
calls onto EdenFS to keep track of timing, stats, etc.

For now, this just holds the callback data passed in, we need to copy it as
ProjectedFS will deallocate it when the EdenFS callback returns, but since we
intend to complete these asynchronously, the callback data needs to outlive the
callback, hence the copy. It's likely that this is copying too much, and only
part of it actually needs to be copied, this will be tackled later.

Reviewed By: wez

Differential Revision: D23505511

fbshipit-source-id: ece00183e3194611d3d63465878470d6e53b790c
2020-09-11 09:19:09 -07:00