Summary:
We bump commit date for other operations like amend, rebase, histedit, etc.
Let's do the same for stack editing.
Reviewed By: evangrayk
Differential Revision: D46188950
fbshipit-source-id: 0e636c13f6bd07945c00f5376991e7dcc0a8793a
Summary: This will be used to bump date for the modified commits.
Reviewed By: evangrayk
Differential Revision: D46188949
fbshipit-source-id: 459b5cebf4929343c9442d2d48d8ddf7342a0776
Summary:
It does not make much sense to stack edit a single-commit stack. In the future
if we have split operations then it might make sense to use it. For now let's
just hide the button for a single commit.
Reviewed By: evangrayk
Differential Revision: D46156654
fbshipit-source-id: 553daae9b420ff9bbb500843c36c31977ec04d27
Summary:
Track stack editing sessions: duration, how many times each operation gets
used. For reordering, we also distinguish between DnD reorder and button
reorder.
Reviewed By: zzl0
Differential Revision: D46155621
fbshipit-source-id: f4bc679be2be3c5747a9a7968cac66bc76995afe
Summary: Minor change to make the next change cleaner.
Reviewed By: evangrayk
Differential Revision: D46155619
fbshipit-source-id: 1b5a1c13f6b876763de67ff9af51ba66b3b5b7a8
Summary:
Make "Edit stack" publicly available so we can get feedback.
`experimentalFeatures` will move on to gate other WIP features.
Reviewed By: evangrayk
Differential Revision: D46155618
fbshipit-source-id: 85e3766a08c0faa6d01e02715a515002298c018a
Summary:
When editing the stack, the submit button won't work for the pending commits,
until "Save changes". So let's hide them.
Reviewed By: evangrayk
Differential Revision: D46155620
fbshipit-source-id: f7c5452a0bfa88659843d88e581e597bbc7e3442
Summary: This is useful in upcoming changes.
Reviewed By: evangrayk
Differential Revision: D46155622
fbshipit-source-id: 72c956818efacfaa2ae28f4ef068d606e62eb439
Summary:
This can be useful for the client to match exportedStack response with its
exportStack request.
Reviewed By: evangrayk
Differential Revision: D46150702
fbshipit-source-id: 090cf66a848f554f51eaa879e877516d2a74b366
Summary: Those were found by a spell checker extension.
Reviewed By: evangrayk
Differential Revision: D46150706
fbshipit-source-id: 7ef1e22b3074b54aa196b2411d0aa69b5423a750
Summary:
We've seen crashes on Windows when the mount is initialized but a later step at
mount time fails. In between these 2 events, if a write to the working copy
happens the ProjectedFS code assumes that the InodeMap is initialized and thus
tries to access the rootInode. This assumption is unfortunately broken by the
call to mountFinished and the code should instead follow the regular unmount
code path to make sure that no pending notifications are inflight.
I suspect NFS and FUSE also would exhibit the same issue.
Reviewed By: kmancini
Differential Revision: D46169999
fbshipit-source-id: ed1eb17dc2f084acb7e2d88c555150b3b8c6662e
Summary:
This offers a new interface for Shard Manager managed repos to be able to load redacted content.
The new API entry point: `open_managed_repos_unredacted` is analogous to `open_repo_unredacted`, but supports a Shard Manager based workflow.
Reviewed By: RajivTS
Differential Revision: D46280863
fbshipit-source-id: e2e4aebcb08d01f3be97d11d6fe8da2822ba6f29
Summary: Adding a way to configure the blake3 key for blake3 hashing
Reviewed By: chadaustin
Differential Revision: D44499469
fbshipit-source-id: 344edd91cfc867c8a49d0db9369dfe2132e86c77
Summary: I am planning to enable `copytrace.fallback-to-content-similarity=True` for hg repos, and will use this metric to monitor how useful the content similarity fallback is
Reviewed By: muirdm
Differential Revision: D46163311
fbshipit-source-id: d21b0288965f8ec4da7c6c80e37d1b557b357ea6
Summary: Our cache is in the dagcopytrace instance, so let's make it a singleton.
Reviewed By: quark-zju
Differential Revision: D46105882
fbshipit-source-id: 0984015e7b052482b27f950fc05563c432aa23b1
Summary: this function will be used in the following diff
Reviewed By: quark-zju
Differential Revision: D46105885
fbshipit-source-id: 9d02fb62a44b1e5bd18eba5236522e297fae0f64
Summary:
This diff modifies the behavior of `gitimport` and `remote-gitimport` when importing `annotated-tags`. In addition to:
- storing the raw tag
- converting the tag to a bookmark
- storing the metadata of the tag as changeset
this diff maintains a mapping between the tag-name and the changeset representing the metadata of the tag. This mapping would be useful to answer queries about the tag metadata when queried through Git and also enable going back to Git from Mononoke without losing data.
Differential Revision: D46067809
fbshipit-source-id: e2463160cdf647b50fa4ecfe4674d079016b4adc
Summary: Implement an alternative to ChangesetPathHistory::history using the new commit graph. This is almost identical to the skiplist implementation except that an (incorrect) optimization was removed that was trying to minimize the number of is_ancestor queries which should no longer be needed as they are a lot faster with the new commit graph.
Differential Revision: D46109911
fbshipit-source-id: 3e8f0c36a48084116673dda3741de87e0741f1a2
Summary: Implement an alternative to ChangesetContext::history using the new commit graph by using AncestorsStreamBuilder. Also made the tests not depend on the exact output history order but instead accept any topological order.
Differential Revision: D46109910
fbshipit-source-id: 31f3e219e9addf04b49fc500ad245d541f110887
Summary:
Factors out the logic of creating an ancestors stream to a builder to allow for more customizability (required for ChangesetContext::history) and reduce code duplication.
Additionally this optimizes range_stream to only traverse changesets that are descendants of start_id. Ancestry checks are kept to a minimum (worst case O(merges)) by only checking on parents of changesets that have a skip tree parent with generation lower than the generation of start_id.
Reviewed By: liubov-dmitrieva
Differential Revision: D46276429
fbshipit-source-id: 65c4f2892c92baaab0fef4f5041f06095ec49e05
Summary: allow using `SqliteOverlay` on non-Windows, since OverlayChecker has now been updated to work with it.
Reviewed By: chadaustin
Differential Revision: D44105360
fbshipit-source-id: 5f78e6c9b5323faeee394da4a51d7e84f8d44a2f
Summary:
vscode/webview-ui-toolkit includes dark theme variable values, but not light theme variable values. This means for the web ISL, we need to include the light theme values our selves (e.g. `--background: #fff`).
This is wrong when rendered inside vscode, since vscode provides the theme variables itself. It's more than redundant, because it means we don't respect some light theme variables.
We can fix this by extracting the light theme variable definitions and only including them in the `index.tsx` used to render the web ISL, and not include them in the vscode `islWebviewEntry.tsx`.
Reviewed By: zzl0
Differential Revision: D46227804
fbshipit-source-id: 8a4424e0f764f14bd6bcad4eccd0e0ffae29b991
Summary:
In the rare case where fetching both the BlobMetadata and the Blob failed, the
LocalStoreCachedBackingStore would still try to dereference the nullptr Blob,
leading to a crash.
Reviewed By: chadaustin
Differential Revision: D46211469
fbshipit-source-id: f98dd215dbda432507f3823439d354d3d662dc6f
Summary: We didn't have a way to do this before so let's add it.
Reviewed By: mitrandir77
Differential Revision: D46190481
fbshipit-source-id: 84544f0226ef3a4ef4d8ac9b4bf66551e4671793
Summary: It's not ideal that we pull mononoke_app and even instantiate MononokeApp here. This is an attempt to decouple Mononoke from Metagit.
Reviewed By: mitrandir77
Differential Revision: D45862434
fbshipit-source-id: 6eab3577743810461f22535d89cf9a00dc1cbb65
Summary: Most of the useful ways to use these methods requires providing an async closure so let's asyncify them.
Reviewed By: RajivTS
Differential Revision: D45607981
fbshipit-source-id: ee7b471cc5d60a793a79928f6c15c48c0da1d08e
