Summary:
The `_makelogrevset` feels cryptic, partially because its use of `opt2revset`
and related logic for adhoc revset expression calculation.
This diff removes `opt2revset` and related logic, so:
- `opts` is no longer both input and output. It's only input. The output is a
different variable.
- Use `revsetlang` APIs to format revset strings directly, without going
through an indirection via `opts`. Avoid `repr` or `a % b` formatting.
Note: `%d` is formatted as `_intlist(v)` instead of `rev(v)`.
The new code generates slightly simpler revset expressions with less `()`s
(or "group" in revsetlang AST).
Reviewed By: zzl0
Differential Revision: D45936983
fbshipit-source-id: 3155016a85fa9ea61f9334a2d1fc82eac5450fec
Summary:
It's already the same as `descendants` in our current implementation.
It's non-trivial to implement efficiently and is rarely used. So let's just
remove it for now.
Note the order of children of a commit is undefined, unlike parents. If we want
to provide a "meaningful" order and implement this in the future we might want
to use commit date etc to sort children.
Reviewed By: zzl0
Differential Revision: D45936979
fbshipit-source-id: bff72a130a5ffb7c573f06374da8f9c02791049f
Summary: Useful to chain a list of revset together.
Reviewed By: zzl0
Differential Revision: D45936980
fbshipit-source-id: 1775cd472e239f56971d0b441aae3e416852ea3f
Summary: Named branches are removed in our implementation. Clean them up in the log command.
Reviewed By: zzl0
Differential Revision: D45936987
fbshipit-source-id: 98d3df01b1f3db53861f886289cb720dccf0535a
Summary: It's not used anywhere. This removes a dependency on the legacy filelog.
Reviewed By: zzl0
Differential Revision: D45936981
fbshipit-source-id: 1c3af8dc792454d1bf893e922c1c37c80fa0a79b
Summary: This can simplify logic that checks a bunch of repo requirements.
Reviewed By: zzl0
Differential Revision: D45936978
fbshipit-source-id: eec8ca0035642bf2324782b7fb7e97cb740cc02d
Summary: We need that for optimizing our storage.
Reviewed By: RajivTS
Differential Revision: D46362446
fbshipit-source-id: d81973cd05cffdc78ad84da867fa4791efea877c
Summary:
Allow collapsing file changes
Currently there is no way to mark files as viewed, or collapse large ones of no interest (especially generated files). This is pretty painful when you want to go back forth between several files.
This adds a chevron (same as used in the StatusChecks card) that can be clicked to toggle collapsing, matching github's behavior.
![Screen Shot 2023-05-25 at 1 28 20 PM](https://github.com/facebook/sapling/assets/77301670/d52c1af6-3ad3-4e0a-8a0f-a3e10c45e07f)
Pull Request resolved: https://github.com/facebook/sapling/pull/630
Test Plan:
Tested manually:
| Before | After |
|--|
| https://pxl.cl/2KDNT | https://pxl.cl/2KDP0 |
Also checked that ISL was not affected by these changes
Reviewed By: muirdm
Differential Revision: D46204666
Pulled By: sggutier
fbshipit-source-id: 2173ce18619b09cb7a5d3640a6263e5f8b489d86
Summary: As in title. Once `BlobRepo` has been removed from this tool, I will also migrate it to the new `Mononoke Admin`
Reviewed By: mitrandir77
Differential Revision: D46444744
fbshipit-source-id: 059623d32d608f852254f16f811bcaf4e6bf3b4a
Summary: This includes PR 7 so drops the patch.
Reviewed By: zertosh
Differential Revision: D46451758
fbshipit-source-id: 5df8ccbfa610eab470744e28b5bffe411a983996
Summary: Removing the previous default ctor to ensure that we always compute and pass blake3.
Reviewed By: chadaustin
Differential Revision: D46268716
fbshipit-source-id: d9bfbc7bfd07b61dbb2e915c3fe72d7526d919e1
Summary: Adding a method to retrieve blake3 hash for a list of files.
Reviewed By: chadaustin
Differential Revision: D46268718
fbshipit-source-id: 59cb3d25a1d059a7e9b6a4da784a820945ffbd32
Summary: Expose blake3 via file attributes and changing some integration tests accordingly. Added blake3_sum so that it could be used to verify blake3 hashes and updated the tests to work with blake3.
Reviewed By: chadaustin
Differential Revision: D46307686
fbshipit-source-id: 6f2a4e8e25757862ef17d56f92b90a95c7f5a474
Summary: This utility binary could be used from the integration tests to compute blake3 hashes as it is easier to have it than adding the python pypi package with native dependencies.
Reviewed By: chadaustin
Differential Revision: D46307685
fbshipit-source-id: 1c48c689312cd9a04a19a62ad02ae3e9185041e5
Summary: If backing store doesn't provide a blake3 hash then we should be able to compute and cache it on demand.
Reviewed By: chadaustin
Differential Revision: D46316187
fbshipit-source-id: 9b77368ac5bb351d0edd80274b280692f8e1f774
Summary: Adding some util functions to ThriftUtil to support blake3
Reviewed By: chadaustin
Differential Revision: D46268709
fbshipit-source-id: 1bc7b7b02ecb121e10e4b15036aa645466e7f762
Summary:
Adding blake3 support into TreeEntry and backing stores.
Note: Http and RE CAS stores don't provide blake3 hash so far. While it would be pretty easy to add support for RE, not sure how hard it would be for the http store.
Reviewed By: chadaustin
Differential Revision: D46268715
fbshipit-source-id: db66e63fe0348eb582a8050f22cdc0ff720ccf85
Summary: Exposing blake3 from hg to eden
Reviewed By: chadaustin
Differential Revision: D46268710
fbshipit-source-id: 5f34b5f9586cc8c9507cc987378dc172959b4079
Summary:
Adding blake3 into the `Entry` and `Info` objects to make it possible to retrieve blake3 hashes.
The FileNode part will be integrated in the next diff
Reviewed By: chadaustin
Differential Revision: D46268719
fbshipit-source-id: b787b583e5abb3ed306fd1870f96bbdbc9fc0711
Summary: Adding blake3 support to the FileHash util that is used to compute hashes on Windows.
Reviewed By: chadaustin
Differential Revision: D46268714
fbshipit-source-id: cdca3dced494b1f37841121df09351acfdd6c745
Summary: Frequently we will be operating with the blake3 key that is represented as `std::optional` so making it is easier to initialize blake3 appropriately.
Reviewed By: chadaustin
Differential Revision: D46268711
fbshipit-source-id: 2b9882683e79de2325d23353a4ca7260f3853f47
Summary:
Adding blake3 support to SerializedBlobMetadata.
* The serialized data is stored as:
* - version (1 byte, big endian)
* - blob_size (up to 10 bytes, big endian)
* - used_hashes (1 byte, big-endian)
* - hashes stored in order of their type values e.g. from less significant
to more significant
* - hash (N bytes)
...
* - hash (M bytes)
Reviewed By: chadaustin
Differential Revision: D44500908
fbshipit-source-id: d64081db8591f85be5cdf3fd98ff9839c028d5fb
Summary: Use `-` for old working copy parent, so we can easily go back to the previous working copy parent with `hg go -`. This is similar to `cd -` to go back to the previous folder.
Reviewed By: quark-zju
Differential Revision: D46368217
fbshipit-source-id: ab51992f8dde66a7535ba673892bbb6c0f01ecec
Summary:
first in a set of diffs with the intent of removing `lazy_static!` from fbcode.
this diff changes `std::sync::Mutex` and `parking_lot::Mutex` to plain `static` initializations where possible.
Reviewed By: zertosh
Differential Revision: D46335784
fbshipit-source-id: 105848f38dcb8083be77a4ad4db267058081fe53
Summary: Show 9 characters for autocompleted revs, to match rev numbers shown in e.g. `hg sl`. This makes it a little easier to verify the rev that was autocompleted for you matches the one you were looking at in the smart log (i.e. if you're looking at the end of the rev rather than the beginning).
Reviewed By: zzl0
Differential Revision: D46398818
fbshipit-source-id: 70f19d60df7aa85371e1c1838b362b621da5b493
Summary: This library doesn't seem to be used anymore in that file, so seems to be safe to delete it
Reviewed By: zzl0
Differential Revision: D46433066
fbshipit-source-id: 7c522b99048130f2ecd996e6ba901b5e5cccad2b
Summary:
saintelmosfire
Will only land this after D45356044 is landed and tested.
Differential Revision: D45356043
fbshipit-source-id: 068aa45e1edd954b8ba5dc3355f9392ab06419b5