mirror of
https://github.com/facebook/sapling.git
synced 2024-10-11 01:07:15 +03:00
275e4eff76
Summary: This removes the Extend implementation for FileBytes, which was incorrect (it discarded existing data!). I had introduced this as a backwards compatibility shim when doing the Bytes 0.4 to Bytes 0.5 migration :/ We don't really need this shim, considering: - The only place that really matters that uses this is the remotefilelog crate, where we have a content id, and where we should use `filestore::fetch_concat` instead. - The other places are tests (or close to abandonware...), which can do their own folding. Longer term, I'd like to remove the whole `Content` stream in hg entries, so those callsites can use the filestore methods, which a) have test coverage (unlike ad-hoc folds, which don't always do), and b) are more efficient since they know how large the destination buffer needs to be ahead of time, and don't need to re-allocate. To make sure this fixes the bug, I also introduced tests for the remotefilelog crate. As expected, the chunked variant fails without this fix. Reviewed By: mitrandir77 Differential Revision: D20248978 fbshipit-source-id: 1b554d3e595eb867b6b6cf4204d31f27dd90a111 |
||
---|---|---|
.. | ||
bundles/src | ||
revlog | ||
types |