mirror of
https://github.com/facebook/sapling.git
synced 2024-10-05 14:28:17 +03:00
3c4afb88e3
Summary: Cmake automatically includes its own manifest in executables. We should make CMake aware of our custom manifest so that it combines them together to avoid a "duplicate manifest" error In addition, we should only include the manifest in the resource file if we're building with buck. The Cmake build will break if we try to include the manifest in the resource file. This is because every target that includes notifications will pull in the resource file, and this causes all of those targets to have duplicated manifest errors during linking. Reviewed By: chadaustin Differential Revision: D36318044 fbshipit-source-id: dde35e5602f0161c4961103970b880f98e399098
24 lines
922 B
Plaintext
24 lines
922 B
Plaintext
#include "WindowsNotifierConstants.h"
|
|
/////////////////////////////////////////////////////////////////////////////
|
|
//
|
|
// Icon
|
|
//
|
|
|
|
// Icon with lowest ID value placed first to ensure application icon
|
|
// remains consistent on all systems.
|
|
|
|
IDI_WNOTIFICATIONICON ICON "edenw256.ico"
|
|
IDI_ONOTIFICATIONICON ICON "edeno256.ico"
|
|
IDI_GNOTIFICATIONICON ICON "edeng256.ico"
|
|
IDI_RNOTIFICATIONICON ICON "edenr256.ico"
|
|
|
|
// Manifest
|
|
// 24 == RT_MANIFEST and 1 == exe manifest
|
|
#ifdef EDENFS_INCLUDE_MANIFEST
|
|
// We only want to include the manifest in the RC file if we're building with
|
|
// Buck. This is because CMake does not handle duplicated manifests in a
|
|
// graceful way. We end up pulling the resource file into every executable
|
|
// that includes notifications, and that causes duplicated manifest errors.
|
|
1 24 "edenfs.exe.manifest"
|
|
#endif
|