mirror of
https://github.com/facebook/sapling.git
synced 2024-10-05 14:28:17 +03:00
4c57fa380b
Summary:
# Problem
The `eden clone` and `hg clone` command currently allow you to specify that you want to use FilteredFS, but they don't allow you to specify the filter to active after the clone completes. Instead, the user has to manually set the filter themselves by running `hg filteredfs enable {path_to_filter}`.
This is annoying for many reasons, and it prevents us from easily rolling out filters on Sandcastle/ODs.
# Solution
We should allow users to pass in the Filter they want to enable at clone time. This will allow them to skip the `hg filteredfs enable {path_to_filter}` step. Even better, we'll allow passing this filter via an Hg Config. That way we can easily enable FilteredFS + use a specific filter just by setting a config value.
# This diff
We want to enable a filter after the repo is successfully cloned. This diff adds a new config option clone.eden-sparse-filter which allows users to specify which filter to activate after cloning. *This option will eventually replace the clone.use-eden-sparse option!*
The config works as follows:
* if clone.eden-sparse-filter is not set, we won't clone with FilteredFS
* if clone.eden-sparse-filter is set to an empty string, we'll clone with FilteredFS but we won't activate a filter
* if clone.eden-sparse-filter is set to a string value, we'll use that as the filter to activate after the clone completes.
The actual activating of the filter happens in the `edenfsctl clone` logic. That logic is added in the diffs stacked below this one.
Reviewed By: muirdm
Differential Revision: D53599528
fbshipit-source-id: f271c2091d5b0473bd25c1419b660cd0d514bded
|
||
|---|---|---|
| .. | ||
| facebook/lib | ||
| fsck | ||
| helpers | ||
| hg | ||
| lib | ||
| snapshot | ||
| basic_test.py | ||
| casing_test.py | ||
| chown_test.py | ||
| clone_test.py | ||
| CMakeLists.txt | ||
| config_test.py | ||
| corrupt_overlay_test.py | ||
| debug_getpath_test.py | ||
| debug_subscribe_test.py | ||
| debug_test.py | ||
| doteden_test.py | ||
| edenclient_test.py | ||
| fsck_test.py | ||
| glob_test.py | ||
| health_test.py | ||
| help_test.py | ||
| info_test.py | ||
| invalidate_test.py | ||
| long_path_test.py | ||
| materialized_query_test.py | ||
| mmap_test.py | ||
| mount_test.py | ||
| oexcl_test.py | ||
| patch_test.py | ||
| persistence_test.py | ||
| prjfs_match_fs.py | ||
| prjfs_stress.py | ||
| projfs_buffer.py | ||
| projfs_enumeration.py | ||
| rage_test.py | ||
| rc_test.py | ||
| readdir_test.py | ||
| redirect_test.py | ||
| remount_test.py | ||
| rename_test.py | ||
| restart_test.py | ||
| rocksdb_store_test.py | ||
| sed_test.py | ||
| service_log_test.py | ||
| setattr_test.py | ||
| stale_inode_test.py | ||
| stale_test.py | ||
| start_test.py | ||
| stats_test.py | ||
| stop_test.py | ||
| takeover_test.py | ||
| TARGETS | ||
| thrift_test.py | ||
| unicode_test.py | ||
| unixsocket_test.py | ||
| unlink_test.py | ||
| userinfo_test.py | ||
| windows_fsck_test.py | ||
| xattr_test.py | ||